gherkin_lint 0.1.2 → 0.3.0

data/lib/gherkin_lint/linter/invalid_file_name.rb

@@ -8,7 +8,7 @@ module GherkinLint
         base = File.basename file
         next unless base != base.downcase || base =~ /[ -]/
         references = [reference(file)]
-        add_issue(references, 'Feature files should be snake_cased')
+        add_error(references, 'Feature files should be snake_cased')
       end
     end
   end

data/lib/gherkin_lint/linter/invalid_step_flow.rb

@@ -14,7 +14,7 @@ module GherkinLint
 
     def last_step_is_an_action(file, feature, scenario, steps)
       references = [reference(file, feature, scenario, steps.last)]
-      add_issue(references, 'Last step is an action') if steps.last['keyword'] == 'When '
+      add_error(references, 'Last step is an action') if steps.last['keyword'] == 'When '
     end
 
     def given_after_non_given(file, feature, scenario, steps)
@@ -22,7 +22,7 @@ module GherkinLint
       steps.each do |step|
         references = [reference(file, feature, scenario, step)]
         description = 'Given after Action or Verification'
-        add_issue(references, description) if step['keyword'] == 'Given ' && last_step['keyword'] != 'Given '
+        add_error(references, description) if step['keyword'] == 'Given ' && last_step['keyword'] != 'Given '
         last_step = step
       end
     end
@@ -31,7 +31,7 @@ module GherkinLint
       steps.each do |step|
         break if step['keyword'] == 'When '
         references = [reference(file, feature, scenario, step)]
-        add_issue(references, 'Missing Action') if step['keyword'] == 'Then '
+        add_error(references, 'Missing Action') if step['keyword'] == 'Then '
       end
     end
   end

data/lib/gherkin_lint/linter/missing_example_name.rb

@@ -6,11 +6,12 @@ module GherkinLint
     def lint
       scenarios do |file, feature, scenario|
         next unless scenario.key? 'examples'
+        next unless scenario['examples'].length > 1
         scenario['examples'].each do |example|
           name = example.key?('name') ? example['name'].strip : ''
           next unless name.empty?
           references = [reference(file, feature, scenario)]
-          add_issue(references, 'No Example Name')
+          add_error(references, 'No Example Name')
         end
       end
     end

data/lib/gherkin_lint/linter/missing_feature_description.rb

@@ -8,7 +8,7 @@ module GherkinLint
         name = feature.key?('description') ? feature['description'].strip : ''
         next unless name.empty?
         references = [reference(file, feature)]
-        add_issue(references, 'Favor a user story as description')
+        add_error(references, 'Favor a user story as description')
       end
     end
   end

data/lib/gherkin_lint/linter/missing_feature_name.rb

@@ -8,7 +8,7 @@ module GherkinLint
         name = feature.key?('name') ? feature['name'].strip : ''
         next unless name.empty?
         references = [reference(file, feature)]
-        add_issue(references, 'No Feature Name')
+        add_error(references, 'No Feature Name')
       end
     end
   end

data/lib/gherkin_lint/linter/missing_scenario_name.rb

@@ -8,7 +8,7 @@ module GherkinLint
         name = scenario.key?('name') ? scenario['name'].strip : ''
         references = [reference(file, feature, scenario)]
         next unless name.empty?
-        add_issue(references, 'No Scenario Name')
+        add_error(references, 'No Scenario Name')
       end
     end
   end

data/lib/gherkin_lint/linter/missing_test_action.rb

@@ -8,7 +8,7 @@ module GherkinLint
         when_steps = scenario['steps'].select { |step| step['keyword'] == 'When ' }
         next unless when_steps.empty?
         references = [reference(file, feature, scenario)]
-        add_issue(references, 'No \'When\'-Step')
+        add_error(references, 'No \'When\'-Step')
       end
     end
   end

data/lib/gherkin_lint/linter/missing_verification.rb

@@ -8,7 +8,7 @@ module GherkinLint
         then_steps = scenario['steps'].select { |step| step['keyword'] == 'Then ' }
         next unless then_steps.empty?
         references = [reference(file, feature, scenario)]
-        add_issue(references, 'No verification step')
+        add_error(references, 'No verification step')
       end
     end
   end

data/lib/gherkin_lint/linter/same_tag_for_all_scenarios.rb

@@ -5,13 +5,34 @@ module GherkinLint
   class SameTagForAllScenarios < Linter
     def lint
       features do |file, feature|
-        tags = gather_same_tags feature
-        next if tags.nil?
-        next if tags.empty?
-        next unless feature['elements'].length > 1
-        references = [reference(file, feature)]
+        lint_scenarios file, feature
+        lint_examples file, feature
+      end
+    end
+
+    def lint_scenarios(file, feature)
+      tags = gather_same_tags feature
+      return if tags.nil?
+      return if tags.length < 1
+      return unless feature['elements'].length > 1
+      references = [reference(file, feature)]
+      tags.each do |tag|
+        next if tag == '@skip'
+
+        add_error(references, "Tag '#{tag}' should be used at Feature level")
+      end
+    end
+
+    def lint_examples(file, feature)
+      feature['elements'].each do |scenario|
+        tags = gather_same_tags_for_outline scenario
+        next if tags.nil? || tags.empty?
+        next unless scenario['examples'].length > 1
+        references = [reference(file, feature, scenario)]
         tags.each do |tag|
-          add_issue(references, "Tag '#{tag}' should be used at Feature level")
+          next if tag == '@skip'
+
+          add_error(references, "Tag '#{tag}' should be used at Scenario Outline level")
         end
       end
     end
@@ -28,5 +49,17 @@ module GherkinLint
       end
       result
     end
+
+    def gather_same_tags_for_outline(scenario)
+      result = nil
+      return result unless scenario.include? 'examples'
+      scenario['examples'].each do |example|
+        return nil unless example.include? 'tags'
+        tags = example['tags'].map { |tag| tag['name'] }
+        result = tags if result.nil?
+        result &= tags
+      end
+      result
+    end
   end
 end

data/lib/gherkin_lint/linter/too_clumsy.rb

@@ -8,7 +8,7 @@ module GherkinLint
         characters = scenario['steps'].map { |step| step['name'].length }.inject(0, :+)
         next if characters < 400
         references = [reference(file, feature, scenario)]
-        add_issue(references, "Used #{characters} Characters")
+        add_error(references, "Used #{characters} Characters")
       end
     end
   end

data/lib/gherkin_lint/linter/too_long_step.rb

@@ -7,7 +7,7 @@ module GherkinLint
       steps do |file, feature, scenario, step|
         next if step['name'].length < 80
         references = [reference(file, feature, scenario, step)]
-        add_issue(references, "Used #{step['name'].length} characters")
+        add_error(references, "Used #{step['name'].length} characters")
       end
     end
   end

data/lib/gherkin_lint/linter/too_many_different_tags.rb

@@ -20,14 +20,14 @@ module GherkinLint
       tags.uniq!
       references.uniq!
       return false unless tags.length >= 3
-      add_issue(references, "Used #{tags.length} Tags within single Feature")
+      add_error(references, "Used #{tags.length} Tags within single Feature")
     end
 
     def warn_across_all_features(references, tags)
       tags.uniq!
       references.uniq!
       return false unless tags.length >= 10
-      add_issue(references, "Used #{tags.length} Tags across all Features")
+      add_error(references, "Used #{tags.length} Tags across all Features")
     end
 
     def tags_for_feature(feature)

data/lib/gherkin_lint/linter/too_many_steps.rb

@@ -7,7 +7,7 @@ module GherkinLint
       filled_scenarios do |file, feature, scenario|
         next if scenario['steps'].length < 10
         references = [reference(file, feature, scenario)]
-        add_issue(references, "Used #{scenario['steps'].length} Steps")
+        add_error(references, "Used #{scenario['steps'].length} Steps")
       end
     end
   end

data/lib/gherkin_lint/linter/too_many_tags.rb

@@ -8,7 +8,7 @@ module GherkinLint
         tags = gather_tags(feature) + gather_tags(scenario)
         next unless tags.length >= 3
         references = [reference(file, feature, scenario)]
-        add_issue(references, "Used #{tags.length} Tags")
+        add_error(references, "Used #{tags.length} Tags")
       end
     end
   end

data/lib/gherkin_lint/linter/unique_scenario_names.rb

@@ -12,7 +12,7 @@ module GherkinLint
       end
       references_by_name.each do |name, references|
         next if references.length <= 1
-        add_issue(references, "'#{name}' used #{references.length} times")
+        add_error(references, "'#{name}' used #{references.length} times")
       end
     end
   end

data/lib/gherkin_lint/linter/unknown_variable.rb

@@ -10,7 +10,7 @@ module GherkinLint
           step_vars(step).each do |used_var|
             next if known_vars.include? used_var
             references = [reference(file, feature, scenario)]
-            add_issue(references, "'<#{used_var}>' is unknown")
+            add_error(references, "'<#{used_var}>' is unknown")
           end
         end
       end

data/lib/gherkin_lint/linter/unused_variable.rb

@@ -10,7 +10,7 @@ module GherkinLint
           next unless example.key? 'rows'
           example['rows'].first['cells'].each do |variable|
             references = [reference(file, feature, scenario)]
-            add_issue(references, "'<#{variable}>' is unused") unless used?(variable, scenario)
+            add_error(references, "'<#{variable}>' is unused") unless used?(variable, scenario)
           end
         end
       end

data/lib/gherkin_lint/linter/use_background.rb

@@ -11,7 +11,7 @@ module GherkinLint
         next if givens.length <= 1
         next if givens.uniq.length > 1
         references = [reference(file, feature)]
-        add_issue(references, "Step '#{givens.uniq.first}' should be part of background")
+        add_error(references, "Step '#{givens.uniq.first}' should be part of background")
       end
     end
 

data/lib/gherkin_lint/linter/use_outline.rb

@@ -17,7 +17,7 @@ module GherkinLint
         similarity = determine_similarity(lhs[:text], rhs[:text])
         next unless similarity >= 0.95
         references = [lhs[:reference], rhs[:reference]]
-        add_issue(references, "Scenarios are similar by #{similarity.round(3) * 100} %")
+        add_error(references, "Scenarios are similar by #{similarity.round(3) * 100} %")
       end
     end
 

metadata

@@ -1,18 +1,20 @@
 --- !ruby/object:Gem::Specification
 name: gherkin_lint
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.3.0
+  prerelease: 
 platform: ruby
 authors:
 - Stefan Rohe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-17 00:00:00.000000000 Z
+date: 2016-05-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gherkin
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - '='
       - !ruby/object:Gem::Version
@@ -20,6 +22,7 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - '='
       - !ruby/object:Gem::Version
@@ -27,43 +30,65 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: term-ansicolor
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 1.3.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 1.3.2
 - !ruby/object:Gem::Dependency
   name: amatch
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 0.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 0.3.0
+- !ruby/object:Gem::Dependency
+  name: engtagger
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 0.2.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 0.2.0
 - !ruby/object:Gem::Dependency
   name: aruba
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 0.6.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 0.6.2
 description: Lint Gherkin Files
@@ -73,8 +98,8 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- ".rubocop.yml"
-- ".travis.yml"
+- .rubocop.yml
+- .travis.yml
 - Dockerfile
 - Gemfile
 - Guardfile
@@ -88,6 +113,7 @@ files:
 - features/background_does_more_than_setup.feature
 - features/background_requires_scenario.feature
 - features/bad_scenario_name.feature
+- features/be_declarative.feature
 - features/disable_tags.feature
 - features/file_name_differs_feature_name.feature
 - features/invalid_file_name.feature
@@ -120,6 +146,7 @@ files:
 - lib/gherkin_lint/linter/background_does_more_than_setup.rb
 - lib/gherkin_lint/linter/background_requires_multiple_scenarios.rb
 - lib/gherkin_lint/linter/bad_scenario_name.rb
+- lib/gherkin_lint/linter/be_declarative.rb
 - lib/gherkin_lint/linter/file_name_differs_feature_name.rb
 - lib/gherkin_lint/linter/invalid_file_name.rb
 - lib/gherkin_lint/linter/invalid_step_flow.rb
@@ -142,25 +169,26 @@ files:
 - lib/gherkin_lint/linter/use_outline.rb
 homepage: http://github.com/funkwerk/gherkin_lint/
 licenses: []
-metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - ">="
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - ">="
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 1.8.23
 signing_key: 
-specification_version: 4
+specification_version: 3
 summary: Gherkin Lint
 test_files: []

checksums.yaml

@@ -1,7 +0,0 @@
----
-SHA1:
-  metadata.gz: 55bcc404f41403702960d9d2947515739567023f
-  data.tar.gz: a26de407f1adb5dfd372da3f4e32a395ff85d20a
-SHA512:
-  metadata.gz: 15112d1f645e2c06b58d9022d44e5004ac38c75c87caf8ba5d2c9776eb1eeabe62f61b05908ca058fe8f7a64736758d2d7e029d1fd673eaae321bf2db073bee4
-  data.tar.gz: 4c93f4a4e9e479d2f9764ec71e4064d9aa6f50a43a26c7ce511f976c11a0fe5f4b45a4224f1575412c999de9633a2df0934fb4caa587ddecef37f46947b790a8