gherkin 2.6.9 → 2.7.1

data/History.md

@@ -1,3 +1,14 @@
+## [2.7.1](https://github.com/cucumber/gherkin/compare/v2.7.0...v2.7.1)
+
+2.7.0 release got hosed
+
+## [2.7.0](https://github.com/cucumber/gherkin/compare/v2.6.9...v2.7.0)
+
+### Changed Features
+
+* Formatter.close no longer closes streams. (Alan Parkinson)
+* Formatter.close renamed to Formatter.done. (Aslak Hellesøy)
+
 ## [2.6.9](https://github.com/cucumber/gherkin/compare/v2.6.8...v2.6.9)
 
 ### Changed Features

data/README.md

@@ -54,7 +54,7 @@ The jar file is in the central Maven repo.
     <dependency>
         <groupId>info.cukes</groupId>
         <artifactId>gherkin</artifactId>
-        <version>2.6.9</version>
+        <version>2.7.1</version>
     </dependency>
 
 You can get it manually from [Maven Central](http://search.maven.org/#browse%7C-2073395818)
@@ -145,13 +145,6 @@ And you can try it out with node.js:
 
     node js/example/print.js spec/gherkin/fixtures/1.feature
 
-You can also try out Gherkin running in the browser (likely to move to a separate project):
-
-    # Pull in the Ace (http://ace.ajax.org/) editor:
-    git submodule update --init
-    # Open a sample Gherkin-powered editor in Chrome
-    open js/example/index.html
-
 If you're hacking and just want to rebuild the English parser:
 
   rake js/lib/gherkin/lexer/en.js
@@ -227,8 +220,6 @@ Now you can build Windows gems:
 * Run `bundle update`, so Gemfile.lock gets updated with the changes.
 * Commit changes, otherwise you will get an error at the end when a tag is made.
 * Run `bundle exec rake gems:prepare && ./build_native_gems.sh && bundle exec rake release:ALL`
-  * The specs intermittently fail with a segfault from therubyracer. Running specs can be disabled with SKIP_JS_SPECS=true
-* Announce on Cucumber list, IRC and Twitter.
 
 ## Note on Patches/Pull Requests
  

data/features/step_definitions/json_formatter_steps.rb

@@ -17,7 +17,7 @@ end
 
 Then /^the outputted JSON should be:$/ do |expected_json|
   require 'json'
-  @formatter.close
+  @formatter.done
   actual_json = @out.string
   puts actual_json
   puts JSON.pretty_generate(JSON.parse(actual_json))

data/features/step_definitions/pretty_formatter_steps.rb

@@ -20,7 +20,7 @@ module PrettyPlease
     json_formatter      = Gherkin::Formatter::JSONFormatter.new(json)
     gherkin_parser      = Gherkin::Parser::Parser.new(json_formatter, true)
     parse(gherkin_parser, gherkin, feature_path)
-    json_formatter.close
+    json_formatter.done
 
     io                  = StringIO.new
     pretty_formatter    = Gherkin::Formatter::PrettyFormatter.new(io, true, false)

data/gherkin.gemspec

@@ -3,7 +3,7 @@
 Gem::Specification.new do |s|
   s.name        = "gherkin"
   # If bumping the major version here, comment out the cucumber dependency below and uncomment in the Gemfile to build against a local cucumber.
-  s.version     = "2.6.9"
+  s.version     = "2.7.1"
   s.authors     = ["Mike Sassak", "Gregory Hnatiuk", "Aslak Hellesøy"]
   s.description = "A fast Gherkin lexer/parser based on the Ragel State Machine Compiler."
   s.summary     = "#{s.name}-#{s.version}"
@@ -46,7 +46,7 @@ Gem::Specification.new do |s|
 
   s.add_runtime_dependency('json', '>= 1.4.6')
 
-  s.add_development_dependency('cucumber', '>= 1.1.3')
+  s.add_development_dependency('cucumber', '>= 1.1.4')
   s.add_development_dependency('rake', '>= 0.9.2')
   s.add_development_dependency('bundler', '>= 1.0.21')
   s.add_development_dependency('rspec', '>= 2.7.0')

data/lib/gherkin/formatter/filter_formatter.rb

@@ -89,6 +89,10 @@ module Gherkin
         @formatter.eof
       end
 
+      def done
+        @formatter.done
+      end
+
     private
 
       def detect_filter(filters)
@@ -128,7 +132,7 @@ module Gherkin
         @examples_events.clear
         @examples_tags.clear
         @examples_name = nil
-	@examples_range = nil
+        @examples_range = nil
       end
 
       def replay_events!(events)

data/lib/gherkin/formatter/json_formatter.rb

@@ -18,7 +18,7 @@ module Gherkin
         @feature_hashes = []
       end
 
-      def close
+      def done
         @io.write(@feature_hashes.to_json)
       end
 

data/lib/gherkin/formatter/pretty_formatter.rb

@@ -155,6 +155,10 @@ module Gherkin
         # NO-OP
       end
 
+      def done
+        # NO-OP
+      end
+
       def table(rows)
         cell_lengths = rows.map do |row| 
           row.cells.map do |cell| 
@@ -177,7 +181,7 @@ module Gherkin
 
     private
 
-    def doc_string(doc_string)
+      def doc_string(doc_string)
         @io.puts "      \"\"\"" + doc_string.content_type + "\n" + escape_triple_quotes(indent(doc_string.value, '      ')) + "\n      \"\"\""
       end
 

data/spec/gherkin/formatter/json_formatter_spec.rb

@@ -22,7 +22,7 @@ module Gherkin
         f.result(Model::Result.new(:passed, 1, nil))
 
         f.eof
-        f.close
+        f.done
         
         expected = %{
           [

data/spec/gherkin/js_lexer_spec.rb

@@ -1,5 +1,5 @@
 #encoding: utf-8
-if !defined?(JRUBY_VERSION) && !(defined?(RUBY_ENGINE) && RUBY_ENGINE == "ironruby") && ENV['GHERKIN_JS'] && !ENV['SKIP_JS_SPECS']
+if !defined?(JRUBY_VERSION) && !(defined?(RUBY_ENGINE) && RUBY_ENGINE == "ironruby") && ENV['GHERKIN_JS']
 require 'spec_helper'
 require 'gherkin/js_lexer'
 

data/spec/gherkin/json_parser_spec.rb

@@ -12,7 +12,7 @@ module Gherkin
       f = Formatter::JSONFormatter.new(io)
       p = JSONParser.new(f, f)
       p.parse(json)
-      f.close
+      f.done
       expected = JSON.parse(json)
       actual   = JSON.parse(io.string)
       actual.should == expected

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gherkin
 version: !ruby/object:Gem::Version
-  version: 2.6.9
+  version: 2.7.1
   prerelease: 
 platform: ruby
 authors:
@@ -11,11 +11,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-12-03 00:00:00.000000000 Z
+date: 2011-12-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake-compiler
-  requirement: &2157059160 !ruby/object:Gem::Requirement
+  requirement: &2157036760 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -23,10 +23,10 @@ dependencies:
         version: 0.7.9
   type: :development
   prerelease: false
-  version_requirements: *2157059160
+  version_requirements: *2157036760
 - !ruby/object:Gem::Dependency
   name: json
-  requirement: &2157069780 !ruby/object:Gem::Requirement
+  requirement: &2157016300 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -34,21 +34,21 @@ dependencies:
         version: 1.4.6
   type: :runtime
   prerelease: false
-  version_requirements: *2157069780
+  version_requirements: *2157016300
 - !ruby/object:Gem::Dependency
   name: cucumber
-  requirement: &2157069080 !ruby/object:Gem::Requirement
+  requirement: &2157015420 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 1.1.3
+        version: 1.1.4
   type: :development
   prerelease: false
-  version_requirements: *2157069080
+  version_requirements: *2157015420
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &2157068620 !ruby/object:Gem::Requirement
+  requirement: &2157014680 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -56,10 +56,10 @@ dependencies:
         version: 0.9.2
   type: :development
   prerelease: false
-  version_requirements: *2157068620
+  version_requirements: *2157014680
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &2157068160 !ruby/object:Gem::Requirement
+  requirement: &2157013760 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -67,10 +67,10 @@ dependencies:
         version: 1.0.21
   type: :development
   prerelease: false
-  version_requirements: *2157068160
+  version_requirements: *2157013760
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2157067640 !ruby/object:Gem::Requirement
+  requirement: &2157012740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -78,10 +78,10 @@ dependencies:
         version: 2.7.0
   type: :development
   prerelease: false
-  version_requirements: *2157067640
+  version_requirements: *2157012740
 - !ruby/object:Gem::Dependency
   name: rubyzip
-  requirement: &2157067120 !ruby/object:Gem::Requirement
+  requirement: &2157011640 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -89,10 +89,10 @@ dependencies:
         version: 0.9.5
   type: :development
   prerelease: false
-  version_requirements: *2157067120
+  version_requirements: *2157011640
 - !ruby/object:Gem::Dependency
   name: therubyracer
-  requirement: &2157066480 !ruby/object:Gem::Requirement
+  requirement: &2157010920 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -100,10 +100,10 @@ dependencies:
         version: 0.9.9
   type: :development
   prerelease: false
-  version_requirements: *2157066480
+  version_requirements: *2157010920
 - !ruby/object:Gem::Dependency
   name: yard
-  requirement: &2157065940 !ruby/object:Gem::Requirement
+  requirement: &2157009840 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -111,10 +111,10 @@ dependencies:
         version: 0.7.4
   type: :development
   prerelease: false
-  version_requirements: *2157065940
+  version_requirements: *2157009840
 - !ruby/object:Gem::Dependency
   name: rdiscount
-  requirement: &2157065240 !ruby/object:Gem::Requirement
+  requirement: &2157008940 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -122,10 +122,10 @@ dependencies:
         version: 1.6.8
   type: :development
   prerelease: false
-  version_requirements: *2157065240
+  version_requirements: *2157008940
 - !ruby/object:Gem::Dependency
   name: term-ansicolor
-  requirement: &2157064400 !ruby/object:Gem::Requirement
+  requirement: &2157008020 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -133,10 +133,10 @@ dependencies:
         version: 1.0.6
   type: :development
   prerelease: false
-  version_requirements: *2157064400
+  version_requirements: *2157008020
 - !ruby/object:Gem::Dependency
   name: builder
-  requirement: &2157063840 !ruby/object:Gem::Requirement
+  requirement: &2157006020 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -144,7 +144,7 @@ dependencies:
         version: 2.1.2
   type: :development
   prerelease: false
-  version_requirements: *2157063840
+  version_requirements: *2157006020
 description: A fast Gherkin lexer/parser based on the Ragel State Machine Compiler.
 email: cukes@googlegroups.com
 executables: []
@@ -490,7 +490,7 @@ rubyforge_project:
 rubygems_version: 1.8.10
 signing_key: 
 specification_version: 3
-summary: gherkin-2.6.9
+summary: gherkin-2.7.1
 test_files:
 - features/escaped_pipes.feature
 - features/feature_parser.feature