gh 0.1.2 → 0.2.0

data/.travis.yml

@@ -12,6 +12,5 @@ rvm:
   - ree
 matrix:
   allow_failures:
-    - rvm: ruby-head
-    - rvm: rbx-18mode
-    - rvm: rbx-19mode
+    - rvm: jruby-19mode
+    - rvm: jruby-head

data/README.md

@@ -1,38 +1,118 @@
-**This is work in progress and not yet usable!**
+# GH - Layered GitHub API client
 
-Goal of this library is to ease usage of the Github API as part of large, tightly integrated, distributed projects, such as [Travis CI](http://travis-ci.org). It was born out due to issues we ran into with all existing Github libraries and the Github API itself.
+This is a highly flexible, layered, low-level GitHub client library, trying to get out of your way and let you get to the GitHub data as simple as possible. Unless you add layers, you will end up with Hashes and Arrays. The approach and API should be familiar from projects like Rack or Faraday.
 
-With that in mind, this library follows the following goals:
+Simple example:
 
-* Implement features in separate layers, make layers as independend of each other as possible
-* Higher level layers should not worry about when to send requests
-* It should only send requests to Github when necessary
-* It should be able to fetch data from Github asynchronously (i.e. HTTP requests to Travis should not be bound to HTTP requests to Github, if possible)
-* It should be able to deal with events and hooks well (i.e. update cached entities with hook data)
-* It should not have intransparent magic (i.e. implicit, undocumented requirements on fields we get from Github)
-* It should shield against possible changes to the Github API or at least complain about those changes if it can't deal with it.
+``` ruby
+require 'gh'
+puts GH['users/rkh']['name']
+```
+
+This will by default use all the middleware that ships with GH, in the following order
+
+* `GH::Remote` - sends HTTP requests to GitHub and parses the response
+* `GH::Normalizer` - renames fields consistenly, adds hypermedia links if possible
+* `GH::Cache` - caches the responses (will use Rails cache if in Rails, in-memory cache otherwise)
+* `GH::LazyLoader` - will load missing fields when accessed (handy for dealing with incomplete data without sending to many requests)
+* `GH::LinkFollower` - will add content of hypermedia links as fields (lazyly), allows you to traverse relations
+
+## Main Entry Points
+
+Every layer has two main entry points:
+
+* `[key]` - loads data from GitHub
+* `load(data)` - takes data and applies modifications (handy for dealing with service hook payloads)
+
+These two methods are exposed by any instance of a layer and the `GH` constant.
+
+## Using a Single Layer
+
+You can initialize and use any layer on its own:
+
+``` ruby
+gh = GH::Remote.new
+puts gh['users/rkh']['name']
+```
+
+Layers know which other layer they should usually wrap (`Remote` wraps no other layer, `LazyLoader` and `LinkFollower` wrap `Normalizer` by default, anything else wraps `Remote`), so you can initialize them right away:
+
+``` ruby
+gh = GH::LazyLoader.new
+```
+
+You can also pass the layer that should be wrapped as an argument:
+
+``` ruby
+gh = GH::LazyLoader.new(GH::LinkFollower.new)
+```
+
+## Creating Your Own Stack
+
+For convinience a stack DSL is provided:
 
-Most of this is not yet implemented!
+``` ruby
+gh = GH::Stack.build do
+  use GH::Normalizer
+  use GH::Cache
+end
 
-The lower level APIs support a Rack-like stacking API:
+puts gh['users/rkh']['name']
+```
+
+You can also create reusable `Stack` instances:
 
 ``` ruby
-api = GH::Stack.build do
-  use GH::Cache, cache: Rails.cache
+stack = GH::Stack.new do
   use GH::Normalizer
-  use GH::Remote, username: "admin", password: "admin"
+  use GH::Cache
 end
+
+gh = stack.build username: 'rkh', password: 'abc123'
+puts gh['user']['name']
 ```
 
-Usage example:
+One such instance (with the standard setup) can be accessed as `GH::DefaultStack`
+
+## Scoping
+
+With the main goal to separate authentication from other logic, the `gh` library supports scopting:
 
 ``` ruby
-GH.with username: 'rkh', password: 'abc123' do
-  sven = GH['users/svenfuchs']
+GH.with GH::LazyLoader.new do
+  puts GH['users/rkh']['name']
+end
+```
+
+That way, you could create a stack with, for instance, an [access token](http://developer.github.com/v3/oauth/):
 
-  if sven['hireable']
-    # recruiter has to be provided by some different library
-    Recruiter.contact sven['email']
-  end
+``` ruby
+authenticated = GH::DefaultStack token: 'e72e16c7e42f292c6912e7710c838347ae178b4a'
+
+GH.with(authenticated) do
+  # ...
+end
+```
+
+Since this is rather common, you can pass options directly to `with`:
+
+``` ruby
+GH.with(username: 'rkh', password: 'abc123') do
+  # ...
 end
 ```
+
+Scoping is thread-safe.
+
+## Is this production ready?
+
+I hope so, we use it in production for [Travis CI](http://travis-ci.org/). The work on this library has been funded by the [Travis Love Campaign](https://love.travis-ci.org/).
+
+## History
+
+* 2012-04-10: 0.2.0 - added link following plus bug fixes (mainly encoding issues)
+* 2012-04-06: 0.1.2 - bug fix release (issues with cache reloading)
+* 2012-04-06: 0.1.1 - bug fix release (DSL fixes)
+* 2012-04-04: 0.1.0 - many bug fixes plus lazy loading
+* 2012-03-21: 0.0.1 - first public release
+* 2012-03-05: project started

data/lib/gh.rb

@@ -3,14 +3,15 @@ require 'backports'
 require 'forwardable'
 
 module GH
-  autoload :Cache,      'gh/cache'
-  autoload :Case,       'gh/case'
-  autoload :LazyLoader, 'gh/lazy_loader'
-  autoload :Normalizer, 'gh/normalizer'
-  autoload :Remote,     'gh/remote'
-  autoload :Response,   'gh/response'
-  autoload :Stack,      'gh/stack'
-  autoload :Wrapper,    'gh/wrapper'
+  autoload :Cache,        'gh/cache'
+  autoload :Case,         'gh/case'
+  autoload :LazyLoader,   'gh/lazy_loader'
+  autoload :LinkFollower, 'gh/link_follower'
+  autoload :Normalizer,   'gh/normalizer'
+  autoload :Remote,       'gh/remote'
+  autoload :Response,     'gh/response'
+  autoload :Stack,        'gh/stack'
+  autoload :Wrapper,      'gh/wrapper'
 
   def self.with(backend)
     backend = DefaultStack.build(backend) if Hash === backend
@@ -32,6 +33,7 @@ module GH
   def_delegators :current, :api_host, :[], :reset
 
   DefaultStack = Stack.new do
+    use LinkFollower
     use LazyLoader
     use Cache
     use Normalizer

data/lib/gh/link_follower.rb

@@ -0,0 +1,19 @@
+module GH
+  class LinkFollower < Wrapper
+    wraps GH::Normalizer
+    double_dispatch
+
+    def modify_hash(hash)
+      hash = super
+      setup_lazy_loading(hash) if hash['_links']
+      hash
+    end
+
+    private
+
+    def lazy_load(hash, key)
+      link = hash['_links'][key]
+      { key => backend[link['href']] } if link
+    end
+  end
+end

data/lib/gh/response.rb

@@ -34,8 +34,8 @@ module GH
       else raise ArgumentError, "cannot parse #{body.inspect}"
       end
 
+      @body.force_encoding("utf-8") if @body.respond_to? :force_encoding
       @body ||= MultiJson.encode(@data)
-      @body   = @body.encode("utf-8") if @body.respond_to? :encode
       @data ||= MultiJson.decode(@body)
     end
 

data/lib/gh/version.rb

@@ -1,4 +1,4 @@
 module GH
   # Public: Library version.
-  VERSION = "0.1.2"
+  VERSION = "0.2.0"
 end

data/spec/link_follower_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+describe GH::LinkFollower do
+  before { subject.backend = GH::Normalizer.new(GH::MockBackend.new) }
+
+  let(:pull_request) { subject['/repos/sinatra/sinatra/pulls/56'] }
+  let(:comments) { pull_request['comments'] }
+  let(:comment) { comments.first }
+  let(:commentator) { comment['owner'] }
+
+  it 'follows links' do
+    commentator['login'].should be == 'rtomayko'
+  end
+
+  it 'works with lazy loading' do
+    subject.backend = GH::LazyLoader.new(subject.backend)
+    # location is not included in the comment payload
+    commentator["location"].should be == "San Francisco"
+  end
+end

data/spec/payloads/repos/sinatra/sinatra/issues/56/comments.yml

@@ -0,0 +1,36 @@
+---
+- !binary "c2VydmVy": !binary |-
+    bmdpbngvMS4wLjEz
+  !binary "ZGF0ZQ==": !binary |-
+    VHVlLCAxMCBBcHIgMjAxMiAxMTo1MzoxMiBHTVQ=
+  !binary "Y29udGVudC10eXBl": !binary |-
+    YXBwbGljYXRpb24vanNvbjsgY2hhcnNldD11dGYtOA==
+  !binary "dHJhbnNmZXItZW5jb2Rpbmc=": !binary |-
+    Y2h1bmtlZA==
+  !binary "Y29ubmVjdGlvbg==": !binary |-
+    a2VlcC1hbGl2ZQ==
+  !binary "c3RhdHVz": !binary |-
+    MjAwIE9L
+  !binary "eC1yYXRlbGltaXQtbGltaXQ=": !binary |-
+    NTAwMA==
+  !binary "ZXRhZw==": !binary |-
+    ImI5MDUzNGQ0Zjk3YTU0OGEwNTY1NWIyODg4OGM4YTZhIg==
+  !binary "eC1yYXRlbGltaXQtcmVtYWluaW5n": !binary |-
+    NDk5Mw==
+- ! '[{"created_at":"2010-09-01T15:42:44Z","body":"This all looks good to me. Anyone
+  run the unit tests under 1.8.6, 1.8.7, 1.9.2?","url":"https://api.github.com/repos/sinatra/sinatra/issues/comments/383214","updated_at":"2010-09-01T15:42:44Z","user":{"gravatar_id":"abfc88b96ae18c85ba7aac3bded2ec5e","url":"https://api.github.com/users/rtomayko","login":"rtomayko","avatar_url":"https://secure.gravatar.com/avatar/abfc88b96ae18c85ba7aac3bded2ec5e?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","id":404},"id":383214},{"created_at":"2010-09-01T15:48:46Z","body":"Yep,
+  all pass. Even on JRuby 1.5.2. But on 1.9.2 they have to be run manually (see #52),
+  at least on my box. Same goes for current master, however.","url":"https://api.github.com/repos/sinatra/sinatra/issues/comments/383231","updated_at":"2010-09-01T16:00:16Z","user":{"gravatar_id":"5c2b452f6eea4a6d84c105ebd971d2a4","url":"https://api.github.com/users/rkh","login":"rkh","avatar_url":"https://secure.gravatar.com/avatar/5c2b452f6eea4a6d84c105ebd971d2a4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","id":30442},"id":383231},{"created_at":"2010-09-01T16:16:08Z","body":"Hi,
+  why would you want to keep a version of Tilt bundled on Sinatra when Sinatra can
+  include Tilt as a dependency?","url":"https://api.github.com/repos/sinatra/sinatra/issues/comments/383302","updated_at":"2010-09-01T16:16:08Z","user":{"gravatar_id":"9d0d8afbcf75a57c86e41ba0fc6f8a98","url":"https://api.github.com/users/mr-rock","login":"mr-rock","avatar_url":"https://secure.gravatar.com/avatar/9d0d8afbcf75a57c86e41ba0fc6f8a98?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","id":23641},"id":383302},{"created_at":"2010-09-01T16:18:24Z","body":"Yeah.
+  I think the last time blake and I discussed tilt bundling, we decided to *not* bundle
+  it and just make it a dependency.","url":"https://api.github.com/repos/sinatra/sinatra/issues/comments/383307","updated_at":"2010-09-01T16:18:24Z","user":{"gravatar_id":"abfc88b96ae18c85ba7aac3bded2ec5e","url":"https://api.github.com/users/rtomayko","login":"rtomayko","avatar_url":"https://secure.gravatar.com/avatar/abfc88b96ae18c85ba7aac3bded2ec5e?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","id":404},"id":383307},{"created_at":"2010-09-01T16:21:54Z","body":"Lots
+  of goodies in here, particularly added support for scss views.","url":"https://api.github.com/repos/sinatra/sinatra/issues/comments/383320","updated_at":"2010-09-01T16:21:54Z","user":{"gravatar_id":"7fe945668a4fc098e886e20dea71d2ee","url":"https://api.github.com/users/zzak","login":"zzak","avatar_url":"https://secure.gravatar.com/avatar/7fe945668a4fc098e886e20dea71d2ee?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","id":277819},"id":383320},{"created_at":"2010-09-01T16:27:24Z","body":"@RTomayko:
+  I don''t see the point to repeat code that is going to be obsolete in some time
+  anyway. I already made a pull request in which Tilt is removed from Sinatra and
+  Tilt is a dependency of the gem. I tested it in Ruby 1.9.1 and it seems to work.","url":"https://api.github.com/repos/sinatra/sinatra/issues/comments/383334","updated_at":"2010-09-01T20:46:27Z","user":{"gravatar_id":"9d0d8afbcf75a57c86e41ba0fc6f8a98","url":"https://api.github.com/users/mr-rock","login":"mr-rock","avatar_url":"https://secure.gravatar.com/avatar/9d0d8afbcf75a57c86e41ba0fc6f8a98?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","id":23641},"id":383334},{"created_at":"2010-09-02T05:20:52Z","body":"@RTomayko:
+  Before Tilt is unbundled, could you please do another Tilt release? I think the
+  ScssTemplate hasn''t made it into 1.0.1.","url":"https://api.github.com/repos/sinatra/sinatra/issues/comments/384475","updated_at":"2010-09-02T05:20:52Z","user":{"gravatar_id":"5c2b452f6eea4a6d84c105ebd971d2a4","url":"https://api.github.com/users/rkh","login":"rkh","avatar_url":"https://secure.gravatar.com/avatar/5c2b452f6eea4a6d84c105ebd971d2a4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","id":30442},"id":384475},{"created_at":"2010-09-02T05:35:17Z","body":"Scss
+  support was added after 1.0.1: http://github.com/rtomayko/tilt/commit/d6e8795c619970d0cfdbf4aead0869c592c44fe6","url":"https://api.github.com/repos/sinatra/sinatra/issues/comments/384487","updated_at":"2010-09-02T05:35:17Z","user":{"gravatar_id":"7fe945668a4fc098e886e20dea71d2ee","url":"https://api.github.com/users/zzak","login":"zzak","avatar_url":"https://secure.gravatar.com/avatar/7fe945668a4fc098e886e20dea71d2ee?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","id":277819},"id":384487},{"created_at":"2010-09-07T05:35:18Z","body":"You
+  can now do `rake spec` on 1.9.2p0, too. (And it passes, of course.)","url":"https://api.github.com/repos/sinatra/sinatra/issues/comments/392094","updated_at":"2010-09-07T05:35:39Z","user":{"gravatar_id":"5c2b452f6eea4a6d84c105ebd971d2a4","url":"https://api.github.com/users/rkh","login":"rkh","avatar_url":"https://secure.gravatar.com/avatar/5c2b452f6eea4a6d84c105ebd971d2a4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","id":30442},"id":392094},{"created_at":"2010-09-19T21:21:50Z","body":"How
+  do you feel about including #62 and #63, maybe even #58?","url":"https://api.github.com/repos/sinatra/sinatra/issues/comments/416490","updated_at":"2010-09-19T21:21:50Z","user":{"gravatar_id":"5c2b452f6eea4a6d84c105ebd971d2a4","url":"https://api.github.com/users/rkh","login":"rkh","avatar_url":"https://secure.gravatar.com/avatar/5c2b452f6eea4a6d84c105ebd971d2a4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","id":30442},"id":416490}]'

data/spec/payloads/repos/sinatra/sinatra/issues/comments/383214.yml

@@ -0,0 +1,21 @@
+---
+- !binary "c2VydmVy": !binary |-
+    bmdpbngvMS4wLjEz
+  !binary "ZGF0ZQ==": !binary |-
+    VHVlLCAxMCBBcHIgMjAxMiAxMTo1MzoyNyBHTVQ=
+  !binary "Y29udGVudC10eXBl": !binary |-
+    YXBwbGljYXRpb24vanNvbjsgY2hhcnNldD11dGYtOA==
+  !binary "dHJhbnNmZXItZW5jb2Rpbmc=": !binary |-
+    Y2h1bmtlZA==
+  !binary "Y29ubmVjdGlvbg==": !binary |-
+    a2VlcC1hbGl2ZQ==
+  !binary "c3RhdHVz": !binary |-
+    MjAwIE9L
+  !binary "eC1yYXRlbGltaXQtbGltaXQ=": !binary |-
+    NTAwMA==
+  !binary "ZXRhZw==": !binary |-
+    ImJhOWJlN2ViNTlmZjBkZDZhNWFhYTU3MzM0ODE5ZjI5Ig==
+  !binary "eC1yYXRlbGltaXQtcmVtYWluaW5n": !binary |-
+    NDk5Mg==
+- ! '{"created_at":"2010-09-01T15:42:44Z","body":"This all looks good to me. Anyone
+  run the unit tests under 1.8.6, 1.8.7, 1.9.2?","url":"https://api.github.com/repos/sinatra/sinatra/issues/comments/383214","updated_at":"2010-09-01T15:42:44Z","user":{"gravatar_id":"abfc88b96ae18c85ba7aac3bded2ec5e","avatar_url":"https://secure.gravatar.com/avatar/abfc88b96ae18c85ba7aac3bded2ec5e?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/rtomayko","login":"rtomayko","id":404},"id":383214}'

data/spec/payloads/repos/sinatra/sinatra/pulls/56.yml

@@ -0,0 +1,23 @@
+---
+- !binary "c2VydmVy": !binary |-
+    bmdpbngvMS4wLjEz
+  !binary "ZGF0ZQ==": !binary |-
+    VHVlLCAxMCBBcHIgMjAxMiAxMTo1MzoxMSBHTVQ=
+  !binary "Y29udGVudC10eXBl": !binary |-
+    YXBwbGljYXRpb24vanNvbjsgY2hhcnNldD11dGYtOA==
+  !binary "dHJhbnNmZXItZW5jb2Rpbmc=": !binary |-
+    Y2h1bmtlZA==
+  !binary "Y29ubmVjdGlvbg==": !binary |-
+    a2VlcC1hbGl2ZQ==
+  !binary "c3RhdHVz": !binary |-
+    MjAwIE9L
+  !binary "eC1yYXRlbGltaXQtbGltaXQ=": !binary |-
+    NTAwMA==
+  !binary "ZXRhZw==": !binary |-
+    Ijg2ODgwMDdjMWIwMWZiZmM3OTY2NGE1OWJiMjc2MjVlIg==
+  !binary "eC1yYXRlbGltaXQtcmVtYWluaW5n": !binary |-
+    NDk5NA==
+- ! '{"merged":true,"created_at":"2010-09-01T11:33:50Z","review_comments":0,"number":56,"additions":2956,"head":{"repo":{"has_wiki":false,"created_at":"2009-12-03T10:42:35Z","description":"Classy
+  web-development dressed in a DSL","open_issues":0,"git_url":"git://github.com/rkh/sinatra.git","watchers":10,"pushed_at":"2012-03-22T10:06:05Z","url":"https://api.github.com/repos/rkh/sinatra","mirror_url":null,"fork":true,"html_url":"https://github.com/rkh/sinatra","homepage":"http://sinatra.github.com","svn_url":"https://github.com/rkh/sinatra","has_downloads":false,"size":160,"private":false,"updated_at":"2012-03-22T10:06:06Z","master_branch":"master","has_issues":false,"owner":{"gravatar_id":"5c2b452f6eea4a6d84c105ebd971d2a4","avatar_url":"https://secure.gravatar.com/avatar/5c2b452f6eea4a6d84c105ebd971d2a4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/rkh","login":"rkh","id":30442},"name":"sinatra","forks":3,"language":"Ruby","clone_url":"https://github.com/rkh/sinatra.git","ssh_url":"git@github.com:rkh/sinatra.git","id":393951},"ref":"1.1","sha":"69791f71285c84e217efc061eee15ef32ffca515","label":"rkh:1.1","user":{"gravatar_id":"5c2b452f6eea4a6d84c105ebd971d2a4","avatar_url":"https://secure.gravatar.com/avatar/5c2b452f6eea4a6d84c105ebd971d2a4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/rkh","login":"rkh","id":30442}},"merged_at":"2010-09-25T19:43:05Z","body":"Patches
+  prepared for 1.1 release.  See also http://github.com/sinatra/sinatra/issues/issue/55","diff_url":"https://github.com/sinatra/sinatra/pull/56.diff","commits":81,"url":"https://api.github.com/repos/sinatra/sinatra/pulls/56","deletions":1065,"html_url":"https://github.com/sinatra/sinatra/pull/56","patch_url":"https://github.com/sinatra/sinatra/pull/56.patch","comments":10,"base":{"repo":{"has_wiki":false,"created_at":"2009-01-14T01:27:30Z","description":"Classy
+  web-development dressed in a DSL (official / canonical repo)","open_issues":12,"git_url":"git://github.com/sinatra/sinatra.git","watchers":3442,"pushed_at":"2012-04-02T13:58:27Z","url":"https://api.github.com/repos/sinatra/sinatra","mirror_url":null,"fork":true,"html_url":"https://github.com/sinatra/sinatra","homepage":"http://www.sinatrarb.com/","svn_url":"https://github.com/sinatra/sinatra","has_downloads":true,"size":460,"private":false,"updated_at":"2012-04-10T10:05:43Z","has_issues":true,"owner":{"gravatar_id":"22be51f9cf3849462ffc4107675ec182","avatar_url":"https://secure.gravatar.com/avatar/22be51f9cf3849462ffc4107675ec182?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png","url":"https://api.github.com/users/sinatra","login":"sinatra","id":8312},"name":"sinatra","forks":431,"language":"Ruby","clone_url":"https://github.com/sinatra/sinatra.git","ssh_url":"git@github.com:sinatra/sinatra.git","id":106995},"ref":"master","sha":"1187a866346e82c98b8ad545b8f155632f7d9283","label":"sinatra:master","user":{"gravatar_id":"22be51f9cf3849462ffc4107675ec182","avatar_url":"https://secure.gravatar.com/avatar/22be51f9cf3849462ffc4107675ec182?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-orgs.png","url":"https://api.github.com/users/sinatra","login":"sinatra","id":8312}},"updated_at":"2010-09-25T19:43:06Z","state":"closed","mergeable":null,"_links":{"review_comments":{"href":"https://api.github.com/repos/sinatra/sinatra/pulls/56/comments"},"html":{"href":"https://github.com/sinatra/sinatra/pull/56"},"comments":{"href":"https://api.github.com/repos/sinatra/sinatra/issues/56/comments"},"self":{"href":"https://api.github.com/repos/sinatra/sinatra/pulls/56"}},"user":{"gravatar_id":"5c2b452f6eea4a6d84c105ebd971d2a4","avatar_url":"https://secure.gravatar.com/avatar/5c2b452f6eea4a6d84c105ebd971d2a4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","url":"https://api.github.com/users/rkh","login":"rkh","id":30442},"id":632,"merged_by":null,"changed_files":41,"closed_at":"2010-09-25T19:43:05Z","title":"1.1","issue_url":"https://github.com/sinatra/sinatra/issues/56"}'

data/spec/payloads/users/rtomayko.yml

@@ -0,0 +1,21 @@
+---
+- !binary "c2VydmVy": !binary |-
+    bmdpbngvMS4wLjEz
+  !binary "ZGF0ZQ==": !binary |-
+    VHVlLCAxMCBBcHIgMjAxMiAxMjowODo1MSBHTVQ=
+  !binary "Y29udGVudC10eXBl": !binary |-
+    YXBwbGljYXRpb24vanNvbjsgY2hhcnNldD11dGYtOA==
+  !binary "dHJhbnNmZXItZW5jb2Rpbmc=": !binary |-
+    Y2h1bmtlZA==
+  !binary "Y29ubmVjdGlvbg==": !binary |-
+    a2VlcC1hbGl2ZQ==
+  !binary "c3RhdHVz": !binary |-
+    MjAwIE9L
+  !binary "eC1yYXRlbGltaXQtbGltaXQ=": !binary |-
+    NTAwMA==
+  !binary "ZXRhZw==": !binary |-
+    ImE2NGMxMmQ5Y2YyZTJmM2E5ZDgyNWMxNjJkNTc0ZjE2Ig==
+  !binary "eC1yYXRlbGltaXQtcmVtYWluaW5n": !binary |-
+    NDk4Nw==
+- ! '{"created_at":"2008-02-19T03:30:53Z","type":"User","blog":"http://twitter.com/rtomayko","email":"r@tomayko.com","gravatar_id":"abfc88b96ae18c85ba7aac3bded2ec5e","followers":1099,"following":97,"url":"https://api.github.com/users/rtomayko","login":"rtomayko","public_repos":39,"hireable":false,"avatar_url":"https://secure.gravatar.com/avatar/abfc88b96ae18c85ba7aac3bded2ec5e?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png","public_gists":84,"name":"Ryan
+  Tomayko","location":"San Francisco","bio":null,"html_url":"https://github.com/rtomayko","company":"GitHub","id":404}'

data/spec/response_spec.rb

@@ -1,5 +1,15 @@
+# encoding: utf-8
 require 'spec_helper'
 
 describe GH::Response do
-  it 'is specified'
+  it 'handles UTF-8 properly, even if encoded binary' do
+    raw = '{"foo":"über cool sista året"}'
+    raw.force_encoding 'binary' if raw.respond_to? :force_encoding
+    response = GH::Response.new({}, raw)
+    response['foo'].should be == 'über cool sista året'
+  end
+
+  it 'handles broken encodings properly' do
+    GH::Response.new({}, "{\"foo\":\"\xC3\"}")["foo"].should be == "\xC3"
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gh
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-04-06 00:00:00.000000000 Z
+date: 2012-04-10 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70120007137640 !ruby/object:Gem::Requirement
+  requirement: &70274565390500 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70120007137640
+  version_requirements: *70274565390500
 - !ruby/object:Gem::Dependency
   name: webmock
-  requirement: &70120007137220 !ruby/object:Gem::Requirement
+  requirement: &70274565390060 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70120007137220
+  version_requirements: *70274565390060
 - !ruby/object:Gem::Dependency
   name: faraday
-  requirement: &70120007136720 !ruby/object:Gem::Requirement
+  requirement: &70274565389500 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: '0.7'
   type: :runtime
   prerelease: false
-  version_requirements: *70120007136720
+  version_requirements: *70274565389500
 - !ruby/object:Gem::Dependency
   name: backports
-  requirement: &70120007136220 !ruby/object:Gem::Requirement
+  requirement: &70274565388980 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -54,10 +54,10 @@ dependencies:
         version: '2.3'
   type: :runtime
   prerelease: false
-  version_requirements: *70120007136220
+  version_requirements: *70274565388980
 - !ruby/object:Gem::Dependency
   name: multi_json
-  requirement: &70120007135740 !ruby/object:Gem::Requirement
+  requirement: &70274565388440 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -65,7 +65,7 @@ dependencies:
         version: '1.0'
   type: :runtime
   prerelease: false
-  version_requirements: *70120007135740
+  version_requirements: *70274565388440
 description: multi-layer client for the github api v3
 email:
 - konstantin.mailinglists@googlemail.com
@@ -84,6 +84,7 @@ files:
 - lib/gh/case.rb
 - lib/gh/faraday.rb
 - lib/gh/lazy_loader.rb
+- lib/gh/link_follower.rb
 - lib/gh/normalizer.rb
 - lib/gh/remote.rb
 - lib/gh/response.rb
@@ -93,8 +94,13 @@ files:
 - spec/cache_spec.rb
 - spec/gh_spec.rb
 - spec/lazy_loader_spec.rb
+- spec/link_follower_spec.rb
 - spec/normalizer_spec.rb
+- spec/payloads/repos/sinatra/sinatra/issues/56/comments.yml
+- spec/payloads/repos/sinatra/sinatra/issues/comments/383214.yml
+- spec/payloads/repos/sinatra/sinatra/pulls/56.yml
 - spec/payloads/users/rkh.yml
+- spec/payloads/users/rtomayko.yml
 - spec/payloads/users/svenfuchs.yml
 - spec/remote_spec.rb
 - spec/response_spec.rb
@@ -121,7 +127,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.11
+rubygems_version: 1.8.10
 signing_key: 
 specification_version: 3
 summary: layered github client
@@ -129,8 +135,13 @@ test_files:
 - spec/cache_spec.rb
 - spec/gh_spec.rb
 - spec/lazy_loader_spec.rb
+- spec/link_follower_spec.rb
 - spec/normalizer_spec.rb
+- spec/payloads/repos/sinatra/sinatra/issues/56/comments.yml
+- spec/payloads/repos/sinatra/sinatra/issues/comments/383214.yml
+- spec/payloads/repos/sinatra/sinatra/pulls/56.yml
 - spec/payloads/users/rkh.yml
+- spec/payloads/users/rtomayko.yml
 - spec/payloads/users/svenfuchs.yml
 - spec/remote_spec.rb
 - spec/response_spec.rb