gh-events 0.8.2 → 0.8.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f42768b024e11b3e98a2352ca81f6105d3ff4b9e5767efaa3bfb56377e8c2c7a
-  data.tar.gz: 43c3fa8883db2ab811e5e358966b50b0bef3a93c73a6446f8b31ce63df7b0a7e
+  metadata.gz: 23309b6819c759bd4ae39468e40dc374409484ae1ec4568c42713ba82dbf305e
+  data.tar.gz: f9decf307c3770b981bbca41bb149f008a59aa8279a2b01ef59e4adb8d55a44b
 SHA512:
-  metadata.gz: b9f1922da318421f76427589360f62459fe37f134e468e0cd45650c41b4bd4ab5ca6181c871618986a236c299cf37852037e8996a7cb7054edf0862c320d9898
-  data.tar.gz: 9a8c9102ec4107c01b22c542d1963351fff72f68580f0131901f5556fc8c488c6abca496c9c7f6aab7bee8b3af958086e38e770a0da753117228fe8617bbd3bf
+  metadata.gz: e24a1288484269407ae8761f2db4b49e6f6f0413e7ab4bdbd43e2405f87c8ce71ac117feb42cb82bfe756a2acbf9122180b1169901380acc82db3698001adefa
+  data.tar.gz: 37c811378a88220d83d070ac5bb02ae8466e6e1be977a40307a32610b11f071a56d319832b50671c931d2d738a336fa5b9d9b21236cc32a7ef861da5295bd570

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    gh-events (0.8.2)
+    gh-events (0.8.3)
 
 GEM
   remote: https://rubygems.org/

data/lib/gh/events/text.rb

@@ -47,7 +47,22 @@ module GH::Events::Text
     # if there is no template use a default
     template ||= templates['no_template']
 
-    render(template, event).gsub(/[\n\r]+/, '\n')
+    res = render(template, event).gsub(/[\n\r]+/, '\n')
+    validate(res, dict)
+    res
+  end
+
+  # Validate the format of the response in case it's JSON
+  def validate(response, channel)
+    return unless channel == "slack"
+    begin
+      JSON.parse(response)
+    rescue Exception => e
+      warn "Rendered template is not valid JSON"
+      warn e
+      exit 1
+    end
+    response
   end
 
   def templates_file(dict)

data/lib/gh/events/version.rb

@@ -1,5 +1,5 @@
 module GH
   module Events
-    VERSION = "0.8.2"
+    VERSION = "0.8.3"
   end
 end

data/res/slack.yml

@@ -17,7 +17,7 @@ commit_comment:
     commit <<%= comment.html_url %>|`<%= comment.commit_id %>`>
     on <<%= repository.html_url %>|<%= repository.full_name %>>
   attachments:
-    - fallback: <%= comment.body %>
+    - fallback: <%= comment.body.gsub(/"/,'\"') %>
       color: '#36a64f'
       # pretext: Optional text that appears above the attachment block
       author_name: <%= sender.login %>
@@ -25,7 +25,7 @@ commit_comment:
       author_icon: <%= sender.avatar_url %>
       # title: Slack API Documentation
       # title_link: https://api.slack.com/
-      text: <%= comment.body %>
+      text: <%= comment.body.gsub(/"/,'\"') %>
       # fields:
       #   - title: Priority
       #     value: High
@@ -57,14 +57,14 @@ issue_comment:
     :left_speech_bubble:
     <<%= sender.html_url %>|<%= sender.login %>>
     commented
-    on <<%= comment.html_url %>|<%= issue.title %>>
+    on <<%= comment.html_url %>|<%= issue.title.gsub(/"/,'\"') %>>
   attachments:
-    - fallback: <%= comment.body %>
+    - fallback: <%= comment.body.gsub(/"/,'\"') %>
       color: '#36a64f'
       author_name: <%= sender.login %>
       author_link: <%= sender.html_url %>
       author_icon: <%= sender.avatar_url %>
-      text: <%= comment.body %>
+      text: <%= comment.body.gsub(/"/,'\"') %>
 
 issues:
   text: >-
@@ -143,12 +143,12 @@ pull_request_review_comment:
     new review comment
     on <<%= comment.html_url %>|<%= pull_request.title %>>
   attachments:
-    - fallback: <%= comment.body %>
+    - fallback: <%= comment.body.gsub(/"/,'\"') %>
       color: red
       author_name: <%= sender.login %>
       author_link: <%= sender.html_url %>
       author_icon: <%= sender.avatar_url %>
-      text: <%= comment.body %>
+      text: <%= comment.body.gsub(/"/,'\"') %>
 
 star:
   text: >-

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gh-events
 version: !ruby/object:Gem::Version
-  version: 0.8.2
+  version: 0.8.3
 platform: ruby
 authors:
 - Phil Hofmann
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-06-04 00:00:00.000000000 Z
+date: 2020-06-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler