ggem 1.7.0 → 1.8.0

data/lib/ggem/gem.rb

@@ -8,11 +8,12 @@ module GGem
     attr_reader :root_path, :name
 
     def initialize(path, name)
+      raise NoNameError if name.to_s.empty?
       @root_path, self.name = path, name
     end
 
     def save!
-      Template.new(self).tap{ |t| t.save; t.init }
+      Template.new(self).save
       self
     end
 
@@ -20,7 +21,10 @@ module GGem
     def name=(name); @name = normalize_name(name); end
 
     def module_name
-      transforms = {'_' => '', '-' => ''}
+      transforms = {
+        '_' => '',
+        '-' => ''
+      }
       @module_name ||= transform_name(transforms){ |part| part.capitalize }
     end
 
@@ -37,7 +41,7 @@ module GGem
       name.gsub(*und_camelcs).gsub(*rm_dup_und).sub(*rm_lead_und).downcase
     end
 
-    def transform_name(conditions={}, &block)
+    def transform_name(conditions = {}, &block)
       n = (block ? block.call(self.name) : self.name)
       conditions.each do |on, glue|
         if (a = n.split(on)).size > 1
@@ -47,6 +51,8 @@ module GGem
       n
     end
 
+    NoNameError = Class.new(ArgumentError)
+
   end
 
 end

data/lib/ggem/gemspec.rb

@@ -0,0 +1,85 @@
+require 'pathname'
+require 'scmd'
+
+module GGem
+
+  class Gemspec
+
+    PUSH_HOST_META_KEY = 'allowed_push_host'
+    DEFAULT_PUSH_HOST  = 'https://rubygems.org'.freeze
+    BUILD_TO_DIRNAME   = 'pkg'.freeze
+
+    attr_reader :path, :name, :version, :version_tag
+    attr_reader :gem_file_name, :gem_file, :push_host
+
+    def initialize(root_path)
+      @root = Pathname.new(File.expand_path(root_path))
+      raise NotFoundError unless @root.exist?
+      @path = Pathname.new(Dir[File.join(@root, "{,*}.gemspec")].first.to_s)
+      raise NotFoundError unless @path.exist?
+
+      @spec        = load_gemspec(@path)
+      @name        = @spec.name
+      @version     = @spec.version
+      @version_tag = "v#{@version}"
+
+      @gem_file_name  = "#{@name}-#{@version}.gem"
+      @gem_file       = File.join(BUILD_TO_DIRNAME, @gem_file_name)
+      @built_gem_path = @root.join(@gem_file)
+
+      @push_host = get_push_host(@spec)
+    end
+
+    def run_build_cmd
+      run_cmd("gem build --verbose #{@path}").tap do
+        gem_path = @root.join(@gem_file_name)
+        run_cmd("mkdir -p #{@built_gem_path.dirname}")
+        run_cmd("mv #{gem_path} #{@built_gem_path}")
+      end
+    end
+
+    def run_install_cmd
+      run_cmd("gem install #{@built_gem_path}")
+    end
+
+    def run_push_cmd
+      run_cmd("gem push #{@built_gem_path} --host #{@push_host}")
+    end
+
+    private
+
+    def run_cmd(cmd_string)
+      cmd = Scmd.new(cmd_string)
+      cmd.run
+      if !cmd.success?
+        raise CmdError, "#{cmd_string}\n" \
+                        "#{cmd.stderr.empty? ? cmd.stdout : cmd.stderr}"
+      end
+      [cmd_string, cmd.exitstatus, cmd.stdout]
+    end
+
+    def load_gemspec(path)
+      eval(path.read, TOPLEVEL_BINDING, path.expand_path.to_s)
+    rescue ScriptError, StandardError => e
+      original_line = e.backtrace.find{ |line| line.include?(path.to_s) }
+      msg = "There was a #{e.class} while loading #{path.basename}: \n#{e.message}"
+      msg << " from\n  #{original_line}" if original_line
+      msg << "\n"
+      raise LoadError, msg
+    end
+
+    def get_push_host(spec)
+      ENV['GGEM_PUSH_HOST'] || get_meta(spec)[PUSH_HOST_META_KEY] || DEFAULT_PUSH_HOST
+    end
+
+    def get_meta(spec)
+      (spec.respond_to?(:metadata) ? spec.metadata : {}) || {}
+    end
+
+    NotFoundError = Class.new(ArgumentError)
+    LoadError     = Class.new(ArgumentError)
+    CmdError      = Class.new(RuntimeError)
+
+  end
+
+end

data/lib/ggem/git_repo.rb

@@ -0,0 +1,60 @@
+require 'pathname'
+require 'scmd'
+
+module GGem
+
+  class GitRepo
+
+    attr_reader :path
+
+    def initialize(repo_path)
+      @path = Pathname.new(File.expand_path(repo_path))
+    end
+
+    def run_init_cmd
+      run_cmd("git init").tap do
+        run_cmd("git add --all && git add -f *.gitkeep")
+      end
+    end
+
+    def run_validate_clean_cmd
+      run_cmd("git diff --exit-code")
+    end
+
+    def run_validate_committed_cmd
+      run_cmd("git diff-index --quiet --cached HEAD")
+    end
+
+    def run_push_cmd
+      run_cmd("git push").tap do
+        run_cmd("git push --tags")
+      end
+    end
+
+    def run_add_version_tag_cmd(version, tag)
+      run_cmd("git tag -a -m \"Version #{version}\" #{tag}")
+    end
+
+    def run_rm_tag_cmd(tag)
+      run_cmd("git tag -d #{tag}")
+    end
+
+    private
+
+    def run_cmd(cmd_string)
+      cmd_string = "cd #{@path} && #{cmd_string}"
+      cmd = Scmd.new(cmd_string)
+      cmd.run
+      if !cmd.success?
+        raise CmdError, "#{cmd_string}\n" \
+                        "#{cmd.stderr.empty? ? cmd.stdout : cmd.stderr}"
+      end
+      [cmd_string, cmd.exitstatus, cmd.stdout]
+    end
+
+    NotFoundError = Class.new(ArgumentError)
+    CmdError      = Class.new(RuntimeError)
+
+  end
+
+end

data/lib/ggem/template.rb

@@ -2,6 +2,7 @@ require 'erb'
 require 'fileutils'
 
 module GGem
+
   class Template
 
     def initialize(ggem)
@@ -20,7 +21,6 @@ module GGem
       save_file('gitignore.erb', '.gitignore')
       save_file('Gemfile.erb',   'Gemfile')
       save_file('gemspec.erb',   "#{@gem.name}.gemspec")
-      save_file('Rakefile.erb',  'Rakefile')
       save_file('README.md.erb', 'README.md')
       save_file('LICENSE.erb',   'LICENSE')
 
@@ -34,13 +34,6 @@ module GGem
       save_empty_file('tmp/.gitkeep')
     end
 
-    def init
-      cmd = "cd #{@gem.path} &&"\
-            " git init && git add --all &&"\
-            " git add -f log/.gitkeep && git add -f tmp/.gitkeep"
-      `#{cmd}`
-    end
-
     private
 
     def save_folder(relative_path=nil)
@@ -67,4 +60,5 @@ module GGem
     end
 
   end
+
 end

data/lib/ggem/template_file/Gemfile.erb

@@ -2,5 +2,4 @@ source "https://rubygems.org"
 
 gemspec
 
-gem 'rake', "~> 10.4.0"
-gem 'pry',  "~> 0.9.0"
+gem 'pry', "~> 0.9.0"

data/lib/ggem/template_file/gemspec.erb

@@ -8,9 +8,9 @@ Gem::Specification.new do |gem|
   gem.version     = <%= @gem.module_name %>::VERSION
   gem.authors     = ["TODO: authors"]
   gem.email       = ["TODO: emails"]
-  gem.description = %q{TODO: Write a gem description}
-  gem.summary     = %q{TODO: Write a gem summary}
-  gem.homepage    = "http://github.com/__/<%= @gem.name %>"
+  gem.summary     = "TODO: Write a gem summary"
+  gem.description = "TODO: Write a gem description"
+  gem.homepage    = "TODO: homepage"
   gem.license     = 'MIT'
 
   gem.files         = `git ls-files`.split($/)
@@ -18,7 +18,7 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ["lib"]
 
-  gem.add_development_dependency("assert", ["~> 2.15"])
-  # TODO: gem.add_dependency("gem-name", ["~> 0.0"])
+  gem.add_development_dependency("assert", ["~> 2.15.0"])
+  # TODO: gem.add_dependency("gem-name", ["~> 0.0.0"])
 
 end

data/lib/ggem/version.rb

@@ -1,3 +1,3 @@
 module GGem
-  VERSION = "1.7.0"
+  VERSION = "1.8.0"
 end

data/test/helper.rb

@@ -2,52 +2,13 @@
 # put any test helpers here
 
 # add the root dir to the load path
-$LOAD_PATH.unshift(File.expand_path("../..", __FILE__))
+require 'pathname'
+ROOT_PATH = Pathname.new(File.expand_path('../..', __FILE__))
+$LOAD_PATH.unshift(ROOT_PATH.to_s)
+TMP_PATH = ROOT_PATH.join('tmp')
+TEST_SUPPORT_PATH = ROOT_PATH.join('test/support')
 
 # require pry for debugging (`binding.pry`)
 require 'pry'
 
 require 'test/support/factory'
-
-class Assert::Context
-
-  TMP_PATH = File.expand_path "../../tmp", __FILE__
-
-  def self.create_paths(name_set)
-    called_from = caller.first
-    folders = name_set.expected_folders
-    files = name_set.expected_files
-
-    paths = (folders + files).collect{|p| File.join(TMP_PATH, name_set.name, p)}
-    macro_name =  "create the paths: #{paths.join(', ')}"
-
-    Assert::Macro.new(macro_name) do
-      paths.flatten.each do |path|
-        should "create the path '#{path}'", called_from do
-          assert File.exists?(path), "'#{path}' does not exist"
-        end
-      end
-    end
-
-  end
-
-  def self.generate_name_set(name_set)
-    called_from = caller.first
-    macro_name =  "generate the name_set: #{name_set.inspect}"
-
-    Assert::Macro.new(macro_name) do
-      name_set.variations.each do |variation|
-        [:name, :module_name, :ruby_name].each do |name_type|
-          should "know its :#{name_type} given '#{variation}'", called_from do
-            the_gem = GGem::Gem.new(TMP_PATH, variation)
-            assert_equal name_set.send(name_type), the_gem.send(name_type)
-          end
-        end
-      end
-    end
-
-  end
-
-end
-
-

data/test/support/cmd_tests_helpers.rb

@@ -0,0 +1,53 @@
+require 'much-plugin'
+require 'scmd'
+
+module GGem
+
+  module CmdTestsHelpers
+    include MuchPlugin
+
+    plugin_included do
+      setup do
+        ENV['SCMD_TEST_MODE'] = '1'
+
+        @cmd_spy = nil
+        Scmd.reset
+
+        @exp_cmds_run = []
+      end
+      teardown do
+        Scmd.reset
+        ENV.delete('SCMD_TEST_MODE')
+      end
+
+      private
+
+      def assert_exp_cmds_run(&run_cmd_block)
+        cmd_str, exitstatus, stdout = run_cmd_block.call
+        assert_equal @exp_cmds_run, Scmd.calls.map(&:cmd_str)
+
+        assert_equal Scmd.calls.first.cmd_str,        cmd_str
+        assert_equal Scmd.calls.first.cmd.exitstatus, exitstatus
+        assert_equal Scmd.calls.first.cmd.stdout,     stdout
+      end
+
+      def assert_exp_cmds_error(cmd_error_class, &run_cmd_block)
+        err_cmd_str = @exp_cmds_run.choice
+        Scmd.add_command(err_cmd_str) do |cmd|
+          cmd.exitstatus = 1
+          cmd.stderr     = Factory.string
+          @cmd_spy       = cmd
+        end
+        err = nil
+        begin; run_cmd_block.call; rescue StandardError => err; end
+
+        assert_kind_of cmd_error_class, err
+        exp = "#{@cmd_spy.cmd_str}\n#{@cmd_spy.stderr}"
+        assert_equal exp, err.message
+      end
+
+    end
+
+  end
+
+end

data/test/support/gem1/gem1.gemspec

@@ -0,0 +1,16 @@
+# -*- encoding: utf-8 -*-
+Gem::Specification.new do |gem|
+  gem.name        = "gem1"
+  gem.version     = "0.1.0"
+  gem.authors     = []
+  gem.email       = []
+  gem.summary     = %q{Gem 1 summary}
+  gem.description = %q{Gem 1 description}
+  gem.license     = 'MIT'
+
+  gem.files         = []
+  gem.executables   = []
+  gem.test_files    = []
+  gem.require_paths = []
+
+end

data/test/support/gem2/gem2.gemspec

@@ -0,0 +1,18 @@
+# -*- encoding: utf-8 -*-
+Gem::Specification.new do |gem|
+  gem.name        = "gem2"
+  gem.version     = "0.2.0"
+  gem.authors     = []
+  gem.email       = []
+  gem.summary     = %q{Gem 2 summary}
+  gem.description = %q{Gem 2 description}
+  gem.license     = 'MIT'
+
+  gem.metadata['allowed_push_host'] = 'http://gems.example.com'
+
+  gem.files         = []
+  gem.executables   = []
+  gem.test_files    = []
+  gem.require_paths = []
+
+end

data/test/support/name_set.rb

@@ -21,7 +21,6 @@ module GGem
         [ ".gitignore",
           "Gemfile",
           "#{@name}.gemspec",
-          "Rakefile",
           "README.md",
           "LICENSE",
 

data/test/system/ggem_tests.rb

@@ -5,39 +5,67 @@ require 'test/support/name_set'
 
 module GGem
 
-  class BaseTests < Assert::Context
-    desc "GGem"
+  class SystemTests < Assert::Context
 
     NS_SIMPLE = GGem::NameSet::Simple
     NS_UNDER  = GGem::NameSet::Underscored
     NS_HYPHEN = GGem::NameSet::HyphenatedOther
 
-    [ NS_SIMPLE, NS_UNDER, NS_HYPHEN ].each do |ns|
-      should generate_name_set(ns.new)
+    desc "GGem"
+
+  end
+
+  class GemTests < SystemTests
+    desc "Gem"
+
+    should "know its name attrs for various name styles (simple/underscored/hyphenated)" do
+      [NS_SIMPLE, NS_UNDER, NS_HYPHEN].each do |ns|
+        assert_gem_name_set(ns.new)
+      end
+    end
+
+    private
+
+    def assert_gem_name_set(name_set)
+      name_set.variations.each do |variation|
+        the_gem = GGem::Gem.new(TMP_PATH, variation)
+        [:name, :module_name, :ruby_name].each do |name_type|
+          assert_equal name_set.send(name_type), the_gem.send(name_type)
+        end
+      end
     end
 
   end
 
-  class SaveTests < BaseTests
-    desc "when saving gems"
-    setup_once do
+  class GemSaveTests < GemTests
+    setup do
       FileUtils.rm_rf(TMP_PATH)
       FileUtils.mkdir_p(TMP_PATH)
-      GGem::Gem.new(TMP_PATH, NS_SIMPLE.new.variations.first).save!
-      GGem::Gem.new(TMP_PATH, NS_UNDER.new.variations.first).save!
-      GGem::Gem.new(TMP_PATH, NS_HYPHEN.new.variations.first).save!
     end
-    teardown_once do
+    teardown do
       FileUtils.rm_rf(TMP_PATH)
     end
 
-    should create_paths(NS_SIMPLE.new)
-    should create_paths(NS_UNDER.new)
-    should create_paths(NS_HYPHEN.new)
+    should "save gems with various name styles (simple/underscored/hyphenated)" do
+      [NS_SIMPLE, NS_UNDER, NS_HYPHEN].each do |ns|
+        init_gem = GGem::Gem.new(TMP_PATH, ns.new.variations.first)
+        gem_from_save = init_gem.save!
+
+        assert_gem_created(ns.new)
+        assert_same init_gem, gem_from_save
+      end
+    end
+
+    private
+
+    def assert_gem_created(name_set)
+      folders = name_set.expected_folders
+      files   = name_set.expected_files
+      paths   = (folders + files).collect{ |p| File.join(TMP_PATH, name_set.name, p) }
 
-    should "init a git repo in the gem path" do
-      exp_path = File.join(TMP_PATH, NS_SIMPLE.new.name, '.git')
-      assert File.exists?(exp_path), ".git repo config doesn't exist"
+      paths.flatten.each do |path|
+        assert File.exists?(path), "'#{path}' does not exist"
+      end
     end
 
   end