geti 1.0.0 → 1.1.0

data/VERSION

@@ -1 +1 @@
-1.0.0
+1.1.0

data/lib/geti/client.rb

@@ -29,7 +29,7 @@ class Geti::Client
     end
 
     op_key ||= operation.gsub(/(.)([A-Z])/, '\1_\2').downcase
-    operation.sub!('_certification','') unless certification?
+    op_key.sub!('_certification','') unless certification?
     response_key = (op_key+'_response').to_sym
     result_key = (op_key+'_result').to_sym
 

data/spec/geti_app_client_spec.rb

@@ -53,6 +53,21 @@ describe Geti::AppClient do
     }
   end
 
+  def production_soap_response
+    Nori.parse("<?xml version=\"1.0\" encoding=\"utf-8\"?><soap:Envelope xmlns:soap=\"http://schemas.xmlsoap.org/soap/envelope/\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" xmlns:xsd=\"http://www.w3.org/2001/XMLSchema\"><soap:Body><BoardMerchant_ACHResponse xmlns=\"http://tempuri.org/GETI.eMagnus.WebServices/AppGateway\"><BoardMerchant_ACHResult>&lt;?xml version=\"1.0\" encoding=\"utf-8\"?&gt;&lt;RESPONSE xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" xmlns:xsd=\"http://www.w3.org/2001/XMLSchema\"&gt;&lt;STATUS&gt;Pending&lt;/STATUS&gt;&lt;MESSAGE&gt;1 merchant(s) created.\n0 merchant(s) not created due to errors.\n\n-----------------------\nMerchants Created:\nMy Company (ISO ID: 10150, CrossRef: 83, Status: PendingInput)\n\n&lt;/MESSAGE&gt;&lt;APP_DATA&gt;&lt;Merchant ID=\"1844832\" /&gt;&lt;/APP_DATA&gt;&lt;VALIDATION_MESSAGE&gt;&lt;RESULT&gt;Passed&lt;/RESULT&gt;&lt;SCHEMA_FILE_PATH /&gt;&lt;/VALIDATION_MESSAGE&gt;&lt;/RESPONSE&gt;</BoardMerchant_ACHResult></BoardMerchant_ACHResponse></soap:Body></soap:Envelope>\n")[:envelope][:body]
+  end
+
+  def pending_response
+    {:response=>
+      {:status=>"Pending",
+       :"@xmlns:xsd"=>"http://www.w3.org/2001/XMLSchema",
+       :"@xmlns:xsi"=>"http://www.w3.org/2001/XMLSchema-instance",
+       :message=>
+        "1 merchant(s) created.\n0 merchant(s) not created due to errors.\n\n-----------------------\nMerchants Created:\nMy Company (ISO ID: 10150, CrossRef: 83, Status: PendingInput)\n\n",
+       :validation_message=>{:schema_file_path=>nil, :result=>"Passed"},
+       :app_data=>{:merchant=>{:@id=>"1844832"}}}}
+  end
+
   def success_response
     {:response=>{
       :status=>"Approved",
@@ -122,13 +137,13 @@ describe Geti::AppClient do
   describe '#board_merchant_ach' do
     it 'calls BoardCertificationMerchant_ACH' do
       client = Geti::AppClient.new(test_credentials, {})
-      mock_soap!(client, success_response, "BoardCertificationMerchant_ACH", "board_certification_merchant_ach")
+      mock_soap!(client, pending_response, "BoardCertificationMerchant_ACH", "board_certification_merchant_ach")
       client.board_merchant_ach(request_payload)
     end
 
     it 'calls BoardMerchant_ACH in production' do
       client = Geti::AppClient.new(test_credentials, {}, 'production')
-      mock_soap!(client, success_response, "BoardMerchant_ACH", "board_certification_merchant_ach")
+      mock_soap!(client, pending_response, "BoardMerchant_ACH", "board_merchant_ach")
       client.board_merchant_ach(request_payload)
     end
 
@@ -140,6 +155,16 @@ describe Geti::AppClient do
       }
       subject { client.board_merchant_ach(request_payload) }
 
+      describe 'on pending' do
+        let(:response) { pending_response }
+        its([:success]) { should be_true }
+        its([:status]) { should eq("Pending") }
+
+        it 'normalizes (nested) keys' do
+          subject[:app_data][:merchant][:id].should eq("1844832")
+        end
+      end
+
       describe 'on success' do
         let(:response) { success_response }
         its([:success]) { should be_true }
@@ -162,5 +187,15 @@ describe Geti::AppClient do
         its([:status]) { should be_nil }
       end
     end
+
+    describe 'production response handling' do
+      it 'does not error' do
+        client = Geti::AppClient.new(test_credentials, {}, 'production').tap{|c|
+          c.soap_client.should_receive(:request).with("BoardMerchant_ACH").and_return(OpenStruct.new(:body => production_soap_response))
+        }
+
+        response = client.board_merchant_ach(request_payload)
+      end
+    end
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: geti
 version: !ruby/object:Gem::Version 
-  hash: 23
+  hash: 19
   prerelease: 
   segments: 
   - 1
+  - 1
   - 0
-  - 0
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors: 
 - Jamie Macey
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-11-05 00:00:00 Z
+date: 2012-11-13 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: savon