getaround-rubocop 0.1.4 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bbd6ae46cb126fe3f3916ac816e95792d7bbd5f9ec51764d094eb1fff4b4a12f
-  data.tar.gz: c79b0968e467e7dfb8e707f34655c66bad0e4e47db6fecec64ef71232cbdbb2d
+  metadata.gz: a22bc10f7e80edcd83947d713edb22cb3796a9d39e5659612f311dbf9fab9407
+  data.tar.gz: a0f7bbac938030cab2addc9e450ba19545717a28b5dbada5f7ae6d9131221237
 SHA512:
-  metadata.gz: dcfeccf1213b7acf3d5ca5ae4d2d2d497162bf84e7408eab37d18a5d46725a8f7d69e8c393ba57aed707b8b40cc9a0d23a6852c6a8b46dda8f1af190aa90691e
-  data.tar.gz: b544b8f4e3c3593d32b5c6cd6d84e31e09a1643206f48a8acfb6e06ef7f92174ea2082e9a3024599a4d3cf96637ee8b27467ebb33189e4d8b7ff54d4613ee9e6
+  metadata.gz: f184487d05c6176772703807b05123e3605acd5bf2bdc5295353922a8351f1d65d01eb015845b07a276ba3ca79ee00d39ae1844b7e003f1bf122e7d54bd2a295
+  data.tar.gz: 89ff4abdc4f1f0828c00287dc41524432fa5c67a3d7945a75de401e58c421808e43ebb6d9d5b893c6fdd962b175ac87459cb611068843039e811c65bff652df8

data/.rubocop-rspec.yml

@@ -1,18 +1,25 @@
 require:
   - rubocop-rspec
 
+inherit_from: .rubocop.yml
+
 RSpec/NamedSubject:
-  Description: No justification to why this is better.
-  Enabled: false
+  Enabled: false # Increase spec writing complexity
 
 RSpec/ExampleLength:
-  Description: Exemple length is an unreliable metric.
-  Enabled: false
+  Enabled: false # Exemple length is an unreliable metric.
 
 RSpec/MultipleExpectations:
-  Description: Exemple count is an unreliable metric.
-  Enabled: false
+  Enabled: false # Exemple count is an unreliable metric.
 
 RSpec/MessageSpies:
-  Description: Induces unnecessary repetition in the expectation
-  Enabled: false
+  Enabled: false # Induces unnecessary repetition in the expectation
+
+RSpec/StubbedMock:
+  Enabled: false # StubbedMock semantics are different
+
+RSpec/SubjectStub:
+  Enabled: false # RSpec/SubjectStub is an accepted pattern
+
+RSpec/VerifiedDoubles:
+  Enabled: false # double have a more practical interface

data/.rubocop.yml

@@ -1,29 +1,28 @@
 inherit_gem:
   relaxed-rubocop: .rubocop.yml
 
-Style/ClassAndModuleChildren:
-  EnforcedStyle: compact
+AllCops:
+  Exclude:
+    - vendor/**/* # Prevent validation of bundler gems
+  NewCops: disable # Ignore "pending" cops
 
 Metrics/BlockLength:
-  Description: Length is an unreliable metric.
-  Enabled: false
+  Enabled: false # Length is an unreliable metric.
 
-Layout/SpaceInsideArrayLiteralBrackets:
-  Description: Similar to prettier's config.
-  Enabled: false
+Style/ClassAndModuleChildren:
+  Enabled: false # Neither styles are satisfying in all cases
 
-Layout/FirstArgumentIndentation:
-  Description: Useless indentation is useless.
-  Enabled: false
+Layout/SpaceInsideArrayLiteralBrackets:
+  EnforcedStyle: no_space # Similar to prettier's config.
 
 Layout/FirstArrayElementIndentation:
-  Description: Useless indentation is useless.
-  Enabled: false
+  EnforcedStyle: consistent # Consistent with Layout/FirstArgumentIndentation
 
 Layout/FirstHashElementIndentation:
-  Description: Useless indentation is useless.
-  Enabled: false
+  EnforcedStyle: consistent # Consistent with Layout/FirstArgumentIndentation
+
+Layout/MultilineMethodCallIndentation:
+  EnforcedStyle: indented # Consistent with Rails style
 
-Layout/FirstParameterIndentation:
-  Description: Useless indentation is useless.
-  Enabled: false
+Layout/ArgumentAlignment:
+  EnforcedStyle: with_fixed_indentation # Consistent with Rails style

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source "https://rubygems.org"
 
 gemspec

data/Gemfile.lock

@@ -1,40 +1,44 @@
 PATH
   remote: .
   specs:
-    getaround-rubocop (0.1.4)
+    getaround-rubocop (0.2.3)
       relaxed-rubocop (= 2.5)
-      rubocop (= 0.80.1)
+      rubocop (= 1.11.0)
+      rubocop-rspec (= 2.2.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    ast (2.4.0)
-    jaro_winkler (1.5.4)
-    parallel (1.19.1)
-    parser (2.7.0.5)
-      ast (~> 2.4.0)
+    ast (2.4.2)
+    parallel (1.20.1)
+    parser (3.0.0.0)
+      ast (~> 2.4.1)
     rainbow (3.0.0)
+    regexp_parser (2.1.1)
     relaxed-rubocop (2.5)
     rexml (3.2.4)
-    rubocop (0.80.1)
-      jaro_winkler (~> 1.5.1)
+    rubocop (1.11.0)
       parallel (~> 1.10)
-      parser (>= 2.7.0.1)
+      parser (>= 3.0.0.0)
       rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
       rexml
+      rubocop-ast (>= 1.2.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 1.7)
-    rubocop-rspec (1.38.0)
-      rubocop (>= 0.68.1)
-    ruby-progressbar (1.10.1)
-    unicode-display_width (1.6.1)
+      unicode-display_width (>= 1.4.0, < 3.0)
+    rubocop-ast (1.4.1)
+      parser (>= 2.7.1.5)
+    rubocop-rspec (2.2.0)
+      rubocop (~> 1.0)
+      rubocop-ast (>= 1.1.0)
+    ruby-progressbar (1.11.0)
+    unicode-display_width (2.0.0)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
   getaround-rubocop!
-  rubocop-rspec (= 1.38)
 
 BUNDLED WITH
-   2.1.0
+   2.1.4

data/exemples/dummy_class.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+module DummyModule
+  class DummyClass
+    def empty_method(*args); end
+
+    def dummy_caller_inline
+      empty_method({ key: value }, [nil, nil])
+    end
+
+    def dummy_caller_spread
+      empty_method({
+        key1: 'value1',
+        key2: 'value2',
+      }, [
+        nil,
+        nil,
+      ])
+    end
+
+    def dummy_caller_multiline
+      empty_method({ key1: 'value1', key2: 'value2' },
+        [nil, nil])
+    end
+  end
+end
+
+module DummyModule::InlineClass
+end

data/exemples/spec/dummy_class_spec.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+describe DummyClass do
+  it 'does things' do
+    expect(1 + 1).to eq(2)
+  end
+end

data/getaround-rubocop.gemspec

@@ -1,18 +1,21 @@
+# frozen_string_literal: true
+
 Gem::Specification.new do |gem|
-  gem.name          = "getaround-rubocop"
-  gem.version       = '0.1.4'
-  gem.summary       = "Backend configuration files"
-  gem.description   = "Shared base configuration for Getaround Backend Applications."
-  gem.authors       = ["Drivy", "Laurent Humez"]
-  gem.email         = ["oss@drivy.com"]
-  gem.homepage      = "https://github.com/drivy"
-  gem.license       = "MIT"
+  gem.name = "getaround-rubocop"
+  gem.version = '0.2.4'
+  gem.summary = "Backend configuration files"
+  gem.description = "Shared base configuration for Getaround Backend Applications."
+  gem.authors = ["Drivy", "Laurent Humez"]
+  gem.email = ["oss@drivy.com"]
+  gem.homepage = "https://github.com/drivy"
+  gem.license = "MIT"
+  gem.required_ruby_version = '~> 2.6'
 
-  gem.files         = Dir.chdir(File.expand_path(__dir__)) do
+  gem.files = Dir.chdir(File.expand_path(__dir__)) do
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(spec)/}) }
   end
 
-  gem.add_runtime_dependency "relaxed-rubocop", '= 2.5'
-  gem.add_runtime_dependency "rubocop", '=  0.80.1'
-  gem.add_development_dependency 'rubocop-rspec', '= 1.38'
+  gem.add_runtime_dependency 'relaxed-rubocop', '= 2.5'
+  gem.add_runtime_dependency 'rubocop', '= 1.11.0'
+  gem.add_runtime_dependency 'rubocop-rspec', '= 2.2.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: getaround-rubocop
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.2.4
 platform: ruby
 authors:
 - Drivy
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-27 00:00:00.000000000 Z
+date: 2021-03-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: relaxed-rubocop
@@ -31,28 +31,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.80.1
+        version: 1.11.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.80.1
+        version: 1.11.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: '1.38'
-  type: :development
+        version: 2.2.0
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: '1.38'
+        version: 2.2.0
 description: Shared base configuration for Getaround Backend Applications.
 email:
 - oss@drivy.com
@@ -65,6 +65,8 @@ files:
 - Gemfile
 - Gemfile.lock
 - README.md
+- exemples/dummy_class.rb
+- exemples/spec/dummy_class_spec.rb
 - getaround-rubocop.gemspec
 homepage: https://github.com/drivy
 licenses:
@@ -76,9 +78,9 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - "~>"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="