get_env 0.1.4 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2f2f663152b27c3a911a38ea2ab930a4035f808036c6fc721e5374993a668ccb
-  data.tar.gz: 6f6db938e4c6f1e695d18c0e87914231c8c55e481102e719dfb82a1933e3e914
+  metadata.gz: 840c77f6c35baeec3560a6fb8b64667fffe6e477d344c0b4d92e2b18f9a89758
+  data.tar.gz: '0916cd555771f013375a4d42b190ee04736e101a0e1a9e963eb004cc899cb9bf'
 SHA512:
-  metadata.gz: 0fd52dd3d9e3c1dd5f6ab569cb2e2b4483bf5b3d88c5a9ddee3072f8eedb946f20b1846a916b64728a639f084bb9465857d4a1e5eae08d6a9289649b3c29e135
-  data.tar.gz: 1b39d837f70ca650f69d9ea631497208619303bdb9c75cb1d895ac2f68dc958ceb3f513b0590c2e135e193f95e49db14853fe4c4003495b47d7257606b87d2d8
+  metadata.gz: c636397567c57c93a12cbefc88bbed42e42fc6511a488971840af66a91b2aa8de92173412b9ba88ab9aee689c10307536181723f5e8d1a1fada132778ac0c3cd
+  data.tar.gz: b1b43cea47ab2af9a9f1adbfda13319e0598d4a73566529dcfc8e4496276903804f295feaf4e8a4ca2b0132917cd9d3a3c50ea29c31d3f8dc08698266690bf4c

data/lib/get_env.rb

@@ -1,9 +1,11 @@
 # frozen_string_literal: true
-require "get_env/version"
+
+require 'get_env/version'
 
 module GetEnv
   def self.[](key)
     return nil if key.nil?
+
     v = ENV[key].to_i
     return v if v.to_s == ENV[key]
 
@@ -19,7 +21,7 @@ module GetEnv
   def self.fetch(key, default = nil)
     if ENV.has_key?(key)
       self[key]
-    elsif default != nil
+    elsif !default.nil?
       default
     elsif block_given?
       yield

data/lib/get_env/cops.rb

@@ -0,0 +1,3 @@
+# frozen_string_literal: true
+
+require_relative '../rubocop/cop/lint/no_env'

data/lib/get_env/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module GetEnv
-  VERSION = '0.1.4'
+  VERSION = '0.2.0'
 end

data/lib/rubocop/cop/lint/no_env.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Lint
+      # @example
+      #   # bad
+      #   ENV[]
+      #
+      #   # bad
+      #   ENV.fetch(..)
+      #
+      #   # good
+      #   GetEnv[]
+      #
+      #   # good
+      #   GetEnv.fetch(...)
+      class NoENV < Cop
+        MSG = 'Use `GetEnv` instead of `ENV`.'
+
+        def_node_matcher :is_ENV_index?, '(send (const nil? :ENV) :[] _key)'
+        def_node_matcher :is_ENV_fetch?, '(send (const nil? :ENV) :fetch _key ...)'
+
+        def on_const(node)
+          parent = node.parent
+          return unless is_ENV_index?(parent) || is_ENV_fetch?(parent)
+
+          add_offense(node)
+        end
+
+        def autocorrect(node)
+          lambda do |corrector|
+            if Gem::Version.new(RuboCop::Version.version) >= Gem::Version.new('0.82.0')
+              corrector.replace(node, 'GetEnv')
+            else
+              corrector.replace(node.loc.expression, 'GetEnv')
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/spec/get_env_spec.rb

@@ -0,0 +1,67 @@
+# frozen_string_literal: true
+
+RSpec.describe GetEnv do
+  before(:all) do
+    ENV['SOME_STRING'] = 'foo'
+    ENV['SOME_INT'] = '1'
+    ENV['SOME_FLOAT'] = '1.23'
+    ENV['SOME_TRUE'] = 'true'
+    ENV['SOME_FALSE'] = 'false'
+  end
+
+  it "has a version number" do
+    expect(GetEnv::VERSION).not_to be nil
+  end
+
+  describe '#[]' do
+    it 'handles nil' do
+      expect(GetEnv[nil]).to eq(nil)
+    end
+
+    it 'handles missing value' do
+      expect(GetEnv['klfadjslfkadjsflkadjs']).to eq(nil)
+    end
+
+    it 'returns strings' do
+      expect(GetEnv['SOME_STRING']).to eq('foo')
+    end
+
+    it 'casts ints' do
+      expect(GetEnv['SOME_INT']).to eq(1)
+    end
+
+    it 'casts floats' do
+      expect(GetEnv['SOME_FLOAT']).to eq(1.23)
+    end
+
+    it 'casts bools' do
+      expect(GetEnv['SOME_TRUE']).to be(true)
+      expect(GetEnv['SOME_FALSE']).to be(false)
+    end
+  end
+
+  describe '#fetch' do
+    it 'casts types' do
+      expect(GetEnv.fetch('SOME_FLOAT')).to eq(1.23)
+    end
+
+    it 'returns the value when found' do
+      expect(GetEnv.fetch('SOME_FLOAT', 3.21)).to eq(1.23)
+    end
+
+    it 'returns the defaults when not found' do
+      expect(GetEnv.fetch('SOME_NON_EXISTANT_FLOAT', 3.21)).to eq(3.21)
+    end
+
+    it 'raises an exception if not found and no default is specified' do
+      expect do
+        GetEnv.fetch('SOME_NON_EXISTANT_FLOAT')
+      end.to raise_error KeyError, /key not found: "SOME_NON_EXISTANT_FLOAT"/
+    end
+
+    it 'accepts a block for the default value' do
+      v = GetEnv.fetch('SOME_NON_EXISTANT_FLOAT') { 3.21 }
+      expect(v).to eq(3.21)
+    end
+  end
+end

data/spec/rubocop/cop/lint/no_env_spec.rb

@@ -0,0 +1,76 @@
+# frozen_string_literal: true
+
+require 'rubocop'
+require 'rubocop/rspec/support'
+require_relative '../../../../lib/rubocop/cop/lint/no_env'
+
+RSpec.describe RuboCop::Cop::Lint::NoENV do
+  include RuboCop::RSpec::ExpectOffense
+
+  let(:config) { RuboCop::Config.new }
+
+  subject(:cop) { described_class.new(config) }
+
+  describe '#[]' do
+    it 'registers an offense when using `ENV`' do
+      expect_offense(<<~RUBY)
+        FOO = ENV['FOO']
+              ^^^ Use `GetEnv` instead of `ENV`.
+      RUBY
+
+      expect_correction(<<~RUBY)
+        FOO = GetEnv['FOO']
+      RUBY
+    end
+
+    it 'does not register an offense when using `GetEnv`' do
+      expect_no_offenses(<<~RUBY)
+        FOO = GetEnv['FOO']
+      RUBY
+    end
+  end
+
+  describe '#fetch' do
+    it 'registers an offense when using `ENV`' do
+      expect_offense(<<~RUBY)
+        do_the_thing(ENV.fetch('FOO'))
+                     ^^^ Use `GetEnv` instead of `ENV`.
+      RUBY
+
+      expect_correction(<<~RUBY)
+        do_the_thing(GetEnv.fetch('FOO'))
+      RUBY
+    end
+
+    it 'registers an offense when using `ENV` with a default value' do
+      expect_offense(<<~RUBY)
+        a = x + ENV.fetch('FOO', 42)
+                ^^^ Use `GetEnv` instead of `ENV`.
+      RUBY
+
+      expect_correction(<<~RUBY)
+        a = x + GetEnv.fetch('FOO', 42)
+      RUBY
+    end
+
+    it 'does not register an offense when using `GetEnv`' do
+      expect_no_offenses(<<~RUBY)
+        do_the_thing(GetEnv.fetch('FOO'))
+      RUBY
+    end
+
+    it 'does not register an offense when using `GetEnv` with a default value' do
+      expect_no_offenses(<<~RUBY)
+        a = x + GetEnv.fetch('FOO', 42)
+      RUBY
+    end
+  end
+
+  it 'does not register an offense when using `ENV` for a method not defined by `GetEnv`' do
+    expect_no_offenses(<<~RUBY)
+      ENV.map do |var|
+        foo << var.lowercase
+      end
+    RUBY
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,14 @@
+require "bundler/setup"
+require "get_env"
+
+RSpec.configure do |config|
+  # Enable flags like --only-failures and --next-failure
+  config.example_status_persistence_file_path = ".rspec_status"
+
+  # Disable RSpec exposing methods globally on `Module` and `main`
+  config.disable_monkey_patching!
+
+  config.expect_with :rspec do |c|
+    c.syntax = :expect
+  end
+end

metadata

@@ -1,16 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: get_env
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.2.0
 platform: ruby
 authors:
 - Simon Mathieu
 - Bartek Kruszczynski
 - Jonathan Barber
+- Paul Padier
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-02 00:00:00.000000000 Z
+date: 2020-05-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -68,16 +69,36 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Read values from ENV in a reasonable way
 email:
 - bartek@rainforestqa.com
 - jonathan@rainforestqa.com
+- pp@rainforestqa.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
 - lib/get_env.rb
+- lib/get_env/cops.rb
 - lib/get_env/version.rb
+- lib/rubocop/cop/lint/no_env.rb
+- spec/get_env_spec.rb
+- spec/rubocop/cop/lint/no_env_spec.rb
+- spec/spec_helper.rb
 homepage: https://github.com/rainforestapp/get_env
 licenses:
 - MIT
@@ -101,4 +122,7 @@ rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Read values from ENV in a reasonable way
-test_files: []
+test_files:
+- spec/spec_helper.rb
+- spec/get_env_spec.rb
+- spec/rubocop/cop/lint/no_env_spec.rb