gergich 1.2.3 → 2.0.0

data/spec/gergich/capture/stylelint_capture_spec.rb

@@ -1,54 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "../../support/capture_shared_examples"
-
-RSpec.describe Gergich::Capture::StylelintCapture do
-  let(:output) do
-    <<~OUTPUT
-      app/stylesheets/base/_print.scss
-       3:17  ✖  Unexpected invalid hex color "#owiehfi"   color-no-invalid-hex
-       3:17  ⚠  Expected "#owiehfi" to be "#OWIEHFI"      color-hex-case
-
-      app/stylesheets/base/_variables.scss
-        2:15  ✖  Unexpected invalid hex color "#2D3B4"   color-no-invalid-hex
-       30:15  ⚠  Expected "#2d3b4a" to be "#2D3B4A"      color-hex-case
-       45:12  ℹ  Expected "#2d3b4a" to be "#2D3B4A"      color-hex-case
-    OUTPUT
-  end
-  let(:comments) do
-    [
-      {
-        path: "app/stylesheets/base/_print.scss",
-        position: 3,
-        message: "[stylelint] Unexpected invalid hex color \"#owiehfi\"",
-        severity: "error"
-      },
-      {
-        path: "app/stylesheets/base/_print.scss",
-        position: 3,
-        message: "[stylelint] Expected \"#owiehfi\" to be \"#OWIEHFI\"",
-        severity: "warn"
-      },
-      {
-        path: "app/stylesheets/base/_variables.scss",
-        position: 2,
-        message: "[stylelint] Unexpected invalid hex color \"#2D3B4\"",
-        severity: "error"
-      },
-      {
-        path: "app/stylesheets/base/_variables.scss",
-        position: 30,
-        message: "[stylelint] Expected \"#2d3b4a\" to be \"#2D3B4A\"",
-        severity: "warn"
-      },
-      {
-        path: "app/stylesheets/base/_variables.scss",
-        position: 45,
-        message: "[stylelint] Expected \"#2d3b4a\" to be \"#2D3B4A\"",
-        severity: "info"
-      }
-    ]
-  end
-
-  it_behaves_like "a captor"
-end

data/spec/gergich/capture/swiftlint_capture_spec.rb

@@ -1,42 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "../../support/capture_shared_examples"
-
-RSpec.describe Gergich::Capture::SwiftlintCapture do
-  # rubocop:disable Layout/LineLength
-  let(:colon_violation) { "Colon Violation: Colons should be next to the identifier when specifying a type. (colon)" }
-  let(:line_length_violation) { "Line Length Violation: Line should be 100 characters or less: currently 129 characters (line_length)" }
-  let(:force_cast_violation) { "Force Cast Violation: Force casts should be avoided. (force_cast)" }
-  # rubocop:enable Layout/LineLength
-  let(:output) do
-    <<~OUTPUT
-      /path/to/My.swift:13:22: warning: #{colon_violation}
-      /path/to/Fail.swift:76: warning: #{line_length_violation}
-      /path/to/Cast.swift:15:9: error: #{force_cast_violation}
-    OUTPUT
-  end
-  let(:comments) do
-    [
-      {
-        path: "/path/to/My.swift",
-        position: 13,
-        message: "[swiftlint] #{colon_violation}",
-        severity: "warn"
-      },
-      {
-        path: "/path/to/Fail.swift",
-        position: 76,
-        message: "[swiftlint] #{line_length_violation}",
-        severity: "warn"
-      },
-      {
-        path: "/path/to/Cast.swift",
-        position: 15,
-        message: "[swiftlint] #{force_cast_violation}",
-        severity: "error"
-      }
-    ]
-  end
-
-  it_behaves_like "a captor"
-end

data/spec/gergich/capture/yamllint_capture_spec.rb

@@ -1,31 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "../../support/capture_shared_examples"
-
-RSpec.describe Gergich::Capture::YamllintCapture do
-  let(:output) do
-    <<~OUTPUT
-      ./api/config/lti/development/config.yml
-        2:8       error    string value is redundantly quoted with double quotes  (quoted-strings)
-        12:3      warning  comment not indented like content  (comments-indentation)
-    OUTPUT
-  end
-  let(:comments) do
-    [
-      {
-        path: "api/config/lti/development/config.yml",
-        position: 2,
-        message: "[yamllint] string value is redundantly quoted with double quotes",
-        severity: "error"
-      },
-      {
-        path: "api/config/lti/development/config.yml",
-        position: 12,
-        message: "[yamllint] comment not indented like content",
-        severity: "warn"
-      }
-    ]
-  end
-
-  it_behaves_like "a captor"
-end

data/spec/gergich/capture_spec.rb

@@ -1,75 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "../../lib/gergich/capture"
-
-RSpec.describe Gergich::Capture do
-  let!(:draft) { double }
-
-  let :output do
-    <<~OUTPUT
-      #{path}
-        4:21  error  Missing semicolon  semi
-    OUTPUT
-  end
-
-  before do
-    allow(Gergich::Draft).to receive(:new).and_return(draft)
-    $stdin = StringIO.new(output)
-  end
-
-  after do
-    $stdin = STDIN
-  end
-
-  context "stdin" do
-    let(:path) { "jsapp/models/user.js" }
-
-    it "should catch errors" do
-      expect(draft).to receive(:add_comment).with(
-        "jsapp/models/user.js",
-        4,
-        "[eslint] Missing semicolon",
-        "error"
-      )
-      described_class.run("eslint", "-", suppress_output: true)
-    end
-
-    it "shouldn't eat stdin" do
-      allow(draft).to receive(:add_comment)
-      expect($stdout).to receive(:puts).exactly(output.lines.size).times
-      described_class.run("eslint", "-")
-    end
-  end
-
-  context "absolute paths" do
-    before do
-      allow(described_class).to receive(:base_path).and_return("/the/directory/")
-    end
-
-    context "under us" do
-      let(:path) { "/the/directory/jsapp/models/user.js" }
-      it "should be relativized" do
-        expect(draft).to receive(:add_comment).with(
-          "jsapp/models/user.js",
-          4,
-          "[eslint] Missing semicolon",
-          "error"
-        )
-        described_class.run("eslint", "-", suppress_output: true)
-      end
-    end
-
-    context "elsewhere" do
-      let(:path) { "/other/directory/jsapp/models/user.js" }
-      it "should not be relativized" do
-        expect(draft).to receive(:add_comment).with(
-          "/other/directory/jsapp/models/user.js",
-          4,
-          "[eslint] Missing semicolon",
-          "error"
-        )
-        described_class.run("eslint", "-", suppress_output: true)
-      end
-    end
-  end
-end

data/spec/gergich_spec.rb

@@ -1,396 +0,0 @@
-# frozen_string_literal: true
-
-require "httparty"
-
-RSpec.describe Gergich::API do
-  context "bad change-id" do
-    let(:result) { double(:result, body: "Not Found: 1234") }
-
-    before :each do
-      allow(HTTParty).to receive(:send).and_return(result)
-      allow(described_class).to receive(:prepare_options).and_return({})
-    end
-
-    it "provides helpful error when Change-Id not found" do
-      # Get ride of CI_TEST_RUN environment variable so the api preforms normally
-      ENV["CI_TEST_RUN"] = nil
-      expect { described_class.get("/a/changes/1234") }
-        .to raise_error(/Cannot find Change-Id: 1234/)
-    end
-  end
-
-  context "GERGICH_DIGEST_AUTH exists" do
-    it "uses digest auth" do
-      original_basic_auth = ENV["GERGICH_DIGEST_AUTH"]
-      ENV["GERGICH_DIGEST_AUTH"] = "1"
-      original_gergich_key = ENV["GERGICH_KEY"]
-      ENV["GERGICH_KEY"] = "foo"
-      allow(described_class).to receive(:base_uri).and_return("https://gerrit.foobar.com")
-
-      expect(described_class.send(:prepare_options, {}))
-        .to match(
-          hash_including(
-            digest_auth: { username: "gergich", password: ENV["GERGICH_KEY"] }
-          )
-        )
-
-      ENV["GERGICH_DIGEST_AUTH"] = original_basic_auth
-      ENV["GERGICH_KEY"] = original_gergich_key
-    end
-  end
-
-  context "GERGICH_DIGEST_AUTH does not exist" do
-    it "uses basic auth" do
-      original_basic_auth = ENV["GERGICH_DIGEST_AUTH"]
-      ENV["GERGICH_DIGEST_AUTH"] = nil
-      original_gergich_key = ENV["GERGICH_KEY"]
-      ENV["GERGICH_KEY"] = "foo"
-      allow(described_class).to receive(:base_uri).and_return("https://gerrit.foobar.com")
-
-      expect(described_class.send(:prepare_options, {}))
-        .to match(hash_including(basic_auth: { username: "gergich", password: ENV["GERGICH_KEY"] }))
-
-      ENV["GERGICH_DIGEST_AUTH"] = original_basic_auth
-      ENV["GERGICH_KEY"] = original_gergich_key
-    end
-  end
-end
-
-RSpec.describe Gergich::Commit do
-  before :each do
-    allow(Gergich).to receive(:use_git?).and_return(false)
-  end
-
-  context "change_id works" do
-    it "supports branches with slashes" do
-      allow(ENV).to receive(:[]).with("GERRIT_PATCHSET_REVISION").and_return("commit-ish")
-      allow(ENV).to receive(:[]).with("GERRIT_PROJECT").and_return("spec-project")
-      allow(ENV).to receive(:[]).with("GERRIT_BRANCH").and_return("releases/2017.11.17")
-      allow(ENV).to receive(:[]).with("GERRIT_CHANGE_ID").and_return("dummychangeset")
-
-      expect(described_class.new.change_id) # %2F = / and %7E = ~
-        .to match("spec-project~releases%2F2017.11.17~dummychangeset")
-    end
-  end
-end
-
-RSpec.describe Gergich::Draft do
-  let!(:draft) do
-    commit = double(
-      :commit,
-      files: [
-        "foo.rb",
-        "bar/baz.lol"
-      ],
-      revision_id: "test",
-      change_id: "test"
-    )
-    described_class.new commit
-  end
-
-  after do
-    draft.reset!
-  end
-
-  context "#GERGICH_DB_PATH" do
-    it "uses the custom path" do
-      original_db_path = ENV["GERGICH_DB_PATH"]
-      ENV["GERGICH_DB_PATH"] = "/custom"
-
-      expect(draft.db_file).to eq("/custom/gergich-test.sqlite3")
-
-      ENV["GERGICH_DB_PATH"] = original_db_path
-    end
-
-    it "uses the default path" do
-      expect(draft.db_file).to eq("/tmp/gergich-test.sqlite3")
-    end
-  end
-
-  describe "#info" do
-    subject { draft.info }
-
-    describe "[:comments]" do
-      subject { super()[:comments] }
-
-      it "includes file comments" do
-        draft.add_comment "foo.rb", 1, "fix foo", "info"
-        expect(subject).to eq("foo.rb" => [{ line: 1, message: "[INFO] fix foo" }])
-      end
-
-      it "strips whitespace from filename" do
-        draft.add_comment " foo.rb\n", 1, "fix foo", "info"
-        expect(subject).to eq("foo.rb" => [{ line: 1, message: "[INFO] fix foo" }])
-      end
-
-      it "includes COMMIT_MSG comments" do
-        draft.add_comment "/COMMIT_MSG", 1, "fix commit", "info"
-        expect(subject).to eq("/COMMIT_MSG" => [{ line: 1, message: "[INFO] fix commit" }])
-      end
-
-      it "doesn't include orphaned file comments" do
-        draft.add_comment "invalid.rb", 1, "fix invalid", "info"
-        expect(subject).to eq({})
-      end
-    end
-
-    describe "[:cover_message_parts]" do
-      subject { super()[:cover_message_parts] }
-      let(:message_1) { "this is good" }
-      let(:message_2) { "loljk it's terrible" }
-
-      it "includes explicitly added messages" do
-        draft.add_message message_1
-        draft.add_message message_2
-
-        expect(subject).to include(message_1)
-        expect(subject).to include(message_2)
-      end
-
-      context "orphaned file comments exist" do
-        let(:orphaned_comment) { "fix invalid" }
-
-        before :each do
-          draft.add_comment "invalid.rb", 1, orphaned_comment, "info"
-        end
-
-        it "includes orphan file message" do
-          expect(subject.first).to match(/#{orphaned_comment}/)
-        end
-      end
-    end
-
-    describe "[:total_comments]" do
-      subject { super()[:total_comments] }
-
-      it "includes inline and orphaned comments" do
-        draft.add_comment "foo.rb", 1, "fix foo", "info"
-        draft.add_comment "invalid.rb", 1, "fix invalid", "info"
-        expect(subject).to eq 2
-      end
-    end
-
-    describe "[:labels]" do
-      subject { super()[:labels] }
-
-      it "uses the lowest score for each label" do
-        draft.add_label "QA-Review", 1
-        draft.add_label "QA-Review", -1
-        draft.add_label "Code-Review", -2
-        draft.add_label "Code-Review", 1
-
-        expect(subject).to eq(
-          "QA-Review" => -1,
-          "Code-Review" => -2
-        )
-      end
-
-      it "disallows \"Verified\"" do
-        expect { draft.add_label "Verified", 1 }.to raise_error(/can't set Verified/)
-      end
-
-      it "disallows scores > 1" do
-        expect { draft.add_label "Foo", 2 }.to raise_error(/invalid score/)
-      end
-
-      describe "[\"Code-Review\"]" do
-        subject { super()["Code-Review"] }
-
-        it "defaults to zero" do
-          expect(subject).to eq(0)
-        end
-
-        it "is the lowest comment severity if not set" do
-          draft.add_comment "foo.rb", 1, "fix foo", "info"
-          draft.add_comment "foo.rb", 2, "fix foo", "error"
-          draft.add_comment "foo.rb", 3, "fix foo", "warn"
-
-          expect(subject).to eq(-2)
-        end
-
-        it "is trumped by a lower comment severity if negative" do
-          draft.add_label "Code-Review", 1
-          draft.add_comment "foo.rb", 1, "fix foo", "warn"
-
-          expect(subject).to eq(-1)
-        end
-
-        it "is not trumped by a lower comment severity if zero" do
-          draft.add_label "Code-Review", 1
-          draft.add_comment "foo.rb", 1, "this is ok", "info"
-
-          expect(subject).to eq(1)
-        end
-
-        it "is not trumped by a higher comment severity" do
-          draft.add_label "Code-Review", -1
-          draft.add_comment "foo.rb", 1, "this is ok", "info"
-
-          expect(subject).to eq(-1)
-        end
-      end
-    end
-  end
-end
-
-RSpec.describe Gergich::Review do
-  let(:change_id) { "test" }
-  let!(:commit) do
-    double(
-      :commit,
-      change_id: change_id,
-      files: [
-        "foo.rb",
-        "bar/baz.lol"
-      ],
-      info: {},
-      revision_id: change_id,
-      revision_number: 1
-    )
-  end
-  let!(:draft) do
-    Gergich::Draft.new commit
-  end
-  let!(:review) { described_class.new(commit, draft) }
-
-  after do
-    draft.reset!
-  end
-
-  describe "#status" do
-    subject { review.status }
-
-    context "nothing to publish" do
-      before :each do
-        allow(review).to receive(:anything_to_publish?).and_return(false)
-      end
-      it { expect { subject }.to output(include("Nothing to publish")).to_stdout }
-    end
-
-    context "something to publish" do
-      before :each do
-        allow(review).to receive(:anything_to_publish?).and_return(true)
-        allow(review).to receive(:already_commented?).and_return(false)
-        allow(review).to receive(:generate_payload).and_return({})
-        allow(review).to receive(:my_messages).and_return([])
-      end
-      it {
-        expected_outputs = [
-          "Project:",
-          "Branch:",
-          "Revision:",
-          "ChangeId: #{change_id}",
-          "Files:"
-          # There's more... but this is good
-        ]
-        expect { subject }.to output(include(*expected_outputs)).to_stdout
-      }
-    end
-  end
-
-  describe "#publish!" do
-    context "nothing to publish" do
-      before :each do
-        allow(review).to receive(:anything_to_publish?).and_return(false)
-      end
-
-      it "does nothing" do
-        expect(Gergich::API).not_to receive(:post)
-
-        review.publish!
-      end
-    end
-
-    context "something to publish" do
-      before :each do
-        allow(review).to receive(:anything_to_publish?).and_return(true)
-        allow(review).to receive(:already_commented?).and_return(false)
-        allow(review).to receive(:generate_payload).and_return({})
-      end
-
-      it "publishes via the api" do
-        expect(Gergich::API).to receive(:post)
-        review.publish!
-      end
-    end
-  end
-
-  describe "#anything_to_publish?" do
-    before :each do
-      allow(review).to receive(:current_label).and_return("BAHA")
-      allow(review).to receive(:current_label_revision).and_return("Revision trash stuff")
-    end
-
-    context "no comments exist" do
-      it "returns false" do
-        allow(review).to receive(:new_score?).and_return(false)
-        expect(review.anything_to_publish?).to eq false
-      end
-    end
-
-    context "comments exist" do
-      it "returns true" do
-        draft.info[:comments] = "Hello there this is a comment"
-        expect(review.anything_to_publish?).to eq true
-      end
-    end
-  end
-
-  describe "#new_score?" do
-    before :each do
-      allow(review).to receive(:current_label_is_for_current_revision?).and_return(true)
-      allow(review).to receive(:current_score).and_return(0)
-    end
-
-    context "score is the same" do
-      it "returns false" do
-        draft.info[:score] = 0
-        expect(review.new_score?).to eq false
-      end
-    end
-
-    context "score is different" do
-      it "returns true" do
-        draft.info[:score] = -1
-        expect(review.new_score?).to eq true
-      end
-    end
-  end
-
-  describe "#upcoming_score" do
-    context "current_label_is_for_current_revision? is true" do
-      it "Should return the min value of draft.info[:score] and current_score" do
-        allow(review).to receive(:current_label_is_for_current_revision?).and_return(true)
-        allow(review).to receive(:current_score).and_return(0)
-        review.draft.info[:score] = 1
-        expect(review.upcoming_score).to eq 0
-      end
-    end
-
-    context "current_label_is_for_current_revision? is false" do
-      it "Should return the value of draft.info[:score]" do
-        allow(review).to receive(:current_label_is_for_current_revision?).and_return(false)
-        review.draft.info[:score] = 1
-        expect(review.upcoming_score).to eq 1
-      end
-    end
-  end
-
-  describe "#cover_message" do
-    context "score is negative" do
-      it "includes the Code-Review score if negative" do
-        allow(review).to receive(:upcoming_score).and_return(-1)
-        review.draft.add_label "Code-Review", -1
-        expect(review.cover_message).to match(/^-1/)
-      end
-    end
-
-    context "score is non-negative" do
-      it "doesn't include the score if not negative" do
-        allow(review).to receive(:upcoming_score).and_return(0)
-        draft.add_label "Code-Review", 0
-        expect(subject).to_not match(/^0/)
-      end
-    end
-  end
-end

data/spec/spec_helper.rb

@@ -1,92 +0,0 @@
-# frozen_string_literal: true
-
-require "simplecov" if ENV["COVERAGE"]
-require_relative "../lib/gergich"
-
-# This file was generated by the `rspec --init` command. Conventionally, all
-# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
-# The generated `.rspec` file contains `--require spec_helper` which will cause
-# this file to always be loaded, without a need to explicitly require it in any
-# files.
-#
-# Given that it is always loaded, you are encouraged to keep this file as
-# light-weight as possible. Requiring heavyweight dependencies from this file
-# will add to the boot time of your test suite on EVERY test run, even for an
-# individual file that may not need all of that loaded. Instead, consider making
-# a separate helper file that requires the additional dependencies and performs
-# the additional setup, and require it from the spec files that actually need
-# it.
-#
-# The `.rspec` file also contains a few flags that are not defaults but that
-# users commonly want.
-#
-# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
-RSpec.configure do |config|
-  # rspec-expectations config goes here. You can use an alternate
-  # assertion/expectation library such as wrong or the stdlib/minitest
-  # assertions if you prefer.
-  config.expect_with :rspec do |expectations|
-    # This option will default to `true` in RSpec 4. It makes the `description`
-    # and `failure_message` of custom matchers include text for helper methods
-    # defined using `chain`, e.g.:
-    #     be_bigger_than(2).and_smaller_than(4).description
-    #     # => "be bigger than 2 and smaller than 4"
-    # ...rather than:
-    #     # => "be bigger than 2"
-    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
-  end
-
-  # rspec-mocks config goes here. You can use an alternate test double
-  # library (such as bogus or mocha) by changing the `mock_with` option here.
-  config.mock_with :rspec do |mocks|
-    # Prevents you from mocking or stubbing a method that does not exist on
-    # a real object. This is generally recommended, and will default to
-    # `true` in RSpec 4.
-    mocks.verify_partial_doubles = true
-  end
-
-  # These two settings work together to allow you to limit a spec run
-  # to individual examples or groups you care about by tagging them with
-  # `:focus` metadata. When nothing is tagged with `:focus`, all examples
-  # get run.
-  config.filter_run :focus
-  config.run_all_when_everything_filtered = true
-
-  # Limits the available syntax to the non-monkey patched syntax that is
-  # recommended. For more details, see:
-  #   - http://myronmars.to/n/dev-blog/2012/06/rspecs-new-expectation-syntax
-  #   - http://teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
-  #   - http://myronmars.to/n/dev-blog/2014/05/notable-changes-in-rspec-3#new__config_option_to_disable_rspeccore_monkey_patching
-  config.disable_monkey_patching!
-
-  # This setting enables warnings. It's recommended, but in some cases may
-  # be too noisy due to issues in dependencies.
-  config.warnings = true
-
-  # Many RSpec users commonly either run the entire suite or an individual
-  # file, and it's useful to allow more verbose output when running an
-  # individual spec file.
-  if config.files_to_run.one?
-    # Use the documentation formatter for detailed output,
-    # unless a formatter has already been configured
-    # (e.g. via a command-line flag).
-    config.default_formatter = "doc"
-  end
-
-  # Print the 10 slowest examples and example groups at the
-  # end of the spec run, to help surface which specs are running
-  # particularly slow.
-  config.profile_examples = 10
-
-  # Run specs in random order to surface order dependencies. If you find an
-  # order dependency and want to debug it, you can fix the order by providing
-  # the seed, which is printed after each run.
-  #     --seed 1234
-  config.order = :random
-
-  # Seed global randomization in this process using the `--seed` CLI option.
-  # Setting this allows you to use `--seed` to deterministically reproduce
-  # test failures related to randomization by passing the same `--seed` value
-  # as the one that triggered the failure.
-  Kernel.srand config.seed
-end