gergich 1.1.1 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d2ed144a6c64e2faa3cdad9dfdcb75fe535203b5
-  data.tar.gz: e52ae51766e213f18050a7885b724cd106ae953e
+  metadata.gz: e58c68d37d5edc2b490942f01486e732dbe9dc65
+  data.tar.gz: f7adcb070fa5a7cb343d89c8ac3209a1dcb66fa5
 SHA512:
-  metadata.gz: bb201b5e1f6b385bbbdbbda08c9ca4b3c8046e67a1a6bf0aa9d560be6106535a591c4e0ba773858de4f49c928538c646fcb02f69a1923690e7048aabc13749c1
-  data.tar.gz: 239fa8d431558eb4bc9fa16373ad9aca7235c75c30e7d113f9fd9b8a4a3cf3844525a664006262723fa5af5d01c78941f89fedc9b2a8344ba7d0e29598a0a613
+  metadata.gz: cf13893fd3b0f17fba6e14a191b8ee0722605a657801013b275ff9c5aa8035050d0dc8515d8af6b94f43cd6da42f369673f17a5d54a3df214524ba9e655e1ccc
+  data.tar.gz: dec0877120594b960d2d447025d6ec11fb4ae6cb74027fea8318872855b87c18b26f4883a0c48df1a9e670c3408c31c76536f2a9d4228d6f54ebec711dc74cec

data/README.md

@@ -1,7 +1,6 @@
 # Gergich
 
 [![Gem Version](https://badge.fury.io/rb/gergich.svg)](https://rubygems.org/gems/gergich)
-[![Dependency Status](https://gemnasium.com/badges/a2946a7849cd94f5ec0f4c3173a968f4.svg)](https://gemnasium.com/cc6fb44edee9fcf855cec82d3b6aed0f)
 [![Build Status](https://travis-ci.org/instructure/gergich.svg?branch=master)](https://travis-ci.org/instructure/gergich)
 
 Gergich is a command-line tool (and ruby lib) for easily posting comments

data/bin/run_tests.sh

@@ -2,51 +2,21 @@
 
 set -e
 
-function run_command {
-  echo -e "\n[$@] STARTING $(date)"
-  last_status=0
-  "$@" || last_status=$?
-  if [[ $last_status == 0 ]]; then
-    echo -e "[$@] \033[32mOK\033[0m"
-  else
-    echo -e "[$@] \033[31mFAILED!\033[0m"
-  fi
-  echo -e "[$@] FINISHED $(date)\n"
+bundle exec rubocop --fail-level autocorrect
 
-  [[ $last_status == 0 ]] || clean_up_and_exit
-}
+ruby -v | egrep "^ruby 2\.4" && export COVERAGE=1
 
-function clean_up_and_exit {
-  end_timestamp=$(date +%s)
-  duration=$((end_timestamp-start_timestamp))
-
-  if [[ $last_status != 0 ]]; then
-    echo -e "\033[31mBUILD FAILED\033[0m in $duration seconds\n"
-  else
-    echo "BUILD PASSED in $duration seconds"
-  fi
-  exit $last_status
-}
-
-start_timestamp=$(date +%s)
-
-run_command bundle exec rubocop
-
-export COVERAGE=1
-
-run_command bundle exec rspec
+bundle exec rspec
 
 # these actually hit gerrit; only run them in CI land (you can do it
 # locally if you set all the docker-compose env vars)
 if [[ "$GERRIT_PATCHSET_REVISION" ]]; then
-  run_command bin/gergich citest
-  run_command bin/master_bouncer check
-  DRY_RUN=1 run_command bin/master_bouncer check_all
+  bundle exec bin/gergich citest
+  bundle exec bin/master_bouncer check
+  DRY_RUN=1 bundle exec bin/master_bouncer check_all
   # ensure gergich works without .git directories
   rm -rf .git
-  run_command bin/gergich status
+  bundle exec bin/gergich status
 fi
 
-run_command bin/check_coverage
-
-clean_up_and_exit
+bundle exec bin/check_coverage

data/lib/gergich/capture/androidlint_capture.rb

@@ -11,7 +11,7 @@ module Gergich
       }.freeze
 
       def run(output)
-        # rubocop:disable Metrics/LineLength
+        # rubocop:disable Layout/LineLength
         #
         # Example:
         # /path/to/some.xml:27: Warning: Consider adding android:drawableStart="@drawable/a_media" to better support right-to-left layouts [RtlHardcoded]
@@ -26,7 +26,7 @@ module Gergich
         #    <plurals name="number">
         #    ^
         #
-        # rubocop:enable Metrics/LineLength
+        # rubocop:enable Layout/LineLength
         pattern = /
           ^([^:\n]+):(\d+)?:?\s(\w+):\s(.*?)\n
           ([^\n]+\n

data/lib/gergich/capture/swiftlint_capture.rb

@@ -12,13 +12,13 @@ module Gergich
       }.freeze
 
       def run(output)
-        # rubocop:disable Metrics/LineLength
+        # rubocop:disable Layout/LineLength
         #
         # Example:
         # /path/to/My.swift:13:22: warning: Colon Violation: Colons should be next to the identifier when specifying a type. (colon)
         # /path/to/Fail.swift:80: warning: Line Length Violation: Line should be 100 characters or less: currently 108 characters (line_length)
         #
-        # rubocop:enable Metrics/LineLength
+        # rubocop:enable Layout/LineLength
         pattern = /
           ^([^:\n]+):(\d+)(?::\d+)?:\s(\w+):\s(.*?)\n
         /mx

data/lib/gergich/cli/gergich.rb

@@ -14,7 +14,7 @@ CI_TEST_ARGS = {
   ],
   "label" => ["Code-Review", 1],
   "message" => ["this is a test"],
-  "capture" => ["rubocop", "echo #{Shellwords.escape(<<~OUTPUT)}"]
+  "capture" => ["rubocop", format("echo %<output>s", output: Shellwords.escape(<<~OUTPUT))]
     bin/gergich:47:8: C: Prefer double-quoted strings
     if ENV['DEBUG']
            ^^^^^^^

data/spec/gergich/capture/androidlint_capture_spec.rb

@@ -3,12 +3,12 @@
 require_relative "../../support/capture_shared_examples"
 
 RSpec.describe Gergich::Capture::AndroidlintCapture do
-  # rubocop:disable Metrics/LineLength
+  # rubocop:disable Layout/LineLength
   let(:rtl_hardcoded) { 'Consider adding android:drawableStart="@drawable/a_media" to better support right-to-left layouts [RtlHardcoded]' }
   let(:rtl_enabled) { "The project references RTL attributes, but does not explicitly enable or disable RTL support with android:supportsRtl in the manifest [RtlEnabled]" }
   let(:lint_error) { 'No .class files were found in project "0.0.2", so none of the classfile based checks could be run. Does the project need to be built first? [LintError]' }
   let(:unused_quantity) { 'For language "fr" (French) the following quantities are not relevant: few, zero [UnusedQuantity]' }
-  # rubocop:enable Metrics/LineLength
+  # rubocop:enable Layout/LineLength
   let(:output) do
     <<~OUTPUT
       /path/to/some.xml:27: Warning: #{rtl_hardcoded}
@@ -31,9 +31,9 @@ RSpec.describe Gergich::Capture::AndroidlintCapture do
       {
         path: "/path/to/some.xml",
         position: 27,
-        # rubocop:disable Metrics/LineLength
+        # rubocop:disable Layout/LineLength
         message: "[androidlint] #{rtl_hardcoded}\n\n    android:drawableLeft=\"@drawable/ic_cv_media\"/>\n    ~~~~~~~~~~~~~~~~~~~~",
-        # rubocop:enable Metrics/LineLength
+        # rubocop:enable Layout/LineLength
         severity: "warn"
       },
       {

data/spec/gergich/capture/swiftlint_capture_spec.rb

@@ -3,11 +3,11 @@
 require_relative "../../support/capture_shared_examples"
 
 RSpec.describe Gergich::Capture::SwiftlintCapture do
-  # rubocop:disable Metrics/LineLength
+  # rubocop:disable Layout/LineLength
   let(:colon_violation) { "Colon Violation: Colons should be next to the identifier when specifying a type. (colon)" }
   let(:line_length_violation) { "Line Length Violation: Line should be 100 characters or less: currently 129 characters (line_length)" }
   let(:force_cast_violation) { "Force Cast Violation: Force casts should be avoided. (force_cast)" }
-  # rubocop:enable Metrics/LineLength
+  # rubocop:enable Layout/LineLength
   let(:output) do
     <<~OUTPUT
       /path/to/My.swift:13:22: warning: #{colon_violation}

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gergich
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.2.0
 platform: ruby
 authors:
 - Jon Jensen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-07 00:00:00.000000000 Z
+date: 2020-01-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -16,84 +16,84 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.16'
+        version: '0.17'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.16'
+        version: '0.17'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '1.4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '1.4'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.5'
+        version: '3.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.5'
+        version: '3.9'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.49'
+        version: 0.79.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.49'
+        version: 0.79.0
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.16.0
+        version: 0.17.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.16.0
+        version: 0.17.1
 description: Gergich is a little command-line tool for wiring up linters to Gerrit
   so you can get nice inline comments right on the review
 email: jon@instructure.com