gergich 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9da4c870097f2129eaa052c2b41b840da0cc096f
-  data.tar.gz: 4d3102825f2858c5e63cade4fb751d29f9c2a73b
+  metadata.gz: cef81a3c65bdd0fc840a4d528f2e53226d53e92e
+  data.tar.gz: 40df25850f29562ad41d343634b14f57d400a9a9
 SHA512:
-  metadata.gz: 011eb695e557e2c00074731bd9521d606ba13f0fa18d0fccd71095b7db8c1cc58e215eeeabee1fd80ac34075111621d3ece3fc85ccf0d2ccb5620686400ea1c3
-  data.tar.gz: b616b994af49ce7c2c714d3d40a7e8eee6cb613aede43e31d7e4cb106844d1acd538d02f71dfedab83aa0c0a5843ea02427603f9adff3552bdfc850c96821015
+  metadata.gz: aa63ad319d840a44e9fa108d613171584f155adffae2d3499401f18552f22cefdc8956a9e3e5934a4b0040f3440761eb5ef2cabe98341d3cdfb9a4aeb999a30f
+  data.tar.gz: d3b7c367fde6d1dab7214c373a11d167e81ea84c44291cb4899102a808a676262fac3cac3348725616770f2fc9e7fe03b32ccf99ed995ec3afa25d36fbc4a4ca

data/lib/gergich.rb

@@ -1,3 +1,4 @@
+require "erb"
 require "sqlite3"
 require "json"
 require "fileutils"
@@ -80,7 +81,7 @@ module Gergich
 
     def change_id
       if info[:project] && info[:branch]
-        "#{info[:project]}~#{info[:branch]}~#{info[:change_id]}"
+        ERB::Util.url_encode "#{info[:project]}~#{info[:branch]}~#{info[:change_id]}"
       else
         info[:change_id]
       end

data/spec/gergich_spec.rb

@@ -52,6 +52,24 @@ RSpec.describe Gergich::API do
   end
 end
 
+RSpec.describe Gergich::Commit do
+  before :each do
+    allow(Gergich).to receive(:use_git?).and_return(false)
+  end
+
+  context "change_id works" do
+    it "supports branches with slashes" do
+      allow(ENV).to receive(:[]).with("GERRIT_PATCHSET_REVISION").and_return("commit-ish")
+      allow(ENV).to receive(:[]).with("GERRIT_PROJECT").and_return("spec-project")
+      allow(ENV).to receive(:[]).with("GERRIT_BRANCH").and_return("releases/2017.11.17")
+      allow(ENV).to receive(:[]).with("GERRIT_CHANGE_ID").and_return("dummychangeset")
+
+      expect(described_class.new.change_id) # %2F = / and %7E = ~
+        .to match("spec-project%7Ereleases%2F2017.11.17%7Edummychangeset")
+    end
+  end
+end
+
 RSpec.describe Gergich::Draft do
   let!(:draft) do
     commit = double(

metadata

@@ -1,97 +1,97 @@
 --- !ruby/object:Gem::Specification
 name: gergich
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Jon Jensen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-26 00:00:00.000000000 Z
+date: 2017-11-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: httparty
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.6'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '12.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '12.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '3.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '3.5'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 0.47.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 0.47.1
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 0.13.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 0.13.0
 description: Gergich is a little command-line tool for wiring up linters to Gerrit
@@ -105,12 +105,6 @@ extra_rdoc_files: []
 files:
 - LICENSE
 - README.md
-- bin/check_coverage
-- bin/gergich
-- bin/master_bouncer
-- bin/run_tests.sh
-- lib/gergich.rb
-- lib/gergich/capture.rb
 - lib/gergich/capture/androidlint_capture.rb
 - lib/gergich/capture/brakeman_capture.rb
 - lib/gergich/capture/eslint_capture.rb
@@ -120,9 +114,11 @@ files:
 - lib/gergich/capture/shellcheck_capture.rb
 - lib/gergich/capture/stylelint_capture.rb
 - lib/gergich/capture/swiftlint_capture.rb
-- lib/gergich/cli.rb
+- lib/gergich/capture.rb
 - lib/gergich/cli/gergich.rb
 - lib/gergich/cli/master_bouncer.rb
+- lib/gergich/cli.rb
+- lib/gergich.rb
 - spec/gergich/capture/androidlint_capture_spec.rb
 - spec/gergich/capture/brakeman_capture_spec.rb
 - spec/gergich/capture/custom_capture_spec.rb
@@ -137,6 +133,10 @@ files:
 - spec/gergich_spec.rb
 - spec/spec_helper.rb
 - spec/support/capture_shared_examples.rb
+- bin/check_coverage
+- bin/gergich
+- bin/master_bouncer
+- bin/run_tests.sh
 homepage: https://github.com/instructure/gergich
 licenses:
 - MIT
@@ -147,17 +147,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.0.14.1
 signing_key: 
 specification_version: 4
 summary: Command-line tool for adding Gerrit comments