gergich 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 63c9da0967fcb4d7728a748f1b64011e2fa03d02
-  data.tar.gz: 45e9c346faca8b021db278e2f6f96f32b9184b20
+  metadata.gz: b8af2aab61e1b5c93269e3d9e2e6d4fb5dd01201
+  data.tar.gz: 88a33e274c6a36ec65be8e32a05c151ef747f4d1
 SHA512:
-  metadata.gz: 170522d85e67ccb5293e3b4a797814abba906dd76eeb2769fa335b1723949bc73e22d922c44f32bb741e6d92f39b69ee90754b52b3dc7a7be7ffcbb049943579
-  data.tar.gz: ea79a99e4ffe01e6902908ffce696cd37843f67ac7fdf0449d6dc0eeaf91ec91147a1cfb2ab41428db2c450c8b101615c243c42a2114a37c7c3ff01e69e1dd04
+  metadata.gz: dc12a8e5761990be3b1de20fa15dfd9392e83dcdb2c6a72553d859b9e88787550129fe48006674e4f4594f3170fd39037dfa8cb17440860d766634556a0a576f
+  data.tar.gz: 9da9a59b35a715a688d7e9f3e700a011ccfa4ee027b8454c60fb70ef694faa9a80d5834e83458392947f38b26a322e0e7f99805c93e0ae642cdfcfd8261349a8

data/lib/gergich.rb

@@ -197,6 +197,13 @@ module Gergich
         ret = HTTParty.send(method, url, options).body
         if ret.sub!(/\A\)\]\}'\n/, "") && ret =~ /\A("|\[|\{)/
           JSON.parse("[#{ret}]")[0] # array hack so we can parse a string literal
+        elsif ret =~ /Not Found: (?<change_id>.*)/
+          raise("Cannot find Change-Id: #{Regexp.last_match[:change_id]}.\n"\
+                "This is most likely due to this"\
+                " Change-Id already being used"\
+                " by an ABANDONED change.\n"\
+                "To fix, `git commit --amend`,"\
+                " remove the Change-Id line, and push again.")
         else
           raise("Non-JSON response: #{ret}")
         end

data/spec/gergich_spec.rb

@@ -1,5 +1,18 @@
 require_relative "../lib/gergich"
 
+RSpec.describe Gergich::API do
+  let(:result) { double(:result, { body: "Not Found: 1234" }) }
+
+  before :each do
+    allow(HTTParty).to receive(:send).and_return(result)
+    allow(described_class).to receive(:base_options).and_return({})
+  end
+
+  it "provides helpful error when Change-Id not found" do
+    expect { described_class.get("/a/changes/1234") }.to raise_error(/Cannot find Change-Id: 1234/)
+  end
+end
+
 RSpec.describe Gergich::Draft do
   let!(:draft) do
     commit = double(:commit, {

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gergich
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Jon Jensen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-27 00:00:00.000000000 Z
+date: 2016-06-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sqlite3