georama 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a1325af5593583c33903c73c8215c06d48acc925
-  data.tar.gz: 315425c00c6ab1559677524c9682f450bff8364c
+  metadata.gz: 8001f29fdde201d6e11ae1f5a9d8fa2181e4d56d
+  data.tar.gz: 80fc06570d990b3c446c1a15abc6ac22caa17eb4
 SHA512:
-  metadata.gz: e84530110d0fb0d2f31757e6d59743c29aa52534145eb69d810e7e3be33eed795f8d6f05c5e13875bb12a134e419508fef9fae5588551bb6c48625f3cd00b6de
-  data.tar.gz: e7bb16fb354936d3fbcf419d76e945652e1ee75485560db5ae9e6ba19ca8292fc21a72a591a6fd88cf61830437d0d7b3e6ab156d1172652a74f0e7f32060f24d
+  metadata.gz: 3bbbab913d224a405bd2b3c4d1d22650286f7badd06d3ea861544199b375f3bab286a72cc05dc68b9b21bb3acabfc3b0974a78ef1e3dd25cafe7421c8643b3f6
+  data.tar.gz: 0dd4deec02fbea9b10f2a7a23a52006cfd67ec367e62180f6a35b57715284c3b76432699fac5c92e69d8ec76c0bd122e211a339387d17d90de0b2b6e18b0e379

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+# 0.2.0
+* Can parse place urls
+
+
 # 0.1.0
 * Basic Google maps urls can be parsed
 

data/lib/georama/parser.rb

@@ -14,6 +14,8 @@ module Georama
       split_path = path.split("/")
       if split_path[2].start_with?("@")
         :general
+      elsif split_path[2] == 'place'
+        :place
       end
     end
 

data/lib/georama/url.rb

@@ -33,12 +33,19 @@ module Georama
       metadata[:zoom]
     end
 
+    def place
+      return nil unless type == :place
+      @place ||= path_components[2].gsub("+", " ")
+    end
+
     private
 
     def coordinates_component
       @coordinates_component ||= case type
       when :general
         path_components[1]
+      when :place
+        path_components[3]
       end
     end
 

data/lib/georama/version.rb

@@ -1,3 +1,3 @@
 module Georama
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

data/spec/georama/parser_spec.rb

@@ -2,6 +2,8 @@ require 'spec_helper'
 
 describe Georama::Parser do
 
+  let(:general_url) { "https://www.google.com/maps/@-33.9218305,18.4296954,15z?hl=en" }
+
   describe :url_type do
 
     context "with an no path" do
@@ -10,6 +12,20 @@ describe Georama::Parser do
       end
     end
 
+    context "with a general maps path" do
+      let(:path) { "/maps/@-33.9218305,18.4296954,15z?hl=en" }
+      it "returns the correct type" do
+        expect(Georama::Parser.url_type(path)).to eq(:general)
+      end
+    end
+
+    context "with a place path" do
+      let(:path) { "/maps/place/Cape+Town/@-33.9092719,18.8965703,8.13z/data=foobar" }
+      it "returns the correct type" do
+        expect(Georama::Parser.url_type(path)).to eq(:place)
+      end
+    end
+
   end
 
   describe :is_google_maps_url? do
@@ -27,7 +43,7 @@ describe Georama::Parser do
 
     context "with a valid url" do
       it "returns true" do
-        expect(Georama::Parser.is_google_maps_url?("https://www.google.com/maps/@-33.9218305,18.4296954,15z?hl=en")).to be_truthy
+        expect(Georama::Parser.is_google_maps_url?(general_url)).to be_truthy
       end
     end
   end

data/spec/georama/url_spec.rb

@@ -3,6 +3,7 @@ require 'spec_helper'
 describe Georama::Url do
 
   let(:valid_general_url) { "https://www.google.com/maps/@-33.9218305,18.4296954,15z?hl=en" }
+  let(:valid_place_url) { "https://www.google.com/maps/place/Cape+Town/@-33.9218305,18.4296954,15z/data=foobar" }
 
   describe :initialize do
 
@@ -29,27 +30,34 @@ describe Georama::Url do
   end
 
   describe :type do
-    let(:result) { Georama::Url.new(valid_general_url) }
+    let(:result) { Georama::Url.new(url) }
 
     context "with a general url" do
-
+      let(:url) { valid_general_url }
       it "returns the correct type" do
         expect(result.type).to eq(:general)
       end
+    end
 
+    context "with a place url" do
+      let(:url) { valid_place_url }
+      it "returns the correct type" do
+        expect(result.type).to eq(:place)
+      end
     end
   end
 
   describe :coordinates do
+    let(:expected_coordinates) do
+      {
+        latitude: -33.9218305,
+        longitude: 18.4296954
+      }
+    end
+    let(:result) { Georama::Url.new(url) }
 
     context "with a general url" do
-      let(:result) { Georama::Url.new(valid_general_url) }
-      let(:expected_coordinates) do
-        {
-          latitude: -33.9218305,
-          longitude: 18.4296954
-        }
-      end
+      let(:url) { valid_general_url }
 
       it "extracts the coordinates" do
         expect(result.coordinates).to eq(expected_coordinates)
@@ -66,11 +74,20 @@ describe Georama::Url do
       end
     end
 
+    context "with a place url" do
+      let(:url) { valid_place_url }
+
+      it "extracts the coordinates" do
+        expect(result.coordinates).to eq(expected_coordinates)
+      end
+    end
+
   end
 
   describe :metadata do
+    let(:result) { Georama::Url.new(url) }
     context "with a general url" do
-      let(:result) { Georama::Url.new(valid_general_url) }
+      let(:url) { valid_general_url }
       it "extracts the zoom" do
         expect(result.metadata[:zoom]).to eq(15)
       end
@@ -82,7 +99,32 @@ describe Georama::Url do
       end
     end
 
+    context "with a place url" do
+      let(:url) { valid_place_url }
+      it "extracts the zoom" do
+        expect(result.metadata[:zoom]).to eq(15)
+      end
+    end
+
+  end
+
+  describe :place do
+    let(:result) { Georama::Url.new(url) }
+    context "with a general url" do
+      let(:url) { valid_general_url }
 
+      it "returns nil" do
+        expect(result.place).to be_nil
+      end
+    end
+
+    context "with a place url" do
+      let(:url) { valid_place_url }
+
+      it "returns the correct place" do
+        expect(result.place).to eq("Cape Town")
+      end
+    end
   end
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: georama
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Martin Pretorius