geoengineer 0.1.1 → 0.1.2

data/spec/resources/{aws_ses_receipt_rule_set.rb → aws_ses_receipt_rule_set_spec.rb}

@@ -1,23 +1,30 @@
 require_relative '../spec_helper'
 
 describe("GeoEngineer::Resources::AwsSesReceiptRuleSet") do
+  let(:ses_client) { AwsClients.ses }
+
   common_resource_tests(GeoEngineer::Resources::AwsSesReceiptRuleSet,
                         'aws_ses_receipt_rule_set')
 
+  before { ses_client.setup_stubbing }
+
   describe "#_fetch_remote_resources" do
     it 'should create list of hashes from returned AWS SDK' do
-      ses = AwsClients.ses
-      # ses.list_receipt_rule_sets.rule_sets
-      stub = ses.stub_data(
+      ses_client.stub_responses(
         :list_receipt_rule_sets,
         {
           rule_sets: [
-            { name: "fake-rule-set", created_timestamp: "2016-10-19 20:19:29 UTC" },
-            { name: "fake-rule-set-2", created_timestamp: "2016-10-19 20:19:29 UTC" }
+            {
+              name: "fake-rule-set",
+              created_timestamp: Time.parse("2016-10-19 20:19:29 UTC")
+            },
+            {
+              name: "fake-rule-set-2",
+              created_timestamp: Time.parse("2016-10-19 20:19:29 UTC")
+            }
           ]
         }
       )
-      sns.stub_responses(:list_receipt_rule_sets, stub)
       remote_resources = GeoEngineer::Resources::AwsSesReceiptRuleSet._fetch_remote_resources
       expect(remote_resources.length).to eq 2
     end

data/spec/resources/{aws_ses_receipt_rule.rb → aws_ses_receipt_rule_spec.rb}

@@ -1,14 +1,16 @@
 require_relative '../spec_helper'
 
 describe("GeoEngineer::Resources::AwsSesReceiptRule") do
+  let(:ses_client) { AwsClients.ses }
+
   common_resource_tests(GeoEngineer::Resources::AwsSesReceiptRule,
-                        'aws_ses_policy')
+                        'aws_ses_receipt_rule')
+
+  before { ses_client.setup_stubbing }
 
   describe "#_fetch_remote_resources" do
     it 'should create list of hashes from returned AWS SDK' do
-      ses = AwsClients.ses
-      # ses.list_policies.policies
-      stub = ses.stub_data(
+      ses_client.stub_responses(
         :describe_active_receipt_rule_set,
         {
           rules: [
@@ -25,7 +27,6 @@ describe("GeoEngineer::Resources::AwsSesReceiptRule") do
           ]
         }
       )
-      sns.stub_responses(:describe_active_receipt_rule_set, stub)
       remote_resources = GeoEngineer::Resources::AwsSesReceiptRule._fetch_remote_resources
       expect(remote_resources.length).to eq 2
     end

data/spec/resources/aws_subnet_spec.rb

@@ -11,8 +11,8 @@ describe("GeoEngineer::Resources::AwsSubnet") do
         :describe_subnets,
         {
           subnets: [
-            { subnet_id: '1', cidr_block: "10.120.0.0/24", tags: [{ key: 'Name', value: 'one' }] },
-            { subnet_id: '2', cidr_block: "10.120.1.0/24", tags: [{ key: 'Name', value: 'two' }] }
+            { subnet_id: '1', cidr_block: "10.10.0.0/24", tags: [{ key: 'Name', value: 'one' }] },
+            { subnet_id: '2', cidr_block: "10.10.1.0/24", tags: [{ key: 'Name', value: 'two' }] }
           ]
         }
       )

data/spec/resources/aws_vpc_dhcp_options_association_spec.rb

@@ -15,13 +15,13 @@ describe("GeoEngineer::Resources::AwsVpcDhcpOptionsAssociation") do
           vpcs: [
             {
               vpc_id: 'name1',
-              cidr_block: "10.120.0.0/24",
+              cidr_block: "10.10.0.0/24",
               tags: [{ key: 'Name', value: 'one' }],
               dhcp_options_id: '1'
             },
             {
               vpc_id: 'name2',
-              cidr_block: "10.120.1.0/24",
+              cidr_block: "10.10.1.0/24",
               tags: [{ key: 'Name', value: 'two' }],
               dhcp_options_id: '2'
             }

data/spec/resources/aws_vpc_spec.rb

@@ -11,8 +11,8 @@ describe("GeoEngineer::Resources::AwsVpc") do
         :describe_vpcs,
         {
           vpcs: [
-            { vpc_id: 'name1', cidr_block: "10.120.0.0/24", tags: [{ key: 'Name', value: 'one' }] },
-            { vpc_id: 'name2', cidr_block: "10.120.1.0/24", tags: [{ key: 'Name', value: 'two' }] }
+            { vpc_id: 'name1', cidr_block: "10.10.0.0/24", tags: [{ key: 'Name', value: 'one' }] },
+            { vpc_id: 'name2', cidr_block: "10.10.1.0/24", tags: [{ key: 'Name', value: 'two' }] }
           ]
         }
       )

data/spec/sub_resource_spec.rb

@@ -12,9 +12,21 @@ describe("GeoEngineer::SubResource") do
     it 'should return a list, with key[0] value[1]' do
       sr = GeoEngineer::SubResource.new(nil, 'tags') {
         x 10
+
+        # i.e. can have sub resources as well
+        foo {
+          bar 20
+        }
+
+        foo {
+          bar 40
+        }
       }
+
       expect(sr.to_terraform_json[0]).to eq 'tags'
       expect(sr.to_terraform_json[1]['x']).to eq 10
+      expect(sr.to_terraform_json[1]['foo'][0]['bar']).to eq 20
+      expect(sr.to_terraform_json[1]['foo'][1]['bar']).to eq 40
     end
   end
 end

data/spec/utils/has_subresources_spec.rb

@@ -10,11 +10,20 @@ describe("HasSubResources") do
     x = WithSubResources.new()
     x.one_sr {
       value 10
+      sr {
+        multi true
+      }
     }
 
+    # checks for assigned value
     expect(x.one_sr.value).to eq 10
+
+    # checks for non assigned value
     expect(x.no_one_value).to eq nil
 
+    # checks that there are multi level sub resources
+    expect(x.one_sr.sr.multi).to eq true
+
     x.multi_sr {
       value 20
     }

data/spec/utils/has_validations_spec.rb

@@ -56,7 +56,7 @@ describe("HasValidations") do
 
   describe "#validate_at_least_one_present" do
     it "checks that at least of the specified attributes is defined" do
-      class Subject < GeoEngineer::Resource
+      class Subject2 < GeoEngineer::Resource
         include HasValidations
         validate -> {
           validate_only_one_present([:foo, :bar, :baz])
@@ -67,14 +67,34 @@ describe("HasValidations") do
         end
       end
 
-      valid = Subject.new('subject', 'id') { foo("quack") }
+      valid = Subject2.new('subject', 'id') { foo("quack") }
       expect(valid.errors).to be_empty
 
-      invalid = Subject.new('subject', 'id') {
+      invalid = Subject2.new('subject', 'id') {
         foo("quack")
         bar("meow")
       }
       expect(invalid.errors).to_not be_empty
     end
   end
+
+  describe "#validate_policy_length" do
+    it "enforces AWS policy size limits" do
+      class Subject3 < GeoEngineer::Resource
+        include HasValidations
+        validate -> {
+          validate_policy_length(self.policy)
+        }
+
+        def _terraform_id
+          'id'
+        end
+      end
+      invalid = Subject3.new('subject', 'id') { policy("abcdefgh" * 64 * 11) }
+      expect(invalid.errors).to_not be_empty
+
+      valid = Subject3.new('subject', 'id') { policy("abcdefgh" * 64 * 9) }
+      expect(valid.errors).to be_empty
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: geoengineer
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - coinbase
@@ -30,7 +30,7 @@ cert_chain:
   6WK7/7ziN7oP5gOag1gEqjCieZEtmPdj2uvE5+X0/bQOpstnZfPbeaMxswFdxMB4
   gvJWIT9xvxqnL8bM/44RAGrzrkx7OQi5HEoMCpfXJevlu1PF17Y3ylbNGBL4Og==
   -----END CERTIFICATE-----
-date: 2016-12-29 00:00:00.000000000 Z
+date: 2017-01-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -193,9 +193,13 @@ files:
 - lib/geoengineer/output.rb
 - lib/geoengineer/project.rb
 - lib/geoengineer/resource.rb
+- lib/geoengineer/resources/aws_cloudtrail.rb
+- lib/geoengineer/resources/aws_cloudwatch_event_rule.rb
+- lib/geoengineer/resources/aws_cloudwatch_event_target.rb
 - lib/geoengineer/resources/aws_customer_gateway.rb
 - lib/geoengineer/resources/aws_db_instance.rb
 - lib/geoengineer/resources/aws_db_parameter_group.rb
+- lib/geoengineer/resources/aws_dynamodb_table.rb
 - lib/geoengineer/resources/aws_eip.rb
 - lib/geoengineer/resources/aws_elasticache_cluster.rb
 - lib/geoengineer/resources/aws_elasticache_parameter_group.rb
@@ -208,13 +212,17 @@ files:
 - lib/geoengineer/resources/aws_iam_policy.rb
 - lib/geoengineer/resources/aws_iam_policy_attachment.rb
 - lib/geoengineer/resources/aws_iam_role.rb
+- lib/geoengineer/resources/aws_iam_role_policy.rb
 - lib/geoengineer/resources/aws_iam_user.rb
 - lib/geoengineer/resources/aws_instance.rb
 - lib/geoengineer/resources/aws_internet_gateway.rb
+- lib/geoengineer/resources/aws_kinesis_stream.rb
 - lib/geoengineer/resources/aws_lambda_alias.rb
 - lib/geoengineer/resources/aws_lambda_event_source_mapping.rb
 - lib/geoengineer/resources/aws_lambda_function.rb
 - lib/geoengineer/resources/aws_lambda_permission.rb
+- lib/geoengineer/resources/aws_load_balancer_backend_server_policy.rb
+- lib/geoengineer/resources/aws_load_balancer_policy.rb
 - lib/geoengineer/resources/aws_main_route_table_association.rb
 - lib/geoengineer/resources/aws_nat_gateway.rb
 - lib/geoengineer/resources/aws_network_acl.rb
@@ -261,9 +269,13 @@ files:
 - spec/output_spec.rb
 - spec/project_spec.rb
 - spec/resource_spec.rb
+- spec/resources/aws_cloudtrail_spec.rb
+- spec/resources/aws_cloudwatch_event_rule_spec.rb
+- spec/resources/aws_cloudwatch_event_target_spec.rb
 - spec/resources/aws_customer_gateway_spec.rb
 - spec/resources/aws_db_instance_spec.rb
 - spec/resources/aws_db_parameter_group_spec.rb
+- spec/resources/aws_dynamodb_table_spec.rb
 - spec/resources/aws_eip_spec.rb
 - spec/resources/aws_elasticache_replication_group_spec.rb
 - spec/resources/aws_elasticache_subnet_group_spec.rb
@@ -276,13 +288,17 @@ files:
 - spec/resources/aws_iam_policy_attachment_spec.rb
 - spec/resources/aws_iam_policy_spec.rb
 - spec/resources/aws_iam_role_spec.rb
-- spec/resources/aws_iam_user.rb
+- spec/resources/aws_iam_rule_policy_spec.rb
+- spec/resources/aws_iam_user_spec.rb
 - spec/resources/aws_instance_spec.rb
 - spec/resources/aws_internet_gateway_spec.rb
+- spec/resources/aws_kinesis_stream_spec.rb
 - spec/resources/aws_lambda_alias_spec.rb
 - spec/resources/aws_lambda_event_source_mapping_spec.rb
 - spec/resources/aws_lambda_function_spec.rb
 - spec/resources/aws_lambda_permission_spec.rb
+- spec/resources/aws_load_balancer_backend_server_policy_spec.rb
+- spec/resources/aws_load_balancer_policy_spec.rb
 - spec/resources/aws_main_route_table_association_spec.rb
 - spec/resources/aws_nat_gateway_spec.rb
 - spec/resources/aws_network_acl_rule_spec.rb
@@ -296,10 +312,10 @@ files:
 - spec/resources/aws_route_table_spec.rb
 - spec/resources/aws_s3_bucket_spec.rb
 - spec/resources/aws_security_group_spec.rb
-- spec/resources/aws_ses_receipt_rule.rb
-- spec/resources/aws_ses_receipt_rule_set.rb
+- spec/resources/aws_ses_receipt_rule_set_spec.rb
+- spec/resources/aws_ses_receipt_rule_spec.rb
 - spec/resources/aws_sns_topic_spec.rb
-- spec/resources/aws_sns_topic_subscription.rb
+- spec/resources/aws_sns_topic_subscription_spec.rb
 - spec/resources/aws_sqs_queue_spec.rb
 - spec/resources/aws_subnet_spec.rb
 - spec/resources/aws_vpc_dhcp_options_association_spec.rb
@@ -351,9 +367,13 @@ test_files:
 - spec/output_spec.rb
 - spec/project_spec.rb
 - spec/resource_spec.rb
+- spec/resources/aws_cloudtrail_spec.rb
+- spec/resources/aws_cloudwatch_event_rule_spec.rb
+- spec/resources/aws_cloudwatch_event_target_spec.rb
 - spec/resources/aws_customer_gateway_spec.rb
 - spec/resources/aws_db_instance_spec.rb
 - spec/resources/aws_db_parameter_group_spec.rb
+- spec/resources/aws_dynamodb_table_spec.rb
 - spec/resources/aws_eip_spec.rb
 - spec/resources/aws_elasticache_replication_group_spec.rb
 - spec/resources/aws_elasticache_subnet_group_spec.rb
@@ -366,13 +386,17 @@ test_files:
 - spec/resources/aws_iam_policy_attachment_spec.rb
 - spec/resources/aws_iam_policy_spec.rb
 - spec/resources/aws_iam_role_spec.rb
-- spec/resources/aws_iam_user.rb
+- spec/resources/aws_iam_rule_policy_spec.rb
+- spec/resources/aws_iam_user_spec.rb
 - spec/resources/aws_instance_spec.rb
 - spec/resources/aws_internet_gateway_spec.rb
+- spec/resources/aws_kinesis_stream_spec.rb
 - spec/resources/aws_lambda_alias_spec.rb
 - spec/resources/aws_lambda_event_source_mapping_spec.rb
 - spec/resources/aws_lambda_function_spec.rb
 - spec/resources/aws_lambda_permission_spec.rb
+- spec/resources/aws_load_balancer_backend_server_policy_spec.rb
+- spec/resources/aws_load_balancer_policy_spec.rb
 - spec/resources/aws_main_route_table_association_spec.rb
 - spec/resources/aws_nat_gateway_spec.rb
 - spec/resources/aws_network_acl_rule_spec.rb
@@ -386,10 +410,10 @@ test_files:
 - spec/resources/aws_route_table_spec.rb
 - spec/resources/aws_s3_bucket_spec.rb
 - spec/resources/aws_security_group_spec.rb
-- spec/resources/aws_ses_receipt_rule.rb
-- spec/resources/aws_ses_receipt_rule_set.rb
+- spec/resources/aws_ses_receipt_rule_set_spec.rb
+- spec/resources/aws_ses_receipt_rule_spec.rb
 - spec/resources/aws_sns_topic_spec.rb
-- spec/resources/aws_sns_topic_subscription.rb
+- spec/resources/aws_sns_topic_subscription_spec.rb
 - spec/resources/aws_sqs_queue_spec.rb
 - spec/resources/aws_subnet_spec.rb
 - spec/resources/aws_vpc_dhcp_options_association_spec.rb