geodetic 0.5.0 → 0.5.2

data/lib/geodetic/coordinate/ups.rb

@@ -132,9 +132,9 @@ module Geodetic
         LLA.new(lat: lat, lng: lng, alt: 0.0)
       end
 
-      def self.from_lla(lla_coord, datum = WGS84)
-        lat = lla_coord.lat
-        lng = lla_coord.lng
+      def self.from_lla(lla, datum = WGS84)
+        lat = lla.lat
+        lng = lla.lng
 
         # Determine hemisphere and zone
         hemisphere = lat >= 0 ? 'N' : 'S'
@@ -183,8 +183,8 @@ module Geodetic
         to_lla(datum).to_ecef(datum)
       end
 
-      def self.from_ecef(ecef_coord, datum = WGS84)
-        lla_coord = ecef_coord.to_lla(datum)
+      def self.from_ecef(ecef, datum = WGS84)
+        lla_coord = ecef.to_lla(datum)
         from_lla(lla_coord, datum)
       end
 
@@ -192,8 +192,8 @@ module Geodetic
         to_lla(datum).to_utm(datum)
       end
 
-      def self.from_utm(utm_coord, datum = WGS84)
-        lla_coord = utm_coord.to_lla(datum)
+      def self.from_utm(utm, datum = WGS84)
+        lla_coord = utm.to_lla(datum)
         from_lla(lla_coord, datum)
       end
 
@@ -201,8 +201,8 @@ module Geodetic
         to_lla(datum).to_enu(reference_lla)
       end
 
-      def self.from_enu(enu_coord, reference_lla, datum = WGS84)
-        lla_coord = enu_coord.to_lla(reference_lla)
+      def self.from_enu(enu, reference_lla, datum = WGS84)
+        lla_coord = enu.to_lla(reference_lla)
         from_lla(lla_coord, datum)
       end
 
@@ -210,8 +210,8 @@ module Geodetic
         to_lla(datum).to_ned(reference_lla)
       end
 
-      def self.from_ned(ned_coord, reference_lla, datum = WGS84)
-        lla_coord = ned_coord.to_lla(reference_lla)
+      def self.from_ned(ned, reference_lla, datum = WGS84)
+        lla_coord = ned.to_lla(reference_lla)
         from_lla(lla_coord, datum)
       end
 
@@ -219,8 +219,8 @@ module Geodetic
         MGRS.from_lla(to_lla(datum), datum, precision)
       end
 
-      def self.from_mgrs(mgrs_coord, datum = WGS84)
-        lla_coord = mgrs_coord.to_lla(datum)
+      def self.from_mgrs(mgrs, datum = WGS84)
+        lla_coord = mgrs.to_lla(datum)
         from_lla(lla_coord, datum)
       end
 
@@ -228,8 +228,8 @@ module Geodetic
         WebMercator.from_lla(to_lla(datum), datum)
       end
 
-      def self.from_web_mercator(web_mercator_coord, datum = WGS84)
-        lla_coord = web_mercator_coord.to_lla(datum)
+      def self.from_web_mercator(web_mercator, datum = WGS84)
+        lla_coord = web_mercator.to_lla(datum)
         from_lla(lla_coord, datum)
       end
 
@@ -237,8 +237,8 @@ module Geodetic
         USNG.from_lla(to_lla(datum), datum, precision)
       end
 
-      def self.from_usng(usng_coord, datum = WGS84)
-        lla_coord = usng_coord.to_lla(datum)
+      def self.from_usng(usng, datum = WGS84)
+        lla_coord = usng.to_lla(datum)
         from_lla(lla_coord, datum)
       end
 
@@ -246,8 +246,8 @@ module Geodetic
         BNG.from_lla(to_lla(datum), datum)
       end
 
-      def self.from_bng(bng_coord, datum = WGS84)
-        lla_coord = bng_coord.to_lla(datum)
+      def self.from_bng(bng, datum = WGS84)
+        lla_coord = bng.to_lla(datum)
         from_lla(lla_coord, datum)
       end
 
@@ -255,8 +255,8 @@ module Geodetic
         StatePlane.from_lla(to_lla(datum), zone_code, datum)
       end
 
-      def self.from_state_plane(sp_coord, datum = WGS84)
-        lla_coord = sp_coord.to_lla(datum)
+      def self.from_state_plane(state_plane, datum = WGS84)
+        lla_coord = state_plane.to_lla(datum)
         from_lla(lla_coord, datum)
       end
 

data/lib/geodetic/coordinate/usng.rb

@@ -49,13 +49,13 @@ module Geodetic
         MGRS.new(mgrs_string: mgrs_string)
       end
 
-      def self.from_mgrs(mgrs_coord)
+      def self.from_mgrs(mgrs)
         # Extract components from MGRS
-        grid_zone = mgrs_coord.grid_zone_designator
-        square_id = mgrs_coord.square_identifier
-        easting = mgrs_coord.easting
-        northing = mgrs_coord.northing
-        precision = mgrs_coord.precision
+        grid_zone = mgrs.grid_zone_designator
+        square_id = mgrs.square_identifier
+        easting = mgrs.easting
+        northing = mgrs.northing
+        precision = mgrs.precision
 
         new(grid_zone: grid_zone, square_id: square_id, easting: easting, northing: northing, precision: precision)
       end
@@ -64,8 +64,8 @@ module Geodetic
         to_mgrs.to_utm
       end
 
-      def self.from_utm(utm_coord, precision = 5)
-        mgrs_coord = MGRS.from_utm(utm_coord, precision)
+      def self.from_utm(utm, precision = 5)
+        mgrs_coord = MGRS.from_utm(utm, precision)
         from_mgrs(mgrs_coord)
       end
 
@@ -73,8 +73,8 @@ module Geodetic
         to_mgrs.to_lla(datum)
       end
 
-      def self.from_lla(lla_coord, datum = WGS84, precision = 5)
-        mgrs_coord = MGRS.from_lla(lla_coord, datum, precision)
+      def self.from_lla(lla, datum = WGS84, precision = 5)
+        mgrs_coord = MGRS.from_lla(lla, datum, precision)
         from_mgrs(mgrs_coord)
       end
 
@@ -82,8 +82,8 @@ module Geodetic
         to_lla(datum).to_ecef(datum)
       end
 
-      def self.from_ecef(ecef_coord, datum = WGS84, precision = 5)
-        lla_coord = ecef_coord.to_lla(datum)
+      def self.from_ecef(ecef, datum = WGS84, precision = 5)
+        lla_coord = ecef.to_lla(datum)
         from_lla(lla_coord, datum, precision)
       end
 
@@ -91,8 +91,8 @@ module Geodetic
         to_lla(datum).to_enu(reference_lla)
       end
 
-      def self.from_enu(enu_coord, reference_lla, datum = WGS84, precision = 5)
-        lla_coord = enu_coord.to_lla(reference_lla)
+      def self.from_enu(enu, reference_lla, datum = WGS84, precision = 5)
+        lla_coord = enu.to_lla(reference_lla)
         from_lla(lla_coord, datum, precision)
       end
 
@@ -100,8 +100,8 @@ module Geodetic
         to_lla(datum).to_ned(reference_lla)
       end
 
-      def self.from_ned(ned_coord, reference_lla, datum = WGS84, precision = 5)
-        lla_coord = ned_coord.to_lla(reference_lla)
+      def self.from_ned(ned, reference_lla, datum = WGS84, precision = 5)
+        lla_coord = ned.to_lla(reference_lla)
         from_lla(lla_coord, datum, precision)
       end
 
@@ -109,8 +109,8 @@ module Geodetic
         UPS.from_lla(to_lla(datum), datum)
       end
 
-      def self.from_ups(ups_coord, datum = WGS84, precision = 5)
-        lla_coord = ups_coord.to_lla(datum)
+      def self.from_ups(ups, datum = WGS84, precision = 5)
+        lla_coord = ups.to_lla(datum)
         from_lla(lla_coord, datum, precision)
       end
 
@@ -118,8 +118,8 @@ module Geodetic
         WebMercator.from_lla(to_lla(datum), datum)
       end
 
-      def self.from_web_mercator(web_mercator_coord, datum = WGS84, precision = 5)
-        lla_coord = web_mercator_coord.to_lla(datum)
+      def self.from_web_mercator(web_mercator, datum = WGS84, precision = 5)
+        lla_coord = web_mercator.to_lla(datum)
         from_lla(lla_coord, datum, precision)
       end
 
@@ -127,16 +127,16 @@ module Geodetic
         BNG.from_lla(to_lla(datum), datum)
       end
 
-      def self.from_bng(bng_coord, datum = WGS84, precision = 5)
-        from_lla(bng_coord.to_lla(datum), datum, precision)
+      def self.from_bng(bng, datum = WGS84, precision = 5)
+        from_lla(bng.to_lla(datum), datum, precision)
       end
 
       def to_state_plane(zone_code, datum = WGS84)
         StatePlane.from_lla(to_lla(datum), zone_code, datum)
       end
 
-      def self.from_state_plane(sp_coord, datum = WGS84, precision = 5)
-        from_lla(sp_coord.to_lla(datum), datum, precision)
+      def self.from_state_plane(state_plane, datum = WGS84, precision = 5)
+        from_lla(state_plane.to_lla(datum), datum, precision)
       end
 
       def ==(other)
@@ -196,7 +196,7 @@ module Geodetic
             adjacent_usng = USNG.new(grid_zone: @grid_zone_designator, square_id: @square_identifier,
                                      easting: new_east, northing: new_north, precision: @precision)
             squares[direction] = adjacent_usng
-          rescue => e
+          rescue ArgumentError
             # Skip invalid adjacent squares (e.g., crossing zone boundaries)
             squares[direction] = nil
           end

data/lib/geodetic/coordinate/utm.rb

@@ -152,48 +152,48 @@ module Geodetic
         MGRS.from_utm(self, precision)
       end
 
-      def self.from_mgrs(mgrs_coord, datum = WGS84)
-        mgrs_coord.to_utm
+      def self.from_mgrs(mgrs, datum = WGS84)
+        mgrs.to_utm
       end
 
       def to_usng(datum = WGS84, precision = 5)
         USNG.from_utm(self, precision)
       end
 
-      def self.from_usng(usng_coord, datum = WGS84)
-        usng_coord.to_utm
+      def self.from_usng(usng, datum = WGS84)
+        usng.to_utm
       end
 
       def to_web_mercator(datum = WGS84)
         WebMercator.from_lla(to_lla(datum), datum)
       end
 
-      def self.from_web_mercator(wm_coord, datum = WGS84)
-        from_lla(wm_coord.to_lla(datum), datum)
+      def self.from_web_mercator(web_mercator, datum = WGS84)
+        from_lla(web_mercator.to_lla(datum), datum)
       end
 
       def to_ups(datum = WGS84)
         UPS.from_lla(to_lla(datum), datum)
       end
 
-      def self.from_ups(ups_coord, datum = WGS84)
-        from_lla(ups_coord.to_lla(datum), datum)
+      def self.from_ups(ups, datum = WGS84)
+        from_lla(ups.to_lla(datum), datum)
       end
 
       def to_state_plane(zone_code, datum = WGS84)
         StatePlane.from_lla(to_lla(datum), zone_code, datum)
       end
 
-      def self.from_state_plane(sp_coord, datum = WGS84)
-        from_lla(sp_coord.to_lla(datum), datum)
+      def self.from_state_plane(state_plane, datum = WGS84)
+        from_lla(state_plane.to_lla(datum), datum)
       end
 
       def to_bng(datum = WGS84)
         BNG.from_lla(to_lla(datum))
       end
 
-      def self.from_bng(bng_coord, datum = WGS84)
-        from_lla(bng_coord.to_lla, datum)
+      def self.from_bng(bng, datum = WGS84)
+        from_lla(bng.to_lla, datum)
       end
 
       def to_s(precision = 2)

data/lib/geodetic/coordinate/web_mercator.rb

@@ -62,9 +62,9 @@ module Geodetic
         LLA.new(lat: lat, lng: lng, alt: 0.0)
       end
 
-      def self.from_lla(lla_coord, datum = WGS84)
-        lat = lla_coord.lat
-        lng = lla_coord.lng
+      def self.from_lla(lla, datum = WGS84)
+        lat = lla.lat
+        lng = lla.lng
 
         # Clamp latitude to Web Mercator limits
         lat = [[-MAX_LATITUDE, lat].max, MAX_LATITUDE].min
@@ -80,8 +80,8 @@ module Geodetic
         to_lla(datum).to_ecef(datum)
       end
 
-      def self.from_ecef(ecef_coord, datum = WGS84)
-        lla_coord = ecef_coord.to_lla(datum)
+      def self.from_ecef(ecef, datum = WGS84)
+        lla_coord = ecef.to_lla(datum)
         from_lla(lla_coord, datum)
       end
 
@@ -89,8 +89,8 @@ module Geodetic
         to_lla(datum).to_utm(datum)
       end
 
-      def self.from_utm(utm_coord, datum = WGS84)
-        lla_coord = utm_coord.to_lla(datum)
+      def self.from_utm(utm, datum = WGS84)
+        lla_coord = utm.to_lla(datum)
         from_lla(lla_coord, datum)
       end
 
@@ -98,8 +98,8 @@ module Geodetic
         to_lla(datum).to_enu(reference_lla)
       end
 
-      def self.from_enu(enu_coord, reference_lla, datum = WGS84)
-        lla_coord = enu_coord.to_lla(reference_lla)
+      def self.from_enu(enu, reference_lla, datum = WGS84)
+        lla_coord = enu.to_lla(reference_lla)
         from_lla(lla_coord, datum)
       end
 
@@ -107,8 +107,8 @@ module Geodetic
         to_lla(datum).to_ned(reference_lla)
       end
 
-      def self.from_ned(ned_coord, reference_lla, datum = WGS84)
-        lla_coord = ned_coord.to_lla(reference_lla)
+      def self.from_ned(ned, reference_lla, datum = WGS84)
+        lla_coord = ned.to_lla(reference_lla)
         from_lla(lla_coord, datum)
       end
 
@@ -116,8 +116,8 @@ module Geodetic
         MGRS.from_lla(to_lla(datum), datum, precision)
       end
 
-      def self.from_mgrs(mgrs_coord, datum = WGS84)
-        lla_coord = mgrs_coord.to_lla(datum)
+      def self.from_mgrs(mgrs, datum = WGS84)
+        lla_coord = mgrs.to_lla(datum)
         from_lla(lla_coord, datum)
       end
 
@@ -125,32 +125,32 @@ module Geodetic
         USNG.from_lla(to_lla(datum), datum, precision)
       end
 
-      def self.from_usng(usng_coord, datum = WGS84)
-        from_lla(usng_coord.to_lla(datum), datum)
+      def self.from_usng(usng, datum = WGS84)
+        from_lla(usng.to_lla(datum), datum)
       end
 
       def to_ups(datum = WGS84)
         UPS.from_lla(to_lla(datum), datum)
       end
 
-      def self.from_ups(ups_coord, datum = WGS84)
-        from_lla(ups_coord.to_lla(datum), datum)
+      def self.from_ups(ups, datum = WGS84)
+        from_lla(ups.to_lla(datum), datum)
       end
 
       def to_state_plane(zone_code, datum = WGS84)
         StatePlane.from_lla(to_lla(datum), zone_code, datum)
       end
 
-      def self.from_state_plane(sp_coord, datum = WGS84)
-        from_lla(sp_coord.to_lla(datum), datum)
+      def self.from_state_plane(state_plane, datum = WGS84)
+        from_lla(state_plane.to_lla(datum), datum)
       end
 
       def to_bng(datum = WGS84)
         BNG.from_lla(to_lla(datum))
       end
 
-      def self.from_bng(bng_coord, datum = WGS84)
-        from_lla(bng_coord.to_lla, datum)
+      def self.from_bng(bng, datum = WGS84)
+        from_lla(bng.to_lla, datum)
       end
 
       # Tile coordinate methods for web mapping

data/lib/geodetic/coordinate.rb

@@ -11,7 +11,7 @@ module Geodetic
       attr_reader :registered_classes
 
       def systems
-        @registered_classes.map(&:first).freeze
+        @systems_cache ||= @registered_classes.map(&:first).freeze
       end
 
       def register_class(klass, hash_conversion_style: nil)
@@ -19,8 +19,9 @@ module Geodetic
       end
 
       def finalize!
-        raise "Geodetic::Coordinate already finalized!" if @finalized
+        return if @finalized
         @finalized = true
+        @systems_cache = nil
 
         # Phase 1: Generate cross-hash conversion methods between spatial hash subclasses
         SpatialHash.finalize_cross_hash_conversions!