geodetic 0.3.0 → 0.3.2

data/lib/geodetic/coordinate/gars.rb

@@ -76,12 +76,12 @@ module Geodetic
         VALID_LENGTHS.include?(@code.length) && valid_characters?(@code)
       end
 
+      protected
+
       def code_value
         @code
       end
 
-      protected
-
       def normalize(string)
         result = String.new(capacity: string.length)
         string.each_char.with_index do |ch, i|
@@ -227,7 +227,6 @@ module Geodetic
       end
 
       register_hash_system(:gars, self, default_precision: 7)
-      Coordinate.register_class(self)
     end
   end
 end

data/lib/geodetic/coordinate/georef.rb

@@ -55,12 +55,12 @@ module Geodetic
         VALID_LENGTHS.include?(@code.length) && valid_characters?(@code)
       end
 
+      protected
+
       def code_value
         @code
       end
 
-      protected
-
       def normalize(string)
         string.upcase
       end
@@ -198,7 +198,6 @@ module Geodetic
       end
 
       register_hash_system(:georef, self, default_precision: 8)
-      Coordinate.register_class(self)
     end
   end
 end

data/lib/geodetic/coordinate/gh.rb

@@ -39,13 +39,12 @@ module Geodetic
         @geohash.length > 0 && @geohash.each_char.all? { |c| CHAR_INDEX.key?(c) }
       end
 
-      # Expose code_value for base class equality and other shared methods
+      protected
+
       def code_value
         @geohash
       end
 
-      protected
-
       def normalize(string)
         string.downcase
       end
@@ -155,7 +154,6 @@ module Geodetic
       alias_method :validate_code!, :validate_geohash!
 
       register_hash_system(:gh, self, default_precision: 12)
-      Coordinate.register_class(self)
     end
   end
 end

data/lib/geodetic/coordinate/gh36.rb

@@ -74,10 +74,6 @@ module Geodetic
         @geohash.length > 0 && @geohash.each_char.all? { |c| VALID_CHARS_SET.include?(c) }
       end
 
-      def code_value
-        @geohash
-      end
-
       # --- GH36-specific overrides (matrix-based algorithms) ---
 
       # Uses recursive matrix-based neighbor calculation instead of bounds-based
@@ -105,6 +101,10 @@ module Geodetic
 
       protected
 
+      def code_value
+        @geohash
+      end
+
       def set_code(value)
         @geohash = value
       end
@@ -243,7 +243,6 @@ module Geodetic
       alias_method :validate_code!, :validate_geohash!
 
       register_hash_system(:gh36, self, default_precision: 10)
-      Coordinate.register_class(self)
     end
   end
 end

data/lib/geodetic/coordinate/h3.rb

@@ -358,12 +358,12 @@ module Geodetic
         end
       end
 
+      protected
+
       def code_value
         @code
       end
 
-      protected
-
       def normalize(string)
         string.downcase.delete_prefix('0x')
       end
@@ -407,7 +407,6 @@ module Geodetic
       alias_method :validate_code!, :validate_h3!
 
       register_hash_system(:h3, self, default_precision: 7)
-      Coordinate.register_class(self)
     end
   end
 end

data/lib/geodetic/coordinate/ham.rb

@@ -74,12 +74,12 @@ module Geodetic
           valid_characters?(@locator)
       end
 
+      protected
+
       def code_value
         @locator
       end
 
-      protected
-
       def normalize(string)
         result = String.new(capacity: string.length)
         string.each_char.with_index do |ch, i|
@@ -220,7 +220,6 @@ module Geodetic
       end
 
       register_hash_system(:ham, self, default_precision: 6)
-      Coordinate.register_class(self)
     end
   end
 end

data/lib/geodetic/coordinate/lla.rb

@@ -305,6 +305,12 @@ module Geodetic
         new(lat: parts[0].to_f, lng: parts[1].to_f, alt: parts[2].to_f)
       end
 
+      def valid?
+        @lat.finite? && @lng.finite? && @alt.finite? &&
+          @lat >= -90 && @lat <= 90 &&
+          @lng >= -180 && @lng <= 180
+      end
+
       def ==(other)
         return false unless other.is_a?(LLA)
 
@@ -325,7 +331,7 @@ module Geodetic
         raise ArgumentError, "Longitude must be between -180 and 180 degrees" if @lng < -180 || @lng > 180
       end
 
-      Coordinate.register_class(self)
+      Coordinate.register_class(self, hash_conversion_style: :no_datum)
     end
   end
 end

data/lib/geodetic/coordinate/mgrs.rb

@@ -305,7 +305,7 @@ module Geodetic
         bands[index]
       end
 
-      Coordinate.register_class(self)
+      Coordinate.register_class(self, hash_conversion_style: :with_datum_and_precision)
     end
   end
 end

data/lib/geodetic/coordinate/ned.rb

@@ -224,6 +224,10 @@ module Geodetic
         new(n: parts[0].to_f, e: parts[1].to_f, d: parts[2].to_f)
       end
 
+      def valid?
+        @n.finite? && @e.finite? && @d.finite?
+      end
+
       def ==(other)
         return false unless other.is_a?(NED)
 

data/lib/geodetic/coordinate/olc.rb

@@ -267,7 +267,6 @@ module Geodetic
       end
 
       register_hash_system(:olc, self, default_precision: 10)
-      Coordinate.register_class(self)
     end
   end
 end

data/lib/geodetic/coordinate/spatial_hash.rb

@@ -12,7 +12,7 @@
 #   decode_bounds(code_string)    → { min_lat:, max_lat:, min_lng:, max_lng: }
 #   validate_code!(string)        → raises ArgumentError or nil
 #   set_code(normalized_string)   → sets the internal ivar (@geohash, @code, etc.)
-#   code_value                    → returns the internal ivar
+#   code_value                    → returns the internal ivar (protected)
 #   self.default_precision        → Integer
 #   self.hash_system_name         → Symbol (:gh, :gh36, :ham, :olc)
 #
@@ -52,6 +52,7 @@ module Geodetic
             class_name: klass.name.split('::').last,
             default_precision: default_precision
           }
+          Coordinate.register_class(klass)
         end
 
         # Called once after all spatial hash subclasses are loaded.
@@ -285,7 +286,6 @@ module Geodetic
         code_value == other.code_value
       end
 
-      alias_method :to_slug, :to_s
 
       # Returns all 8 neighboring cells
       # Keys: :N, :S, :E, :W, :NE, :NW, :SE, :SW

data/lib/geodetic/coordinate/ups.rb

@@ -312,7 +312,7 @@ module Geodetic
         end
       end
 
-      Coordinate.register_class(self)
+      Coordinate.register_class(self, hash_conversion_style: :with_datum)
     end
   end
 end

data/lib/geodetic/coordinate/usng.rb

@@ -262,7 +262,7 @@ module Geodetic
         end
       end
 
-      Coordinate.register_class(self)
+      Coordinate.register_class(self, hash_conversion_style: :with_datum_and_precision)
     end
   end
 end

data/lib/geodetic/coordinate/utm.rb

@@ -249,7 +249,7 @@ module Geodetic
         raise ArgumentError, "Northing must be positive" if @northing < 0
       end
 
-      Coordinate.register_class(self)
+      Coordinate.register_class(self, hash_conversion_style: :no_datum)
     end
   end
 end

data/lib/geodetic/coordinate/web_mercator.rb

@@ -230,7 +230,7 @@ module Geodetic
         }
       end
 
-      Coordinate.register_class(self)
+      Coordinate.register_class(self, hash_conversion_style: :no_datum)
     end
   end
 end

data/lib/geodetic/coordinate.rb

@@ -3,13 +3,39 @@
 module Geodetic
   module Coordinate
     # Registry for coordinate classes — each class registers itself at load time
+    # Each entry is [klass, options_hash] where options may include :hash_conversion_style
     @registered_classes = []
+    @finalized = false
 
     class << self
       attr_reader :registered_classes
 
-      def register_class(klass)
-        @registered_classes << klass
+      def systems
+        @registered_classes.map(&:first).freeze
+      end
+
+      def register_class(klass, hash_conversion_style: nil)
+        @registered_classes << [klass, { hash_conversion_style: hash_conversion_style }]
+      end
+
+      def finalize!
+        raise "Geodetic::Coordinate already finalized!" if @finalized
+        @finalized = true
+
+        # Phase 1: Generate cross-hash conversion methods between spatial hash subclasses
+        SpatialHash.finalize_cross_hash_conversions!
+
+        # Phase 2: Generate hash conversion methods on non-hash coordinate classes
+        @registered_classes.each do |klass, opts|
+          next unless opts[:hash_conversion_style]
+          SpatialHash.generate_hash_conversions_for(klass, style: opts[:hash_conversion_style])
+        end
+
+        # Phase 3: Include distance/bearing mixins in all registered coordinate classes
+        @registered_classes.each do |klass, _opts|
+          klass.include(DistanceMethods)
+          klass.include(BearingMethods)
+        end
       end
     end
   end
@@ -257,27 +283,5 @@ module Geodetic
   end
 end
 
-# Generate cross-hash conversion methods (to_gh, to_ham, etc.) between all spatial hash subclasses
-Geodetic::Coordinate::SpatialHash.finalize_cross_hash_conversions!
-
-# Generate hash conversion methods (to_gh, from_gh, etc.) on non-hash coordinate classes
-sh = Geodetic::Coordinate::SpatialHash
-sh.generate_hash_conversions_for(Geodetic::Coordinate::LLA,          style: :no_datum)
-sh.generate_hash_conversions_for(Geodetic::Coordinate::ECEF,         style: :no_datum)
-sh.generate_hash_conversions_for(Geodetic::Coordinate::UTM,          style: :no_datum)
-sh.generate_hash_conversions_for(Geodetic::Coordinate::WebMercator,  style: :no_datum)
-sh.generate_hash_conversions_for(Geodetic::Coordinate::BNG,          style: :with_datum)
-sh.generate_hash_conversions_for(Geodetic::Coordinate::UPS,          style: :with_datum)
-sh.generate_hash_conversions_for(Geodetic::Coordinate::MGRS,         style: :with_datum_and_precision)
-sh.generate_hash_conversions_for(Geodetic::Coordinate::USNG,         style: :with_datum_and_precision)
-
-# Include distance/bearing mixins in all registered coordinate classes
-ALL_COORD_CLASSES = Geodetic::Coordinate.registered_classes.freeze
-
-ALL_COORD_CLASSES.each do |klass|
-  klass.include(Geodetic::Coordinate::DistanceMethods)
-  klass.include(Geodetic::Coordinate::BearingMethods)
-end
-
-# GCS is a convenience alias for Geodetic::Coordinate, available after require "geodetic"
-GCS = Geodetic::Coordinate
+# All classes loaded and registered — finalize conversions and mixins
+Geodetic::Coordinate.finalize!

data/lib/geodetic/feature.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+
+module Geodetic
+  class Feature
+    attr_accessor :label, :geometry, :metadata
+
+    def initialize(label:, geometry:, metadata: {})
+      @label    = label
+      @geometry = geometry
+      @metadata = metadata
+    end
+
+    def distance_to(other)
+      if @geometry.is_a?(Path)
+        @geometry.distance_to(other)
+      else
+        resolve_point.distance_to(resolve_point_from(other))
+      end
+    end
+
+    def bearing_to(other)
+      if @geometry.is_a?(Path)
+        @geometry.bearing_to(other)
+      else
+        resolve_point.bearing_to(resolve_point_from(other))
+      end
+    end
+
+    def to_s
+      "#{@label} (#{@geometry})"
+    end
+
+    def inspect
+      "#<Geodetic::Feature name=#{@label.inspect} geometry=#{@geometry.inspect} metadata=#{@metadata.inspect}>"
+    end
+
+    private
+
+    def resolve_point
+      @geometry.respond_to?(:centroid) ? @geometry.centroid : @geometry
+    end
+
+    def resolve_point_from(other)
+      case other
+      when Feature
+        other.send(:resolve_point)
+      else
+        other.respond_to?(:centroid) ? other.centroid : other
+      end
+    end
+  end
+end

data/lib/geodetic/geoid_height.rb

@@ -107,14 +107,14 @@ module Geodetic
       raise ArgumentError, "Unknown vertical datum: #{to_datum}" unless to_info
 
       if from_info[:type] == 'orthometric'
-        geoid_model = GeoidHeight.new(geoid_model: from_info[:reference_geoid])
+        geoid_model = GeoidHeight.for(from_info[:reference_geoid])
         ellipsoidal_height = geoid_model.orthometric_to_ellipsoidal(lat, lng, height)
       else
         ellipsoidal_height = height
       end
 
       if to_info[:type] == 'orthometric'
-        geoid_model = GeoidHeight.new(geoid_model: to_info[:reference_geoid])
+        geoid_model = GeoidHeight.for(to_info[:reference_geoid])
         geoid_model.ellipsoidal_to_orthometric(lat, lng, ellipsoidal_height)
       else
         ellipsoidal_height
@@ -175,6 +175,11 @@ module Geodetic
       end
     end
 
+    def self.for(geoid_model = 'EGM2008')
+      @instances ||= {}
+      @instances[geoid_model] ||= new(geoid_model: geoid_model)
+    end
+
     def self.available_models
       GEOID_MODELS.keys
     end
@@ -271,7 +276,7 @@ module Geodetic
     def convert_height_datum(from_datum, to_datum, geoid_model = 'EGM2008')
       return self unless respond_to?(:lat) && respond_to?(:lng) && respond_to?(:alt)
 
-      geoid = GeoidHeight.new(geoid_model: geoid_model)
+      geoid = GeoidHeight.for(geoid_model)
       new_height = geoid.convert_vertical_datum(self.lat, self.lng, self.alt, from_datum, to_datum)
 
       self.class.new(lat: self.lat, lng: self.lng, alt: new_height)
@@ -280,19 +285,19 @@ module Geodetic
     def geoid_height(geoid_model = 'EGM2008')
       return nil unless respond_to?(:lat) && respond_to?(:lng)
 
-      geoid = GeoidHeight.new(geoid_model: geoid_model)
+      geoid = GeoidHeight.for(geoid_model)
       geoid.geoid_height_at(self.lat, self.lng)
     end
 
     def orthometric_height(geoid_model = 'EGM2008')
       return nil unless respond_to?(:alt) && respond_to?(:lat) && respond_to?(:lng)
 
-      geoid = GeoidHeight.new(geoid_model: geoid_model)
+      geoid = GeoidHeight.for(geoid_model)
       geoid.ellipsoidal_to_orthometric(self.lat, self.lng, self.alt)
     end
 
     def self.from_orthometric_height(lat, lng, orthometric_height, geoid_model = 'EGM2008')
-      geoid = GeoidHeight.new(geoid_model: geoid_model)
+      geoid = GeoidHeight.for(geoid_model)
       geoid.orthometric_to_ellipsoidal(lat, lng, orthometric_height)
     end
   end