geocode_records 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bffb7333678baee4fe92ba535fe31c94ff1dc05b
-  data.tar.gz: c4450f1647e77e47d4e2986124cd7c6889c520e9
+  metadata.gz: 21a4000dec35d9e348e5d08e8cc134ea770c8b2f
+  data.tar.gz: a90cf2b53712ce6fd19cad8c332229f55854a943
 SHA512:
-  metadata.gz: 1b1fc9a9aa539b6ab95d3ad6bb075ab271e127b29c8fcd0fdacb02e7eb34790dda26eb5fab94af9cc8b52b58b77efde86afafb6c4f1b458797a122bef1d9afba
-  data.tar.gz: e41b32652d3e48ce12a960ac3fcbd50aeb07f51f85e27f0c6a0dfa68837d585c964ca69334cfc03b216edad898306f8423356371aa63f741e49a2daad64f4da2
+  metadata.gz: 34a891649b15bcd2bbce05570e780dc38ea1e48afe3fab2fefcace3dfca7bbff592c74cf329c6303d39a733b2780f868862b4ed2d68f8720a6e88f2478ba99ef
+  data.tar.gz: be33ccd4bca6261e6a9e2661c931576dddf303d5279eb366b13127c660932f81ad270172410fc49a70d543fc358d5b85d20e6a873cc5e58af54f4739679a7621

data/.gitignore

@@ -13,3 +13,4 @@
 *.a
 mkmf.log
 /node_modules/
+log/*

data/CHANGELOG

@@ -1,3 +1,9 @@
+0.1.3 / 2016-06-20
+
+* Enhancements
+
+  * Don't even try to dump/geocode lines without city/postcode or glob
+
 0.1.2 / 2016-03-16
 
 * Enhancements

data/lib/geocode_records.rb

@@ -51,9 +51,9 @@ class GeocodeRecords
     c = connection
     c.unprepared_statement do
       if glob
-        c.to_sql records.select('id', 'glob').arel, records.bind_values
+        c.to_sql records.select('id', 'glob').where.not(glob: nil).arel, records.bind_values
       else
-        c.to_sql records.select('id', 'house_number_and_street', 'house_number', 'unit_number', 'city', 'state', "regexp_replace(postcode, '.0$', '') AS postcode").arel, records.bind_values
+        c.to_sql records.select('id', 'house_number_and_street', 'house_number', 'unit_number', 'city', 'state', "regexp_replace(postcode, '.0$', '') AS postcode").where('city IS NOT NULL OR postcode IS NOT NULL').arel, records.bind_values
       end
     end
   end

data/lib/geocode_records/version.rb

@@ -1,3 +1,3 @@
 class GeocodeRecords
-  VERSION = '0.1.2'
+  VERSION = '0.1.3'
 end

data/spec/geocode_records_spec.rb

@@ -44,6 +44,12 @@ end
 require 'active_record'
 ActiveRecord::Base.establish_connection
 
+require 'logger'
+require 'fileutils'
+FileUtils.mkdir_p 'log'
+logger = Logger.new 'log/test.log'
+ActiveRecord::Base.logger = logger
+
 class Home < ActiveRecord::Base
 end
 class GlobHome < ActiveRecord::Base

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: geocode_records
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Seamus Abshere
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-16 00:00:00.000000000 Z
+date: 2016-06-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord