geoblacklight 5.3.0 → 6.0.0.pre.alpha.2

data/spec/components/geoblacklight/homepage_feature_facet_component_spec.rb

@@ -3,38 +3,30 @@
 require "spec_helper"
 
 RSpec.describe Geoblacklight::HomepageFeatureFacetComponent, type: :component do
-  subject(:rendered) do
-    render_inline_to_capybara_node(described_class.new(**kargs))
-  end
-
   # Build a search
-  let(:context) { {whatever: :value} }
-  let(:service) { Blacklight::SearchService.new(config: blacklight_config, user_params: user_params, **context) }
-  let(:repository) { Blacklight::Solr::Repository.new(blacklight_config) }
-  let(:user_params) { {} }
-  let(:blacklight_config) { Blacklight::Configuration.new }
-  let(:copy_of_catalog_config) { ::CatalogController.blacklight_config.deep_copy }
-  let(:blacklight_solr) { RSolr.connect(Blacklight.connection_config.except(:adapter)) }
+  let(:service) { Blacklight::SearchService.new(config: blacklight_config, search_state:) }
+  let(:search_state) { Blacklight::SearchState.new({}, blacklight_config) }
+  let(:blacklight_config) { ::CatalogController.blacklight_config.deep_copy }
+  let(:facet_field) { Geoblacklight.configuration.fields.provider }
+  let(:facet_config) { blacklight_config.facet_fields[facet_field] }
+  let(:facet_field_presenter) { Blacklight::FacetFieldPresenter.new(facet_config, nil, vc_test_controller.view_context, nil) }
+  let(:response) { service.search_results }
+  let(:items) { response.aggregations[facet_field].items }
 
-  describe "homepage" do
-    before do
-      (@response, @document_list) = service.search_results
-    end
-
-    let(:kargs) do
-      {
-        icon: "home",
-        label: "geoblacklight.home.institution",
-        facet_field: Settings.FIELDS.PROVIDER,
-        response: @response
-      }
-    end
+  subject(:instance) do
+    described_class.new(
+      icon: "home",
+      label: "geoblacklight.home.institution",
+      facet_field_presenter: facet_field_presenter,
+      items: items
+    )
+  end
 
-    it "includes facet links" do
-      expect(rendered).to have_selector("div.category-block")
-      expect(rendered).to have_selector("div.category-icon")
-      expect(rendered).to have_selector("a.home-facet-link")
-      expect(rendered).to have_selector("a.more_facets_link")
-    end
+  it "includes facet links" do
+    render_inline(instance)
+    expect(page).to have_selector("div.category-block")
+    expect(page).to have_selector("div.category-icon")
+    expect(page).to have_selector("a.home-facet-link")
+    expect(page).to have_selector("a.more_facets_link")
   end
 end

data/spec/components/geoblacklight/iiif_drag_drop_component_spec.rb

@@ -8,7 +8,6 @@ RSpec.describe Geoblacklight::IiifDragDropComponent, type: :component do
     let(:item_viewer) { instance_double(Geoblacklight::ItemViewer, iiif_manifest: reference) }
     let(:document) { instance_double(SolrDocument, id: 123, item_viewer: item_viewer) }
     let(:component) { described_class.new(document: document) }
-    let(:rendered) { render_inline_to_capybara_node(component) }
 
     context "does not have viewer_endpoint url" do
       let(:endpoint) { nil }
@@ -21,9 +20,10 @@ RSpec.describe Geoblacklight::IiifDragDropComponent, type: :component do
     context "has viewer_endpoint url" do
       let(:endpoint) { "https://url.com/manifest.json" }
       it "renders iiif drag and drop icon" do
+        render_inline(component)
         expect(component.render?).to be true
-        expect(rendered).to have_selector(:css, ".blacklight-icons-iiif-drag-drop")
-        expect(rendered).to have_selector(:css, "a[href='https://url.com/manifest.json?manifest=https://url.com/manifest.json']")
+        expect(page).to have_selector(:css, ".blacklight-icons-iiif-drag-drop")
+        expect(page).to have_selector(:css, "a[href='https://url.com/manifest.json?manifest=https://url.com/manifest.json']")
       end
     end
   end

data/spec/components/geoblacklight/index_map_legend_component_spec.rb

@@ -5,28 +5,14 @@ require "spec_helper"
 RSpec.describe Geoblacklight::IndexMapLegendComponent, type: :component do
   let(:document) { instance_double(SolrDocument) }
 
-  subject(:rendered) do
-    render_inline_to_capybara_node(described_class.new(document:))
-  end
-
   context "when the document has an index map" do
     before do
       allow(document).to receive_message_chain(:item_viewer, :index_map).and_return(true)
     end
 
-    it "shows available map text" do
-      expect(rendered).to have_text("Green tile indicates")
-      expect(rendered).to have_selector(:css, ".index-map-legend-default")
-    end
-
-    it "shows unavailable map text" do
-      expect(rendered).to have_text("Yellow tile indicates")
-      expect(rendered).to have_selector(:css, ".index-map-legend-unavailable")
-    end
-
-    it "shows selected map text" do
-      expect(rendered).to have_text("Blue tile indicates")
-      expect(rendered).to have_selector(:css, ".index-map-legend-selected")
+    it "renders the legend" do
+      render_inline(described_class.new(document:))
+      expect(page.text.strip).to include "Green tile indicates Map held by collection"
     end
   end
 
@@ -36,7 +22,8 @@ RSpec.describe Geoblacklight::IndexMapLegendComponent, type: :component do
     end
 
     it "does not render" do
-      expect(rendered.text.strip).to be_empty
+      render_inline(described_class.new(document:))
+      expect(page.text.strip).to be_empty
     end
   end
 end

data/spec/components/geoblacklight/item_map_viewer_component_spec.rb

@@ -3,8 +3,8 @@
 require "spec_helper"
 
 RSpec.describe Geoblacklight::ItemMapViewerComponent, type: :component do
-  subject(:rendered) do
-    render_inline_to_capybara_node(described_class.new(document:))
+  before do
+    render_inline(described_class.new(document: document))
   end
 
   context "IIIF viewer" do
@@ -12,7 +12,7 @@ RSpec.describe Geoblacklight::ItemMapViewerComponent, type: :component do
     let(:document) { SolrDocument.new(fixture) }
 
     it "uses the IIIF tag" do
-      expect(rendered).to have_css("div#mirador")
+      expect(page).to have_css("div#mirador")
     end
   end
 
@@ -21,7 +21,7 @@ RSpec.describe Geoblacklight::ItemMapViewerComponent, type: :component do
     let(:document) { SolrDocument.new(fixture) }
 
     it "uses the open layers tag" do
-      expect(rendered).to have_css("div#openlayers-viewer")
+      expect(page).to have_css("div#openlayers-viewer")
     end
   end
 
@@ -30,7 +30,7 @@ RSpec.describe Geoblacklight::ItemMapViewerComponent, type: :component do
     let(:document) { SolrDocument.new(fixture) }
 
     it "uses the IIIF tag" do
-      expect(rendered).to have_css("div#leaflet-viewer")
+      expect(page).to have_css("div#leaflet-viewer")
     end
   end
 end

data/spec/components/geoblacklight/login_link_component_spec.rb

@@ -3,20 +3,18 @@
 require "spec_helper"
 
 RSpec.describe Geoblacklight::LoginLinkComponent, type: :component do
-  subject(:rendered) do
-    render_inline_to_capybara_node(described_class.new(document: document))
-  end
   let(:document) { instance_double(SolrDocument, id: 123) }
 
   context "when rendering is required" do
     before do
-      allow_any_instance_of(GeoblacklightHelper).to receive(:document_available?).and_return(false)
+      allow(vc_test_controller).to receive(:user_signed_in?).and_return(false)
       allow(document).to receive(:restricted?).and_return(true)
       allow(document).to receive(:same_institution?).and_return(true)
     end
 
     it "shows download link" do
-      expect(rendered).to have_text(I18n.t("geoblacklight.tools.login_to_view"))
+      render_inline(described_class.new(document: document))
+      expect(page).to have_text(I18n.t("geoblacklight.tools.login_to_view"))
     end
   end
 
@@ -27,7 +25,8 @@ RSpec.describe Geoblacklight::LoginLinkComponent, type: :component do
     end
 
     it "does not render anything" do
-      expect(rendered).not_to have_text(I18n.t("geoblacklight.tools.login_to_view"))
+      render_inline(described_class.new(document: document))
+      expect(page).not_to have_text(I18n.t("geoblacklight.tools.login_to_view"))
     end
   end
 end

data/spec/components/geoblacklight/search_result_component_spec.rb

@@ -12,7 +12,6 @@ RSpec.describe Geoblacklight::SearchResultComponent, type: :component do
       config.add_index_field "multi_display"
     end
   end
-  let(:solr_fields) { Settings.FIELDS }
   let(:presenter) do
     Blacklight::DocumentPresenter.new(document, request_context, blacklight_config)
   end
@@ -26,21 +25,18 @@ RSpec.describe Geoblacklight::SearchResultComponent, type: :component do
       multi_display: %w[blue blah]
     )
   end
-  subject(:rendered) do
-    render_inline_to_capybara_node(described_class.new(document: presenter))
-  end
-
   before do
     allow(request_context).to receive(:snippit)
     allow_any_instance_of(BlacklightHelper).to receive(:link_to_document)
     allow_any_instance_of(GeoblacklightHelper).to receive(:blacklight_config).and_return(blacklight_config)
+    render_inline(described_class.new(document: presenter))
   end
 
   describe "#index_fields_display" do
     let(:multi_valued_text) { document["multi_display"].join(" and ") }
     let(:combined_fields) { document["gbl_wxsIdentifier_s"] + ". " + document["period"] }
 
-    subject(:index_fields_display) { rendered.find("[itemprop=description]").text }
+    subject(:index_fields_display) { page.find("[itemprop=description]").text }
 
     context "with multi-valued field" do
       it "each value is separated by comma" do

data/spec/components/geoblacklight/static_map_component_spec.rb

@@ -11,10 +11,10 @@ RSpec.describe Geoblacklight::StaticMapComponent, type: :component do
 
   before do
     allow(document).to receive(:viewer_protocol).and_return("map")
-    allow(Settings).to receive(:SIDEBAR_STATIC_MAP).and_return(["map"])
+    allow(Geoblacklight.configuration).to receive(:sidebar_static_map).and_return(["map"])
   end
 
-  context "when the protocol matches the SIDEBAR_STATIC_MAP setting" do
+  context "when the protocol matches the sidebar_static_map setting" do
     it "renders the static map" do
       expect(rendered.css("#static-map")).to be_present
     end

data/spec/components/geoblacklight/viewer_help_text_component_spec.rb

@@ -6,13 +6,10 @@ RSpec.describe Geoblacklight::ViewerHelpTextComponent, type: :component do
   let(:feature) { "viewer_protocol" }
   let(:key) { "wms" }
 
-  subject(:rendered) do
-    render_inline_to_capybara_node(described_class.new(feature, key))
-  end
-
   context "when the help text exists for an existing viewer protocol" do
     it "shows correct help text title for wms" do
-      expect(rendered).to have_text(I18n.t("geoblacklight.help_text.viewer_protocol.wms.title"))
+      render_inline(described_class.new(feature, key))
+      expect(page).to have_text(I18n.t("geoblacklight.help_text.viewer_protocol.wms.title"))
     end
   end
 
@@ -22,7 +19,8 @@ RSpec.describe Geoblacklight::ViewerHelpTextComponent, type: :component do
     end
 
     it "shows missing help text class" do
-      expect(render_inline_to_capybara_node(described_class.new(feature, key))).to have_css(".translation-missing")
+      render_inline(described_class.new(feature, key))
+      expect(page).to have_css(".translation-missing")
     end
   end
 end

data/spec/components/geoblacklight/web_services_component_spec.rb

@@ -6,33 +6,34 @@ RSpec.describe Geoblacklight::WebServicesComponent, type: :component do
   let(:document) { instance_double(SolrDocument, id: 123, wxs_identifier: "wxs_identifier") }
   let(:ref) { instance_double(Geoblacklight::Reference, type: type, endpoint: "endpoint") }
   let(:component) { described_class.new(document: document, ref: ref) }
-  subject(:rendered) do
-    render_inline_to_capybara_node(component)
+
+  before do
+    render_inline(component)
   end
 
   context "when wms is rendered" do
     let(:type) { "wms" }
     it "shows the web mapping service and layers" do
-      expect(rendered).to have_text("Web Mapping Service (WMS)")
-      expect(rendered).to have_text("WMS layers")
-      expect(rendered).to have_css(".web-services-form")
+      expect(page).to have_text("Web Mapping Service (WMS)")
+      expect(page).to have_text("WMS layers")
+      expect(page).to have_css(".web-services-form")
     end
   end
 
   context "when wfs is rendered" do
     let(:type) { "wfs" }
     it "shows the web mapping service and typeNames" do
-      expect(rendered).to have_text("Web Feature Service (WFS)")
-      expect(rendered).to have_text("WFS typeNames")
-      expect(rendered).to have_css(".web-services-form")
+      expect(page).to have_text("Web Feature Service (WFS)")
+      expect(page).to have_text("WFS typeNames")
+      expect(page).to have_css(".web-services-form")
     end
   end
 
   context "when iiif is rendered" do
     let(:type) { "iiif" }
     it "shows the service" do
-      expect(rendered).to have_text("International Image Interoperability Framework (IIIF)")
-      expect(rendered).to have_css(".web-services-form")
+      expect(page).to have_text("International Image Interoperability Framework (IIIF)")
+      expect(page).to have_css(".web-services-form")
     end
   end
 

data/spec/controllers/catalog_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-describe CatalogController, type: :controller do
+RSpec.describe CatalogController, type: :controller do
   describe "#web_services" do
     it "returns a document based off an id" do
       get :web_services, params: {id: "mit-f6rqs4ucovjk2"}
@@ -73,12 +73,12 @@ describe CatalogController, type: :controller do
       expect(response.body).not_to be_empty
       response_values = JSON.parse(response.body)
       expect(response_values).to include "gbl_mdVersion_s" => "Aardvark"
-      expect(response_values).to include Settings.FIELDS.TITLE => "100 Foot Grid Cambridge MA 2004"
-      expect(response_values).to include Settings.FIELDS.IDENTIFIER => ["urn:geodata.tufts.edu:Tufts.CambridgeGrid100_04"]
-      expect(response_values).to include Settings.FIELDS.ACCESS_RIGHTS => "Public"
-      expect(response_values).to include Settings.FIELDS.PROVIDER => "Tufts"
-      expect(response_values).to include Settings.FIELDS.ID => "tufts-cambridgegrid100-04"
-      expect(response_values).to include Settings.FIELDS.GEOMETRY => "ENVELOPE(-71.163984,-71.052581,42.408316,42.34757)"
+      expect(response_values).to include Geoblacklight.configuration.fields.title => "100 Foot Grid Cambridge MA 2004"
+      expect(response_values).to include Geoblacklight.configuration.fields.identifier => ["urn:geodata.tufts.edu:Tufts.CambridgeGrid100_04"]
+      expect(response_values).to include Geoblacklight.configuration.fields.access_rights => "Public"
+      expect(response_values).to include Geoblacklight.configuration.fields.provider => "Tufts"
+      expect(response_values).to include Geoblacklight.configuration.fields.id => "tufts-cambridgegrid100-04"
+      expect(response_values).to include Geoblacklight.configuration.fields.geometry => "ENVELOPE(-71.163984,-71.052581,42.408316,42.34757)"
     end
   end
 end

data/spec/controllers/download_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-describe DownloadController, type: :controller do
+RSpec.describe DownloadController, type: :controller do
   describe "#file" do
     describe "restricted file" do
       it "redirects to login for authentication" do

data/spec/controllers/relation_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-describe RelationController, type: :controller do
+RSpec.describe RelationController, type: :controller do
   describe "#index" do
     it "returns a listing of related documents for a record" do
       get :index, params: {id: "nyu_2451_34502"}

data/spec/controllers/wms_controller_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-describe WmsController, type: :controller do
+RSpec.describe WmsController, type: :controller do
   let(:wms_layer) { instance_double(Geoblacklight::WmsLayer) }
   let(:feature_info) { {values: ["fid", "layer:example"]} }
   let(:params) do

data/spec/features/axe_spec.rb

@@ -3,7 +3,7 @@
 require "axe-rspec"
 require "spec_helper"
 
-feature "Accessibility testing", js: true do
+RSpec.feature "Accessibility testing", js: true do
   context "logged out tests" do
     it "validates the home page" do
       visit root_path
@@ -23,7 +23,7 @@ feature "Accessibility testing", js: true do
 
     it "validates an bookmarks page" do
       visit solr_document_path("tufts-cambridgegrid100-04")
-      find(".checkbox.toggle-bookmark").click
+      click_on "Bookmark"
       visit bookmarks_path
       expect(page).to be_accessible
     end
@@ -52,9 +52,9 @@ feature "Accessibility testing", js: true do
       expect(page).to be_accessible
     end
 
-    it "validates an bookmarks page" do
+    it "validates the bookmarks page" do
       visit solr_document_path("nyu_2451_34502")
-      find(".checkbox.toggle-bookmark").click
+      click_on "Bookmark"
       visit "/bookmarks"
       expect(page).to be_accessible
     end

data/spec/features/bookmarks_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-feature "Blacklight Bookmarks" do
+RSpec.feature "Blacklight Bookmarks" do
   scenario "index has created bookmarks" do
     visit solr_document_path "harvard-g7064-s2-1834-k3"
     click_button "Bookmark"

data/spec/features/citations_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-feature "Blacklight Citation" do
+RSpec.feature "Blacklight Citation" do
   scenario "citations can be copied", js: true do
     sign_in # NOTE: this seems to be required for clipboard permissions to be granted succesfully
     page.driver.browser.add_permission("clipboard-read", "granted")

data/spec/features/configurable_basemap_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-feature "Configurable basemap", js: true do
+RSpec.feature "Configurable basemap", js: true do
   scenario "defaults to positron" do
     visit root_path
     expect(page).to have_css "img[src*='carto']", visible: :all

data/spec/features/data_dictionary_download_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-feature "Data dictionary download tool" do
+RSpec.feature "Data dictionary download tool" do
   feature "when data_dictionary reference present" do
     scenario "shows up in tools" do
       visit solr_document_path "nyu_2451_34502"

data/spec/features/download_layer_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-feature "Download layer" do
+RSpec.feature "Download layer" do
   let(:shapefile_download) { instance_double(Geoblacklight::ShapefileDownload) }
   let(:kmz_download) { instance_double(Geoblacklight::KmzDownload) }
   let(:csv_download) { instance_double(Geoblacklight::CsvDownload) }

data/spec/features/empty_search_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-feature "Empty search" do
+RSpec.feature "Empty search" do
   before do
     visit root_path
   end

data/spec/features/esri_viewer_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-feature "feature_layer reference", js: true do
+RSpec.feature "feature_layer reference", js: true do
   scenario "displays image map layer" do
     skip "spec depend on potentially flaky external services"
     visit solr_document_path "32653ed6-8d83-4692-8a06-bf13ffe2c018"

data/spec/features/exports_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-feature "Export features" do
+RSpec.feature "Export features" do
   feature "when esri web services are available" do
     feature "Open in ArcGIS Online" do
       scenario "shows up in tools" do

data/spec/features/full_screen_control_spec.rb

@@ -2,21 +2,14 @@
 
 require "spec_helper"
 
-feature "Leaflet fullscreen control", js: true do
-  scenario "WMS layer should have full screen control" do
-    visit solr_document_path("stanford-cz128vq0535")
-    expect(page).to have_css(".leaflet-control-zoom-fullscreen", visible: :all)
-  end
-end
-
-feature "IIIF fullscreen control", js: true do
+RSpec.feature "IIIF fullscreen control", js: true do
   scenario "IIIF layer should have full screen control" do
     visit solr_document_path("princeton-sx61dn82p")
-    expect(page).to have_button("Full screen", visible: :all)
+    expect(page).to have_button("Full screen")
   end
 
   scenario "IIIF image should have full screen control" do
     visit solr_document_path("princeton-02870w62c")
-    expect(page).to have_css("img[alt='Toggle full page']", visible: :all)
+    expect(page).to have_css("img[alt='Toggle full page']")
   end
 end

data/spec/features/help_text_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-feature "Help Text" do
+RSpec.feature "Help Text" do
   scenario "Displays help text entry" do
     visit "/catalog/stanford-cg357zz0321"
     expect(page).to have_css ".help-text", count: 1

data/spec/features/home_page_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-feature "Home page", js: true do # use js: true for tests which require js, but it slows things down
+RSpec.feature "Home page", js: true do # use js: true for tests which require js, but it slows things down
   before do
     visit root_path
   end

data/spec/features/index_map_spec.rb

@@ -2,12 +2,12 @@
 
 require "spec_helper"
 
-feature "Index map", js: true do
+RSpec.feature "Index map", js: true do
   # Colors
   default_color = "#7FCDBB"
   selected_color = "#2C7FB8"
   scenario "displays index map viewer (polygon)" do
-    skip "Doesn't work for importmaps when headless in CI" if ENV["CI"] && ENV.fetch("ASSET_PIPELINE") == "importmap"
+    skip "Doesn't work for importmaps when headless in CI" if ENV["CI"]
 
     visit solr_document_path("stanford-fb897vt9938")
     # Wait until SVG elements are added
@@ -24,7 +24,7 @@ feature "Index map", js: true do
   end
 
   scenario "displays index map viewer (points)" do
-    skip "Doesn't work for importmaps when headless in CI" if ENV["CI"] && ENV.fetch("ASSET_PIPELINE") == "importmap"
+    skip "Doesn't work for importmaps when headless in CI" if ENV["CI"]
 
     visit solr_document_path("cornell-ny-aerial-photos-1960s")
     # Wait until SVG elements are added

data/spec/features/index_view_spec.rb

@@ -2,21 +2,21 @@
 
 require "spec_helper"
 
-feature "Index view", js: true do
-  let(:subject_field) { Settings.FIELDS.SUBJECT }
+RSpec.feature "Index view", js: true do
+  let(:subject_field) { Geoblacklight.configuration.fields.subject }
   before do
     visit search_catalog_path(q: "*")
   end
 
   scenario "should have documents and map on page" do
-    visit search_catalog_path(f: {Settings.FIELDS.PROVIDER => ["Stanford"]})
+    visit search_catalog_path(f: {Geoblacklight.configuration.fields.provider => ["Stanford"]})
     expect(page).to have_css("#documents")
-    expect(page).to have_css(".document", count: 6)
+    expect(page).to have_css(".document", count: 5)
     expect(page).to have_css("#leaflet-viewer")
   end
 
   scenario "should have sort and per_page on page" do
-    visit search_catalog_path(f: {Settings.FIELDS.PROVIDER => ["Stanford"]})
+    visit search_catalog_path(f: {Geoblacklight.configuration.fields.provider => ["Stanford"]})
     expect(page).to have_css("#sort-dropdown")
     expect(page).to have_css("#per_page-dropdown")
   end
@@ -49,7 +49,7 @@ feature "Index view", js: true do
 
   scenario "hover on record should produce bounding box on map" do
     # Needed to find an svg element on the page
-    visit search_catalog_path(f: {Settings.FIELDS.PROVIDER => ["Stanford"]})
+    visit search_catalog_path(f: {Geoblacklight.configuration.fields.provider => ["Stanford"]})
     # BL7 has svg icons, so sniffing for SVG path won't return false
     # expect(Nokogiri::HTML.parse(page.body).css('path').length).to eq 0
     find(".documentHeader", match: :first).hover
@@ -82,7 +82,7 @@ feature "Index view", js: true do
   end
 
   scenario "should have schema.org props listed" do
-    visit search_catalog_path(f: {Settings.FIELDS.PROVIDER => ["Stanford"]})
+    visit search_catalog_path(f: {Geoblacklight.configuration.fields.provider => ["Stanford"]})
     within(".documentHeader", match: :first) do
       expect(page).to have_css("a[itemprop='name']")
       find(".dropdown-toggle").click

data/spec/features/layer_inspection_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-feature "Layer inspection", js: true do
+RSpec.feature "Layer inspection", js: true do
   scenario "clicking map should trigger inspection" do
     visit solr_document_path("tufts-cambridgegrid100-04")
     expect(page).to have_css("th", text: "Attribute")

data/spec/features/layer_opacity_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-feature "Layer opacity", js: true do
+RSpec.feature "Layer opacity", js: true do
   scenario "WMS layer should have opacity control" do
     visit solr_document_path("mit-f6rqs4ucovjk2")
     expect(page).to have_css("div.opacity-text", text: "75%")

data/spec/features/layer_preview_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-feature "Layer preview", js: true do
+RSpec.feature "Layer preview", js: true do
   scenario "Restricted layer should show bounding box" do
     visit solr_document_path("stanford-cg357zz0321")
     within("#leaflet-viewer") do

data/spec/features/layer_with_no_references_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-feature "layer with no wms or iiif" do
+RSpec.feature "layer with no wms or iiif" do
   scenario "has map with bounding box" do
     pending "waiting on #201, need example metadata record"
     fail