geoblacklight 5.0.2 → 5.2.0

data/app/javascript/geoblacklight/core.js

@@ -7,7 +7,6 @@ import initializeMetadataDownload from "geoblacklight/initializers/metadata_down
 
 // Stimulus controllers
 import ClipboardController from "geoblacklight/controllers/clipboard_controller";
-import CloverViewerController from "geoblacklight/controllers/clover_viewer_controller";
 import DownloadsController from "geoblacklight/controllers/downloads_controller";
 import LeafletViewerController from "geoblacklight/controllers/leaflet_viewer_controller";
 import OembedViewerController from "geoblacklight/controllers/oembed_viewer_controller";
@@ -54,7 +53,6 @@ Geoblacklight.onLoad(initializeMetadataDownload);
 // Register our Stimulus controllers
 if (typeof Stimulus !== "undefined") {
   Stimulus.register("openlayers-viewer", OpenlayersViewerController);
-  Stimulus.register("clover-viewer", CloverViewerController);
   Stimulus.register("oembed-viewer", OembedViewerController);
   Stimulus.register("leaflet-viewer", LeafletViewerController);
   Stimulus.register("search-results", SearchResultsController);

data/app/javascript/geoblacklight/index.js

@@ -1,6 +1,5 @@
 // Stimulus controllers
 import OpenlayersViewerController from "geoblacklight/controllers/openlayers_viewer_controller";
-import CloverViewerController from "geoblacklight/controllers/clover_viewer_controller";
 import OembedViewerController from "geoblacklight/controllers/oembed_viewer_controller";
 import LeafletViewerController from "geoblacklight/controllers/leaflet_viewer_controller";
 import SearchResultsController from "geoblacklight/controllers/search_results_controller";
@@ -16,7 +15,6 @@ import leafletBasemaps from "geoblacklight/leaflet/basemaps";
 
 export default {
   OpenlayersViewerController,
-  CloverViewerController,
   OembedViewerController,
   LeafletViewerController,
   SearchResultsController,

data/config/locales/geoblacklight.en.yml

@@ -172,5 +172,6 @@ en:
       stanford: Stanford University
       texas: The University of Texas at Austin
       tufts: Tufts University
+      triangle-exclamation-solid: Warning
       ucla: University of California, Los Angeles
       uva: University of Virginia

data/lib/generators/geoblacklight/assets/importmap_generator.rb

@@ -21,10 +21,9 @@ module Geoblacklight
         delivered via CDN.
       DESCRIPTION
 
-      # If this is a local dev/test build, symlink the frontend package so we
-      # can reference its stylesheets in development
-      def link_frontend
-        run "yarn link @geoblacklight/frontend" if options[:test]
+      # Switch bootstrap import to ESM version so we can import individual parts
+      def use_bootstrap_esm
+        gsub_file "config/importmap.rb", /dist\/js\/bootstrap\.js/, "dist/js/bootstrap.esm.js"
       end
 
       # Add the customization overrides and insert before bootstrap import
@@ -62,17 +61,6 @@ module Geoblacklight
         append_to_file "app/javascript/application.js", "import Geoblacklight from \"geoblacklight\";"
       end
 
-      # Add pins for application dependencies to the importmap
-      def update_importmap
-        gsub_file "config/importmap.rb", "bootstrap.min.js", "https://cdn.skypack.dev/bootstrap@5.3.3"
-        append_to_file "config/importmap.rb" do
-          <<~CONTENT
-            pin "@github/auto-complete-element", to: "https://cdn.skypack.dev/@github/auto-complete-element"
-            pin "@popperjs/core", to: "https://ga.jspm.io/npm:@popperjs/core@2.11.8/dist/umd/popper.min.js"
-          CONTENT
-        end
-      end
-
       # Run the build so styles are available for the first load of the app
       def build_styles
         run "yarn build:css"

data/lib/generators/geoblacklight/assets/vite_generator.rb

@@ -42,23 +42,13 @@ module Geoblacklight
         run "bundle exec vite install"
       end
 
-      # Pick a version of the frontend asset package and install it.
-      def add_frontend
-        # If a branch was specified (e.g. you are running a template.rb build
-        # against a test branch), use the latest version available on npm
-        if ENV["BRANCH"]
-          run "yarn add @geoblacklight/frontend@latest"
-
-        # Otherwise, pick the version from npm that matches our Geoblacklight
-        # gem version
-        else
-          run "yarn add @geoblacklight/frontend@#{Geoblacklight::VERSION}"
+      # The vite-plugin-ruby package has a breaking change in 5.1.2,
+      # so we need to resolve to a specific version to avoid issues.
+      # Remove after https://github.com/ElMassimo/vite_ruby/issues/586 is fixed.
+      def pin_vite_plugin_ruby
+        inject_into_file "package.json", before: "  \"dependencies\": {" do
+          "  \"resolutions\": { \"vite-plugin-ruby\": \"5.1.1\" },\n"
         end
-
-        # If in local development or CI, also create a link. This will make it so
-        # changes made in the outer directory are picked up automatically.
-        # `yarn link` has to have already been run in the outer directory first.
-        run "yarn link @geoblacklight/frontend" if options[:test]
       end
 
       # The vite_rails gem doesn't currently install the vite-plugin-rails

data/lib/generators/geoblacklight/assets_generator.rb

@@ -7,6 +7,21 @@ module Geoblacklight
     class_option :"asset-pipeline", type: :string, default: ENV.fetch("ASSET_PIPELINE", "vite"), desc: "Choose the asset pipeline to use (vite or importmap)"
     class_option :test, type: :boolean, default: ENV.fetch("CI", false), aliases: "-t", desc: "Indicates that app will be installed in a test environment"
 
+    # Pick a version of the frontend asset package and install it.
+    #
+    # If a branch was specified (e.g. you are running a template.rb build
+    # against a test branch), use the latest version available on npm.
+    #
+    # Otherwise, pick the version from npm that matches our Geoblacklight
+    # gem version.
+    def add_frontend
+      if ENV["BRANCH"]
+        run "yarn add @geoblacklight/frontend@latest"
+      else
+        run "yarn add @geoblacklight/frontend@#{Geoblacklight::VERSION}"
+      end
+    end
+
     def run_asset_pipeline_specific_generator
       generated_options = "--test=true" if options[:test]
       generator = if options[:"asset-pipeline"]

data/lib/generators/geoblacklight/templates/settings.yml

@@ -1,5 +1,5 @@
 # ArcGIS Online Base URL
-ARCGIS_BASE_URL: 'https://www.arcgis.com/home/webmap/viewer.html'
+ARCGIS_BASE_URL: 'https://www.arcgis.com/apps/mapviewer/index.html'
 
 # Download path can be configured using this setting
 #DOWNLOAD_PATH: "./tmp/cache/downloads"

data/lib/geoblacklight/download/geojson_download.rb

@@ -14,7 +14,7 @@ module Geoblacklight
       request_params = GEOJSON_DOWNLOAD_PARAMS.merge(typeName: document.wxs_identifier)
       super(document, {
         type: "geojson",
-        extension: "json",
+        extension: "geojson",
         request_params: request_params,
         content_type: "application/json",
         service_type: "wfs"

data/lib/geoblacklight/engine.rb

@@ -32,7 +32,7 @@ module Geoblacklight
       next unless app.config.respond_to?(:importmap) # skip for Vite
 
       app.config.importmap.paths << Engine.root.join("config/importmap.rb")
-      app.config.importmap.cache_sweepers << Engine.root.join("app/assets/javascripts")
+      app.config.importmap.cache_sweepers << Engine.root.join("app/javascript")
     end
   end
 end

data/lib/geoblacklight/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Geoblacklight
-  VERSION = "5.0.2"
+  VERSION = "5.2.0"
 end

data/lib/tasks/geoblacklight.rake

@@ -13,6 +13,7 @@ end
 def with_solr(&block)
   puts "Starting Solr"
   system_with_error_handling "docker compose up -d solr"
+  sleep 5 # give solr a few seconds to load the core config and be ready
   yield
 ensure
   puts "Stopping Solr"
@@ -23,7 +24,7 @@ namespace :geoblacklight do
   desc "Run Solr and GeoBlacklight for interactive development"
   task :server, [:rails_server_args] do |_t, args|
     with_solr do
-      Rake::Task["geoblacklight:internal:seed"].invoke
+      Rake::Task["geoblacklight:index:seed"].invoke
 
       puts "Starting GeoBlacklight (Rails server)"
       puts " "
@@ -35,26 +36,15 @@ namespace :geoblacklight do
     end
   end
 
-  # Local fixtures: bundle exec rake "geoblacklight:index:seed"
-  # Remote fixtures: bundle exec rake "geoblacklight:index:seed[:remote]"
+  # Get fixture items bundled with the gem and index them into Solr
   namespace :index do
     desc "Index GBL test fixture metadata into Solr"
-    task :seed, [:remote] => :environment do |t, args|
-      docs = []
+    task seed: :environment do
+      puts "Indexing test fixtures"
 
-      if args.remote
-        puts "Indexing - Remote test fixtures"
-        JSON.parse(
-          URI.parse("https://api.github.com/repos/geoblacklight/geoblacklight/contents/spec/fixtures/solr_documents").open.read
-        ).each do |fixture|
-          if fixture["name"].include?(".json")
-            docs << JSON.parse(URI.parse(fixture["download_url"]).open.read)
-          end
-        end
-      else
-        puts "Indexing - Local test fixtures"
-        docs = Dir["spec/fixtures/solr_documents/*.json"].map { |f| JSON.parse File.read(f) }.flatten
-      end
+      gem_path = Gem::Specification.find_by_name("geoblacklight").gem_dir
+      fixtures_path = File.join(gem_path, "spec", "fixtures", "solr_documents", "*.json")
+      docs = Dir[fixtures_path].flat_map { |f| JSON.parse(File.read(f)) }
 
       Blacklight.default_index.connection.add docs
       Blacklight.default_index.connection.commit
@@ -71,19 +61,21 @@ namespace :geoblacklight do
       FileUtils.mkdir_p(Rails.root.join("tmp", "cache", "downloads"), verbose: true)
     end
     desc "Precaches a download"
-    task :precache, [:doc_id, :download_type, :timeout] => [:environment] do |_t, args|
+    task :precache, %i[doc_id download_type timeout] => [:environment] do |_t, args|
       unless args[:doc_id] && args[:download_type] && args[:timeout]
-        fail "Please supply required arguments [document_id, download_type and timeout]"
+        raise "Please supply required arguments [document_id, download_type and timeout]"
       end
+
       document = Geoblacklight::SolrDocument.find(args[:doc_id])
-      fail Blacklight::Exceptions::RecordNotFound if document[:id] != args[:doc_id]
+      raise Blacklight::Exceptions::RecordNotFound if document[:id] != args[:doc_id]
+
       download = "Geoblacklight::#{args[:download_type].capitalize}Download"
         .constantize.new(document, timeout: args[:timeout].to_i)
       download.get
       Rails.logger.info "Successfully downloaded #{download.file_name}"
       Rails.logger.info Geoblacklight::ShapefileDownload.file_path.to_s
-    rescue Geoblacklight::Exceptions::ExternalDownloadFailed => error
-      Rails.logger.error error.message + " " + error.url
+    rescue Geoblacklight::Exceptions::ExternalDownloadFailed => e
+      Rails.logger.error e.message + " " + e.url
     rescue NameError
       Rails.logger.error "Could not find that download type \"#{args[:download_type]}\""
     end

data/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@geoblacklight/frontend",
   "type": "module",
-  "version": "5.0.2",
+  "version": "5.2.0",
   "license": "Apache-2.0",
   "publishConfig": {
     "access": "public"
@@ -22,22 +22,19 @@
     "@github/auto-complete-element": "^3.6.2",
     "@hotwired/stimulus": "^3.2.2",
     "@popperjs/core": "^2.11.8",
-    "@samvera/clover-iiif": "^2.3.2",
     "blacklight-frontend": "8",
     "bootstrap": "^5.3.3",
     "esri-leaflet": "^3.0.12",
     "leaflet": "^1.9.4",
     "leaflet-iiif": "^3.0.0",
     "leaflet-fullscreen": "^1.0.2",
-    "ol": "8.1.0",
-    "ol-pmtiles": "^0.3.0",
-    "react": "^18.2.0",
-    "react-dom": "^18.2.0"
+    "ol": "10.7.0",
+    "ol-pmtiles": "^2.0.2"
   },
   "devDependencies": {
-    "jsdom": "^24.1.0",
+    "jsdom": "^27.3.0",
     "rollup-plugin-includepaths": "^0.2.4",
-    "vite": "^5.0.0",
-    "vitest": "^2.0.3"
+    "vite": "^7.2.2",
+    "vitest": "^4.0.15"
   }
 }

data/solr/conf/solrconfig.xml

@@ -94,7 +94,7 @@
   </query>
 
   <requestDispatcher handleSelect="false">
-    <requestParsers enableRemoteStreaming="true" multipartUploadLimitInKB="2048000" formdataUploadLimitInKB="2048"/>
+    <requestParsers multipartUploadLimitInKB="2048000" formdataUploadLimitInKB="2048"/>
     <httpCaching never304="true"/>
    </requestDispatcher>
 

data/spec/components/blacklight/icons/triangle_exclamation_solid_component_spec.rb

@@ -10,6 +10,6 @@ RSpec.describe Blacklight::Icons::TriangleExclamationSolidComponent, type: :comp
     expect(rendered).to have_css("title")
     expect(rendered).to have_css("svg")
     expect(rendered).to have_css(".blacklight-icons")
-    expect(rendered.find("title").text).to eq "Triangle Exclamation Solid"
+    expect(rendered.find("title").text).to eq "Warning"
   end
 end

data/spec/components/geoblacklight/document_component_spec.rb

@@ -62,7 +62,7 @@ RSpec.describe Geoblacklight::DocumentComponent, type: :component do
     end
 
     it "uses the IIIF tag for the container" do
-      expect(rendered).to have_css("div#clover-viewer")
+      expect(rendered).to have_css("div#mirador")
     end
   end
 

data/spec/components/geoblacklight/download_links_component_spec.rb

@@ -82,6 +82,22 @@ RSpec.describe Geoblacklight::DownloadLinksComponent, type: :component do
     end
   end
 
+  describe "#iiif_jpg_url" do
+    let(:references_field) { Settings.FIELDS.REFERENCES }
+    let(:document_attributes) do
+      {
+        references_field => {
+          "http://iiif.io/api/image" => "https://example.edu/image/info.json"
+        }.to_json
+      }
+    end
+    let(:document) { SolrDocument.new(document_attributes) }
+
+    it "returns JPG download URL when given URL to a IIIF info.json" do
+      expect(component.iiif_jpg_url).to eq "https://example.edu/image/full/full/0/default.jpg"
+    end
+  end
+
   describe "#download_link_generated" do
     let(:download_type) { "SHAPEFILE" }
 

data/spec/components/geoblacklight/item_map_viewer_component_spec.rb

@@ -12,7 +12,7 @@ RSpec.describe Geoblacklight::ItemMapViewerComponent, type: :component do
     let(:document) { SolrDocument.new(fixture) }
 
     it "uses the IIIF tag" do
-      expect(rendered).to have_css("div#clover-viewer")
+      expect(rendered).to have_css("div#mirador")
     end
   end
 

data/spec/features/configurable_basemap_spec.rb

@@ -5,33 +5,36 @@ require "spec_helper"
 feature "Configurable basemap", js: true do
   scenario "defaults to positron" do
     visit root_path
-    expect(page).to have_css "img[src*='carto']"
+    expect(page).to have_css "img[src*='carto']", visible: :all
   end
+
   feature "without provided basemap config" do
     before do
       CatalogController.blacklight_config.basemap_provider = nil
     end
     scenario "has Carto map" do
       visit root_path
-      expect(page).to have_css "img[src*='carto']"
+      expect(page).to have_css "img[src*='carto']", visible: :all
     end
   end
+
   feature "using darkMatter" do
     before do
       CatalogController.blacklight_config.basemap_provider = "darkMatter"
     end
     scenario "has darkMatter map" do
       visit root_path
-      expect(page).to have_css "img[src*='dark_all']"
+      expect(page).to have_css "img[src*='dark_all']", visible: :all
     end
   end
+
   feature "using openstreetmapHot" do
     before do
       CatalogController.blacklight_config.basemap_provider = "openstreetmapHot"
     end
     scenario "has openstreetmapHot map" do
       visit root_path
-      expect(page).to have_css "img[src*='hot']"
+      expect(page).to have_css "img[src*='hot']", visible: :all
     end
   end
 end

data/spec/features/full_screen_control_spec.rb

@@ -11,11 +11,13 @@ end
 
 feature "Clover IIIF fullscreen control", js: true do
   scenario "IIIF layer should have full screen control" do
+    skip "Clover is disabled" # see https://github.com/geoblacklight/geoblacklight/issues/1675
     visit solr_document_path("princeton-sx61dn82p")
     expect(page).to have_button("Toggle full page")
   end
 
   scenario "IIIF image should have full screen control" do
+    skip "Clover is disabled" # see https://github.com/geoblacklight/geoblacklight/issues/1675
     visit solr_document_path("princeton-02870w62c")
     expect(page).to have_css("[data-button='full-page']")
   end

data/spec/features/home_page_spec.rb

@@ -7,11 +7,6 @@ feature "Home page", js: true do # use js: true for tests which require js, but
     visit root_path
   end
 
-  scenario "navbar" do
-    expect(page).to have_css "#bookmarks_nav"
-    expect(page).to have_css "a", text: "History"
-  end
-
   scenario "search bar" do
     expect(page).not_to have_css "#search-navbar"
     expect(page).to have_css "h1", text: "Explore and discover..."
@@ -31,7 +26,7 @@ feature "Home page", js: true do # use js: true for tests which require js, but
   scenario "map should be visible" do
     within "#main-container" do
       expect(page).to have_css("#leaflet-viewer")
-      expect(page).to have_css("img.leaflet-tile", minimum: 3)
+      expect(page).to have_css("img.leaflet-tile", visible: :all)
     end
   end
 

data/spec/features/index_view_spec.rb

@@ -22,29 +22,29 @@ feature "Index view", js: true do
   end
 
   scenario "should have facets listed correctly" do
-    skip "Takes too long in CI" if ENV["CI"]
+    skip "Capybara thinks elements are not visible or interactable, but they are"
 
-    within "#facet-panel-collapse" do
-      expect(page).to have_css("div.card.facet-limit", text: "Year")
-      expect(page).to have_css("div.card.facet-limit", text: "Place")
-      expect(page).to have_css("div.card.facet-limit", text: "Access")
-      expect(page).to have_css("div.card.facet-limit", text: "Resource Class")
-      expect(page).to have_css("div.card.facet-limit", text: "Resource Type")
-      expect(page).to have_css("div.card.facet-limit", text: "Format")
-      expect(page).to have_css("div.card.facet-limit", text: "Subject")
-      expect(page).to have_css("div.card.facet-limit", text: "Theme")
-      expect(page).to have_css("div.card.facet-limit", text: "Creator")
-      expect(page).to have_css("div.card.facet-limit", text: "Publisher")
-      expect(page).to have_css("div.card.facet-limit", text: "Provider")
-      expect(page).to have_css("div.card.facet-limit", text: "Georeferenced")
+    within "#facet-panel-collapse", visible: :all do
+      expect(page).to have_css("div.card.facet-limit", text: "Year", visible: :all)
+      expect(page).to have_css("div.card.facet-limit", text: "Place", visible: :all)
+      expect(page).to have_css("div.card.facet-limit", text: "Access", visible: :all)
+      expect(page).to have_css("div.card.facet-limit", text: "Resource Class", visible: :all)
+      expect(page).to have_css("div.card.facet-limit", text: "Resource Type", visible: :all)
+      expect(page).to have_css("div.card.facet-limit", text: "Format", visible: :all)
+      expect(page).to have_css("div.card.facet-limit", text: "Subject", visible: :all)
+      expect(page).to have_css("div.card.facet-limit", text: "Theme", visible: :all)
+      expect(page).to have_css("div.card.facet-limit", text: "Creator", visible: :all)
+      expect(page).to have_css("div.card.facet-limit", text: "Publisher", visible: :all)
+      expect(page).to have_css("div.card.facet-limit", text: "Provider", visible: :all)
+      expect(page).to have_css("div.card.facet-limit", text: "Georeferenced", visible: :all)
     end
 
-    click_button "Provider"
+    click_button "Provider", visible: :all
 
-    expect(page).to have_css("a.facet-select", text: "University of Minnesota", visible: true)
-    expect(page).to have_css("a.facet-select", text: "MIT", visible: true)
-    expect(page).to have_css("a.facet-select", text: "Stanford", visible: true)
-    expect(page).to have_css(".more_facets a", text: /more\sProvider\s»/, visible: true)
+    expect(page).to have_css("a.facet-select", text: "University of Minnesota", visible: :all)
+    expect(page).to have_css("a.facet-select", text: "MIT", visible: :all)
+    expect(page).to have_css("a.facet-select", text: "Stanford", visible: :all)
+    expect(page).to have_css(".more_facets a", text: /more\sProvider\s»/, visible: :all)
   end
 
   scenario "hover on record should produce bounding box on map" do
@@ -67,9 +67,10 @@ feature "Index view", js: true do
   end
 
   scenario "spatial search should reset to page one" do
+    skip "FIXME: Only works with a headful browser?"
     visit "/?per_page=5&q=%2A&page=2"
     find("#leaflet-viewer").double_click
-    expect(find(".page-entries")).to have_content(/^1 - \d of \d.*$/)
+    expect(page).to have_css ".page-entries", text: /^1 - 5 of \d.*$/
   end
 
   scenario "clicking map search should retain current search parameters" do
@@ -77,7 +78,6 @@ feature "Index view", js: true do
     find("#leaflet-viewer").double_click
     within "#appliedParams" do
       expect(page).to have_content("Subject Population")
-      expect(page).to have_css "span.filter-name", text: "Bounding Box"
     end
   end
 

data/spec/features/layer_inspection_spec.rb

@@ -12,6 +12,7 @@ feature "Layer inspection", js: true do
 
   context "with a pmtiles layer" do
     scenario "clicking map should trigger inspection" do
+      skip "FIXME: Only works with a headful browser?"
       visit solr_document_path("princeton-t722hd30j")
       expect(page).to have_css("th", text: "Attribute")
       find("#openlayers-viewer").click

data/spec/features/relations_spec.rb

@@ -23,8 +23,8 @@ feature "Display related documents" do
 
   scenario "Record with relations should render widget in catalog#show", js: true do
     visit solr_document_path("nyu_2451_34635")
-    expect(page).to have_css(".card.relations")
-    expect(page).to have_css("div.card-header", text: "Derived records...")
+    expect(page).to have_css(".card.relations", visible: :all)
+    expect(page).to have_css("div.card-header", text: "Derived records...", visible: :all)
   end
 
   scenario "Record without relations should not render widget in catalog#show", js: true do
@@ -36,9 +36,9 @@ feature "Display related documents" do
     # Wabash Topo parent record
     visit solr_document_path("eee6150b-ce2f-4837-9d17-ce72a0c1c26f")
 
-    expect(page).to have_content("Has part...")
-    expect(page).to have_link("Browse all 4 records...")
-    click_link("Browse all 4 records...")
+    expect(page).to have_content(:all, "Has part...")
+    expect(page).to have_link("Browse all 4 records...", visible: :all)
+    click_link("Browse all 4 records...", visible: :all)
 
     expect(page).not_to have_content("No results found for your search")
   end
@@ -46,24 +46,24 @@ feature "Display related documents" do
   scenario "Record with dct_isPartOf_sm value(s) should link to relations", js: true do
     # All Relationships
     visit solr_document_path("all-relationships")
-    expect(page).to have_content("Is part of...")
+    expect(page).to have_content(:all, "Is part of...")
   end
 
   scenario "Record pointed at by a parent with dct_isPartOf_sm value(s) should link back", js: true do
     # The Related Record
     visit solr_document_path("the-related-record")
-    expect(page).to have_content("Has part...")
+    expect(page).to have_content(:all, "Has part...")
   end
 
   scenario "Record with pcdm_memberOf_sm value(s) should link to relations", js: true do
     # All Relationships
     visit solr_document_path("all-relationships")
-    expect(page).to have_content("Belongs to collection...")
+    expect(page).to have_content(:all, "Belongs to collection...")
   end
 
   scenario "Record pointed at by a parent with pcdm_memberOf_sm value(s) should link back", js: true do
     # The Related Record
     visit solr_document_path("the-related-record")
-    expect(page).to have_content("Collection records...")
+    expect(page).to have_content(:all, "Collection records...")
   end
 end

data/spec/features/search_spec.rb

@@ -11,11 +11,11 @@ feature "Search" do
   scenario "When searching child records from a parent record, supressed records are not hidden", js: true do
     visit "/catalog/princeton-1r66j405w"
 
-    within(".card.relations.relationship-source_descendants") do
-      expect(page).to have_link(href: /f%5Bdct_source_sm%5D/)
+    within(".card.relations.relationship-source_descendants", visible: :all) do
+      expect(page).to have_link(href: /f%5Bdct_source_sm%5D/, visible: :all)
     end
 
-    click_link "Browse all 4 records..."
+    click_link "Browse all 4 records...", visible: :all
     expect(page).to have_css ".document", count: 4
   end
 

data/spec/features/tms_spec.rb

@@ -5,7 +5,7 @@ require "spec_helper"
 feature "tms layer" do
   scenario "displays tms layer", js: true do
     visit solr_document_path("cugir-007957")
-    expect(page).to have_css ".leaflet-control-zoom", visible: true
-    expect(page).to have_css "img[src*='cugir.library.cornell.edu']"
+    expect(page).to have_css ".leaflet-control-zoom"
+    expect(page).to have_css "img[src*='cugir.library.cornell.edu']", visible: :all
   end
 end

data/spec/features/xyz_spec.rb

@@ -5,7 +5,7 @@ require "spec_helper"
 feature "xyz layer" do
   scenario "displays tms layer", js: true do
     visit solr_document_path("6f47b103-9955-4bbe-a364-387039623106-xyz")
-    expect(page).to have_css ".leaflet-control-zoom", visible: :visible
-    expect(page).to have_css "img[src*='earthquake.usgs.gov']"
+    expect(page).to have_css ".leaflet-control-zoom"
+    expect(page).to have_css "img[src*='earthquake.usgs.gov']", visible: :all
   end
 end

data/spec/helpers/geoblacklight_helper_spec.rb

@@ -41,23 +41,6 @@ describe GeoblacklightHelper, type: :helper do
     end
   end
 
-  describe "#iiif_jpg_url" do
-    let(:document) { SolrDocument.new(document_attributes) }
-    let(:references_field) { Settings.FIELDS.REFERENCES }
-    let(:document_attributes) do
-      {
-        references_field => {
-          "http://iiif.io/api/image" => "https://example.edu/image/info.json"
-        }.to_json
-      }
-    end
-
-    it "returns JPG download URL when given URL to a IIIF info.json" do
-      assign(:document, document)
-      expect(helper.iiif_jpg_url).to eq "https://example.edu/image/full/full/0/default.jpg"
-    end
-  end
-
   describe "#snippit" do
     let(:document) { SolrDocument.new(document_attributes) }
     let(:references_field) { Settings.FIELDS.REFERENCES }

data/spec/lib/geoblacklight/download/geojson_download_spec.rb

@@ -11,6 +11,7 @@ describe Geoblacklight::GeojsonDownload do
       options = download.instance_variable_get(:@options)
       expect(options[:content_type]).to eq "application/json"
       expect(options[:request_params][:typeName]).to eq "stanford-test"
+      expect(options[:extension]).to eq "geojson"
     end
     it "merges custom options" do
       download = described_class.new(document, timeout: 33)