geoblacklight 4.0.0 → 4.1.1

data/spec/fixtures/solr_documents/wmts-single-layer.json

@@ -1,7 +1,7 @@
 {
     "gbl_mdVersion_s": "Aardvark",
     "dct_identifier_sm": [
-      "ark:/99999/fk4544658v"
+        "ark:/99999/fk4544658v"
     ],
     "id": "princeton-fk4544658v-wmts",
     "dct_title_s": "The Balkans [and] Turkey : G.S.G.S. no. 2097 / War Office. General Staff. Geographical Section (WMTS Fixture)",
@@ -10,16 +10,16 @@
     "schema_provider_s": "Princeton",
     "dct_accessRights_s": "Public",
     "dct_description_sm": [
-      "Relief shown by contours approximately 100 feet interval, spot heights, and shading. Title varies; some sheets are titled \"Turkey\". Shows international boundaries, railways, 2 categories of roads, telegraph lines, places of worship, ruins. Constantinople latest edition map has a glossary."
+        "Relief shown by contours approximately 100 feet interval, spot heights, and shading. Title varies; some sheets are titled \"Turkey\". Shows international boundaries, railways, 2 categories of roads, telegraph lines, places of worship, ruins. Constantinople latest edition map has a glossary."
     ],
     "dct_creator_sm": [
         "Great Britain. War Office. General Staff. Geographical Section"
     ],
     "dct_language_sm": [
-      "eng"
+        "eng"
     ],
     "dct_publisher_sm": [
-      "[London] : War Office. General Staff. Geographical Section. General Staff, 1908-25."
+        "[London] : War Office. General Staff. Geographical Section. General Staff, 1908-25."
     ],
     "dct_subject_sm": [
         "Balkan Peninsula Maps",
@@ -30,13 +30,13 @@
         "Balkan Peninsula",
         "Turkey"
     ],
-    "dct_issued_s": 1908,
+    "dct_issued_s": "1908",
     "gbl_indexYear_im": [
-        "1908"
+        1908
     ],
     "gbl_mdModified_dt": "2022-02-03T22:13:40Z",
     "gbl_wxsIdentifier_s": "mosaic",
-    "dct_references_s": "{\"http://schema.org/url\":\"https://catalog.princeton.edu/catalog/99125413918506421\",\"http://schema.org/thumbnailUrl\":\"https://figgy-staging.princeton.edu/downloads/6b55d939-7188-4bce-9550-0ac535441f22/file/9042b887-da2e-4aa9-9ca5-d3ba77f440c4\",\"http://iiif.io/api/image\":\"https://iiif-cloud-staging.princeton.edu/iiif/2/05%2F71%2F04%2F0571046f9c7149a3b950899323f70788%2Fintermediate_file/info.json\",\"http://iiif.io/api/presentation#manifest\":\"https://figgy-staging.princeton.edu/concern/scanned_maps/2a91d82c-541c-426c-b787-cc62afe8f248/manifest\",\"http://www.opengis.net/def/serviceType/ogc/wmts\":\"https://map-tiles-staging.princeton.edu/mosaicjson/WMTSCapabilities.xml?id=2a91d82c541c426cb787cc62afe8f248\"}",
+    "dct_references_s": "{\"http://schema.org/url\":\"https://catalog.princeton.edu/catalog/99125413918506421\",\"http://schema.org/thumbnailUrl\":\"https://figgy-staging.princeton.edu/downloads/6b55d939-7188-4bce-9550-0ac535441f22/file/9042b887-da2e-4aa9-9ca5-d3ba77f440c4\",\"http://iiif.io/api/image\":\"https://iiif-cloud-staging.princeton.edu/iiif/2/05%2F71%2F04%2F0571046f9c7149a3b950899323f70788%2Fintermediate_file/info.json\",\"http://iiif.io/api/presentation#manifest\":\"https://figgy-staging.princeton.edu/concern/scanned_maps/2a91d82c-541c-426c-b787-cc62afe8f248/manifest\",\"http://www.opengis.net/def/serviceType/ogc/wmts\":\"https://map-tiles-staging.princeton.edu/2a91d82c541c426cb787cc62afe8f248/mosaicjson/WMTSCapabilities.xml\"}",
     "gbl_resourceClass_sm": [
         "Maps",
         "Web services"

data/spec/fixtures/solr_documents/xyz.json

@@ -3,7 +3,7 @@
     "6f47b103-9955-4bbe-a364-387039623106"
   ],
   "dct_title_s": "Quaternary Fault and Fold Database of the United States (XYZ)",
-  "dct_description_sm":[
+  "dct_description_sm": [
     "Quaternary Fault and Fold Database of the United States"
   ],
   "dct_accessRights_s": "Public",
@@ -28,9 +28,9 @@
     "Earthquakes",
     "Faults"
   ],
-  "dct_issued_s": 2020,
+  "dct_issued_s": "2020",
   "gbl_indexYear_im": [
-    "2020"
+    2020
   ],
   "dct_temporal_sm": [
     "2020"

data/spec/helpers/arcgis_helper_spec.rb

@@ -1,15 +1,16 @@
 # frozen_string_literal: true
-require 'spec_helper'
+
+require "spec_helper"
 
 describe ArcgisHelper, type: :helper do
-  describe '#arcgis_link' do
-    let(:application_name) { 'My GeoBlacklight Deployment' }
+  describe "#arcgis_link" do
+    let(:application_name) { "My GeoBlacklight Deployment" }
 
-    it 'creates a valid ArcGIS online url with correct params' do
-      expect(arcgis_link('http://example.com/foo/MapServer')).to eq 'https://www.arcgis.com/home/webmap/viewer.html?urls=http%3A%2F%2Fexample.com%2Ffoo%2FMapServer'
+    it "creates a valid ArcGIS online url with correct params" do
+      expect(arcgis_link("http://example.com/foo/MapServer")).to eq "https://www.arcgis.com/home/webmap/viewer.html?urls=http%3A%2F%2Fexample.com%2Ffoo%2FMapServer"
     end
-    it 'handles multiple urls' do
-      expect(arcgis_link(['http://example.com/foo/MapServer', 'http://example.com/foo/FeatureServer'])).to eq 'https://www.arcgis.com/home/webmap/viewer.html?urls=http%3A%2F%2Fexample.com%2Ffoo%2FMapServer&urls=http%3A%2F%2Fexample.com%2Ffoo%2FFeatureServer'
+    it "handles multiple urls" do
+      expect(arcgis_link(["http://example.com/foo/MapServer", "http://example.com/foo/FeatureServer"])).to eq "https://www.arcgis.com/home/webmap/viewer.html?urls=http%3A%2F%2Fexample.com%2Ffoo%2FMapServer&urls=http%3A%2F%2Fexample.com%2Ffoo%2FFeatureServer"
     end
   end
 end

data/spec/helpers/carto_helper_spec.rb

@@ -1,12 +1,13 @@
 # frozen_string_literal: true
-require 'spec_helper'
+
+require "spec_helper"
 
 describe CartoHelper, type: :helper do
-  describe '#carto_link' do
-    let(:application_name) { 'My GeoBlacklight Deployment' }
+  describe "#carto_link" do
+    let(:application_name) { "My GeoBlacklight Deployment" }
 
-    it 'removes spaces from application_name to produce valid Carto request URL' do
-      expect(carto_link('http://demo.org/wfs/layer.json')).to eq 'http://oneclick.carto.com/?file=http%3A%2F%2Fdemo.org%2Fwfs%2Flayer.json&provider=MyGeoBlacklightDeployment&logo=http%3A%2F%2Fgeoblacklight.org%2Fimages%2Fgeoblacklight-logo.png'
+    it "removes spaces from application_name to produce valid Carto request URL" do
+      expect(carto_link("http://demo.org/wfs/layer.json")).to eq "http://oneclick.carto.com/?file=http%3A%2F%2Fdemo.org%2Fwfs%2Flayer.json&provider=MyGeoBlacklightDeployment&logo=http%3A%2F%2Fgeoblacklight.org%2Fimages%2Fgeoblacklight-logo.png"
     end
   end
 end

data/spec/helpers/geoblacklight/geoblacklight_helper_behavior_spec.rb

@@ -1,31 +1,26 @@
 # frozen_string_literal: true
-require 'spec_helper'
+
+require "spec_helper"
 
 describe Geoblacklight::GeoblacklightHelperBehavior do
   let(:dummy_class) do
     Class.new.extend(described_class)
   end
-  let(:presenter) { instance_double(MyPresenter, fake_name: 'druid:abc123') }
-
-  before do
-    class MyPresenter < Blacklight::ShowPresenter
-      def fake_name; end
-    end
-  end
+  let(:presenter) { instance_double(Geoblacklight::DocumentPresenter, index_fields_display: "druid:abc123") }
 
-  describe '#geoblacklight_present' do
+  describe "#geoblacklight_present" do
     before do
       expect(dummy_class).to receive(:presenter).and_return(presenter)
     end
 
-    context 'as a Symbol' do
-      it 'calls defined presenter class' do
-        expect(dummy_class.geoblacklight_present(:fake_name)).to eq 'druid:abc123'
+    context "as a Symbol" do
+      it "calls defined presenter class" do
+        expect(dummy_class.geoblacklight_present(:index_fields_display)).to eq "druid:abc123"
       end
     end
-    context 'as a String' do
-      it 'calls defined presenter class' do
-        expect(dummy_class.geoblacklight_present('fake_name')).to eq 'druid:abc123'
+    context "as a String" do
+      it "calls defined presenter class" do
+        expect(dummy_class.geoblacklight_present("index_fields_display")).to eq "druid:abc123"
       end
     end
   end