geoblacklight 4.0.0 → 4.1.0

data/.rubocop_todo.yml

@@ -1,437 +0,0 @@
-# This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2022-09-13 13:23:36 UTC using RuboCop version 1.36.0.
-# The point is for the user to remove these configuration records
-# one by one as the offenses are removed from the code base.
-# Note that changes in the inspected code, or installation of new
-# versions of RuboCop, may require this file to be generated again.
-
-# Offense count: 3
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: with_first_argument, with_fixed_indentation
-Layout/ArgumentAlignment:
-  Exclude:
-    - 'app/controllers/download_controller.rb'
-    - 'lib/geoblacklight/metadata/html.rb'
-
-# Offense count: 9
-# This cop supports safe autocorrection (--autocorrect).
-Layout/EmptyLineAfterGuardClause:
-  Exclude:
-    - 'app/helpers/geoblacklight_helper.rb'
-    - 'app/models/concerns/geoblacklight/solr_document/arcgis.rb'
-    - 'app/models/concerns/geoblacklight/solr_document/carto.rb'
-    - 'lib/geoblacklight/bounding_box.rb'
-    - 'lib/geoblacklight/download.rb'
-    - 'lib/geoblacklight/item_viewer.rb'
-    - 'lib/geoblacklight/metadata/base.rb'
-    - 'lib/geoblacklight/references.rb'
-
-# Offense count: 148
-# This cop supports safe autocorrection (--autocorrect).
-Layout/EmptyLineAfterMagicComment:
-  Enabled: false
-
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EmptyLineBetweenMethodDefs, EmptyLineBetweenClassDefs, EmptyLineBetweenModuleDefs, AllowAdjacentOneLineDefs, NumberOfEmptyLines.
-Layout/EmptyLineBetweenDefs:
-  Exclude:
-    - 'lib/geoblacklight/exceptions.rb'
-
-# Offense count: 3
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowAliasSyntax, AllowedMethods.
-# AllowedMethods: alias_method, public, protected, private
-Layout/EmptyLinesAroundAttributeAccessor:
-  Exclude:
-    - 'lib/geoblacklight/metadata/base.rb'
-    - 'lib/geoblacklight/references.rb'
-    - 'lib/geoblacklight/relation/relation_response.rb'
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Lint/BooleanSymbol:
-  Exclude:
-    - 'spec/features/metadata_panel_spec.rb'
-
-# Offense count: 4
-# Configuration parameters: AllowedMethods.
-# AllowedMethods: enums
-Lint/ConstantDefinitionInBlock:
-  Exclude:
-    - 'spec/helpers/geoblacklight/geoblacklight_helper_behavior_spec.rb'
-    - 'spec/lib/geoblacklight/view_helper_override_spec.rb'
-    - 'spec/models/concerns/geoblacklight/solr_document/carto_spec.rb'
-    - 'spec/models/concerns/geoblacklight/solr_document/finder_spec.rb'
-
-# Offense count: 1
-Lint/MissingSuper:
-  Exclude:
-    - 'lib/geoblacklight/exceptions.rb'
-
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-Lint/SendWithMixinArgument:
-  Exclude:
-    - 'lib/geoblacklight/engine.rb'
-
-# Offense count: 7
-# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods, CountRepeatedAttributes.
-Metrics/AbcSize:
-  Max: 27
-
-# Offense count: 1
-# Configuration parameters: EnforcedStyleForLeadingUnderscores.
-# SupportedStylesForLeadingUnderscores: disallowed, required, optional
-Naming/MemoizedInstanceVariableName:
-  Exclude:
-    - 'app/models/concerns/geoblacklight/solr_document/finder.rb'
-
-# Offense count: 2
-# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-# AllowedNames: as, at, by, db, id, in, io, ip, of, on, os, pp, to
-Naming/MethodParameterName:
-  Exclude:
-    - 'lib/geoblacklight/references.rb'
-
-# Offense count: 5
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: PreferredName.
-Naming/RescuedExceptionsVariableName:
-  Exclude:
-    - 'app/helpers/geoblacklight_helper.rb'
-    - 'lib/geoblacklight/download.rb'
-    - 'lib/geoblacklight/metadata/base.rb'
-    - 'lib/geoblacklight/wms_layer.rb'
-
-# Offense count: 162
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnabledMethods.
-RSpec/Capybara/FeatureMethods:
-  Enabled: false
-
-# Offense count: 19
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/Capybara/SpecificFinders:
-  Exclude:
-    - 'spec/features/download_layer_spec.rb'
-    - 'spec/features/layer_inspection_spec.rb'
-    - 'spec/features/multiple_downloads_spec.rb'
-    - 'spec/features/search_results_map_spec.rb'
-    - 'spec/features/show_page_download_spec.rb'
-    - 'spec/features/split_view.html.erb_spec.rb'
-
-# Offense count: 18
-RSpec/Capybara/VisibilityMatcher:
-  Exclude:
-    - 'spec/features/esri_viewer_spec.rb'
-    - 'spec/features/iiif_viewer_spec.rb'
-    - 'spec/features/split_view.html.erb_spec.rb'
-    - 'spec/features/tms_spec.rb'
-
-# Offense count: 16
-# Configuration parameters: Prefixes, AllowedPatterns.
-# Prefixes: when, with, without
-RSpec/ContextWording:
-  Exclude:
-    - 'spec/helpers/geoblacklight/geoblacklight_helper_behavior_spec.rb'
-    - 'spec/helpers/geoblacklight_helper_spec.rb'
-    - 'spec/lib/geoblacklight/item_viewer_spec.rb'
-    - 'spec/lib/geoblacklight/reference_spec.rb'
-    - 'spec/views/catalog/_show_downloads.html.erb_spec.rb'
-
-# Offense count: 2
-# This cop supports unsafe autocorrection (--autocorrect-all).
-RSpec/EmptyExampleGroup:
-  Exclude:
-    - 'spec/views/catalog/_document_split.html.erb_spec.rb'
-    - 'spec/views/catalog/_index_split.html.erb_spec.rb'
-
-# Offense count: 63
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowConsecutiveOneLiners.
-RSpec/EmptyLineAfterExample:
-  Enabled: false
-
-# Offense count: 77
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/EmptyLineAfterExampleGroup:
-  Enabled: false
-
-# Offense count: 61
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/EmptyLineAfterFinalLet:
-  Enabled: false
-
-# Offense count: 13
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowConsecutiveOneLiners.
-RSpec/EmptyLineAfterHook:
-  Exclude:
-    - 'spec/features/configurable_basemap_spec.rb'
-    - 'spec/features/empty_search_spec.rb'
-    - 'spec/features/home_page_spec.rb'
-    - 'spec/lib/geoblacklight/download_spec.rb'
-    - 'spec/lib/geoblacklight/metadata_spec.rb'
-    - 'spec/lib/geoblacklight/metadata_transformer/base_spec.rb'
-    - 'spec/lib/geoblacklight/references_spec.rb'
-
-# Offense count: 9
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/EmptyLineAfterSubject:
-  Exclude:
-    - 'spec/lib/geoblacklight/document_presenter_spec.rb'
-    - 'spec/lib/geoblacklight/metadata_transformer/base_spec.rb'
-    - 'spec/lib/geoblacklight/metadata_transformer/fgdc_spec.rb'
-    - 'spec/lib/geoblacklight/metadata_transformer/iso19139_spec.rb'
-    - 'spec/lib/geoblacklight/metadata_transformer_spec.rb'
-    - 'spec/lib/geoblacklight/wms_layer_spec.rb'
-
-# Offense count: 5
-RSpec/ExpectInHook:
-  Exclude:
-    - 'spec/helpers/geoblacklight/geoblacklight_helper_behavior_spec.rb'
-    - 'spec/lib/geoblacklight/metadata/base_spec.rb'
-    - 'spec/lib/geoblacklight/metadata_transformer/iso19139_spec.rb'
-    - 'spec/views/catalog/_show_downloads.html.erb_spec.rb'
-
-# Offense count: 6
-# Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
-# Include: **/*_spec*rb*, **/spec/**/*
-RSpec/FilePath:
-  Exclude:
-    - 'spec/lib/geoblacklight/download/geojson_download_spec.rb'
-    - 'spec/lib/geoblacklight/download/geotiff_download_spec.rb'
-    - 'spec/lib/geoblacklight/download/hgl_download_spec.rb'
-    - 'spec/lib/geoblacklight/download/kmz_download_spec.rb'
-    - 'spec/lib/geoblacklight/download/shapefile_download_spec.rb'
-    - 'spec/lib/geoblacklight/wms_layer/feature_info_response_spec.rb'
-
-# Offense count: 1
-# Configuration parameters: AssignmentOnly.
-RSpec/InstanceVariable:
-  Exclude:
-    - 'spec/components/geoblacklight/homepage_feature_facet_component_spec.rb'
-
-# Offense count: 1
-RSpec/IteratedExpectation:
-  Exclude:
-    - 'spec/lib/geoblacklight/references_spec.rb'
-
-# Offense count: 4
-RSpec/LeakyConstantDeclaration:
-  Exclude:
-    - 'spec/helpers/geoblacklight/geoblacklight_helper_behavior_spec.rb'
-    - 'spec/lib/geoblacklight/view_helper_override_spec.rb'
-    - 'spec/models/concerns/geoblacklight/solr_document/carto_spec.rb'
-    - 'spec/models/concerns/geoblacklight/solr_document/finder_spec.rb'
-
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/LetBeforeExamples:
-  Exclude:
-    - 'spec/models/concerns/geoblacklight/solr_document_spec.rb'
-
-# Offense count: 46
-# Configuration parameters: .
-# SupportedStyles: have_received, receive
-RSpec/MessageSpies:
-  EnforcedStyle: receive
-
-# Offense count: 126
-RSpec/MultipleExpectations:
-  Max: 9
-
-# Offense count: 67
-# Configuration parameters: AllowSubject.
-RSpec/MultipleMemoizedHelpers:
-  Max: 11
-
-# Offense count: 15
-# Configuration parameters: IgnoreSharedExamples.
-RSpec/NamedSubject:
-  Exclude:
-    - 'spec/lib/geoblacklight/metadata/base_spec.rb'
-    - 'spec/lib/geoblacklight/metadata_transformer/base_spec.rb'
-    - 'spec/lib/geoblacklight/metadata_transformer/fgdc_spec.rb'
-    - 'spec/lib/geoblacklight/metadata_transformer/iso19139_spec.rb'
-    - 'spec/lib/geoblacklight/metadata_transformer_spec.rb'
-    - 'spec/models/concerns/geoblacklight/solr_document/inspection_spec.rb'
-
-# Offense count: 3
-# Configuration parameters: AllowedGroups.
-RSpec/NestedGroups:
-  Max: 4
-
-# Offense count: 1
-RSpec/NoExpectationExample:
-  Exclude:
-    - 'spec/features/layer_with_no_references_spec.rb'
-
-# Offense count: 19
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: Strict, EnforcedStyle, AllowedExplicitMatchers.
-# SupportedStyles: inflected, explicit
-RSpec/PredicateMatcher:
-  Exclude:
-    - 'spec/lib/geoblacklight/download_spec.rb'
-    - 'spec/lib/geoblacklight/wms_layer/feature_info_response_spec.rb'
-    - 'spec/models/concerns/geoblacklight/solr_document/inspection_spec.rb'
-    - 'spec/models/concerns/geoblacklight/solr_document_spec.rb'
-
-# Offense count: 2
-RSpec/RepeatedExampleGroupBody:
-  Exclude:
-    - 'spec/helpers/geoblacklight_helper_spec.rb'
-
-# Offense count: 2
-RSpec/RepeatedExampleGroupDescription:
-  Exclude:
-    - 'spec/helpers/geoblacklight_helper_spec.rb'
-
-# Offense count: 33
-RSpec/StubbedMock:
-  Exclude:
-    - 'spec/features/download_layer_spec.rb'
-    - 'spec/helpers/geoblacklight/geoblacklight_helper_behavior_spec.rb'
-    - 'spec/helpers/geoblacklight_helper_spec.rb'
-    - 'spec/lib/geoblacklight/download_spec.rb'
-    - 'spec/lib/geoblacklight/metadata_transformer/iso19139_spec.rb'
-    - 'spec/models/concerns/geoblacklight/solr_document/carto_spec.rb'
-    - 'spec/models/concerns/geoblacklight/solr_document/inspection_spec.rb'
-    - 'spec/models/concerns/geoblacklight/solr_document_spec.rb'
-    - 'spec/views/catalog/_show_downloads.html.erb_spec.rb'
-
-# Offense count: 2
-RSpec/SubjectStub:
-  Exclude:
-    - 'spec/models/concerns/geoblacklight/solr_document/inspection_spec.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: SafeAutocorrect.
-Rails/ActionControllerFlashBeforeRender:
-  Exclude:
-    - 'app/controllers/download_controller.rb'
-
-# Offense count: 10
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: slashes, arguments
-Rails/FilePath:
-  Exclude:
-    - 'lib/geoblacklight/download.rb'
-    - 'spec/features/metadata_panel_spec.rb'
-    - 'spec/lib/geoblacklight/download_spec.rb'
-    - 'spec/lib/geoblacklight/metadata_transformer/fgdc_spec.rb'
-    - 'spec/lib/geoblacklight/metadata_transformer/iso19139_spec.rb'
-    - 'spec/tasks/geoblacklight_spec.rb'
-
-# Offense count: 7
-# Configuration parameters: Include.
-# Include: app/helpers/**/*.rb
-Rails/HelperInstanceVariable:
-  Exclude:
-    - 'app/helpers/blacklight_helper.rb'
-    - 'app/helpers/geoblacklight/geoblacklight_helper_behavior.rb'
-    - 'app/helpers/geoblacklight_helper.rb'
-
-# Offense count: 3
-Rails/OutputSafety:
-  Exclude:
-    - 'app/controllers/download_controller.rb'
-    - 'app/helpers/geoblacklight_helper.rb'
-
-# Offense count: 7
-# This cop supports safe autocorrection (--autocorrect).
-Rails/RootPathnameMethods:
-  Exclude:
-    - 'spec/features/metadata_panel_spec.rb'
-    - 'spec/lib/geoblacklight/metadata_transformer/fgdc_spec.rb'
-    - 'spec/lib/geoblacklight/metadata_transformer/iso19139_spec.rb'
-    - 'spec/tasks/geoblacklight_spec.rb'
-
-# Offense count: 4
-# This cop supports safe autocorrection (--autocorrect).
-Style/ExpandPathArguments:
-  Exclude:
-    - 'lib/generators/geoblacklight/install_generator.rb'
-    - 'spec/spec_helper.rb'
-    - 'spec/support/features.rb'
-    - 'spec/test_app_templates/lib/generators/test_app_generator.rb'
-
-# Offense count: 1
-# Configuration parameters: MinBodyLength, AllowConsecutiveConditionals.
-Style/GuardClause:
-  Exclude:
-    - 'lib/generators/geoblacklight/assets_generator.rb'
-
-# Offense count: 2
-Style/MissingRespondToMissing:
-  Exclude:
-    - 'app/models/concerns/geoblacklight/solr_document.rb'
-    - 'lib/geoblacklight/references.rb'
-
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-Style/RedundantAssignment:
-  Exclude:
-    - 'app/controllers/download_controller.rb'
-
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-Style/RedundantRegexpEscape:
-  Exclude:
-    - 'lib/generators/geoblacklight/install_generator.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
-# SupportedStyles: slashes, percent_r, mixed
-Style/RegexpLiteral:
-  Exclude:
-    - 'lib/geoblacklight/reference.rb'
-
-# Offense count: 5
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: implicit, explicit
-Style/RescueStandardError:
-  Exclude:
-    - 'app/helpers/geoblacklight_helper.rb'
-    - 'lib/geoblacklight/metadata.rb'
-    - 'lib/geoblacklight/metadata_transformer.rb'
-    - 'lib/geoblacklight/metadata_transformer/base.rb'
-
-# Offense count: 3
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Style/SlicingWithRange:
-  Exclude:
-    - 'spec/helpers/geoblacklight_helper_spec.rb'
-
-# Offense count: 6
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: Mode.
-Style/StringConcatenation:
-  Exclude:
-    - 'app/controllers/download_controller.rb'
-    - 'app/helpers/arcgis_helper.rb'
-    - 'app/helpers/carto_helper.rb'
-    - 'lib/geoblacklight/download.rb'
-    - 'spec/lib/geoblacklight/document_presenter_spec.rb'
-
-# Offense count: 4
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: MinSize.
-# SupportedStyles: percent, brackets
-Style/SymbolArray:
-  EnforcedStyle: brackets
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: WordRegex.
-# SupportedStyles: percent, brackets
-Style/WordArray:
-  EnforcedStyle: percent
-  MinSize: 3

data/config/initializers/new_gbl_settings_defaults_3_4.yml

@@ -1,6 +0,0 @@
-# New GeoBlacklight v3.4
-# Homepage Map Geometry
-# Leave null to default to entire world
-# Add a stringified GeoJSON object to scope initial render (example from UMass)
-HOMEPAGE_MAP_GEOM: null
-# HOMEPAGE_MAP_GEOM: '{"type":"Polygon","coordinates":[[[-73.58,42.93],[-73.58,41.20],[-69.90,41.20],[-69.90,42.93]]]}'