geoblacklight 2.1.2 → 3.0.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (291) hide show
  1. checksums.yaml +4 -4
  2. data/.circleci/config.yml +214 -108
  3. data/.gitignore +3 -1
  4. data/.rubocop.yml +19 -15
  5. data/.rubocop_todo.yml +28 -159
  6. data/Gemfile +3 -8
  7. data/README.md +6 -7
  8. data/Rakefile +1 -0
  9. data/app/assets/images/blacklight/arrow-circle-down.svg +3 -0
  10. data/app/assets/images/blacklight/baruch-cuny.svg +3 -0
  11. data/app/assets/images/blacklight/berkeley.svg +4 -0
  12. data/app/assets/images/blacklight/book.svg +3 -0
  13. data/app/assets/images/blacklight/bookmark.svg +3 -0
  14. data/app/assets/images/blacklight/cd-rom.svg +3 -0
  15. data/app/assets/images/blacklight/chicago.svg +4 -0
  16. data/app/assets/images/blacklight/citation.svg +3 -0
  17. data/app/assets/images/blacklight/collection.svg +3 -0
  18. data/app/assets/images/blacklight/columbia.svg +3 -0
  19. data/app/assets/images/blacklight/cornell.svg +5 -0
  20. data/app/assets/images/blacklight/dvd-rom.svg +3 -0
  21. data/app/assets/images/blacklight/email.svg +3 -0
  22. data/app/assets/images/blacklight/esri-globe.svg +31 -37
  23. data/app/assets/images/blacklight/geoblacklight-icons.json +2079 -0
  24. data/app/assets/images/blacklight/globe.svg +3 -0
  25. data/app/assets/images/blacklight/harvard.svg +3 -0
  26. data/app/assets/images/blacklight/home.svg +3 -0
  27. data/app/assets/images/blacklight/illinois.svg +4 -0
  28. data/app/assets/images/blacklight/image.svg +3 -0
  29. data/app/assets/images/blacklight/indiana.svg +3 -0
  30. data/app/assets/images/blacklight/iowa.svg +3 -0
  31. data/app/assets/images/blacklight/leaf.svg +3 -0
  32. data/app/assets/images/blacklight/lewis-clark.svg +5 -0
  33. data/app/assets/images/blacklight/line.svg +4 -0
  34. data/app/assets/images/blacklight/logo.svg +1 -0
  35. data/app/assets/images/blacklight/map-marker.svg +3 -0
  36. data/app/assets/images/blacklight/map.svg +3 -0
  37. data/app/assets/images/blacklight/maryland.svg +3 -0
  38. data/app/assets/images/blacklight/massgis.svg +3 -0
  39. data/app/assets/images/blacklight/metadata.svg +3 -0
  40. data/app/assets/images/blacklight/michigan-state.svg +4 -0
  41. data/app/assets/images/blacklight/michigan.svg +3 -0
  42. data/app/assets/images/blacklight/minnesota.svg +3 -0
  43. data/app/assets/images/blacklight/mit.svg +3 -0
  44. data/app/assets/images/blacklight/mixed.svg +5 -0
  45. data/app/assets/images/blacklight/multilinestring.svg +6 -0
  46. data/app/assets/images/blacklight/multipoint.svg +3 -0
  47. data/app/assets/images/blacklight/multipolygon.svg +6 -0
  48. data/app/assets/images/blacklight/nyu.svg +6 -0
  49. data/app/assets/images/blacklight/ohio-state.svg +5 -0
  50. data/app/assets/images/blacklight/pagelines-brands.svg +3 -0
  51. data/app/assets/images/blacklight/paper-map.svg +3 -0
  52. data/app/assets/images/blacklight/penn-state.svg +4 -0
  53. data/app/assets/images/blacklight/point.svg +3 -0
  54. data/app/assets/images/blacklight/polygon.svg +4 -0
  55. data/app/assets/images/blacklight/polyline.svg +6 -0
  56. data/app/assets/images/blacklight/princeton.svg +3 -0
  57. data/app/assets/images/blacklight/public.svg +3 -0
  58. data/app/assets/images/blacklight/purdue.svg +4 -0
  59. data/app/assets/images/blacklight/raster.svg +3 -0
  60. data/app/assets/images/blacklight/restricted.svg +3 -0
  61. data/app/assets/images/blacklight/sms.svg +3 -0
  62. data/app/assets/images/blacklight/stanford.svg +3 -0
  63. data/app/assets/images/blacklight/table.svg +3 -0
  64. data/app/assets/images/blacklight/tags.svg +3 -0
  65. data/app/assets/images/blacklight/texas.svg +3 -0
  66. data/app/assets/images/blacklight/tufts.svg +3 -0
  67. data/app/assets/images/blacklight/ucla.svg +3 -0
  68. data/app/assets/images/blacklight/uva.svg +3 -0
  69. data/app/assets/images/blacklight/web_services.svg +3 -0
  70. data/app/assets/images/blacklight/wisconsin.svg +3 -0
  71. data/app/assets/javascripts/geoblacklight/basemaps.js +18 -0
  72. data/app/assets/javascripts/geoblacklight/downloaders/downloader.js +1 -1
  73. data/app/assets/javascripts/geoblacklight/modules/geosearch.js +1 -1
  74. data/app/assets/javascripts/geoblacklight/modules/help_text.js +7 -0
  75. data/app/assets/javascripts/geoblacklight/modules/home.js +1 -1
  76. data/app/assets/javascripts/geoblacklight/modules/item.js +19 -2
  77. data/app/assets/javascripts/geoblacklight/modules/results.js +4 -2
  78. data/app/assets/javascripts/geoblacklight/modules/svg_tooltips.js +31 -0
  79. data/app/assets/javascripts/geoblacklight/viewers/esri.js +2 -2
  80. data/app/assets/javascripts/geoblacklight/viewers/esri/tiled_map_layer.js +1 -1
  81. data/app/assets/javascripts/geoblacklight/viewers/oembed.js +13 -0
  82. data/app/assets/javascripts/geoblacklight/viewers/wms.js +2 -2
  83. data/app/assets/stylesheets/geoblacklight/geoblacklight.scss +2 -0
  84. data/app/assets/stylesheets/geoblacklight/modules/_base.scss +33 -0
  85. data/app/assets/stylesheets/geoblacklight/{_blacklight_overrides.scss → modules/_blacklight_overrides.scss} +8 -9
  86. data/app/assets/stylesheets/geoblacklight/{_styles.scss → modules/_styles.scss} +1 -0
  87. data/app/assets/stylesheets/geoblacklight/modules/downloads.scss +37 -54
  88. data/app/assets/stylesheets/geoblacklight/modules/icon-customization.scss +49 -59
  89. data/app/assets/stylesheets/geoblacklight/modules/item.scss +17 -0
  90. data/app/assets/stylesheets/geoblacklight/modules/results.scss +47 -28
  91. data/app/assets/stylesheets/geoblacklight/modules/sidebar.scss +12 -42
  92. data/app/assets/stylesheets/geoblacklight/modules/toolbar.scss +17 -55
  93. data/app/controllers/download_controller.rb +12 -12
  94. data/app/controllers/relation_controller.rb +1 -0
  95. data/app/controllers/wms_controller.rb +1 -0
  96. data/app/helpers/arcgis_helper.rb +1 -0
  97. data/app/helpers/blacklight_helper.rb +1 -0
  98. data/app/helpers/carto_helper.rb +1 -0
  99. data/app/helpers/geoblacklight_helper.rb +62 -19
  100. data/app/models/concerns/geoblacklight/solr_document.rb +18 -8
  101. data/app/models/concerns/geoblacklight/solr_document/arcgis.rb +2 -1
  102. data/app/models/concerns/geoblacklight/solr_document/carto.rb +1 -13
  103. data/app/models/concerns/geoblacklight/solr_document/citation.rb +29 -0
  104. data/app/models/concerns/geoblacklight/solr_document/finder.rb +1 -0
  105. data/app/models/concerns/geoblacklight/solr_document/inspection.rb +2 -1
  106. data/app/models/concerns/geoblacklight/spatial_search_behavior.rb +8 -1
  107. data/app/presenters/geoblacklight/document_presenter.rb +2 -1
  108. data/app/views/catalog/_arcgis.html.erb +4 -0
  109. data/app/views/catalog/_carto.html.erb +4 -0
  110. data/app/views/catalog/_citation.html.erb +11 -0
  111. data/app/views/catalog/_data_dictionary.html.erb +3 -2
  112. data/app/views/catalog/_document_action.html.erb +1 -1
  113. data/app/views/catalog/_document_split.html.erb +1 -1
  114. data/app/views/catalog/_downloads_primary.html.erb +8 -1
  115. data/app/views/catalog/_header_icons.html.erb +3 -3
  116. data/app/views/catalog/_home_text.html.erb +8 -5
  117. data/app/views/catalog/_index_split_default.html.erb +22 -14
  118. data/app/views/catalog/_show_default_viewer_container.html.erb +6 -1
  119. data/app/views/catalog/_show_header_default.html.erb +2 -4
  120. data/app/views/catalog/_web_services_wfs.html.erb +3 -3
  121. data/app/views/catalog/_web_services_wms.html.erb +3 -3
  122. data/app/views/catalog/metadata.html.erb +3 -1
  123. data/app/views/catalog/web_services.html.erb +9 -7
  124. data/app/views/relation/_ancestors.html.erb +3 -5
  125. data/app/views/relation/_descendants.html.erb +4 -6
  126. data/app/views/relation/index.html.erb +20 -8
  127. data/app/views/relation/index.json.jbuilder +2 -1
  128. data/app/views/shared/_header_navbar.html.erb +1 -1
  129. data/bin/coverage.rb +36 -0
  130. data/config/initializers/rails_config.rb +1 -0
  131. data/config/locales/geoblacklight.en.yml +75 -2
  132. data/geoblacklight.gemspec +6 -8
  133. data/lib/generators/geoblacklight/assets_generator.rb +46 -0
  134. data/lib/generators/geoblacklight/install_generator.rb +8 -9
  135. data/lib/generators/geoblacklight/templates/assets/_blacklight.scss +1 -0
  136. data/lib/generators/geoblacklight/templates/assets/_customizations.scss +28 -0
  137. data/{app/assets/stylesheets/geoblacklight/application.scss → lib/generators/geoblacklight/templates/assets/_geoblacklight.scss} +0 -1
  138. data/lib/generators/geoblacklight/templates/assets/application.scss +7 -0
  139. data/lib/generators/geoblacklight/templates/{geoblacklight.js → assets/geoblacklight.js} +0 -1
  140. data/lib/generators/geoblacklight/templates/catalog_controller.rb +6 -2
  141. data/lib/generators/geoblacklight/templates/settings.yml +17 -0
  142. data/lib/generators/geoblacklight/webpacker_generator.rb +2 -1
  143. data/lib/geoblacklight.rb +1 -0
  144. data/lib/geoblacklight/bounding_box.rb +1 -0
  145. data/lib/geoblacklight/catalog_helper_override.rb +2 -1
  146. data/lib/geoblacklight/constants.rb +4 -2
  147. data/lib/geoblacklight/download.rb +6 -5
  148. data/lib/geoblacklight/download/geojson_download.rb +1 -0
  149. data/lib/geoblacklight/download/geotiff_download.rb +1 -0
  150. data/lib/geoblacklight/download/hgl_download.rb +1 -0
  151. data/lib/geoblacklight/download/kmz_download.rb +2 -1
  152. data/lib/geoblacklight/download/shapefile_download.rb +1 -0
  153. data/lib/geoblacklight/engine.rb +1 -2
  154. data/lib/geoblacklight/exceptions.rb +1 -0
  155. data/lib/geoblacklight/geoblacklight_helper_behavior.rb +1 -0
  156. data/lib/geoblacklight/item_viewer.rb +6 -1
  157. data/lib/geoblacklight/metadata.rb +1 -0
  158. data/lib/geoblacklight/metadata/base.rb +16 -10
  159. data/lib/geoblacklight/metadata/fgdc.rb +1 -0
  160. data/lib/geoblacklight/metadata/html.rb +2 -2
  161. data/lib/geoblacklight/metadata/iso19139.rb +1 -0
  162. data/lib/geoblacklight/metadata_transformer.rb +1 -0
  163. data/lib/geoblacklight/metadata_transformer/base.rb +1 -0
  164. data/lib/geoblacklight/metadata_transformer/fgdc.rb +1 -0
  165. data/lib/geoblacklight/metadata_transformer/iso19139.rb +1 -0
  166. data/lib/geoblacklight/reference.rb +3 -1
  167. data/lib/geoblacklight/references.rb +7 -3
  168. data/lib/geoblacklight/relation/ancestors.rb +2 -1
  169. data/lib/geoblacklight/relation/descendants.rb +2 -1
  170. data/lib/geoblacklight/relation/relation_response.rb +2 -1
  171. data/lib/geoblacklight/routes.rb +1 -0
  172. data/lib/geoblacklight/routes/downloadable.rb +1 -0
  173. data/lib/geoblacklight/routes/exportable.rb +1 -0
  174. data/lib/geoblacklight/routes/wms.rb +1 -0
  175. data/lib/geoblacklight/version.rb +2 -1
  176. data/lib/geoblacklight/view_helper_override.rb +2 -1
  177. data/lib/geoblacklight/wms_layer.rb +3 -2
  178. data/lib/geoblacklight/wms_layer/feature_info_response.rb +1 -0
  179. data/lib/tasks/geoblacklight.rake +33 -32
  180. data/package.json +4 -0
  181. data/schema/references.md +2 -1
  182. data/solr/conf/schema.xml +5 -5
  183. data/spec/controllers/catalog_controller_spec.rb +1 -0
  184. data/spec/controllers/download_controller_spec.rb +2 -1
  185. data/spec/controllers/relation_controller_spec.rb +1 -0
  186. data/spec/controllers/wms_controller_spec.rb +2 -1
  187. data/spec/factories/user.rb +1 -0
  188. data/spec/features/bookmarks_spec.rb +1 -0
  189. data/spec/features/configurable_basemap_spec.rb +10 -0
  190. data/spec/features/data_dictionary_download_spec.rb +1 -0
  191. data/spec/features/download_layer_spec.rb +1 -0
  192. data/spec/features/empty_search_spec.rb +1 -0
  193. data/spec/features/esri_viewer_spec.rb +1 -6
  194. data/spec/features/exports_spec.rb +4 -3
  195. data/spec/features/help_text_spec.rb +9 -0
  196. data/spec/features/home_page_spec.rb +6 -0
  197. data/spec/features/iiif_viewer_spec.rb +1 -0
  198. data/spec/features/index_map_spec.rb +1 -0
  199. data/spec/features/layer_inspection_spec.rb +1 -0
  200. data/spec/features/layer_opacity_spec.rb +1 -0
  201. data/spec/features/layer_preview_spec.rb +1 -0
  202. data/spec/features/layer_with_no_references_spec.rb +1 -0
  203. data/spec/features/linkified_attribute_table_spec.rb +1 -0
  204. data/spec/features/metadata_panel_spec.rb +52 -8
  205. data/spec/features/missing_metadata_spec.rb +13 -0
  206. data/spec/features/multiple_downloads_spec.rb +15 -0
  207. data/spec/features/oembed_spec.rb +10 -0
  208. data/spec/features/relations_spec.rb +10 -28
  209. data/spec/features/saved_searches_spec.rb +1 -0
  210. data/spec/features/search_bar_spec.rb +1 -0
  211. data/spec/features/search_results_map_spec.rb +2 -7
  212. data/spec/features/search_results_overlap_ratio_spec.rb +4 -3
  213. data/spec/features/search_spec.rb +1 -0
  214. data/spec/features/show_page_metadata_spec.rb +1 -0
  215. data/spec/features/sms_spec.rb +1 -0
  216. data/spec/features/split_view.html.erb_spec.rb +5 -4
  217. data/spec/features/suppressed_records_spec.rb +15 -0
  218. data/spec/features/web_services_modal_spec.rb +1 -0
  219. data/spec/fixtures/fgdc/harvard-g7064-s2-1834-k3.xml +1 -0
  220. data/spec/fixtures/iso19139/stanford-cg357zz0321.xml +581 -0
  221. data/spec/fixtures/mods/fb897vt9938.mods +111 -0
  222. data/spec/fixtures/mods/stanford-cg357zz0321.mods +113 -0
  223. data/spec/fixtures/solr_documents/iiif-eastern-hemisphere.json +1 -1
  224. data/spec/fixtures/solr_documents/metadata_no_dct_provenance_s.json +30 -0
  225. data/spec/fixtures/solr_documents/metadata_no_layer_geom_type_s.json +17 -0
  226. data/spec/fixtures/solr_documents/metadata_no_solr_geom.json +23 -0
  227. data/spec/fixtures/solr_documents/multiple-downloads.json +30 -0
  228. data/spec/fixtures/solr_documents/oembed.json +24 -0
  229. data/spec/helpers/arcgis_helper_spec.rb +1 -0
  230. data/spec/helpers/carto_helper_spec.rb +1 -0
  231. data/spec/helpers/geoblacklight_helper_spec.rb +81 -12
  232. data/spec/javascripts/geoblacklight/viewers/esri/tiled_map_layer_spec.js +12 -0
  233. data/spec/javascripts/metadata_download_button_spec.js +1 -1
  234. data/spec/lib/geoblacklight/bounding_box_spec.rb +1 -0
  235. data/spec/lib/geoblacklight/controller_override_spec.rb +1 -0
  236. data/spec/lib/geoblacklight/document_presenter_spec.rb +3 -2
  237. data/spec/lib/geoblacklight/download/geojson_download_spec.rb +1 -0
  238. data/spec/lib/geoblacklight/download/geotiff_download_spec.rb +1 -0
  239. data/spec/lib/geoblacklight/download/hgl_download_spec.rb +1 -0
  240. data/spec/lib/geoblacklight/download/kmz_download_spec.rb +1 -0
  241. data/spec/lib/geoblacklight/download/shapefile_download_spec.rb +1 -0
  242. data/spec/lib/geoblacklight/download_spec.rb +4 -3
  243. data/spec/lib/geoblacklight/geoblacklight_helper_behavior_spec.rb +1 -0
  244. data/spec/lib/geoblacklight/item_viewer_spec.rb +1 -0
  245. data/spec/lib/geoblacklight/metadata/base_spec.rb +22 -7
  246. data/spec/lib/geoblacklight/metadata/html_spec.rb +1 -0
  247. data/spec/lib/geoblacklight/metadata_spec.rb +1 -0
  248. data/spec/lib/geoblacklight/metadata_transformer/base_spec.rb +3 -2
  249. data/spec/lib/geoblacklight/metadata_transformer/fgdc_spec.rb +3 -2
  250. data/spec/lib/geoblacklight/metadata_transformer/iso19139_spec.rb +3 -2
  251. data/spec/lib/geoblacklight/metadata_transformer_spec.rb +4 -3
  252. data/spec/lib/geoblacklight/reference_spec.rb +31 -0
  253. data/spec/lib/geoblacklight/references_spec.rb +2 -3
  254. data/spec/lib/geoblacklight/relation/ancestors_spec.rb +2 -1
  255. data/spec/lib/geoblacklight/relation/descendants_spec.rb +2 -1
  256. data/spec/lib/geoblacklight/relation/relation_response_spec.rb +1 -0
  257. data/spec/lib/geoblacklight/view_helper_override_spec.rb +1 -0
  258. data/spec/lib/geoblacklight/wms_layer/feature_info_response_spec.rb +5 -4
  259. data/spec/lib/geoblacklight/wms_layer_spec.rb +3 -2
  260. data/spec/models/concerns/geoblacklight/solr_document/carto_spec.rb +1 -20
  261. data/spec/models/concerns/geoblacklight/solr_document/citation_spec.rb +14 -0
  262. data/spec/models/concerns/geoblacklight/solr_document/finder_spec.rb +1 -0
  263. data/spec/models/concerns/geoblacklight/solr_document/inspection_spec.rb +1 -0
  264. data/spec/models/concerns/geoblacklight/solr_document_spec.rb +47 -0
  265. data/spec/models/concerns/geoblacklight/spatial_search_behavior_spec.rb +15 -2
  266. data/spec/routing/catalog_routing_spec.rb +1 -0
  267. data/spec/spec_helper.rb +20 -14
  268. data/spec/support/backport_test_helpers.rb +1 -0
  269. data/spec/support/features.rb +1 -0
  270. data/spec/support/features/session_helpers.rb +1 -0
  271. data/spec/support/fixtures.rb +8 -0
  272. data/spec/tasks/geoblacklight_spec.rb +19 -0
  273. data/spec/teaspoon_env.rb +1 -0
  274. data/spec/test_app_templates/Gemfile.extra +1 -0
  275. data/spec/test_app_templates/lib/generators/test_app_generator.rb +1 -0
  276. data/spec/views/catalog/_document_split.html.erb_spec.rb +1 -0
  277. data/spec/views/catalog/_index_split.html.erb_spec.rb +1 -0
  278. data/spec/views/catalog/_results_pagination.html.erb_spec.rb +1 -0
  279. data/spec/views/catalog/_show_downloads.html.erb_spec.rb +1 -0
  280. data/spec/views/catalog/_show_tools.html.erb_spec.rb +2 -4
  281. data/template.rb +1 -0
  282. data/vendor/assets/stylesheets/leaflet.css +0 -1
  283. metadata +158 -75
  284. data/app/assets/images/blacklight/logo.png +0 -0
  285. data/app/assets/javascripts/geoblacklight/modules/collapse.js +0 -7
  286. data/app/assets/stylesheets/geoblacklight/_geoblacklight.scss +0 -36
  287. data/app/assets/stylesheets/geoblacklight/modules/relations.scss +0 -15
  288. data/app/views/catalog/_exports.html.erb +0 -11
  289. data/app/views/catalog/_show_tools.html.erb +0 -25
  290. data/lib/generators/geoblacklight/templates/geoblacklight.scss +0 -4
  291. data/vendor/assets/javascripts/readmore.min.js +0 -11
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: b410d89c3bfd4a377eb0a437ca0c30216d18e65c61e4480edae06393a84db034
4
- data.tar.gz: eb118961474b7417d6f59b22586cb8a92c1f39b7a990d1bb83695dca1723502d
3
+ metadata.gz: 8b6da8bdd22d9bb963b6a62ffbc47b51169c003515007b414aa05d15d6239e09
4
+ data.tar.gz: 3b2f2e52352474379e3428bce9b4dec2113991e457a41e1b58795c56039d8687
5
5
  SHA512:
6
- metadata.gz: 217f927e25aed689a753d931247c070ca2ed3d37d7b403abe0547e24cac44b838cf94ef1bdedf764f917877c1f7d343d4a2be5faae08d2c99a56dff237efcf02
7
- data.tar.gz: 4eb63641d73914d94e54420431305124c4ef51cb0900cb036c9482d2b28bb6c44bbf0c979c4476f47df5a35579dbf43d838767f48123002148d7902420afaf4b
6
+ metadata.gz: 0fa98bbc2a5d93c3b03ef2f04bc83a19621452433600b345a7c48fcff108dabb58159a243fa73f6f955ada943ae377fb252a54302a38262c7175a60321b94e93
7
+ data.tar.gz: 342425a8b399ddedc409245910141f723d88952e145bac45ee2074eb8cc78287b7845dcb0d9c89ae9a012ba3f35ee5b982a9b34a860b07b3f541ac7608968d2c
@@ -1,146 +1,252 @@
1
1
  ---
2
- version: 2
2
+ version: 2.1
3
+ commands:
4
+ restore_bundle_cache:
5
+ description: "Restore gems installed by bundler"
6
+ parameters:
7
+ # Use this parameter to bust the cache, if needed
8
+ cache_prefix:
9
+ type: string
10
+ default: "8-6-2020-A"
11
+ ruby_version:
12
+ type: string
13
+ default: '2.7.1'
14
+ rails_version:
15
+ type: string
16
+ default: '6.0.3.2'
17
+ steps:
18
+ - restore_cache:
19
+ keys:
20
+ - << parameters.cache_prefix >>-{{ checksum "geoblacklight.gemspec" }}-{{ checksum "Gemfile" }}-<< parameters.ruby_version >>-<< parameters.rails_version >>
21
+ paths:
22
+ - /home/circleci/geoblacklight/vendor/bundle
23
+ save_bundle_cache:
24
+ description: "Save gems installed by bundler"
25
+ parameters:
26
+ # Use this parameter to bust the cache, if needed
27
+ cache_prefix:
28
+ type: string
29
+ default: "8-6-2020-A"
30
+ ruby_version:
31
+ type: string
32
+ default: '2.7.1'
33
+ rails_version:
34
+ type: string
35
+ default: '6.0.3.2'
36
+ steps:
37
+ - save_cache:
38
+ key: << parameters.cache_prefix >>-{{ checksum "geoblacklight.gemspec" }}-{{ checksum "Gemfile" }}-<< parameters.ruby_version >>-<< parameters.rails_version >>
39
+ paths:
40
+ - /home/circleci/geoblacklight/vendor/bundle
3
41
  jobs:
4
- rails_5_2_3:
42
+ build:
5
43
  working_directory: ~/geoblacklight
44
+ parameters:
45
+ ruby_version:
46
+ type: string
47
+ default: '2.7.1'
48
+ solr_port:
49
+ type: string
50
+ default: '8983'
51
+ rails_version:
52
+ type: string
53
+ default: '6.0.3.2'
54
+ coverage:
55
+ type: boolean
56
+ default: false
6
57
  docker:
7
- - image: circleci/ruby:2.5.1-node-browsers
8
- environment:
9
- BUNDLE_JOBS: 3
10
- BUNDLE_RETRY: 3
11
- # We need both GEM_HOME and BUNDLE_PATH because of the test app
12
- GEM_HOME: /home/circleci/geoblacklight/vendor/bundle
13
- BUNDLE_PATH: /home/circleci/geoblacklight/vendor/bundle
14
- CI: true
15
- RAILS_ENV: test
16
- RAILS_VERSION: 5.2.3
58
+ - image: circleci/ruby:<< parameters.ruby_version >>-node-browsers
17
59
  - image: solr:7-alpine
18
- command: bin/solr -cloud -noprompt -f -p 8983
60
+ command: bin/solr -cloud -noprompt -f -p <<parameters.solr_port>>
61
+ environment:
62
+ GEM_HOME: /home/circleci/geoblacklight/vendor/bundle
63
+ BUNDLE_PATH: /home/circleci/geoblacklight/vendor/bundle
64
+ BUNDLE_JOBS: 4
65
+ BUNDLE_RETRY: 3
66
+ RAILS_ENV: test
67
+ RACK_ENV: test
68
+ RAILS_VERSION: <<parameters.rails_version>>
19
69
  steps:
20
70
  - checkout
21
- # Update chrome
22
- - run: wget -q -O - https://dl.google.com/linux/linux_signing_key.pub | sudo apt-key add -
23
- - run: sudo sh -c 'echo "deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main" >> /etc/apt/sources.list.d/google.list'
24
- - run: sudo apt-get update
25
- - run: sudo apt-get -y install google-chrome-stable
26
- # Restore bundle cache
27
- - type: cache-restore
28
- name: Restore bundle cache
29
- key: geoblacklight-bundle-5-2-0-{{ checksum "geoblacklight.gemspec" }}-{{ checksum "Gemfile" }}-3f5eff
71
+ - restore_bundle_cache:
72
+ ruby_version: << parameters.ruby_version >>
73
+ rails_version: << parameters.rails_version >>
30
74
  # Install gems
31
75
  - run: bundle check || bundle install
32
- # Run the test suites
33
- - run: bundle exec rake engine_cart:generate
34
- - run:
35
- name: Wait for Solr
36
- command: dockerize -wait tcp://localhost:8983 -timeout 1m
37
- - run:
38
- name: Load config into solr
39
- command: |
40
- cd .internal_test_app/solr/conf
41
- zip -1 -r solr_config.zip ./*
42
- curl -H "Content-type:application/octet-stream" --data-binary @solr_config.zip "http://localhost:8983/solr/admin/configs?action=UPLOAD&name=solrconfig"
43
- curl -H 'Content-type: application/json' http://localhost:8983/api/collections/ -d '{create: {name: blacklight-core, config: solrconfig, numShards: 1}}'
76
+ # Generate the internal test app
44
77
  - run:
45
- name: Seed Solr
46
- command: |
47
- cd .internal_test_app
48
- bundle exec rake geoblacklight:index:seed
49
- bundle exec rake geoblacklight:downloads:mkdir
50
- - run:
51
- name: Compile the assets for Webpack
78
+ name: Generate test app
52
79
  command: |
53
- cd .internal_test_app
54
- rm config/webpacker.yml
55
- bundle exec rails webpacker:install
56
- bundle exec rails webpacker:compile
57
- - run:
58
- name: Run the RSpec test suites
59
- command: bundle exec rake geoblacklight:coverage
60
- # Store bundle cache
61
- - type: cache-save
62
- name: Store bundle cache
63
- key: geoblacklight-bundle-5-2-0-{{ checksum "geoblacklight.gemspec" }}-{{ checksum "Gemfile" }}-3f5eff
64
- paths:
65
- - /home/circleci/geoblacklight/vendor/bundle
66
- rails_5_1_7:
67
- working_directory: ~/geoblacklight
68
- docker:
69
- - image: circleci/ruby:2.4.4-node-browsers
70
- environment:
71
- BUNDLE_JOBS: 3
72
- BUNDLE_RETRY: 3
73
- GEM_HOME: /home/circleci/geoblacklight/vendor/bundle
74
- BUNDLE_PATH: /home/circleci/geoblacklight/vendor/bundle
75
- RAILS_ENV: test
76
- RAILS_VERSION: 5.1.7
77
- - image: solr:7-alpine
78
- command: bin/solr -cloud -noprompt -f -p 8983
79
- steps:
80
- - checkout
81
- # Restore bundle cache
82
- - type: cache-restore
83
- name: Restore bundle cache
84
- key: geoblacklight-bundle-5-1-7-{{ checksum "Gemfile" }}-{{ checksum "geoblacklight.gemspec" }}-3f5eff
85
- # Install gems and run specs
86
- - run: bundle check || bundle install
87
- # Run the test suites
88
- - run: bundle exec rake engine_cart:generate
80
+ [ -e ./.internal_test_app ] || bundle exec rake engine_cart:generate
81
+ - save_bundle_cache:
82
+ ruby_version: << parameters.ruby_version >>
83
+ rails_version: << parameters.rails_version >>
89
84
  - run:
90
85
  name: Wait for Solr
91
- command: dockerize -wait tcp://localhost:8983 -timeout 1m
86
+ command: dockerize -wait tcp://localhost:<<parameters.solr_port>> -timeout 1m
92
87
  - run:
93
88
  name: Load config into solr
94
89
  command: |
95
90
  cd .internal_test_app/solr/conf
96
91
  zip -1 -r solr_config.zip ./*
97
92
  curl -H "Content-type:application/octet-stream" --data-binary @solr_config.zip "http://localhost:8983/solr/admin/configs?action=UPLOAD&name=solrconfig"
98
- curl -H 'Content-type: application/json' http://localhost:8983/api/collections/ -d '{create: {name: blacklight-core, config: solrconfig, numShards: 1}}'
93
+ curl -H 'Content-type: application/json' http://localhost:<<parameters.solr_port>>/api/collections/ -d '{create: {name: blacklight-core, config: solrconfig, numShards: 1}}'
99
94
  - run:
100
95
  name: Seed Solr
101
96
  command: |
102
97
  cd .internal_test_app
98
+ bundle check || bundle install
103
99
  bundle exec rake geoblacklight:index:seed
104
100
  bundle exec rake geoblacklight:downloads:mkdir
101
+ - when:
102
+ condition: <<parameters.coverage>>
103
+ steps:
104
+ - run:
105
+ name: Ensure simplecov is installed
106
+ command: gem install simplecov
107
+ - run:
108
+ name: Run the RSpec test suites
109
+ command: bundle exec rspec
110
+ - run:
111
+ name: Stash Coverage Results
112
+ command: |
113
+ cp -R coverage/ coverage_results/
114
+ cp -R coverage/ /tmp/coverage_results/
115
+ - persist_to_workspace:
116
+ root: '~/geoblacklight'
117
+ paths: 'coverage_results'
118
+ - store_artifacts:
119
+ path: /tmp/coverage_results/
120
+ - unless:
121
+ condition: <<parameters.coverage>>
122
+ steps:
123
+ - run:
124
+ name: Run the RSpec test suites
125
+ command: bundle exec rspec
105
126
  - run:
106
- name: Compile the assets for Webpack
107
- command: |
108
- cd .internal_test_app
109
- rm config/webpacker.yml
110
- bundle exec rails webpacker:install
111
- bundle exec rails webpacker:compile
112
- - run:
113
- name: Run the RSpec test suites
114
- command: bundle exec rake geoblacklight:coverage
115
- # Store bundle cache
116
- - type: cache-save
117
- name: Store bundle cache
118
- key: geoblacklight-bundle-5-1-7-{{ checksum "Gemfile" }}-{{ checksum "geoblacklight.gemspec" }}-3f5eff
119
- paths:
120
- - /home/circleci/geoblacklight/vendor/bundle
127
+ name: Run the Teaspoon test suites
128
+ command: bundle exec rake teaspoon
129
+
121
130
  rubocop:
122
131
  working_directory: ~/geoblacklight
132
+ parameters:
133
+ ruby_version:
134
+ type: string
135
+ default: '2.7.1'
136
+ rails_version:
137
+ type: string
138
+ default: '6.0.3.2'
123
139
  docker:
124
- - image: circleci/ruby:2.5.1-node-browsers
125
- environment:
126
- GEM_HOME: /home/circleci/geoblacklight/vendor/bundle
127
- BUNDLE_PATH: /home/circleci/geoblacklight/vendor/bundle
128
- RAILS_ENV: test
140
+ - image: circleci/ruby:<< parameters.ruby_version >>-node-browsers
141
+ environment:
142
+ GEM_HOME: /home/circleci/geoblacklight/vendor/bundle
143
+ BUNDLE_PATH: /home/circleci/geoblacklight/vendor/bundle
144
+ BUNDLE_JOBS: 4
145
+ BUNDLE_RETRY: 3
146
+ RAILS_ENV: test
147
+ RACK_ENV: test
148
+ RAILS_VERSION: <<parameters.rails_version>>
129
149
  steps:
130
150
  - checkout
131
- # Restore bundle cache
132
- - type: cache-restore
133
- name: Restore bundle cache
134
- key: geoblacklight-bundle-5-2-3-{{ checksum "geoblacklight.gemspec" }}-{{ checksum "Gemfile" }}-3f5eff
151
+ - restore_bundle_cache:
152
+ ruby_version: << parameters.ruby_version >>
153
+ rails_version: << parameters.rails_version >>
135
154
  # Install gems and run rubocop
136
155
  - run: bundle check || bundle install
137
156
  - run: bundle exec rake rubocop
157
+
158
+ coverage_report:
159
+ working_directory: ~/geoblacklight
160
+ parameters:
161
+ ruby_version:
162
+ type: string
163
+ default: '2.7.1'
164
+ rails_version:
165
+ type: string
166
+ default: '6.0.3.2'
167
+ docker:
168
+ - image: circleci/ruby:<< parameters.ruby_version >>-node-browsers
169
+ environment:
170
+ GEM_HOME: /home/circleci/geoblacklight/vendor/bundle
171
+ BUNDLE_PATH: /home/circleci/geoblacklight/vendor/bundle
172
+ BUNDLE_JOBS: 4
173
+ BUNDLE_RETRY: 3
174
+ RAILS_ENV: test
175
+ RACK_ENV: test
176
+ RAILS_VERSION: <<parameters.rails_version>>
177
+ steps:
178
+ - checkout
179
+ - attach_workspace:
180
+ at: '~/geoblacklight'
181
+ - restore_bundle_cache:
182
+ ruby_version: << parameters.ruby_version >>
183
+ rails_version: << parameters.rails_version >>
184
+ # Install gems and check coverage
185
+ - run: bundle check || bundle install
186
+ - run:
187
+ name: Merge and check coverage
188
+ command: |
189
+ RAILS_ENV=test bundle exec ruby ./bin/coverage.rb
190
+ - store_artifacts:
191
+ path: ~/geoblacklight/coverage
192
+ destination: coverage
193
+
138
194
  workflows:
139
- version: 2
140
- build_accept_deploy:
195
+ version: 2.1
196
+ build:
141
197
  jobs:
142
- - rails_5_2_3
143
- - rails_5_1_7
198
+ - build:
199
+ ruby_version: 2.7.1
200
+ rails_version: 6.0.3.2
201
+ coverage: true
202
+ name: "ruby2-7_rails6-0"
203
+ - build:
204
+ ruby_version: 2.6.6
205
+ rails_version: 6.0.3.2
206
+ name: "ruby2-6_rails6-0"
207
+ - build:
208
+ ruby_version: 2.7.1
209
+ rails_version: 5.2.4.3
210
+ name: "ruby2-7_rails5-2"
211
+ - build:
212
+ ruby_version: 2.6.6
213
+ rails_version: 5.2.4.3
214
+ name: "ruby2-6_rails5-2"
144
215
  - rubocop:
145
216
  requires:
146
- - rails_5_2_3
217
+ - ruby2-7_rails6-0
218
+ - coverage_report:
219
+ requires:
220
+ - ruby2-7_rails6-0
221
+ nightly:
222
+ triggers:
223
+ - schedule:
224
+ cron: "0 0 * * *"
225
+ filters:
226
+ branches:
227
+ only:
228
+ - master
229
+ jobs:
230
+ - build:
231
+ ruby_version: 2.7.1
232
+ rails_version: 6.0.3.2
233
+ coverage: true
234
+ name: "ruby2-7_rails6-0"
235
+ - build:
236
+ ruby_version: 2.6.6
237
+ rails_version: 6.0.3.2
238
+ name: "ruby2-6_rails6-0"
239
+ - build:
240
+ ruby_version: 2.7.1
241
+ rails_version: 5.2.4.3
242
+ name: "ruby2-7_rails5-2"
243
+ - build:
244
+ ruby_version: 2.6.6
245
+ rails_version: 5.2.4.3
246
+ name: "ruby2-6_rails5-2"
247
+ - rubocop:
248
+ requires:
249
+ - ruby2-7_rails6-0
250
+ - coverage_report:
251
+ requires:
252
+ - ruby2-7_rails6-0
data/.gitignore CHANGED
@@ -16,4 +16,6 @@ test/tmp
16
16
  test/version_tmp
17
17
  tmp
18
18
  jetty
19
- .internal_test_app
19
+ .internal_test_app
20
+ # Ignore byebug history
21
+ .byebug_history
@@ -9,17 +9,16 @@ Rails:
9
9
  Enabled: true
10
10
 
11
11
  AllCops:
12
- TargetRubyVersion: 2.3
12
+ TargetRubyVersion: 2.7
13
13
  DisplayCopNames: true
14
- Include:
15
- - '**/Rakefile'
16
14
  Exclude:
17
- - 'db/**/*'
18
- - 'vendor/**/*'
19
15
  - '.internal_test_app/**/*'
20
- - 'lib/generators/geoblacklight/templates/**/*'
16
+ - 'db/**/*'
21
17
  - 'geoblacklight.gemspec'
22
18
  - 'Gemfile'
19
+ - 'lib/generators/geoblacklight/templates/**/*'
20
+ - 'tmp/**/*'
21
+ - 'vendor/**/*'
23
22
 
24
23
  Layout/DotPosition:
25
24
  Description: Checks the position of the dot in multi-line method calls.
@@ -30,21 +29,26 @@ Layout/DotPosition:
30
29
  - leading
31
30
  - trailing
32
31
 
33
- Metrics/BlockLength:
32
+ Layout/LineLength:
33
+ Max: 115
34
34
  Exclude:
35
- - 'spec/helpers/geoblacklight_helper_spec.rb'
36
-
37
- Metrics/LineLength:
38
- Max: 100
39
- Exclude:
40
- - 'spec/**/*'
41
- - 'Rakefile'
35
+ - 'app/models/concerns/geoblacklight/spatial_search_behavior.rb'
36
+ - 'bin/coverage.rb'
42
37
  - 'lib/generators/geoblacklight/install_generator.rb'
43
38
  - 'lib/tasks/geoblacklight.rake'
44
- - 'app/models/concerns/geoblacklight/spatial_search_behavior.rb'
39
+ - 'Rakefile'
40
+ - 'spec/**/*'
41
+
42
+ Metrics/BlockLength:
43
+ Exclude:
44
+ - 'lib/tasks/geoblacklight.rake'
45
+ - 'Rakefile'
46
+ - 'spec/**/*'
45
47
 
46
48
  Metrics/MethodLength:
47
49
  Max: 16
50
+ Exclude:
51
+ - 'lib/geoblacklight/metadata/base.rb'
48
52
 
49
53
  Metrics/ModuleLength:
50
54
  Exclude:
@@ -1,58 +1,11 @@
1
1
  # This configuration was generated by
2
2
  # `rubocop --auto-gen-config`
3
- # on 2018-12-21 14:41:38 -0700 using RuboCop version 0.52.1.
3
+ # on 2020-08-07 13:49:06 -0500 using RuboCop version 0.85.1.
4
4
  # The point is for the user to remove these configuration records
5
5
  # one by one as the offenses are removed from the code base.
6
6
  # Note that changes in the inspected code, or installation of new
7
7
  # versions of RuboCop, may require this file to be generated again.
8
8
 
9
- # Offense count: 16
10
- # Cop supports --auto-correct.
11
- # Configuration parameters: Width, IgnoredPatterns.
12
- Layout/IndentationWidth:
13
- Exclude:
14
- - 'app/controllers/download_controller.rb'
15
- - 'app/controllers/relation_controller.rb'
16
- - 'app/controllers/wms_controller.rb'
17
- - 'app/helpers/carto_helper.rb'
18
- - 'app/models/concerns/geoblacklight/solr_document.rb'
19
- - 'app/models/concerns/geoblacklight/solr_document/finder.rb'
20
- - 'lib/geoblacklight/bounding_box.rb'
21
- - 'lib/geoblacklight/download.rb'
22
- - 'lib/geoblacklight/metadata/base.rb'
23
- - 'lib/geoblacklight/metadata/fgdc.rb'
24
- - 'lib/geoblacklight/metadata/iso19139.rb'
25
- - 'lib/geoblacklight/metadata_transformer/base.rb'
26
- - 'lib/geoblacklight/reference.rb'
27
- - 'lib/geoblacklight/references.rb'
28
- - 'lib/tasks/geoblacklight.rake'
29
-
30
- # Offense count: 1
31
- # Cop supports --auto-correct.
32
- # Configuration parameters: AllowForAlignment.
33
- Layout/SpaceBeforeFirstArg:
34
- Exclude:
35
- - 'app/views/relation/index.json.jbuilder'
36
-
37
- # Offense count: 1
38
- # Cop supports --auto-correct.
39
- # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
40
- Lint/UnusedBlockArgument:
41
- Exclude:
42
- - 'lib/tasks/geoblacklight.rake'
43
-
44
- # Offense count: 46
45
- # Configuration parameters: CountComments, ExcludedMethods.
46
- Metrics/BlockLength:
47
- Max: 227
48
-
49
- # Offense count: 1
50
- # Cop supports --auto-correct.
51
- # Configuration parameters: AutoCorrect.
52
- Performance/HashEachMethods:
53
- Exclude:
54
- - 'app/presenters/geoblacklight/document_presenter.rb'
55
-
56
9
  # Offense count: 2
57
10
  # Configuration parameters: CustomIncludeMethods.
58
11
  RSpec/EmptyExampleGroup:
@@ -60,29 +13,14 @@ RSpec/EmptyExampleGroup:
60
13
  - 'spec/views/catalog/_document_split.html.erb_spec.rb'
61
14
  - 'spec/views/catalog/_index_split.html.erb_spec.rb'
62
15
 
63
- # Offense count: 1
64
- # Configuration parameters: EnforcedStyle.
65
- # SupportedStyles: implicit, each, example
66
- RSpec/HookArgument:
67
- Exclude:
68
- - 'spec/spec_helper.rb'
69
-
70
- # Offense count: 8
71
- RSpec/LeadingSubject:
72
- Exclude:
73
- - 'spec/lib/geoblacklight/document_presenter_spec.rb'
74
- - 'spec/lib/geoblacklight/metadata_transformer/base_spec.rb'
75
- - 'spec/lib/geoblacklight/metadata_transformer/fgdc_spec.rb'
76
- - 'spec/lib/geoblacklight/metadata_transformer/iso19139_spec.rb'
77
- - 'spec/lib/geoblacklight/metadata_transformer_spec.rb'
78
-
79
- # Offense count: 49
16
+ # Offense count: 48
80
17
  # Configuration parameters: .
81
18
  # SupportedStyles: have_received, receive
82
19
  RSpec/MessageSpies:
83
20
  EnforcedStyle: receive
84
21
 
85
- # Offense count: 24
22
+ # Offense count: 29
23
+ # Configuration parameters: IgnoreSharedExamples.
86
24
  RSpec/NamedSubject:
87
25
  Exclude:
88
26
  - 'spec/lib/geoblacklight/metadata/base_spec.rb'
@@ -93,65 +31,45 @@ RSpec/NamedSubject:
93
31
  - 'spec/models/concerns/geoblacklight/solr_document/inspection_spec.rb'
94
32
  - 'spec/models/concerns/geoblacklight/spatial_search_behavior_spec.rb'
95
33
 
96
- # Offense count: 6
97
- RSpec/RepeatedDescription:
98
- Exclude:
99
- - 'spec/features/esri_viewer_spec.rb'
100
- - 'spec/features/search_results_map_spec.rb'
101
- - 'spec/lib/geoblacklight/references_spec.rb'
102
-
103
- # Offense count: 2
104
- RSpec/RepeatedExample:
105
- Exclude:
106
- - 'spec/features/esri_viewer_spec.rb'
107
-
108
- # Offense count: 2
34
+ # Offense count: 4
109
35
  RSpec/SubjectStub:
110
36
  Exclude:
37
+ - 'spec/models/concerns/geoblacklight/solr_document/inspection_spec.rb'
111
38
  - 'spec/models/concerns/geoblacklight/spatial_search_behavior_spec.rb'
112
39
 
113
- # Offense count: 7
114
- Rails/FilePath:
115
- Exclude:
116
- - 'lib/geoblacklight/download.rb'
117
- - 'lib/tasks/geoblacklight.rake'
118
- - 'spec/lib/geoblacklight/download_spec.rb'
119
- - 'spec/lib/geoblacklight/metadata_transformer/fgdc_spec.rb'
120
- - 'spec/lib/geoblacklight/metadata_transformer/iso19139_spec.rb'
40
+ # Offense count: 9
41
+ # Configuration parameters: EnforcedStyle.
42
+ # SupportedStyles: slashes, arguments
43
+ # Rails/FilePath:
44
+ # Exclude:
45
+ # - 'lib/geoblacklight/download.rb'
46
+ # - 'lib/tasks/geoblacklight.rake'
47
+ # - 'spec/lib/geoblacklight/download_spec.rb'
48
+ # - 'spec/lib/geoblacklight/metadata_transformer/fgdc_spec.rb'
49
+ # - 'spec/lib/geoblacklight/metadata_transformer/iso19139_spec.rb'
50
+ # - 'spec/tasks/geoblacklight_spec.rb'
121
51
 
122
- # Offense count: 7
52
+ # Offense count: 6
123
53
  Rails/OutputSafety:
124
54
  Exclude:
125
55
  - 'app/controllers/download_controller.rb'
126
56
  - 'app/helpers/geoblacklight_helper.rb'
127
- - 'lib/geoblacklight/view_helper_override.rb'
128
57
 
129
- # Offense count: 1
58
+ # Offense count: 6
130
59
  # Cop supports --auto-correct.
131
- Style/ColonMethodCall:
60
+ # Configuration parameters: Include.
61
+ # Include: **/Rakefile, **/*.rake
62
+ Rails/RakeEnvironment:
132
63
  Exclude:
64
+ - 'lib/capistrano/tasks/**/*.rake'
65
+ - 'Rakefile'
133
66
  - 'lib/tasks/geoblacklight.rake'
134
67
 
135
68
  # Offense count: 1
136
- # Cop supports --auto-correct.
137
- # Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions.
138
- # SupportedStyles: assign_to_condition, assign_inside_condition
139
- Style/ConditionalAssignment:
69
+ # Configuration parameters: MinBodyLength.
70
+ Style/GuardClause:
140
71
  Exclude:
141
- - 'app/controllers/download_controller.rb'
142
-
143
- # Offense count: 2
144
- # Cop supports --auto-correct.
145
- Style/EmptyLiteral:
146
- Exclude:
147
- - 'spec/models/concerns/geoblacklight/spatial_search_behavior_spec.rb'
148
-
149
- # Offense count: 128
150
- # Cop supports --auto-correct.
151
- # Configuration parameters: EnforcedStyle.
152
- # SupportedStyles: when_needed, always, never
153
- Style/FrozenStringLiteralComment:
154
- Enabled: false
72
+ - 'lib/generators/geoblacklight/assets_generator.rb'
155
73
 
156
74
  # Offense count: 3
157
75
  # Cop supports --auto-correct.
@@ -162,56 +80,7 @@ Style/HashSyntax:
162
80
  - 'lib/tasks/geoblacklight.rake'
163
81
 
164
82
  # Offense count: 2
165
- Style/MethodMissing:
83
+ Style/MissingRespondToMissing:
166
84
  Exclude:
167
85
  - 'app/models/concerns/geoblacklight/solr_document.rb'
168
86
  - 'lib/geoblacklight/references.rb'
169
-
170
- # Offense count: 2
171
- # Cop supports --auto-correct.
172
- Style/MultilineIfModifier:
173
- Exclude:
174
- - 'app/helpers/geoblacklight_helper.rb'
175
- - 'lib/geoblacklight/references.rb'
176
-
177
- # Offense count: 2
178
- # Cop supports --auto-correct.
179
- # Configuration parameters: AutoCorrect, EnforcedStyle.
180
- # SupportedStyles: predicate, comparison
181
- Style/NumericPredicate:
182
- Exclude:
183
- - 'spec/**/*'
184
- - 'lib/geoblacklight/relation/relation_response.rb'
185
-
186
- # Offense count: 11
187
- # Cop supports --auto-correct.
188
- # Configuration parameters: PreferredDelimiters.
189
- Style/PercentLiteralDelimiters:
190
- Exclude:
191
- - 'app/models/concerns/geoblacklight/solr_document/inspection.rb'
192
- - 'spec/helpers/geoblacklight_helper_spec.rb'
193
- - 'spec/lib/geoblacklight/document_presenter_spec.rb'
194
- - 'spec/lib/geoblacklight/references_spec.rb'
195
- - 'spec/lib/geoblacklight/wms_layer/feature_info_response_spec.rb'
196
- - 'spec/spec_helper.rb'
197
-
198
- # Offense count: 1
199
- # Cop supports --auto-correct.
200
- # Configuration parameters: ConvertCodeThatCanStartToReturnNil.
201
- Style/SafeNavigation:
202
- Exclude:
203
- - 'app/models/concerns/geoblacklight/solr_document.rb'
204
-
205
- # Offense count: 5
206
- # Cop supports --auto-correct.
207
- # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
208
- # SupportedStyles: single_quotes, double_quotes
209
- Style/StringLiterals:
210
- Exclude:
211
- - 'lib/tasks/geoblacklight.rake'
212
-
213
- # Offense count: 1
214
- # Cop supports --auto-correct.
215
- Style/UnneededInterpolation:
216
- Exclude:
217
- - 'lib/tasks/geoblacklight.rake'