geoblacklight 1.8.0 → 1.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5e4a028e9501e7fe556242ab6993d8ef4deb6e41
-  data.tar.gz: 516f09eb7667c35fd049df03eb7cd06c5f816197
+  metadata.gz: b40275fe73ab76d4f9baa4096284ead710146ddf
+  data.tar.gz: ed87385adb85bdee4d8e0cab05a0ce23bae2fcd2
 SHA512:
-  metadata.gz: 59ec664c8312dae3934b7db59546e17dcf520ed5b9fc6a5724bd303d05352a34891326007742562d7326ae5e32c0cd208570d602cb042ae2af359a75eb930ed4
-  data.tar.gz: 91bfb680d29a94bedc3b596a533054c6a72b06e5e0cb0b0a8ca09541466cdf32fe2a4203c35c95b03bceffc3d7ee750af6e1206649f11b39bac9701af3e1924b
+  metadata.gz: 96341b99c1fe404cb28053c0aa86d06ff67a29aab1c6d36cbf9f180547e7219fe1b1b58892cfaa2e9725fc45a14eb149cf4c774e64926aeebc0375a4ac63b4b4
+  data.tar.gz: e1657c181c8409c75728963b39eaddab110d0d9df79c72b9fa8fa59ca14f4d5260c69d29c23e8a0b2208fbf6681643cd5df35babd2fa586b2043e39eeb5da824

data/.circleci/config.yml

@@ -0,0 +1,109 @@
+---
+version: 2
+jobs:
+  rails_5_2_0:
+    working_directory: ~/geoblacklight
+    docker:
+      - image: circleci/ruby:2.5.1-node-browsers
+        environment:
+          BUNDLE_JOBS: 3
+          BUNDLE_RETRY: 3
+          # We need both GEM_HOME and BUNDLE_PATH because of the test app
+          GEM_HOME: /home/circleci/geoblacklight/vendor/bundle
+          BUNDLE_PATH: /home/circleci/geoblacklight/vendor/bundle
+          CI: true
+          RAILS_ENV: test
+          RAILS_VERSION: 5.2.0
+    steps:
+      - checkout
+      # Restore bundle cache
+      - type: cache-restore
+        name: Restore bundle cache
+        key: geoblacklight-bundle-5-2-0-{{ checksum "geoblacklight.gemspec" }}-{{ checksum "Gemfile" }}-3f5eff
+      # Install gems
+      - run: bundle check || bundle install
+      # Restore cached Solr
+      - type: cache-restore
+        name: Restore solr cache
+        key: geoblacklight-solr{{ checksum ".solr_wrapper" }}
+      # Run solr wrapper, which downloads correct solr version if not cached
+      - run: bundle exec rake solr:clean
+      # Cache Solr
+      - type: cache-save
+        name: Store solr cache
+        key: geoblacklight-solr{{ checksum ".solr_wrapper" }}
+        paths:
+          - tmp/solr
+      # Run specs
+      - run: bundle exec rake ci
+      # Store bundle cache
+      - type: cache-save
+        name: Store bundle cache
+        key: geoblacklight-bundle-5-2-0-{{ checksum "geoblacklight.gemspec" }}-{{ checksum "Gemfile" }}-3f5eff
+        paths:
+          - /home/circleci/geoblacklight/vendor/bundle
+  rails_5_1_6:
+    working_directory: ~/geoblacklight
+    docker:
+      - image: circleci/ruby:2.4.4-node-browsers
+        environment:
+          BUNDLE_JOBS: 3
+          BUNDLE_RETRY: 3
+          GEM_HOME: /home/circleci/geoblacklight/vendor/bundle
+          BUNDLE_PATH: /home/circleci/geoblacklight/vendor/bundle
+          RAILS_ENV: test
+          RAILS_VERSION: 5.1.6
+    steps:
+      - checkout
+      # Restore bundle cache
+      - type: cache-restore
+        name: Restore bundle cache
+        key: geoblacklight-bundle-5-1-6-{{ checksum "Gemfile" }}-{{ checksum "geoblacklight.gemspec" }}-3f5eff
+      # Install gems and run specs
+      - run: bundle check || bundle install
+      # Restore cached Solr
+      - type: cache-restore
+        name: Restore solr cache
+        key: geoblacklight-solr{{ checksum ".solr_wrapper" }}
+      # Run solr wrapper, which downloads correct solr version if not cached
+      - run: bundle exec rake solr:clean
+      # Cache Solr
+      - type: cache-save
+        name: Store solr cache
+        key: geoblacklight-solr{{ checksum ".solr_wrapper" }}
+        paths:
+          - tmp/solr
+      # Run specs
+      - run: bundle exec rake ci
+      # Store bundle cache
+      - type: cache-save
+        name: Store bundle cache
+        key: geoblacklight-bundle-5-1-6-{{ checksum "Gemfile" }}-{{ checksum "geoblacklight.gemspec" }}-3f5eff
+        paths:
+          - /home/circleci/geoblacklight/vendor/bundle
+  rubocop:
+    working_directory: ~/geoblacklight
+    docker:
+      - image: circleci/ruby:2.5.1-node-browsers
+        environment:
+          GEM_HOME: /home/circleci/geoblacklight/vendor/bundle
+          BUNDLE_PATH: /home/circleci/geoblacklight/vendor/bundle
+          RAILS_ENV: test
+    steps:
+      - checkout
+      # Restore bundle cache
+      - type: cache-restore
+        name: Restore bundle cache
+        key: geoblacklight-bundle-5-2-0-{{ checksum "geoblacklight.gemspec" }}-{{ checksum "Gemfile" }}-3f5eff
+      # Install gems and run rubocop
+      - run: bundle check || bundle install
+      - run: bundle exec rake rubocop
+workflows:
+  version: 2
+  build_accept_deploy:
+    jobs:
+      - rails_5_2_0
+      - rails_5_1_6
+      - rubocop:
+          requires:
+            - rails_5_2_0

data/.rubocop.yml

@@ -1,17 +1,37 @@
+require: rubocop-rspec
+
+inherit_gem:
+  bixby: bixby_default.yml
+
+inherit_from: .rubocop_todo.yml
+
 Rails:
   Enabled: true
 
 AllCops:
   DisplayCopNames: true
-
   Include:
   - '**/Rakefile'
-
   Exclude:
   - 'db/**/*'
   - 'vendor/**/*'
   - '.internal_test_app/**/*'
   - 'lib/generators/geoblacklight/templates/**/*'
+  - 'geoblacklight.gemspec'
+  - 'Gemfile'
+
+Layout/DotPosition:
+  Description: Checks the position of the dot in multi-line method calls.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#consistent-multi-line-chains
+  Enabled: true
+  EnforcedStyle: leading
+  SupportedStyles:
+  - leading
+  - trailing
+
+Metrics/BlockLength:
+  Exclude:
+  - 'spec/helpers/geoblacklight_helper_spec.rb'
 
 Metrics/LineLength:
   Max: 100
@@ -19,37 +39,58 @@ Metrics/LineLength:
   - 'spec/**/*'
   - 'Rakefile'
   - 'lib/generators/geoblacklight/install_generator.rb'
-
-# TODO: Refactor large methods.
-Metrics/AbcSize:
-  Max: 23
+  - 'lib/tasks/geoblacklight.rake'
 
 Metrics/MethodLength:
   Max: 16
 
+Metrics/ModuleLength:
+  Exclude:
+  - 'app/helpers/geoblacklight_helper.rb'
+
 # TODO: Add top-level class and module documentation.
 Style/Documentation:
   Enabled: false
 
 # Overrides method in blacklight. Must use method name.
-Style/PredicateName:
+Naming/PredicateName:
   Exclude:
     - 'lib/geoblacklight/view_helper_override.rb'
 
-RSpec/FilePath:
-  Enabled: false
+# geoblacklight references in solr_document_spec are
+# difficult to mock because of the use of 'method_missing'.
+# https://relishapp.com/rspec/rspec-mocks/docs/verifying-doubles/dynamic-classes
+RSpec/AnyInstance:
+  Exclude:
+    - 'spec/models/concerns/geoblacklight/solr_document_spec.rb'
+    - 'spec/helpers/geoblacklight_helper_spec.rb'
+    - 'spec/models/concerns/geoblacklight/solr_document/finder_spec.rb'
 
 # Rubocop bug causes view specs to fail.
 #  https://github.com/nevir/rubocop-rspec/issues/47
 RSpec/DescribeClass:
   Enabled: false
 
-# geoblacklight references in solr_document_spec are
-# difficult to mock because of the use of 'method_missing'.
-# https://relishapp.com/rspec/rspec-mocks/docs/verifying-doubles/dynamic-classes
-RSpec/AnyInstance:
+RSpec/ExampleLength:
   Exclude:
-    - 'spec/models/concerns/geoblacklight/solr_document_spec.rb'
+    - 'spec/views/catalog/_show_downloads.html.erb_spec.rb'
+    - 'spec/features/download_layer_spec.rb'
+    - 'spec/features/home_page_spec.rb'
+    - 'spec/features/index_map_spec.rb'
+    - 'spec/features/metadata_panel_spec.rb'
+    - 'spec/features/saved_searches_spec.rb'
+    - 'spec/features/search_results_map_spec.rb'
+    - 'spec/features/show_page_metadata_spec.rb'
+    - 'spec/features/split_view.html.erb_spec.rb'
+    - 'spec/features/web_services_modal_spec.rb'
+    - 'spec/helpers/geoblacklight_helper_spec.rb'
+    - 'spec/models/concerns/geoblacklight/solr_document/carto_spec.rb'
+    - 'spec/models/concerns/geoblacklight/solr_document/finder_spec.rb'
+
+RSpec/VerifiedDoubles:
+  Exclude:
+    - 'spec/lib/geoblacklight/download/hgl_download_spec.rb'
+    - 'spec/lib/geoblacklight/document_presenter_spec.rb'
 
 Style/SignalException:
   EnforcedStyle: semantic
@@ -59,13 +100,3 @@ Style/StringLiterals:
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#consistent-string-literals
   Enabled: true
   EnforcedStyle: single_quotes
-
-Style/DotPosition:
-  Description: Checks the position of the dot in multi-line method calls.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#consistent-multi-line-chains
-  Enabled: true
-  EnforcedStyle: leading
-  SupportedStyles:
-  - leading
-  - trailing
-

data/.rubocop_todo.yml

@@ -0,0 +1,214 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2018-07-24 14:15:32 -0500 using RuboCop version 0.52.1.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 17
+# Cop supports --auto-correct.
+# Configuration parameters: Width, IgnoredPatterns.
+Layout/IndentationWidth:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AllowForAlignment.
+Layout/SpaceBeforeFirstArg:
+  Exclude:
+    - 'app/views/relation/index.json.jbuilder'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
+Lint/UnusedBlockArgument:
+  Exclude:
+    - 'lib/tasks/geoblacklight.rake'
+
+# Offense count: 37
+# Configuration parameters: CountComments, ExcludedMethods.
+Metrics/BlockLength:
+  Max: 227
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect.
+Performance/HashEachMethods:
+  Exclude:
+    - 'app/presenters/geoblacklight/document_presenter.rb'
+
+# Offense count: 2
+# Configuration parameters: CustomIncludeMethods.
+RSpec/EmptyExampleGroup:
+  Exclude:
+    - 'spec/views/catalog/_document_split.html.erb_spec.rb'
+    - 'spec/views/catalog/_index_split.html.erb_spec.rb'
+
+# Offense count: 24
+# Configuration parameters: Max.
+RSpec/ExampleLength:
+  Exclude:
+    - 'spec/features/download_layer_spec.rb'
+    - 'spec/features/home_page_spec.rb'
+    - 'spec/features/index_map_spec.rb'
+    - 'spec/features/metadata_panel_spec.rb'
+    - 'spec/features/saved_searches_spec.rb'
+    - 'spec/features/search_results_map_spec.rb'
+    - 'spec/features/show_page_metadata_spec.rb'
+    - 'spec/features/split_view.html.erb_spec.rb'
+    - 'spec/features/web_services_modal_spec.rb'
+    - 'spec/helpers/geoblacklight_helper_spec.rb'
+    - 'spec/models/concerns/geoblacklight/solr_document/carto_spec.rb'
+    - 'spec/models/concerns/geoblacklight/solr_document/finder_spec.rb'
+    - 'spec/views/catalog/_downloads.html.erb_spec.rb'
+
+# Offense count: 2
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: implicit, each, example
+RSpec/HookArgument:
+  Exclude:
+    - 'spec/spec_helper.rb'
+    - 'spec/views/catalog/_downloads.html.erb_spec.rb'
+
+# Offense count: 9
+RSpec/LeadingSubject:
+  Exclude:
+    - 'spec/lib/geoblacklight/document_presenter_spec.rb'
+    - 'spec/lib/geoblacklight/metadata_transformer/base_spec.rb'
+    - 'spec/lib/geoblacklight/metadata_transformer/fgdc_spec.rb'
+    - 'spec/lib/geoblacklight/metadata_transformer/iso19139_spec.rb'
+    - 'spec/lib/geoblacklight/metadata_transformer_spec.rb'
+    - 'spec/models/concerns/geoblacklight/spatial_search_behavior_spec.rb'
+
+# Offense count: 58
+# Configuration parameters: .
+# SupportedStyles: have_received, receive
+RSpec/MessageSpies:
+  EnforcedStyle: receive
+
+# Offense count: 38
+RSpec/NamedSubject:
+  Exclude:
+    - 'spec/lib/geoblacklight/metadata/base_spec.rb'
+    - 'spec/lib/geoblacklight/metadata_transformer/base_spec.rb'
+    - 'spec/lib/geoblacklight/metadata_transformer/fgdc_spec.rb'
+    - 'spec/lib/geoblacklight/metadata_transformer/iso19139_spec.rb'
+    - 'spec/lib/geoblacklight/metadata_transformer_spec.rb'
+    - 'spec/models/concerns/geoblacklight/solr_document/carto_spec.rb'
+    - 'spec/models/concerns/geoblacklight/solr_document/finder_spec.rb'
+    - 'spec/models/concerns/geoblacklight/solr_document/inspection_spec.rb'
+    - 'spec/models/concerns/geoblacklight/spatial_search_behavior_spec.rb'
+
+# Offense count: 6
+RSpec/RepeatedDescription:
+  Exclude:
+    - 'spec/features/esri_viewer_spec.rb'
+    - 'spec/features/search_results_map_spec.rb'
+    - 'spec/lib/geoblacklight/references_spec.rb'
+
+# Offense count: 2
+RSpec/RepeatedExample:
+  Exclude:
+    - 'spec/features/esri_viewer_spec.rb'
+
+# Offense count: 1
+RSpec/SubjectStub:
+  Exclude:
+    - 'spec/models/concerns/geoblacklight/spatial_search_behavior_spec.rb'
+
+# Offense count: 12
+# Configuration parameters: IgnoreSymbolicNames.
+RSpec/VerifiedDoubles:
+  Exclude:
+    - 'spec/helpers/geoblacklight_helper_spec.rb'
+    - 'spec/lib/geoblacklight/document_presenter_spec.rb'
+    - 'spec/lib/geoblacklight/download_spec.rb'
+    - 'spec/lib/geoblacklight/geoblacklight_helper_behavior_spec.rb'
+    - 'spec/lib/geoblacklight/wms_layer_spec.rb'
+    - 'spec/models/concerns/geoblacklight/solr_document/finder_spec.rb'
+    - 'spec/models/concerns/geoblacklight/spatial_search_behavior_spec.rb'
+    - 'spec/views/catalog/_downloads.html.erb_spec.rb'
+
+# Offense count: 7
+Rails/FilePath:
+  Exclude:
+    - 'lib/geoblacklight/download.rb'
+    - 'lib/tasks/geoblacklight.rake'
+    - 'spec/lib/geoblacklight/download_spec.rb'
+    - 'spec/lib/geoblacklight/metadata_transformer/fgdc_spec.rb'
+    - 'spec/lib/geoblacklight/metadata_transformer/iso19139_spec.rb'
+
+# Offense count: 6
+Rails/OutputSafety:
+  Exclude:
+    - 'app/controllers/download_controller.rb'
+    - 'app/helpers/geoblacklight_helper.rb'
+    - 'lib/geoblacklight/view_helper_override.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/ColonMethodCall:
+  Exclude:
+    - 'lib/tasks/geoblacklight.rake'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions.
+# SupportedStyles: assign_to_condition, assign_inside_condition
+Style/ConditionalAssignment:
+  Exclude:
+    - 'app/controllers/download_controller.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/EmptyLiteral:
+  Exclude:
+    - 'spec/models/concerns/geoblacklight/spatial_search_behavior_spec.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
+# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
+Style/HashSyntax:
+  Exclude:
+    - 'lib/tasks/geoblacklight.rake'
+
+# Offense count: 2
+Style/MethodMissing:
+  Exclude:
+    - 'app/models/concerns/geoblacklight/solr_document.rb'
+    - 'lib/geoblacklight/references.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/MultilineIfModifier:
+  Exclude:
+    - 'lib/geoblacklight/references.rb'
+
+# Offense count: 12
+# Cop supports --auto-correct.
+# Configuration parameters: PreferredDelimiters.
+Style/PercentLiteralDelimiters:
+  Exclude:
+    - 'app/models/concerns/geoblacklight/solr_document/inspection.rb'
+    - 'spec/helpers/geoblacklight_helper_spec.rb'
+    - 'spec/lib/geoblacklight/document_presenter_spec.rb'
+    - 'spec/lib/geoblacklight/references_spec.rb'
+    - 'spec/lib/geoblacklight/wms_layer/feature_info_response_spec.rb'
+    - 'spec/models/concerns/geoblacklight/solr_document/finder_spec.rb'
+    - 'spec/spec_helper.rb'
+
+# Offense count: 5
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
+# SupportedStyles: single_quotes, double_quotes
+Style/StringLiterals:
+  Exclude:
+    - 'lib/tasks/geoblacklight.rake'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/UnneededInterpolation:
+  Exclude:
+    - 'lib/tasks/geoblacklight.rake'