RubyGems - geoblacklight - Versions diffs - 1.5.1 → 1.6.0 - Mend

geoblacklight 1.5.1 → 1.6.0

Files changed (61) hide show

checksums.yaml +4 -4
data/.travis.yml +7 -3
data/app/assets/javascripts/geoblacklight/geoblacklight.js +1 -1
data/app/assets/javascripts/geoblacklight/modules/metadata.js +7 -0
data/app/assets/javascripts/geoblacklight/modules/metadata_download_button.js +58 -0
data/app/assets/javascripts/geoblacklight/modules/results.js +10 -15
data/app/assets/stylesheets/geoblacklight/_geoblacklight.scss +3 -2
data/app/assets/stylesheets/geoblacklight/modules/metadata.scss +27 -3
data/app/assets/stylesheets/geoblacklight/modules/metadata_content.scss +38 -0
data/app/assets/stylesheets/geoblacklight/modules/metadata_markup.scss +9 -0
data/app/assets/stylesheets/geoblacklight/modules/metadata_missing.scss +7 -0
data/app/helpers/geoblacklight_helper.rb +24 -0
data/app/presenters/geoblacklight/document_presenter.rb +2 -1
data/app/views/catalog/_metadata.html.erb +21 -6
data/app/views/catalog/metadata/_content.html.erb +3 -0
data/app/views/catalog/metadata/_markup.html.erb +8 -0
data/app/views/catalog/metadata/_missing.html.erb +6 -0
data/app/views/catalog/metadata.js.erb +8 -4
data/config/locales/geoblacklight.en.yml +1 -0
data/geoblacklight.gemspec +4 -1
data/lib/generators/geoblacklight/templates/settings.yml +2 -2
data/lib/geoblacklight/engine.rb +2 -1
data/lib/geoblacklight/metadata/base.rb +88 -0
data/lib/geoblacklight/metadata/fgdc.rb +14 -0
data/lib/geoblacklight/metadata/iso19139.rb +14 -0
data/lib/geoblacklight/metadata.rb +12 -31
data/lib/geoblacklight/metadata_transformer/base.rb +49 -0
data/lib/geoblacklight/metadata_transformer/fgdc.rb +16 -0
data/lib/geoblacklight/metadata_transformer/iso19139.rb +16 -0
data/lib/geoblacklight/metadata_transformer.rb +33 -0
data/lib/geoblacklight/references.rb +14 -0
data/lib/geoblacklight/version.rb +1 -1
data/lib/geoblacklight/view_helper_override.rb +3 -2
data/lib/geoblacklight.rb +7 -0
data/spec/features/download_layer_spec.rb +5 -2
data/spec/features/layer_inspection_spec.rb +1 -1
data/spec/features/metadata_panel_spec.rb +15 -4
data/spec/features/saved_searches_spec.rb +1 -1
data/spec/features/split_view.html.erb_spec.rb +2 -2
data/spec/fixtures/solr_documents/harvard_raster.json +2 -2
data/spec/fixtures/solr_documents/public_iiif_princeton.json +1 -1
data/spec/helpers/{geoblacklight_helpers_spec.rb → geoblacklight_helper_spec.rb} +54 -0
data/spec/javascripts/geoblacklight_spec.js +4 -0
data/spec/javascripts/metadata_download_button_spec.js +14 -0
data/spec/lib/geoblacklight/metadata/base_spec.rb +85 -0
data/spec/lib/geoblacklight/metadata_spec.rb +26 -18
data/spec/lib/geoblacklight/metadata_transformer/base_spec.rb +35 -0
data/spec/lib/geoblacklight/metadata_transformer/fgdc_spec.rb +23 -0
data/spec/lib/geoblacklight/metadata_transformer/iso19139_spec.rb +23 -0
data/spec/lib/geoblacklight/metadata_transformer_spec.rb +69 -0
data/spec/lib/geoblacklight/references_spec.rb +12 -1
data/spec/lib/geoblacklight/view_helper_override_spec.rb +1 -0
data/spec/spec_helper.rb +11 -8
data/spec/test_app_templates/lib/generators/test_app_generator.rb +2 -0
data/spec/test_app_templates/metadata/fgdc.html +129 -0
data/spec/test_app_templates/metadata/fgdc.xml +145 -0
data/spec/test_app_templates/metadata/iso.html +275 -0
data/spec/test_app_templates/metadata/iso.xml +511 -0
data/spec/test_app_templates/solr_documents +1 -1
metadata +83 -7
data/app/assets/stylesheets/geoblacklight/modules/coderay.scss +0 -147

data/lib/geoblacklight/metadata_transformer/base.rb ADDED Viewed

@@ -0,0 +1,49 @@
+module Geoblacklight
+  module MetadataTransformer
+    ##
+    # Abstract class for transforming geospatial metadata
+    class Base
+      ##
+      # @param [GeoCombine::Metadata] metadata metadata Object
+      # @see GeoCombine::Metadata
+      def initialize(metadata)
+        @metadata = metadata
+        # Access the Nokogiri::XML Document from the metadata Object
+        fail EmptyMetadataError, 'Failed to retrieve the metadata' if @metadata.blank?
+      end
+      ##
+      # Returns HTML for the metadata transformed into HTML using GeoCombine
+      # @see GeoCombine::Metadata#to_html
+      # @return [String] the transformed metadata in the HTML
+      def transform
+        cleaned_metadata.to_html
+      rescue => e
+        raise TransformError, e.message
+      end
+      private
+      ##
+      # Clean top-level HTML elements from GeoCombine HTML Documents (e. g. <html> and <body>)
+      # @return [Nokogiri::XML::Document] the Nokogiri XML Document for the cleaned HTML
+      def cleaned_metadata
+        transformed_doc = Nokogiri::XML(@metadata.to_html)
+        if transformed_doc.xpath('//body').children.empty?
+          fail TransformError,\
+               'Failed to extract the <body> child elements from the transformed metadata'
+        end
+        transformed_doc.xpath('//body').children
+      rescue => e
+        raise TransformError, e.message
+      end
+      ##
+      # Retrieve the Class for the GeoCombine::Metadata instance
+      # @return [GeoCombine::Metadata]
+      def metadata_class
+        GeoCombine::Metadata
+      end
+    end
+  end
+end

data/lib/geoblacklight/metadata_transformer/fgdc.rb ADDED Viewed

@@ -0,0 +1,16 @@
+module Geoblacklight
+  module MetadataTransformer
+    ##
+    # Class for transforming FGDC XML Documents
+    class Fgdc < Base
+      private
+      ##
+      # Retrieve the Class for the GeoCombine::Metadata instance
+      # @return [GeoCombine::Fgdc]
+      def metadata_class
+        GeoCombine::Fgdc
+      end
+    end
+  end
+end

data/lib/geoblacklight/metadata_transformer/iso19139.rb ADDED Viewed

@@ -0,0 +1,16 @@
+module Geoblacklight
+  module MetadataTransformer
+    ##
+    # Class for transforming ISO19139 XML Documents
+    class Iso19139 < Base
+      private
+      ##
+      # Retrieve the Class for the GeoCombine::Metadata instance
+      # @return [GeoCombine::Iso19139]
+      def metadata_class
+        GeoCombine::Iso19139
+      end
+    end
+  end
+end

data/lib/geoblacklight/metadata_transformer.rb ADDED Viewed

@@ -0,0 +1,33 @@
+require 'geo_combine'
+module Geoblacklight
+  module MetadataTransformer
+    ##
+    # Exceptions raised for the types of geospatial metadata
+    class TypeError < EncodingError; end
+    ##
+    # Exceptions raised when parsing geospatial metadata in the XML
+    class ParseError < EncodingError; end
+    ##
+    # Exception raised when the geospatial metadata content is empty
+    class EmptyMetadataError < ParseError; end
+    ##
+    # Exceptions raised when transforming the metadata into the HTML
+    class TransformError < EncodingError; end
+    ##
+    # Initialize a new MetadataTransformer instance
+    # @param [Geoblacklight::Metadata::Base] metadata string or File path to the raw metadata
+    # @return [Geoblacklight::MetadataTransformer::BaseTransformer]
+    def self.instance(metadata)
+      type = metadata.class.name.split('::').last
+      begin
+        klass = "Geoblacklight::MetadataTransformer::#{type.capitalize}".constantize
+      rescue
+        raise TypeError, "Metadata type #{type} is not supported"
+      end
+      klass.new(metadata)
+    end
+  end
+end

data/lib/geoblacklight/references.rb CHANGED Viewed

@@ -8,6 +8,20 @@ module Geoblacklight
       @refs = parse_references.map { |ref| Reference.new(ref) }
     end
+    ##
+    # Return only those metadata references which are exposed within the configuration
+    # @return [Geoblacklight::Reference]
+    def shown_metadata_refs
+      @refs.select { |ref| Settings.METADATA_SHOWN.include?(ref.type.to_s) }
+    end
+    ##
+    # Return only metadata for shown metadata
+    # @return [Geoblacklight::Metadata::Base]
+    def shown_metadata
+      @shown_metadata ||= shown_metadata_refs.map { |ref| Geoblacklight::Metadata.instance(ref) }
+    end
     ##
     # Accessor for a document's file format
     # @return [String] file format for the document

data/lib/geoblacklight/version.rb CHANGED Viewed

@@ -1,3 +1,3 @@
 module Geoblacklight
-  VERSION = '1.5.1'.freeze
+  VERSION = '1.6.0'.freeze
 end

data/lib/geoblacklight/view_helper_override.rb CHANGED Viewed

@@ -21,7 +21,7 @@ module Geoblacklight
     def render_search_to_s_bbox(params)
       return ''.html_safe if params['bbox'].blank?
-      render_search_to_s_element('Bounding box', render_filter_value(params['bbox']))
+      render_search_to_s_element(t('geoblacklight.bbox_label'), render_filter_value(params['bbox']))
     end
     def render_constraints_filters(localized_params = params)
@@ -30,7 +30,8 @@ module Geoblacklight
       if localized_params[:bbox]
         path = search_action_path(remove_spatial_filter_group(:bbox, localized_params))
-        content << render_constraint_element('Bounding Box', localized_params[:bbox], remove: path)
+        content << render_constraint_element(t('geoblacklight.bbox_label'),
+                                             localized_params[:bbox], remove: path)
       end
       content

data/lib/geoblacklight.rb CHANGED Viewed

@@ -19,6 +19,13 @@ module Geoblacklight
   require 'geoblacklight/download/shapefile_download'
   require 'geoblacklight/download/hgl_download'
   require 'geoblacklight/metadata'
+  require 'geoblacklight/metadata/base'
+  require 'geoblacklight/metadata/fgdc'
+  require 'geoblacklight/metadata/iso19139'
+  require 'geoblacklight/metadata_transformer'
+  require 'geoblacklight/metadata_transformer/base'
+  require 'geoblacklight/metadata_transformer/fgdc'
+  require 'geoblacklight/metadata_transformer/iso19139'
   require 'geoblacklight/reference'
   require 'geoblacklight/references'
   require 'geoblacklight/routes'

data/spec/features/download_layer_spec.rb CHANGED Viewed

@@ -43,7 +43,7 @@ feature 'Download layer' do
   end
   scenario 'clicking jpg download button should redirect to external image' do
     visit solr_document_path('princeton-02870w62c')
-    expect(page).to have_css("a.btn.btn-default[href='http://libimages.princeton.edu/loris2/pudl0076%2Fmap_pownall%2F00000001.jp2/full/full/0/default.jpg']", text: 'Download JPG')
+    expect(page).to have_css("a.btn.btn-default[href='https://libimages.princeton.edu/loris/pudl0076/map_pownall/00000001.jp2/full/full/0/default.jpg']", text: 'Download JPG')
   end
   scenario 'options should be available under toggle' do
     visit solr_document_path('mit-us-ma-e25zcta5dct-2000')
@@ -86,6 +86,9 @@ feature 'Download layer' do
       fill_in('Email', with: 'foo@example.com')
       click_button('Request')
     end
-    expect(page).to have_content('You should receive an email when your download is ready')
+    using_wait_time 45 do
+      expect(page).to have_css('.alert-success')
+      expect(page).to have_content('You should receive an email when your download is ready')
+    end
   end
 end

data/spec/features/layer_inspection_spec.rb CHANGED Viewed

@@ -4,7 +4,7 @@ feature 'Layer inspection', js: true do
   scenario 'clicking map should trigger inspection' do
     visit solr_document_path('mit-us-ma-e25zcta5dct-2000')
     expect(page).to have_css('th', text: 'Attribute')
-    find('#map').trigger('click')
+    find('#map').click
     expect(page).not_to have_css('td.default-text')
   end
 end

data/spec/features/metadata_panel_spec.rb CHANGED Viewed

@@ -2,15 +2,26 @@ require 'spec_helper'
 feature 'Metadata tools' do
   feature 'when metadata references are available', js: :true do
-    scenario 'shows up in tools' do
+    scenario 'shows up as HTML' do
+      visit solr_document_path 'columbia-columbia-landinfo-global-aet'
+      expect(page).to have_css 'li.metadata a', text: 'Metadata'
+      click_link 'Metadata'
+      using_wait_time 15 do
+        within '.metadata-view' do
+          expect(page).to have_css '.pill-metadata', text: 'FGDC'
+          expect(page).to have_css 'dt', text: 'Identification Information'
+          expect(page).to have_css 'dt', text: 'Metadata Reference Information'
+        end
+      end
+    end
+    scenario 'shows up as XML' do
       visit solr_document_path 'stanford-cg357zz0321'
       expect(page).to have_css 'li.metadata a', text: 'Metadata'
       click_link 'Metadata'
       using_wait_time 15 do
         within '.metadata-view' do
-          expect(page).to have_css 'div.label', text: 'MODS'
-          expect(page).to have_css 'div.CodeRay', count: 2
-          expect(page).to have_css 'div.label', text: 'ISO 19139'
+          expect(page).to have_css '.pill-metadata', text: 'MODS'
+          expect(page).to have_css '.CodeRay'
         end
       end
     end

data/spec/features/saved_searches_spec.rb CHANGED Viewed

@@ -8,6 +8,6 @@ feature 'saved searches' do
       expect(page.current_url).to match(/bbox=/)
     end
     visit blacklight.search_history_path
-    expect(page).to have_css 'td.query a', text: /Bounding box:/
+    expect(page).to have_css 'td.query a', text: /#{I18n.t('geoblacklight.bbox_label')}:/
   end
 end

data/spec/features/split_view.html.erb_spec.rb CHANGED Viewed

@@ -34,14 +34,14 @@ feature 'Index view', js: true do
     # Needed to find an svg element on the page
     visit search_catalog_path(f: { Settings.FIELDS.PROVENANCE => ['Stanford'] })
     expect(Nokogiri::HTML.parse(page.body).css('path').length).to eq 0
-    find('.documentHeader', match: :first).trigger(:mouseover)
+    find('.documentHeader', match: :first).hover
     expect(Nokogiri::HTML.parse(page.body).css('path').length).to eq 1
   end
   scenario 'click on a record area to expand collapse' do
     within('.documentHeader', match: :first) do
       expect(page).not_to have_css('.collapse')
-      find('.status-icons').trigger('click')
+      find('.status-icons').click
       expect(page).to have_css('.collapse', visible: true)
     end
   end

data/spec/fixtures/solr_documents/harvard_raster.json CHANGED Viewed

@@ -26,7 +26,7 @@
   ],
   "dc_title_s": "Saint Petersburg Region, Russia, 1834 (Raster Image)",
   "dc_type_s": "Dataset",
-  "dct_references_s": "{\"http://schema.org/DownloadAction\":\"http://hgl.harvard.edu:8080/HGL/HGLOpenDelivery\",\"http://www.opengis.net/def/serviceType/ogc/wcs\":\"http://hgl.harvard.edu:8080/geoserver/wcs\",\"http://www.opengis.net/def/serviceType/ogc/wms\":\"http://hgl.harvard.edu:8080/geoserver/wms\",\"http://www.opengis.net/cat/csw/csdgm\":\"https://raw.githubusercontent.com/OpenGeoMetadata/edu.harvard/master/217/121/227/77/fgdc.xml\"}",
+  "dct_references_s": "{\"http://schema.org/DownloadAction\":\"http://pelham.lib.harvard.edu:8080/HGL/HGLOpenDelivery\",\"http://www.opengis.net/def/serviceType/ogc/wcs\":\"http://pelham.lib.harvard.edu:8090/geoserver/wcs\",\"http://www.opengis.net/def/serviceType/ogc/wms\":\"http://pelham.lib.harvard.edu:8090/geoserver/wms\",\"http://www.opengis.net/cat/csw/csdgm\":\"https://raw.githubusercontent.com/OpenGeoMetadata/edu.harvard/master/217/121/227/77/fgdc.xml\"}",
   "dct_spatial_sm": [
     "Russia Saint Petersburg"
   ],
@@ -36,7 +36,7 @@
   "dct_issued_s": "2000",
   "dct_provenance_s": "Harvard",
   "layer_slug_s": "harvard-g7064-s2-1834-k3",
-  "layer_id_s": "cite:SDE2.G7064_S2_1834_K3",
+  "layer_id_s": "cite:G7064_S2_1834_K3",
   "layer_geom_type_s": "Raster",
   "layer_modified_dt": "2014-05-27T18:09:36Z",
   "solr_geom": "ENVELOPE(30.013108, 30.875309, 60.041712, 59.669749)",

data/spec/fixtures/solr_documents/public_iiif_princeton.json CHANGED Viewed

@@ -16,7 +16,7 @@
     "Rogers, Henry Darwin",
     "Pownall, Thomas"
   ],
-  "dct_references_s": "{\"http://schema.org/url\":\"http://arks.princeton.edu/ark:/88435/02870w62c\",\"http://schema.org/thumbnailUrl\":\"http://libimages.princeton.edu/loris2/pudl0076%2Fmap_pownall%2F00000001.jp2/full/50,/0/default.jpg\",\"http://iiif.io/api/image\":\"http://libimages.princeton.edu/loris2/pudl0076%2Fmap_pownall%2F00000001.jp2/info.json\"}",
+  "dct_references_s": "{\"http://schema.org/url\":\"http://arks.princeton.edu/ark:/88435/02870w62c\",\"http://schema.org/thumbnailUrl\":\"https://libimages.princeton.edu/loris2/pudl0076%2Fmap_pownall%2F00000001.jp2/full/50,/0/default.jpg\",\"http://iiif.io/api/image\":\"https://libimages.princeton.edu/loris/pudl0076/map_pownall/00000001.jp2/info.json\"}",
   "dct_spatial_sm": [
     "New York (State)",
     "New Jersey",

data/spec/helpers/{geoblacklight_helpers_spec.rb → geoblacklight_helper_spec.rb} RENAMED Viewed

@@ -155,4 +155,58 @@ describe GeoblacklightHelper, type: :helper do
       end
     end
   end
+  describe '#render_transformed_metadata' do
+    let(:metadata) { instance_double(Geoblacklight::Metadata::Base) }
+    context 'with valid XML data' do
+      before do
+        allow(metadata).to receive(:transform).and_return('<div>test</div>')
+      end
+      it 'renders the partial with metadata content' do
+        expect(helper).to receive(:render)
+          .with(partial: 'catalog/metadata/content', locals: { content: '<div>test</div>' })
+        helper.render_transformed_metadata(metadata)
+      end
+    end
+    context 'with valid XML data without an HTML transform' do
+      before do
+        allow(metadata).to receive(:transform).and_raise(Geoblacklight::MetadataTransformer::TransformError)
+        allow(metadata).to receive(:to_xml).and_return('<data></data>')
+      end
+      it 'renders the partial with metadata content' do
+        expect(helper).to receive(:render).with(partial: 'catalog/metadata/markup', locals: { content: '<data></data>' })
+        helper.render_transformed_metadata(metadata)
+      end
+    end
+    context 'without XML data' do
+      before do
+        allow(metadata).to receive(:transform).and_raise(Geoblacklight::MetadataTransformer::ParseError)
+      end
+      it 'renders the partial with metadata content' do
+        expect(helper).to receive(:render).with(partial: 'catalog/metadata/missing')
+        helper.render_transformed_metadata(metadata)
+      end
+    end
+  end
+  describe '#first_metadata?' do
+    let(:metadata) { instance_double(Geoblacklight::Metadata::Base) }
+    let(:references) { instance_double(Geoblacklight::References) }
+    let(:document) { instance_double(SolrDocument) }
+    before do
+      allow(document).to receive(:references).and_return(references)
+      allow(references).to receive(:shown_metadata).and_return([metadata])
+      allow(metadata).to receive(:type).and_return('fgdc')
+    end
+    it 'confirms that a metadata resource is the first item reference' do
+      expect(helper.first_metadata?(document, metadata)).to be true
+    end
+  end
 end

data/spec/javascripts/geoblacklight_spec.js CHANGED Viewed

@@ -9,5 +9,9 @@ describe('GeoBlacklight', function() {
     it('History.js is defined', function() {
       expect(History).toBeDefined();
     });
+    it('MetadataDownloadButton is defined', function() {
+      expect(GeoBlacklight.MetadataDownloadButton).toBeDefined();
+    });
   });
 });

data/spec/javascripts/metadata_download_button_spec.js ADDED Viewed

@@ -0,0 +1,14 @@
+//= require geoblacklight
+describe('MetadataDownloadButton', function() {
+  describe('initialize', function() {
+    fixture.set('<button id="foo" data-ref-endpoint="http://testdomain" data-ref-download="#bar">test element</button><a href="http://test2domain" id="bar">another test element</a>');
+    it('creates a new instance and sets the download button @href value', function() {
+      var button = new GeoBlacklight.MetadataDownloadButton('#foo');
+      expect(button.$el.attr('id')).toBe('foo');
+      expect(button.$download.attr('id')).toBe('bar');
+      expect(button.$download.attr('href')).toBe('http://testdomain');
+    });
+  });
+});

data/spec/lib/geoblacklight/metadata/base_spec.rb ADDED Viewed

@@ -0,0 +1,85 @@
+require 'spec_helper'
+describe Geoblacklight::Metadata::Base do
+  let(:connection) { instance_double(Faraday::Connection) }
+  let(:response) { instance_double(Faraday::Response) }
+  let(:opengeometadata) do
+    described_class.new(
+      Geoblacklight::Reference.new(
+        ['http://www.loc.gov/mods/v3', 'http://purl.stanford.edu/cg357zz0321.mods']
+      )
+    )
+  end
+  describe '#document' do
+    before do
+      allow(Faraday).to receive(:new).with(url: 'http://purl.stanford.edu/cg357zz0321.mods').and_return(connection)
+    end
+    context 'with valid XML data at an endpoint URL' do
+      before do
+        allow(response).to receive(:status).and_return(200)
+        allow(response).to receive(:body).and_return('<test>data</test>')
+        allow(connection).to receive(:get).and_return(response)
+      end
+      it 'returns an XML Document containing the payload from an endpoint url' do
+        expect(opengeometadata.document).to be_a Nokogiri::XML::Document
+      end
+    end
+    context 'when attempts to connect to an endpoint URL fail' do
+      subject { opengeometadata.document }
+      before do
+        allow(connection).to receive(:get).and_raise(Faraday::Error::ConnectionFailed, 'test connection failures')
+      end
+      it 'returns nil when a connection error' do
+        expect(subject).to be_a Nokogiri::XML::Document
+        expect(subject.children.empty?).to be true
+      end
+    end
+  end
+  describe '#blank?' do
+    before do
+      allow(Faraday).to receive(:new).with(url: 'http://purl.stanford.edu/cg357zz0321.mods').and_return(connection)
+    end
+    context 'with valid XML data at an endpoint URL' do
+      before do
+        allow(response).to receive(:status).and_return(200)
+        allow(response).to receive(:body).and_return('<test>data</test>')
+        allow(connection).to receive(:get).and_return(response)
+      end
+      it 'returns false' do
+        expect(opengeometadata.blank?).to be false
+      end
+    end
+    context 'when attempts to connect to an endpoint URL fail' do
+      before do
+        allow(connection).to receive(:get).and_raise(Faraday::Error::ConnectionFailed, 'test connection failures')
+      end
+      it 'returns true' do
+        expect(opengeometadata.blank?).to be true
+      end
+    end
+  end
+  describe '#endpoint' do
+    before do
+      allow(Faraday).to receive(:new).with(url: 'http://purl.stanford.edu/cg357zz0321.mods').and_return(connection)
+      allow(response).to receive(:status).and_return(200)
+      allow(response).to receive(:body).and_return('<test>data</test>')
+      allow(connection).to receive(:get).and_return(response)
+    end
+    it 'returns the URI' do
+      expect(opengeometadata.endpoint).to eq 'http://purl.stanford.edu/cg357zz0321.mods'
+    end
+  end
+end

data/spec/lib/geoblacklight/metadata_spec.rb CHANGED Viewed

@@ -1,25 +1,33 @@
 require 'spec_helper'
 describe Geoblacklight::Metadata do
-  let(:response) { double('response') }
-  let(:get) { double('get') }
-  let(:opengeometadata) do
-    described_class.new(
-      Geoblacklight::Reference.new(
-        ['http://www.loc.gov/mods/v3', 'http://purl.stanford.edu/cg357zz0321.mods']
-      )
-    )
-  end
-  describe '#retrieve_metadata' do
-    it 'returns response from an endpoint url' do
-      expect(response).to receive(:get).and_return(get)
-      expect(Faraday).to receive(:new).with(url: 'http://purl.stanford.edu/cg357zz0321.mods').and_return(response)
-      opengeometadata.retrieve_metadata
+  describe '.instance' do
+    let(:reference) { instance_double(Geoblacklight::Reference) }
+    context 'with an FGDC metadata reference' do
+      before do
+        allow(reference).to receive(:type).and_return('fgdc')
+      end
+      it 'constructs an Geoblacklight::Metadata::Fgdc instance' do
+        expect(described_class.instance(reference)).to be_a Geoblacklight::Metadata::Fgdc
+      end
+    end
+    context 'with an ISO19139 metadata reference' do
+      before do
+        allow(reference).to receive(:type).and_return('iso19139')
+      end
+      it 'constructs an Geoblacklight::Metadata::Iso19139 instance' do
+        expect(described_class.instance(reference)).to be_a Geoblacklight::Metadata::Iso19139
+      end
     end
-    it 'returns nil when a connection error' do
-      expect(response).to receive(:get).and_return(Faraday::Error::ConnectionFailed)
-      expect(Faraday).to receive(:new).with(url: 'http://purl.stanford.edu/cg357zz0321.mods').and_return(response)
-      opengeometadata.retrieve_metadata
+    context 'with another metadata reference' do
+      before do
+        allow(reference).to receive(:type).and_return('unsupported')
+      end
+      it 'constructs an Geoblacklight::Metadata::Base instance' do
+        expect(described_class.instance(reference)).to be_a Geoblacklight::Metadata::Base
+      end
     end
   end
 end

data/spec/lib/geoblacklight/metadata_transformer/base_spec.rb ADDED Viewed

@@ -0,0 +1,35 @@
+require 'spec_helper'
+describe Geoblacklight::MetadataTransformer::Base do
+  describe '.new' do
+    it 'raises an error for empty XML' do
+      expect { described_class.new(nil) }.to raise_error Geoblacklight::MetadataTransformer::EmptyMetadataError
+    end
+  end
+  context 'with metadata types without XSL Stylesheets' do
+    let(:metadata) { instance_double(GeoCombine::Metadata) }
+    subject { described_class.new(metadata) }
+    describe '#transform' do
+      before do
+        allow(metadata).to receive(:to_html).and_raise(NoMethodError, 'undefined method `to_html\'')
+      end
+      it 'raises a transform error' do
+        expect { subject.transform }.to raise_error Geoblacklight::MetadataTransformer::TransformError, /undefined method `to_html'/
+      end
+    end
+  end
+  context 'with metadata types with XSL Stylesheets but invalid HTML' do
+    let(:metadata) { instance_double(GeoCombine::Metadata) }
+    subject { described_class.new(metadata) }
+    describe '#transform' do
+      before do
+        allow(metadata).to receive(:to_html).and_return('<invalid-html></invalid-html>')
+      end
+      it 'raises a transform error' do
+        expect { subject.transform }.to raise_error Geoblacklight::MetadataTransformer::TransformError, 'Failed to extract the <body> child elements from the transformed metadata'
+      end
+    end
+  end
+end

data/spec/lib/geoblacklight/metadata_transformer/fgdc_spec.rb ADDED Viewed

@@ -0,0 +1,23 @@
+require 'spec_helper'
+describe Geoblacklight::MetadataTransformer::Fgdc do
+  let(:fgdc_html) { File.read(File.join(Rails.root, 'spec', 'fixtures', 'metadata', 'fgdc.html')) }
+  let(:metadata) { instance_double('Geoblacklight::Metadata::Fgdc') }
+  subject do
+    described_class.new(metadata)
+  end
+  describe '#transform' do
+    before do
+      allow(metadata).to receive(:blank?).and_return(false)
+      allow(metadata).to receive(:to_html).and_return(fgdc_html)
+    end
+    it 'transforms FGDC Documents in the XML into the HTML' do
+      transformed = Nokogiri::XML.fragment(subject.transform)
+      expect(transformed.at_xpath('.//h1').text.strip).to eq('Custom Link Sample')
+      expect(transformed.at_xpath('.//div/dl/dd/dl/dd/dl/dt').text).to eq('Originator')
+      expect(transformed.at_xpath('.//div/dl/dd/dl/dd/dl/dd').text.strip).to eq('Esri')
+    end
+  end
+end

data/spec/lib/geoblacklight/metadata_transformer/iso19139_spec.rb ADDED Viewed

@@ -0,0 +1,23 @@
+require 'spec_helper'
+describe Geoblacklight::MetadataTransformer::Iso19139 do
+  let(:iso_html) { File.read(File.join(Rails.root, 'spec', 'fixtures', 'metadata', 'iso.html')) }
+  let(:metadata) { instance_double('Geoblacklight::Metadata::Iso19139') }
+  subject do
+    described_class.new(metadata)
+  end
+  describe '#transform' do
+    before do
+      expect(metadata).to receive(:blank?).and_return(false)
+      expect(metadata).to receive(:to_html).and_return(iso_html)
+    end
+    it 'transforms ISO19139 Documents in the XML into the HTML' do
+      transformed = Nokogiri::XML.fragment(subject.transform)
+      expect(transformed.at_xpath('.//h1').text.strip).to eq('Abandoned Mine Land Inventory Polygons: Pennsylvania, 2016')
+      expect(transformed.at_xpath('(.//div)[1]/dl/dd/dl/dd/dl/dt').text).to eq('Title')
+      expect(transformed.at_xpath('(.//div)[1]/dl/dd/dl/dd/dl/dd').text.strip).to eq('Abandoned Mine Land Inventory Polygons: Pennsylvania, 2016')
+    end
+  end
+end