geoblacklight 0.12.1 → 1.0.0.pre1

data/lib/geoblacklight/version.rb

@@ -1,3 +1,3 @@
 module Geoblacklight
-  VERSION = '0.12.1'
+  VERSION = '1.0.0.pre1'.freeze
 end

data/spec/controllers/catalog_controller_spec.rb

@@ -5,7 +5,7 @@ describe CatalogController, type: :controller do
     it 'returns a document based off an id' do
       get :web_services, id: 'mit-us-ma-e25zcta5dct-2000'
       expect(response.status).to eq 200
-      expect(assigns(:document)).to_not be_nil
+      expect(assigns(:document)).not_to be_nil
     end
   end
 end

data/spec/controllers/download_controller_spec.rb

@@ -32,8 +32,14 @@ describe Geoblacklight::DownloadController, type: :controller do
     end
   end
   describe '#hgl' do
+    let(:hgl_download) { instance_double(Geoblacklight::HglDownload) }
+
+    before do
+      allow(Geoblacklight::HglDownload).to receive(:new).and_return(hgl_download)
+    end
+
     it 'requests file' do
-      expect_any_instance_of(Geoblacklight::HglDownload).to receive(:get).and_return('success')
+      allow(hgl_download).to receive(:get).and_return('success')
       get :hgl, id: 'harvard-g7064-s2-1834-k3', email: 'foo@example.com'
       expect(response.status).to eq 200
     end

data/spec/features/bookmarks_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 feature 'Blacklight Bookmarks' do
   scenario 'index has created bookmarks' do
-    visit catalog_path 'columbia-columbia-landinfo-global-aet'
+    visit solr_document_path 'columbia-columbia-landinfo-global-aet'
     click_button 'Bookmark'
     visit bookmarks_path
     expect(page).to have_css '.document', count: 1

data/spec/features/configurable_basemap_spec.rb

@@ -1,26 +1,27 @@
 require 'spec_helper'
 
 feature 'Configurable basemap', js: true do
-  scenario 'defaults to mapquest' do
+  scenario 'defaults to positron' do
     visit root_path
-    expect(page).to have_css "img[src*='mqcdn.com']"
+    expect(page).to have_css "img[src*='cartodb']"
   end
   feature 'without provided basemap config' do
     before do
       CatalogController.blacklight_config.basemap_provider = nil
     end
-    scenario 'has mapquest map' do
+    scenario 'has CartoDB map' do
       visit root_path
-      expect(page).to have_css "img[src*='mqcdn.com']"
+      expect(page).to have_css "img[src*='cartodb']"
     end
   end
-  feature 'using positron' do
+  feature 'using darkMatter' do
     before do
-      CatalogController.blacklight_config.basemap_provider = 'positron'
+      CatalogController.blacklight_config.basemap_provider = 'darkMatter'
     end
-    scenario 'has positron map' do
+    scenario 'has darkMatter map' do
+      puts CatalogController.blacklight_config.basemap_provider
       visit root_path
-      expect(page).to have_css "img[src*='light_all']"
+      expect(page).to have_css "img[src*='dark_all']"
     end
   end
 end

data/spec/features/download_layer_spec.rb

@@ -1,47 +1,65 @@
 require 'spec_helper'
 
 feature 'Download layer' do
+  let(:shapefile_download) { instance_double(Geoblacklight::ShapefileDownload) }
+  let(:kmz_download) { instance_double(Geoblacklight::KmzDownload) }
+  let(:hgl_download) { instance_double(Geoblacklight::HglDownload) }
+
+  before do
+    allow(Geoblacklight::ShapefileDownload).to receive(:new).and_return(shapefile_download)
+    allow(Geoblacklight::KmzDownload).to receive(:new).and_return(kmz_download)
+    allow(Geoblacklight::HglDownload).to receive(:new).and_return(hgl_download)
+  end
+
   scenario 'clicking initial shapefile download button should trigger download', js: true do
-    expect_any_instance_of(Geoblacklight::ShapefileDownload).to receive(:get).and_return('mit-us-ma-e25zcta5dct-2000-shapefile.zip')
-    visit catalog_path('mit-us-ma-e25zcta5dct-2000')
+    expect(shapefile_download).to receive(:get).and_return('mit-us-ma-e25zcta5dct-2000-shapefile.zip')
+    visit solr_document_path('mit-us-ma-e25zcta5dct-2000')
     find('a', text: 'Download Shapefile').click
     expect(page).to have_css('a', text: 'Your file mit-us-ma-e25zcta5dct-2000-shapefile.zip is ready for download')
   end
   scenario 'failed download should return message with link to layer', js: true do
-    expect_any_instance_of(Geoblacklight::ShapefileDownload).to receive(:get).and_raise(Geoblacklight::Exceptions::ExternalDownloadFailed.new(message: 'Failed', url: 'http://www.example.com/failed'))
-    visit catalog_path('mit-us-ma-e25zcta5dct-2000')
+    expect(shapefile_download).to receive(:get).and_raise(Geoblacklight::Exceptions::ExternalDownloadFailed.new(message: 'Failed', url: 'http://www.example.com/failed'))
+    visit solr_document_path('mit-us-ma-e25zcta5dct-2000')
     find('a', text: 'Download Shapefile', match: :first).click
     expect(page).to have_css 'div.alert.alert-danger', text: 'Sorry, the requested file could not be downloaded, try downloading it directly from:'
     expect(page).to have_css 'a', text: 'http://www.example.com/failed'
   end
   scenario 'clicking kmz download button should trigger download', js: true do
-    expect_any_instance_of(Geoblacklight::KmzDownload).to receive(:get).and_return('mit-us-ma-e25zcta5dct-2000-kmz.kmz')
-    visit catalog_path('mit-us-ma-e25zcta5dct-2000')
+    expect(kmz_download).to receive(:get).and_return('mit-us-ma-e25zcta5dct-2000-kmz.kmz')
+    visit solr_document_path('mit-us-ma-e25zcta5dct-2000')
     find('button.download-dropdown-toggle').click
     find('a', text: 'Download KMZ').click
     expect(page).to have_css('a', text: 'Your file mit-us-ma-e25zcta5dct-2000-kmz.kmz is ready for download')
   end
+  scenario 'jpg download option should be present under toggle' do
+    visit solr_document_path('princeton-02870w62c')
+    expect(page).to have_css('li a', text: 'Download JPG')
+  end
+  scenario 'clicking jpg download button should redirect to external image' do
+    visit solr_document_path('princeton-02870w62c')
+    expect(page).to have_css("a.btn.btn-default[href='http://libimages.princeton.edu/loris2/pudl0076%2Fmap_pownall%2F00000001.jp2/full/full/0/default.jpg']", text: 'Download JPG')
+  end
   scenario 'options should be available under toggle' do
-    visit catalog_path('mit-us-ma-e25zcta5dct-2000')
+    visit solr_document_path('mit-us-ma-e25zcta5dct-2000')
     find('button.download-dropdown-toggle').click
     expect(page).to have_css('li a', text: 'Download Shapefile')
     expect(page).to have_css('li a', text: 'Download KMZ')
   end
   scenario 'restricted layer should not have download available to non logged in user' do
-    visit catalog_path('stanford-cg357zz0321')
+    visit solr_document_path('stanford-cg357zz0321')
     expect(page).to have_css 'a', text: 'Login to view and download'
-    expect(page).to_not have_css 'button', text: 'Download Shapefile'
+    expect(page).not_to have_css 'button', text: 'Download Shapefile'
   end
   scenario 'restricted layer should have download available to logged in user' do
     sign_in
-    visit catalog_path('stanford-cg357zz0321')
-    expect(page).to_not have_css 'a', text: 'Login to view and download'
+    visit solr_document_path('stanford-cg357zz0321')
+    expect(page).not_to have_css 'a', text: 'Login to view and download'
     expect(page).to have_css 'a', text: 'Download Shapefile'
     expect(page).to have_css 'button.download-dropdown-toggle'
   end
   scenario 'layer with direct download and wms/wfs should include all download types' do
     sign_in
-    visit catalog_path('stanford-cg357zz0321')
+    visit solr_document_path('stanford-cg357zz0321')
     expect(page).to have_css 'a', text: 'Download Shapefile'
     find('button.download-dropdown-toggle').click
     expect(page).to have_css 'li.dropdown-header', text: 'Original'
@@ -50,13 +68,13 @@ feature 'Download layer' do
     expect(page).to have_css 'li a', text: 'Download KMZ'
   end
   scenario 'clicking GeoTIFF button for Harvard layer should show email form', js: true do
-    visit catalog_path('harvard-g7064-s2-1834-k3')
+    visit solr_document_path('harvard-g7064-s2-1834-k3')
     find('a', text: 'Download GeoTIFF').click
     expect(page).to have_css('#hglRequest')
   end
   scenario 'submitting email form should trigger HGL request', js: true do
-    expect_any_instance_of(Geoblacklight::HglDownload).to receive(:get).and_return('success')
-    visit catalog_path('harvard-g7064-s2-1834-k3')
+    expect(hgl_download).to receive(:get).and_return('success')
+    visit solr_document_path('harvard-g7064-s2-1834-k3')
     find('a', text: 'Download GeoTIFF').click
     within '#hglRequest' do
       fill_in('Email', with: 'foo@example.com')

data/spec/features/esri_viewer_spec.rb

@@ -2,38 +2,39 @@ require 'spec_helper'
 
 feature 'feature_layer reference', js: true do
   scenario 'displays image map layer' do
-    visit catalog_path 'minnesota-test-oregon-naip-2011'
+    visit solr_document_path 'minnesota-test-oregon-naip-2011'
     expect(page).to have_css '.leaflet-control-zoom', visible: true
     expect(page).to have_css 'img.leaflet-image-layer', visible: true
   end
   scenario 'displays dynamic layer (all layers)' do
-    visit catalog_path 'illinois-f14ff4-1359-4beb-b931-5cb41d20ab90'
+    visit solr_document_path 'illinois-f14ff4-1359-4beb-b931-5cb41d20ab90'
     expect(page).to have_css '.leaflet-control-zoom', visible: true
     expect(page).to have_css 'img.leaflet-image-layer', visible: true
   end
   scenario 'displays dynamic layer (single layer)' do
-    visit catalog_path 'maryland-fc5cd2-732d-4559-a9c7-df38dd683aec'
+    visit solr_document_path 'maryland-fc5cd2-732d-4559-a9c7-df38dd683aec'
     expect(page).to have_css '.leaflet-control-zoom', visible: true
     expect(page).to have_css 'img.leaflet-image-layer', visible: true
   end
   scenario 'displays feature layer' do
-    visit catalog_path 'minnesota-772ebcaf2ec0405ea1b156b5937593e7_0'
-    expect(page).to have_css '.leaflet-control-zoom', visible: true
     pending 'cannot currently test for svg feature'
+    visit solr_document_path 'minnesota-772ebcaf2ec0405ea1b156b5937593e7_0'
+    expect(page).to have_css '.leaflet-control-zoom', visible: true
     expect(Nokogiri::HTML.parse(page.body).css('g').length).to eq 23
+    fail
   end
   scenario 'displays image map layer' do
-    visit catalog_path 'minnesota-test-oregon-naip-2011'
+    visit solr_document_path 'minnesota-test-oregon-naip-2011'
     expect(page).to have_css '.leaflet-control-zoom', visible: true
     expect(page).to have_css 'img.leaflet-image-layer', visible: true
   end
   scenario 'displays tiled map layer' do
-    visit catalog_path 'minnesota-test-soil-survey-map'
+    visit solr_document_path 'minnesota-test-soil-survey-map'
     expect(page).to have_css '.leaflet-control-zoom', visible: true
     expect(page).to have_css 'img.leaflet-tile.leaflet-tile-loaded', visible: true
   end
   scenario 'displays Esri WMS layer' do
-    visit catalog_path 'psu-32ef9f-0762-445c-8250-f4a5e220a46d'
+    visit solr_document_path 'psu-32ef9f-0762-445c-8250-f4a5e220a46d'
     expect(page).to have_css '.leaflet-control-zoom', visible: true
     expect(page).to have_css 'img.leaflet-tile.leaflet-tile-loaded', visible: true
   end

data/spec/features/exports_spec.rb

@@ -4,7 +4,7 @@ feature 'Export features' do
   feature 'when item is public and wfs is available' do
     feature 'Open in CartoDB' do
       scenario 'shows up in tools' do
-        visit catalog_path 'tufts-cambridgegrid100-04'
+        visit solr_document_path 'tufts-cambridgegrid100-04'
         expect(page).to have_css 'li.exports a', text: 'Open in CartoDB'
         click_link 'Open in CartoDB'
       end
@@ -12,8 +12,8 @@ feature 'Export features' do
   end
   feature 'when restricted or no wfs' do
     scenario 'is not in tools' do
-      visit catalog_path 'princeton-02870w62c'
-      expect(page).to_not have_css 'li.exports a', text: 'Open in CartoDB'
+      visit solr_document_path 'princeton-02870w62c'
+      expect(page).not_to have_css 'li.exports a', text: 'Open in CartoDB'
     end
   end
 end

data/spec/features/home_page_spec.rb

@@ -5,7 +5,7 @@ feature 'Home page', js: true do # use js: true for tests which require js, but
     visit root_path
   end
   scenario 'search bar' do
-    expect(page).to_not have_css '#search-navbar'
+    expect(page).not_to have_css '#search-navbar'
     within '.jumbotron' do
       expect(page).to have_css 'h2', text: 'Explore and discover...'
       expect(page).to have_css 'h3', text: 'Find the maps and data you need'

data/spec/features/iiif_viewer_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 feature 'iiif reference' do
   scenario 'displays leaflet viewer', js: true do
-    visit catalog_path('princeton-02870w62c')
+    visit solr_document_path('princeton-02870w62c')
     expect(page).to have_css '.leaflet-control-zoom', visible: true
   end
 end

data/spec/features/layer_inspection_spec.rb

@@ -2,9 +2,9 @@ require 'spec_helper'
 
 feature 'Layer inspection', js: true do
   scenario 'clicking map should trigger inspection' do
-    visit catalog_path('mit-us-ma-e25zcta5dct-2000')
+    visit solr_document_path('mit-us-ma-e25zcta5dct-2000')
     expect(page).to have_css('th', text: 'Attribute')
     find('#map').trigger('click')
-    expect(page).to_not have_css('td.default-text')
+    expect(page).not_to have_css('td.default-text')
   end
 end

data/spec/features/layer_opacity_spec.rb

@@ -2,14 +2,19 @@ require 'spec_helper'
 
 feature 'Layer opacity', js: true do
   scenario 'WMS layer should have opacity control' do
-    visit catalog_path('mit-us-ma-e25zcta5dct-2000')
+    visit solr_document_path('mit-us-ma-e25zcta5dct-2000')
     expect(page).to have_css('div.opacity-text', text: '75%')
     expect(page.all('div.leaflet-layer')[1][:style]).to match(/opacity: 0.75;/)
   end
 
   scenario 'ESRI image service layer should have opacity control' do
-    visit catalog_path('minnesota-test-oregon-naip-2011')
+    visit solr_document_path('minnesota-test-oregon-naip-2011')
     expect(page).to have_css('div.opacity-text', text: '75%')
     expect(page.find('img.leaflet-image-layer', match: :first)[:style]).to match(/opacity: 0.75;/)
   end
+
+  scenario 'IIIF layer should not have opacity control' do
+    visit solr_document_path('princeton-02870w62c')
+    expect(page).not_to have_css('div.opacity-text', text: '75%')
+  end
 end

data/spec/features/layer_preview_spec.rb

@@ -2,12 +2,12 @@ require 'spec_helper'
 
 feature 'Layer preview', js: true do
   scenario 'Restricted layer should show bounding box' do
-    visit catalog_path('stanford-cg357zz0321')
+    visit solr_document_path('stanford-cg357zz0321')
     expect(Nokogiri::HTML.parse(page.body).css('path').length).to eq 1
   end
 
   scenario 'Public layer should show wms layer not bounding box' do
-    visit catalog_path('mit-us-ma-e25zcta5dct-2000')
+    visit solr_document_path('mit-us-ma-e25zcta5dct-2000')
     expect(Nokogiri::HTML.parse(page.body).css('path').length).to eq 0
     within '.leaflet-tile-pane' do
       expect(page).to have_css('.leaflet-layer', count: 2)

data/spec/features/metadata_panel_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 feature 'Metadata tools' do
   feature 'when metadata references are available', js: :true do
     scenario 'shows up in tools' do
-      visit catalog_path 'stanford-cg357zz0321'
+      visit solr_document_path 'stanford-cg357zz0321'
       expect(page).to have_css 'li.metadata a', text: 'Metadata'
       click_link 'Metadata'
       using_wait_time 15 do
@@ -17,8 +17,8 @@ feature 'Metadata tools' do
   end
   feature 'when metadata references are not available' do
     scenario 'is not in tools' do
-      visit catalog_path 'mit-us-ma-e25zcta5dct-2000'
-      expect(page).to_not have_css 'li.metadata a', text: 'Metadata'
+      visit solr_document_path 'mit-us-ma-e25zcta5dct-2000'
+      expect(page).not_to have_css 'li.metadata a', text: 'Metadata'
     end
   end
 end

data/spec/features/saved_searches_spec.rb

@@ -7,7 +7,7 @@ feature 'saved searches' do
       find('.search-control a').click
       expect(page.current_url).to match(/bbox=/)
     end
-    visit search_history_path
+    visit blacklight.search_history_path
     expect(page).to have_css 'td.query a', text: /Bounding box:/
   end
 end

data/spec/features/search_bar_spec.rb

@@ -2,11 +2,11 @@ require 'spec_helper'
 
 feature 'search bar' do
   scenario 'present on a spatial search' do
-    visit catalog_index_path(bbox: '25 3 75 35')
+    visit search_catalog_path(bbox: '25 3 75 35')
     expect(page).to have_css '#search-navbar'
   end
   scenario 'present on a text search' do
-    visit catalog_index_path(q: 'test')
+    visit search_catalog_path(q: 'test')
     expect(page).to have_css '#search-navbar'
   end
 end

data/spec/features/show_page_metadata_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 feature 'Metadata display on show page' do
   scenario 'with default CatalogController specified fields' do
-    visit catalog_path 'stanford-dp018hs9766'
+    visit solr_document_path 'stanford-dp018hs9766'
     within '.geoblacklight-view-panel' do
       expect(page).to have_css 'dt', count: 8
       expect(page).to have_css 'dd', count: 8

data/spec/features/split_view.html.erb_spec.rb

@@ -1,12 +1,13 @@
 require 'spec_helper'
 
 feature 'Index view', js: true do
+  let(:subject_field) { Settings.FIELDS.SUBJECT }
   before do
-    visit catalog_index_path(q: '*')
+    visit search_catalog_path(q: '*')
   end
 
   scenario 'should have documents and map on page' do
-    visit catalog_index_path(f: { dct_provenance_s: ['Stanford'] })
+    visit search_catalog_path(f: { Settings.FIELDS.PROVENANCE => ['Stanford'] })
     expect(page).to have_css('#documents')
     expect(page).to have_css('.document', count: 3)
     expect(page).to have_css('#map')
@@ -31,7 +32,7 @@ feature 'Index view', js: true do
 
   scenario 'hover on record should produce bounding box on map' do
     # Needed to find an svg element on the page
-    visit catalog_index_path(f: { dct_provenance_s: ['Stanford'] })
+    visit search_catalog_path(f: { Settings.FIELDS.PROVENANCE => ['Stanford'] })
     expect(Nokogiri::HTML.parse(page.body).css('path').length).to eq 0
     find('.documentHeader', match: :first).trigger(:mouseover)
     expect(Nokogiri::HTML.parse(page.body).css('path').length).to eq 1
@@ -39,7 +40,7 @@ feature 'Index view', js: true do
 
   scenario 'click on a record area to expand collapse' do
     within('.documentHeader', match: :first) do
-      expect(page).to_not have_css('.collapse')
+      expect(page).not_to have_css('.collapse')
       find('.status-icons').trigger('click')
       expect(page).to have_css('.collapse', visible: true)
     end
@@ -52,7 +53,7 @@ feature 'Index view', js: true do
   end
 
   scenario 'clicking map search should retain current search parameters' do
-    visit '/?f[dc_subject_sm][]=polygon&f[dc_subject_sm][]=boundaries'
+    visit "/?f[#{subject_field}][]=polygon&f[#{subject_field}][]=boundaries"
     find('#map').double_click
     within '#appliedParams' do
       expect(page).to have_content('Subject polygon')

data/spec/features/web_services_modal_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 feature 'web services tools' do
   feature 'when wms/wfs are provided', js: true do
     scenario 'shows up in tools' do
-      visit catalog_path 'stanford-cg357zz0321'
+      visit solr_document_path 'stanford-cg357zz0321'
       expect(page).to have_css 'li.web_services a', text: 'Web services'
       click_link 'Web services'
       within '.modal-body' do
@@ -20,8 +20,8 @@ feature 'web services tools' do
   end
   feature 'no wms or wfs provided' do
     scenario 'does not show up in tools' do
-      visit catalog_path 'mit-001145244'
-      expect(page).to_not have_css 'li.web_services a', text: 'Web services'
+      visit solr_document_path 'mit-001145244'
+      expect(page).not_to have_css 'li.web_services a', text: 'Web services'
     end
   end
 end

data/spec/helpers/geoblacklight_helpers_spec.rb

@@ -4,9 +4,10 @@ describe GeoblacklightHelper, type: :helper do
   include ActionView::Helpers::UrlHelper
   include ActionView::Helpers::TranslationHelper
   describe '#render_facet_links' do
+    let(:subject_field) { Settings.FIELDS.SUBJECT }
     it 'contains unique links' do
-      expect(self).to receive(:catalog_index_path).exactly(3).times.and_return('http://example.com/catalog?f[dc_subject_sm][]=category')
-      html = Capybara.string(render_facet_links('dc_subject_sm', %w(Test Test Earth Science)))
+      expect(self).to receive(:search_catalog_path).exactly(3).times.and_return("http://example.com/catalog?f[#{subject_field}][]=category")
+      html = Capybara.string(render_facet_links(subject_field, %w(Test Test Earth Science)))
       expect(html).to have_css 'a', count: 3
       expect(html).to have_css 'a', text: 'Test', count: 1
       expect(html).to have_css 'a', text: 'Earth', count: 1
@@ -37,13 +38,74 @@ describe GeoblacklightHelper, type: :helper do
     let(:blacklight_config) { double }
     it 'without configuration' do
       expect(blacklight_config).to receive(:basemap_provider).and_return(nil)
-      expect(geoblacklight_basemap).to eq 'mapquest'
+      expect(geoblacklight_basemap).to eq 'positron'
     end
     it 'with custom configuration' do
       expect(blacklight_config).to receive(:basemap_provider).and_return('positron')
       expect(geoblacklight_basemap).to eq 'positron'
     end
   end
+
+  describe '#iiif_jpg_url' do
+    let(:document) { SolrDocument.new(document_attributes) }
+    let(:references_field) { Settings.FIELDS.REFERENCES }
+    let(:document_attributes) do
+      {
+        references_field => {
+          'http://iiif.io/api/image' => 'https://example.edu/image/info.json'
+        }.to_json
+      }
+    end
+
+    it 'returns JPG download URL when given URL to a IIIF info.json' do
+      assign(:document, document)
+      expect(helper.iiif_jpg_url).to eq 'https://example.edu/image/full/full/0/default.jpg'
+    end
+  end
+
+  describe '#snippit' do
+    let(:document) { SolrDocument.new(document_attributes) }
+    let(:references_field) { Settings.FIELDS.REFERENCES }
+    context 'as a String' do
+      let(:document_attributes) do
+        {
+          value: 'This is a really long string that should get truncated when it gets rendered'\
+          'in the index view to give a brief description of the contents of a particular document'\
+          'indexed into Solr'
+        }
+      end
+      it 'truncates longer strings to 150 characters' do
+        expect(helper.snippit(document).length).to eq 150
+      end
+      it 'truncated string ends with ...' do
+        expect(helper.snippit(document)[-3..-1]).to eq '...'
+      end
+    end
+    context 'as an Array' do
+      let(:document_attributes) do
+        {
+          value: ['This is a really long string that should get truncated when it gets rendered'\
+          'in the index view to give a brief description of the contents of a particular document'\
+          'indexed into Solr']
+        }
+      end
+      it 'truncates longer strings to 150 characters' do
+        expect(helper.snippit(document).length).to eq 150
+      end
+      it 'truncated string ends with ...' do
+        expect(helper.snippit(document)[-3..-1]).to eq '...'
+      end
+    end
+  end
+
+  describe '#cartodb_link' do
+    let(:application_name) { 'My GeoBlacklight Deployment' }
+
+    it 'removes spaces from application_name to produce valid CartoDB request URL' do
+      expect(cartodb_link('http://demo.org/wfs/layer.json')).to eq 'http://oneclick.cartodb.com/?file=http%3A%2F%2Fdemo.org%2Fwfs%2Flayer.json&provider=MyGeoBlacklightDeployment&logo=http%3A%2F%2Fgeoblacklight.org%2Fimages%2Fgeoblacklight-logo.png'
+    end
+  end
+
   describe '#render_web_services' do
     let(:reference) { double(type: 'wms') }
     it 'with a reference to a defined partial' do
@@ -62,4 +124,10 @@ describe GeoblacklightHelper, type: :helper do
       helper.render_web_services(reference)
     end
   end
+
+  describe '#leaflet_options' do
+    it 'returns a hash of options for leaflet' do
+      expect(leaflet_options[:VIEWERS][:WMS][:CONTROLS]).to eq(['Opacity'])
+    end
+  end
 end