geo_combine 0.7.0 → 0.9.0

data/spec/lib/geo_combine/geo_blacklight_harvester_spec.rb

@@ -5,8 +5,9 @@ require 'spec_helper'
 require 'rsolr'
 
 RSpec.describe GeoCombine::GeoBlacklightHarvester do
-  subject(:harvester) { described_class.new(site_key) }
+  subject(:harvester) { described_class.new(site_key, logger:) }
 
+  let(:logger) { instance_double(Logger, warn: nil, info: nil, error: nil, debug: nil) }
   let(:site_key) { :INSTITUTION }
   let(:stub_json_response) { '{}' }
   let(:stub_solr_connection) { double('RSolr::Connection') }
@@ -40,7 +41,7 @@ RSpec.describe GeoCombine::GeoBlacklightHarvester do
 
     let(:docs) { [{ layer_slug_s: 'abc-123' }, { layer_slug_s: 'abc-321' }] }
     let(:stub_json_response) do
-      { response: { docs: docs, pages: { current_page: 1, total_pages: 1 } } }.to_json
+      { response: { docs:, pages: { current_page: 1, total_pages: 1 } } }.to_json
     end
 
     it 'adds documents returned to solr' do
@@ -142,7 +143,7 @@ RSpec.describe GeoCombine::GeoBlacklightHarvester do
         ).and_return(stub_second_response.to_json)
         base_url = 'https://example.com?f%5Bdct_provenance_s%5D%5B%5D=INSTITUTION&format=json&per_page=100'
         docs = described_class::LegacyBlacklightResponse.new(response: stub_first_response,
-                                                             base_url: base_url).documents
+                                                             base_url:).documents
 
         expect(docs.to_a).to eq([first_docs, second_docs])
       end
@@ -182,7 +183,7 @@ RSpec.describe GeoCombine::GeoBlacklightHarvester do
 
         base_url = 'https://example.com?f%5Bdct_provenance_s%5D%5B%5D=INSTITUTION&format=json&per_page=100'
         docs = described_class::ModernBlacklightResponse.new(response: first_results_response,
-                                                             base_url: base_url).documents
+                                                             base_url:).documents
 
         expect(docs.to_a).to eq([
                                   [{ 'layer_slug_s' => 'abc-123' }, { 'layer_slug_s' => 'abc-321' }],

data/spec/lib/geo_combine/geoblacklight_spec.rb

@@ -151,8 +151,8 @@ RSpec.describe GeoCombine::Geoblacklight do
       let(:unparseable_json) do
         <<-JSON
           {
-            \"http://schema.org/url\":\"http://example.com/abc123\",,
-            \"http://schema.org/downloadUrl\":\"http://example.com/abc123/data.zip\"
+            "http://schema.org/url":"http://example.com/abc123",,
+            "http://schema.org/downloadUrl":"http://example.com/abc123/data.zip"
           }
         JSON
       end
@@ -184,7 +184,7 @@ RSpec.describe GeoCombine::Geoblacklight do
 
   describe 'spatial_validate!' do
     context 'when valid' do
-      it { full_geobl.spatial_validate! }
+      it { expect { full_geobl.spatial_validate! }.not_to raise_error }
     end
 
     context 'when invalid' do

data/spec/lib/geo_combine/harvester_spec.rb

@@ -0,0 +1,133 @@
+# frozen_string_literal: true
+
+require 'git'
+require 'geo_combine/harvester'
+require 'spec_helper'
+
+RSpec.describe GeoCombine::Harvester do
+  subject(:harvester) { described_class.new(ogm_path: 'spec/fixtures/indexing', logger:) }
+
+  let(:logger) { instance_double(Logger, warn: nil, info: nil, error: nil, debug: nil) }
+  let(:repo_name) { 'my-institution' }
+  let(:repo_path) { File.join(harvester.ogm_path, repo_name) }
+  let(:repo_url) { "https://github.com/OpenGeoMetadata/#{repo_name}.git" }
+  let(:stub_repo) { instance_double(Git::Base) }
+  let(:stub_gh_api) do
+    [
+      { name: repo_name, size: 100 },
+      { name: 'another-institution', size: 100 },
+      { name: 'outdated-institution', size: 100, archived: true }, # archived
+      { name: 'aardvark', size: 300 },                             # on denylist
+      { name: 'empty', size: 0 }                                   # no data
+    ]
+  end
+
+  before do
+    # stub github API requests
+    # use the whole org response, or just a portion for particular repos
+    allow(Net::HTTP).to receive(:get) do |uri|
+      if uri == described_class.ogm_api_uri
+        stub_gh_api.to_json
+      else
+        repo_name = uri.path.split('/').last.gsub('.git', '')
+        stub_gh_api.find { |repo| repo[:name] == repo_name }.to_json
+      end
+    end
+
+    # stub git commands
+    allow(Git).to receive_messages(open: stub_repo, clone: stub_repo)
+    allow(stub_repo).to receive(:pull).and_return(stub_repo)
+  end
+
+  describe '#docs_to_index' do
+    it 'yields each JSON record with its path, skipping layers.JSON' do
+      expect { |b| harvester.docs_to_index(&b) }.to yield_successive_args(
+        [JSON.parse(File.read('spec/fixtures/indexing/basic_geoblacklight.json')), 'spec/fixtures/indexing/basic_geoblacklight.json'],
+        [JSON.parse(File.read('spec/fixtures/indexing/geoblacklight.json')), 'spec/fixtures/indexing/geoblacklight.json']
+      )
+    end
+
+    it 'skips records with a different schema version' do
+      harvester = described_class.new(ogm_path: 'spec/fixtures/indexing/', schema_version: 'Aardvark', logger:)
+      expect { |b| harvester.docs_to_index(&b) }.to yield_successive_args(
+        [JSON.parse(File.read('spec/fixtures/indexing/aardvark.json')), 'spec/fixtures/indexing/aardvark.json']
+      )
+    end
+  end
+
+  describe '#pull' do
+    it 'can pull a single repository' do
+      harvester.pull(repo_name)
+      expect(Git).to have_received(:open).with(repo_path)
+      expect(stub_repo).to have_received(:pull)
+    end
+
+    it 'clones a repo before pulling if it does not exist' do
+      harvester.pull(repo_name)
+      expect(Git).to have_received(:clone)
+    end
+  end
+
+  describe '#pull_all' do
+    it 'can pull all repositories' do
+      harvester.pull_all
+      expect(Git).to have_received(:open).exactly(2).times
+      expect(stub_repo).to have_received(:pull).exactly(2).times
+    end
+
+    it 'returns the names of repositories pulled' do
+      expect(harvester.pull_all).to eq(%w[my-institution another-institution])
+    end
+
+    it 'skips repositories in the denylist' do
+      harvester.pull_all
+      expect(Git).not_to have_received(:open).with('https://github.com/OpenGeoMetadata/aardvark.git')
+    end
+
+    it 'skips archived repositories' do
+      harvester.pull_all
+      expect(Git).not_to have_received(:open).with('https://github.com/OpenGeoMetadata/outdated-institution.git')
+    end
+  end
+
+  describe '#clone' do
+    it 'can clone a single repository' do
+      harvester.clone(repo_name)
+      expect(Git).to have_received(:clone).with(
+        repo_url,
+        nil, {
+          depth: 1, # shallow clone
+          path: harvester.ogm_path
+        }
+      )
+    end
+
+    it 'skips repositories that already exist' do
+      allow(File).to receive(:directory?).with(repo_path).and_return(true)
+      harvester.clone(repo_name)
+      expect(Git).not_to have_received(:clone)
+    end
+  end
+
+  describe '#clone_all' do
+    it 'can clone all repositories' do
+      harvester.clone_all
+      expect(Git).to have_received(:clone).exactly(2).times
+    end
+
+    it 'skips repositories in the denylist' do
+      harvester.clone_all
+      expect(Git).not_to have_received(:clone).with('https://github.com/OpenGeoMetadata/aardvark.git')
+    end
+
+    it 'returns the names of repositories cloned' do
+      expect(harvester.clone_all).to eq(%w[my-institution another-institution])
+    end
+  end
+
+  describe '#ogm_api_uri' do
+    it 'includes a per_page param' do
+      expect(described_class.send('ogm_api_uri').to_s).to include('per_page')
+    end
+  end
+end

data/spec/lib/geo_combine/indexer_spec.rb

@@ -0,0 +1,134 @@
+# frozen_string_literal: true
+
+require 'geo_combine/indexer'
+require 'spec_helper'
+
+# Mock an available Blacklight installation
+class FakeBlacklight
+  def self.default_index
+    Repository
+  end
+
+  class Repository
+    def self.connection; end
+  end
+end
+
+RSpec.describe GeoCombine::Indexer do
+  subject(:indexer) { described_class.new(solr:, logger:) }
+
+  let(:logger) { instance_double(Logger, warn: nil, info: nil, error: nil, debug: nil) }
+  let(:solr) { instance_double(RSolr::Client, options: { url: 'TEST' }) }
+  let(:docs) do
+    [
+      [{ 'id' => '1' }, 'path/to/record1.json'],              # v1.0 schema
+      [{ 'dc_identifier_s' => '2' }, 'path/to/record2.json']  # aardvark schema
+    ]
+  end
+
+  before do
+    allow(solr).to receive(:update)
+    allow(solr).to receive(:commit)
+  end
+
+  describe '#initialize' do
+    before do
+      allow(RSolr).to receive(:connect).and_return(solr)
+    end
+
+    context 'when solr url is set in the environment' do
+      before do
+        stub_const('ENV', 'SOLR_URL' => 'http://localhost:8983/solr/geoblacklight')
+      end
+
+      it 'connects to the solr instance' do
+        described_class.new(logger:)
+        expect(RSolr).to have_received(:connect).with(
+          be_a(Faraday::Connection),
+          url: 'http://localhost:8983/solr/geoblacklight'
+        )
+      end
+    end
+
+    context 'when there is a configured Blacklight connection' do
+      before do
+        stub_const('Blacklight', FakeBlacklight)
+        allow(FakeBlacklight::Repository).to receive(:connection).and_return(
+          instance_double(RSolr::Client, base_uri: URI('http://localhost:8983/solr/geoblacklight'))
+        )
+      end
+
+      it 'connects to the solr instance' do
+        described_class.new(logger:)
+        expect(RSolr).to have_received(:connect).with(
+          be_a(Faraday::Connection),
+          url: 'http://localhost:8983/solr/geoblacklight'
+        )
+      end
+    end
+
+    context 'when solr url is not set' do
+      before do
+        stub_const('ENV', {})
+      end
+
+      it 'falls back to the Blacklight default' do
+        described_class.new(logger:)
+        expect(RSolr).to have_received(:connect).with(
+          be_a(Faraday::Connection),
+          url: 'http://localhost:8983/solr/blacklight-core'
+        )
+      end
+    end
+  end
+
+  describe '#index' do
+    let(:solr_error_msg) {  { error: { msg: 'error message' } }.to_json }
+    let(:solr_response) { { status: '400', body: solr_error_msg } }
+    let(:error) { RSolr::Error::Http.new({ uri: URI('') }, solr_response) }
+
+    it 'sends records in batches to solr' do
+      indexer.index(docs)
+      expect(solr).to have_received(:update).with(
+        data: "{ add: { doc: {\"id\":\"1\"} },\nadd: { doc: {\"dc_identifier_s\":\"2\"} } }",
+        headers: { 'Content-Type' => 'application/json' },
+        params: { overwrite: true }
+      )
+    end
+
+    it 'commits changes to solr after indexing' do
+      indexer.index(docs)
+      expect(solr).to have_received(:commit).once
+    end
+
+    it 'returns the count of records successfully indexed' do
+      expect(indexer.index(docs)).to eq 2
+    end
+
+    context 'when an error occurs during batch indexing' do
+      before do
+        allow(solr).to receive(:update).and_raise(error)
+        allow(solr).to receive(:add)
+      end
+
+      it 'attempts to index records individually' do
+        total = indexer.index(docs)
+        expect(solr).to have_received(:add).twice
+        expect(total).to eq 2
+      end
+    end
+
+    context 'when an error occurs during individual indexing' do
+      before do
+        allow(solr).to receive(:update).and_raise(error)
+        allow(solr).to receive(:add).with(docs[0][0], anything).and_raise(error)
+        allow(solr).to receive(:add).with(docs[1][0], anything)
+      end
+
+      it 'continues indexing' do
+        total = indexer.index(docs)
+        expect(total).to eq 1
+      end
+    end
+  end
+end

data/spec/lib/geo_combine/migrators/v1_aardvark_migrator_spec.rb

@@ -0,0 +1,46 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe GeoCombine::Migrators::V1AardvarkMigrator do
+  include JsonDocs
+
+  describe '#run' do
+    it 'migrates fields to new names and types' do
+      input_hash = JSON.parse(full_geoblacklight)
+      expected_output = JSON.parse(full_geoblacklight_aardvark)
+      expect(described_class.new(v1_hash: input_hash).run).to eq(expected_output)
+    end
+
+    it 'removes deprecated fields' do
+      input_hash = JSON.parse(full_geoblacklight)
+      output = described_class.new(v1_hash: input_hash).run
+      expect(output.keys).not_to include(described_class::SCHEMA_FIELD_MAP.keys)
+      expect(output.keys).not_to include('dc_type_s')
+      expect(output.keys).not_to include('layer_geom_type_s')
+    end
+
+    it 'leaves custom fields unchanged' do
+      input_hash = JSON.parse(full_geoblacklight)
+      input_hash['custom_field'] = 'custom_value'
+      output = described_class.new(v1_hash: input_hash).run
+      expect(output['custom_field']).to eq('custom_value')
+    end
+
+    context 'when the given record is already in aardvark schema' do
+      it 'returns the record unchanged' do
+        input_hash = JSON.parse(full_geoblacklight_aardvark)
+        expect(described_class.new(v1_hash: input_hash).run).to eq(input_hash)
+      end
+    end
+
+    context 'when the user supplies a mapping for collection names to ids' do
+      it 'converts the collection names to ids' do
+        input_hash = JSON.parse(full_geoblacklight)
+        collection_id_map = { 'Uganda GIS Maps and Data, 2000-2010' => 'stanford-rb371kw9607' }
+        output = described_class.new(v1_hash: input_hash, collection_id_map:).run
+        expect(output['dct_isPartOf_sm']).to eq(['stanford-rb371kw9607'])
+      end
+    end
+  end
+end

data/spec/lib/geo_combine_spec.rb

@@ -2,25 +2,28 @@
 
 require 'spec_helper'
 
-RSpec.describe GeoCombine::Metadata do
+RSpec.describe GeoCombine do
   include XmlDocs
-  describe '#initialize' do
-    it 'reads metadata from file if File is readable' do
-      expect(File).to receive(:readable?).and_return(true)
-      expect(File).to receive(:read).and_return(simple_xml)
-      metadata_object = described_class.new('./tmp/fake/file/location')
-      expect(metadata_object).to be_an described_class
-      expect(metadata_object.metadata).to be_an Nokogiri::XML::Document
-      expect(metadata_object.metadata.css('Author').count).to eq 2
-    end
 
-    it 'reads metadata from parameter if File is not readable' do
-      metadata_object = described_class.new(simple_xml)
-      expect(metadata_object).to be_an described_class
-      expect(metadata_object.metadata).to be_an Nokogiri::XML::Document
-      expect(metadata_object.metadata.css('Author').count).to eq 2
+  describe GeoCombine::Metadata do
+    describe '#initialize' do
+      it 'reads metadata from file if File is readable' do
+        expect(File).to receive(:readable?).and_return(true)
+        expect(File).to receive(:read).and_return(simple_xml)
+        metadata_object = described_class.new('./tmp/fake/file/location')
+        expect(metadata_object).to be_an described_class
+        expect(metadata_object.metadata).to be_an Nokogiri::XML::Document
+        expect(metadata_object.metadata.css('Author').count).to eq 2
+      end
+
+      it 'reads metadata from parameter if File is not readable' do
+        metadata_object = described_class.new(simple_xml)
+        expect(metadata_object).to be_an described_class
+        expect(metadata_object.metadata).to be_an Nokogiri::XML::Document
+        expect(metadata_object.metadata.css('Author').count).to eq 2
+      end
     end
+    # GeoCombine subclasses should individually test `to_geoblacklight` and
+    # `to_html` methods
   end
-  # GeoCombine subclasses should individually test `to_geoblacklight` and
-  # `to_html` methods
 end

data/spec/spec_helper.rb

@@ -7,7 +7,6 @@ SimpleCov.start 'rails' do
   add_filter 'lib/tasks/geo_combine.rake'
   add_filter 'lib/geo_combine/version.rb'
   add_filter 'lib/geo_combine/railtie.rb'
-  add_filter 'lib/geo_combine/cli.rb'
   minimum_coverage 95 # When updating this value, update the README badge value
 end
 
@@ -23,7 +22,7 @@ require 'webmock/rspec'
 WebMock.allow_net_connect!
 
 # include the spec support files
-Dir['./spec/support/**/*.rb'].sort.each { |f| require f }
+Dir['./spec/support/**/*.rb'].each { |f| require f }
 
 RSpec.configure do |config|
   config.include Helpers

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: geo_combine
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.9.0
 platform: ruby
 authors:
 - Jack Reed
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-09-07 00:00:00.000000000 Z
+date: 2024-02-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -108,6 +108,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
+- !ruby/object:Gem::Dependency
+  name: git
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: faraday-retry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.2'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.2'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -237,8 +265,7 @@ dependencies:
 description: A Ruby toolkit for managing geospatial metadata
 email:
 - pjreed@stanford.edu
-executables:
-- geocombine
+executables: []
 extensions: []
 extra_rdoc_files: []
 files:
@@ -251,12 +278,10 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
-- bin/geocombine
 - geo_combine.gemspec
 - lib/geo_combine.rb
 - lib/geo_combine/bounding_box.rb
 - lib/geo_combine/ckan_metadata.rb
-- lib/geo_combine/cli.rb
 - lib/geo_combine/esri_open_data.rb
 - lib/geo_combine/exceptions.rb
 - lib/geo_combine/fgdc.rb
@@ -265,7 +290,11 @@ files:
 - lib/geo_combine/geo_blacklight_harvester.rb
 - lib/geo_combine/geoblacklight.rb
 - lib/geo_combine/geometry_types.rb
+- lib/geo_combine/harvester.rb
+- lib/geo_combine/indexer.rb
 - lib/geo_combine/iso19139.rb
+- lib/geo_combine/logger.rb
+- lib/geo_combine/migrators/v1_aardvark_migrator.rb
 - lib/geo_combine/ogp.rb
 - lib/geo_combine/railtie.rb
 - lib/geo_combine/subjects.rb
@@ -294,6 +323,7 @@ files:
 - spec/fixtures/docs/ckan.json
 - spec/fixtures/docs/esri_open_data.json
 - spec/fixtures/docs/full_geoblacklight.json
+- spec/fixtures/docs/full_geoblacklight_aardvark.json
 - spec/fixtures/docs/geoblacklight_pre_v1.json
 - spec/fixtures/docs/ogp_harvard_line.json
 - spec/fixtures/docs/ogp_harvard_raster.json
@@ -304,6 +334,7 @@ files:
 - spec/fixtures/docs/simple_xslt.xsl
 - spec/fixtures/docs/stanford_iso.xml
 - spec/fixtures/docs/tufts_fgdc.xml
+- spec/fixtures/indexing/aardvark.json
 - spec/fixtures/indexing/basic_geoblacklight.json
 - spec/fixtures/indexing/geoblacklight.json
 - spec/fixtures/indexing/layers.json
@@ -318,10 +349,12 @@ files:
 - spec/lib/geo_combine/formatting_spec.rb
 - spec/lib/geo_combine/geo_blacklight_harvester_spec.rb
 - spec/lib/geo_combine/geoblacklight_spec.rb
+- spec/lib/geo_combine/harvester_spec.rb
+- spec/lib/geo_combine/indexer_spec.rb
 - spec/lib/geo_combine/iso19139_spec.rb
+- spec/lib/geo_combine/migrators/v1_aardvark_migrator_spec.rb
 - spec/lib/geo_combine/ogp_spec.rb
 - spec/lib/geo_combine_spec.rb
-- spec/lib/tasks/geo_combine_spec.rb
 - spec/spec_helper.rb
 - spec/support/fixtures.rb
 homepage: ''
@@ -343,7 +376,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.3.7
 signing_key:
 specification_version: 4
 summary: A Ruby toolkit for managing geospatial metadata
@@ -354,6 +387,7 @@ test_files:
 - spec/fixtures/docs/ckan.json
 - spec/fixtures/docs/esri_open_data.json
 - spec/fixtures/docs/full_geoblacklight.json
+- spec/fixtures/docs/full_geoblacklight_aardvark.json
 - spec/fixtures/docs/geoblacklight_pre_v1.json
 - spec/fixtures/docs/ogp_harvard_line.json
 - spec/fixtures/docs/ogp_harvard_raster.json
@@ -364,6 +398,7 @@ test_files:
 - spec/fixtures/docs/simple_xslt.xsl
 - spec/fixtures/docs/stanford_iso.xml
 - spec/fixtures/docs/tufts_fgdc.xml
+- spec/fixtures/indexing/aardvark.json
 - spec/fixtures/indexing/basic_geoblacklight.json
 - spec/fixtures/indexing/geoblacklight.json
 - spec/fixtures/indexing/layers.json
@@ -378,9 +413,11 @@ test_files:
 - spec/lib/geo_combine/formatting_spec.rb
 - spec/lib/geo_combine/geo_blacklight_harvester_spec.rb
 - spec/lib/geo_combine/geoblacklight_spec.rb
+- spec/lib/geo_combine/harvester_spec.rb
+- spec/lib/geo_combine/indexer_spec.rb
 - spec/lib/geo_combine/iso19139_spec.rb
+- spec/lib/geo_combine/migrators/v1_aardvark_migrator_spec.rb
 - spec/lib/geo_combine/ogp_spec.rb
 - spec/lib/geo_combine_spec.rb
-- spec/lib/tasks/geo_combine_spec.rb
 - spec/spec_helper.rb
 - spec/support/fixtures.rb

data/bin/geocombine

@@ -1,6 +0,0 @@
-#!/usr/bin/env ruby
-# frozen_string_literal: true
-
-require 'geo_combine/cli'
-
-GeoCombine::CLI.start(ARGV)

data/lib/geo_combine/cli.rb

@@ -1,27 +0,0 @@
-# frozen_string_literal: true
-
-require 'thor'
-require 'rake'
-
-root = Gem::Specification.find_by_name('geo_combine').gem_dir
-tasks = File.join(root, 'lib/tasks/*.rake')
-Dir.glob(tasks).each { |r| load r }
-
-module GeoCombine
-  class CLI < Thor
-    desc 'clone', 'Clone all OpenGeoMetadata repositories'
-    def clone
-      Rake::Task['geocombine:clone'].invoke
-    end
-
-    desc 'pull', '"git pull" OpenGeoMetadata repositories'
-    def pull
-      Rake::Task['geocombine:pull'].invoke
-    end
-
-    desc 'index', 'Index all of the GeoBlacklight documents'
-    def index
-      Rake::Task['geocombine:index'].invoke
-    end
-  end
-end

data/spec/lib/tasks/geo_combine_spec.rb

@@ -1,45 +0,0 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-require 'rake'
-
-describe 'geo_combine.rake' do
-  before(:all) do
-    load File.expand_path('../../../lib/tasks/geo_combine.rake', __dir__)
-    Rake::Task.define_task(:environment)
-  end
-
-  before do
-    allow(ENV).to receive(:[]).and_call_original
-    allow(ENV).to receive(:[]).with('OGM_PATH').and_return(File.join(fixture_dir, 'indexing'))
-  end
-
-  describe 'geocombine:clone' do
-    before do
-      WebMock.disable_net_connect!
-    end
-
-    after do
-      WebMock.allow_net_connect!
-    end
-
-    it 'does not clone repos on deny list' do
-      stub_request(:get, 'https://api.github.com/orgs/opengeometadata/repos').to_return(status: 200, body: read_fixture('docs/repos.json'))
-      allow(Kernel).to receive(:system)
-      Rake::Task['geocombine:clone'].invoke
-      expect(Kernel).to have_received(:system).exactly(21).times
-    end
-  end
-
-  describe 'geocombine:index' do
-    it 'only indexes .json files but not layers.json' do
-      rsolr_mock = instance_double(RSolr::Client)
-      allow(rsolr_mock).to receive(:update)
-      allow(rsolr_mock).to receive(:commit)
-      allow(RSolr).to receive(:connect).and_return(rsolr_mock)
-      Rake::Task['geocombine:index'].invoke
-      # We expect 2 files to index
-      expect(rsolr_mock).to have_received(:update).exactly(2).times
-    end
-  end
-end