geneva_drive 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7074e059a0948fb56fa74f002bba45573a5cd89a1018988a1c18046d643f5498
-  data.tar.gz: 90cb36f2142415c9d515d713c5779dcbcfe9da514ee8e5d45db53d4672de7134
+  metadata.gz: 70c9ef44e4b9666d6eb8e4ad93e7e06a7bcc2b00c96ad2271572ab0fc0b11714
+  data.tar.gz: d6e2439f6d272d74eb9e155876416a22d28a097a992f7153954cd6be2eac9b02
 SHA512:
-  metadata.gz: 4b7b5b2f7b41855bbd7650e92179a22eb800c7d8d124d5a2612972fd21469efa4bfc26422a57aff6b53a60564d1adeb27c317774e7e5c5f8ff0cb069d040d50e
-  data.tar.gz: a9a6f805963916273d26f5f3fc6184cae8f2cc203494c1dc6ea18148c71a156c9437221d071d56fe9347e0783088239f55f5e7febb33e0245c22552bd051f56d
+  metadata.gz: f4fc719769aa9cd69604d9ac55d24bbdb06c390bb4009728b1f809247ed284e5aa23e155ab1cdcbf80b3b2e975c30e5d486c67953674550f3a0b58e063283796
+  data.tar.gz: bd0c110f3f0158e1fe8e48faaf957b81c4084b4dfa479be8704ec37f5717e5db54bc754de5738904fc06ef9b7a9bc297883505355274950e9671bc208e1d1373

data/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## [Unreleased]
 
+## [0.3.0]
+
+- Fix `resume!` to retry the failed step instead of skipping it
+- Trim gem dependencies to only activerecord, activejob, activesupport, and railties (no longer depends on full rails gem)
+- Remove unused engine scaffolding (controllers, views, helpers, assets)
+
 ## [0.2.0]
 
 - Add source location tracking to step definitions

data/lib/geneva_drive/executor.rb

@@ -195,13 +195,11 @@ class GenevaDrive::Executor
       transition_step!("in_progress")
       transition_workflow!("performing") if workflow.ready?
 
-      # Set current_step_name to the step being executed,
-      # and next_step_name to what comes after
-      following_step = workflow.steps.next_after(step_def.name)
-      workflow.update!(
-        current_step_name: step_def.name,
-        next_step_name: following_step&.name
-      )
+      # Set current_step_name to the step being executed.
+      # Don't advance next_step_name here - it already points to this step
+      # (set by create_step_execution). We only advance it after successful
+      # completion, so that resume! on a failed step will retry it.
+      workflow.update!(current_step_name: step_def.name)
 
       step_def
     end

data/lib/geneva_drive/flow_control.rb

@@ -186,17 +186,32 @@ module GenevaDrive::FlowControl
   # Skips the current step from outside a step execution.
   # Marks step as skipped and schedules next step (or finishes if last).
   #
-  # @raise [InvalidStateError] if workflow is not in 'ready' state
+  # When called on a 'ready' workflow: marks the scheduled step as skipped.
+  # When called on a 'paused' workflow: skips the failed step (which caused the pause)
+  # and resumes execution with the next step.
+  #
+  # @raise [InvalidStateError] if workflow is not in 'ready' or 'paused' state
   # @return [void]
   def external_skip!
-    raise GenevaDrive::InvalidStateError, "Cannot skip on a #{state} workflow" unless state == "ready"
+    unless %w[ready paused].include?(state)
+      raise GenevaDrive::InvalidStateError, "Cannot skip on a #{state} workflow"
+    end
 
-    logger.info("Flow control: skip! called externally on step #{current_step_name.inspect}")
+    logger.info("Flow control: skip! called externally on step #{next_step_name.inspect}")
     with_lock do
       # with_lock reloads automatically; re-check state in case it changed
-      raise GenevaDrive::InvalidStateError, "Cannot skip on a #{state} workflow" unless state == "ready"
+      unless %w[ready paused].include?(state)
+        raise GenevaDrive::InvalidStateError, "Cannot skip on a #{state} workflow"
+      end
+
+      if state == "paused"
+        # Workflow was paused (e.g., due to failed step). Resume and skip to next step.
+        update!(state: "ready", transitioned_at: nil)
+      else
+        # Workflow is ready with a scheduled step - mark it as skipped
+        current_execution&.mark_skipped!(outcome: "skipped")
+      end
 
-      current_execution&.mark_skipped!(outcome: "skipped")
       schedule_next_step!
     end
   end

data/lib/geneva_drive/jobs/housekeeping_job.rb

@@ -23,7 +23,7 @@
 #   GenevaDrive.stuck_scheduled_threshold = 1.hour
 #   GenevaDrive.stuck_recovery_action = :reattempt # or :cancel
 #
-class GenevaDrive::HousekeepingJob < GenevaDrive::ApplicationJob
+class GenevaDrive::HousekeepingJob < ActiveJob::Base
   queue_as :default
 
   # Performs housekeeping tasks.

data/lib/geneva_drive/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module GenevaDrive
-  VERSION = "0.2.0"
+  VERSION = "0.3.0"
 end

data/test/dummy/config/environments/development.rb

@@ -28,18 +28,6 @@ Rails.application.configure do
   # Change to :null_store to avoid any caching.
   config.cache_store = :memory_store
 
-  # Store uploaded files on the local file system (see config/storage.yml for options).
-  config.active_storage.service = :local
-
-  # Don't care if the mailer can't send.
-  config.action_mailer.raise_delivery_errors = false
-
-  # Make template changes take effect immediately.
-  config.action_mailer.perform_caching = false
-
-  # Set localhost to be used by links generated in mailer templates.
-  config.action_mailer.default_url_options = {host: "localhost", port: 3000}
-
   # Print deprecation notices to the Rails logger.
   config.active_support.deprecation = :log
 
@@ -58,12 +46,6 @@ Rails.application.configure do
   # Raises error for missing translations.
   # config.i18n.raise_on_missing_translations = true
 
-  # Annotate rendered view with file names.
-  config.action_view.annotate_rendered_view_with_filenames = true
-
-  # Uncomment if you wish to allow Action Cable access from any origin.
-  # config.action_cable.disable_request_forgery_protection = true
-
   # Raise error when a before_action's only/except options reference missing actions.
   config.action_controller.raise_on_missing_callback_actions = true
 end

data/test/dummy/config/environments/production.rb

@@ -21,9 +21,6 @@ Rails.application.configure do
   # Enable serving of images, stylesheets, and JavaScripts from an asset server.
   # config.asset_host = "http://assets.example.com"
 
-  # Store uploaded files on the local file system (see config/storage.yml for options).
-  config.active_storage.service = :local
-
   # Assume all access to the app is happening through a SSL-terminating reverse proxy.
   config.assume_ssl = true
 
@@ -52,22 +49,6 @@ Rails.application.configure do
   # Replace the default in-process and non-durable queuing backend for Active Job.
   # config.active_job.queue_adapter = :resque
 
-  # Ignore bad email addresses and do not raise email delivery errors.
-  # Set this to true and configure the email server for immediate delivery to raise delivery errors.
-  # config.action_mailer.raise_delivery_errors = false
-
-  # Set host to be used by links generated in mailer templates.
-  config.action_mailer.default_url_options = {host: "example.com"}
-
-  # Specify outgoing SMTP server. Remember to add smtp/* credentials via rails credentials:edit.
-  # config.action_mailer.smtp_settings = {
-  #   user_name: Rails.application.credentials.dig(:smtp, :user_name),
-  #   password: Rails.application.credentials.dig(:smtp, :password),
-  #   address: "smtp.example.com",
-  #   port: 587,
-  #   authentication: :plain
-  # }
-
   # Enable locale fallbacks for I18n (makes lookups for any locale fall back to
   # the I18n.default_locale when a translation cannot be found).
   config.i18n.fallbacks = true

data/test/dummy/config/environments/test.rb

@@ -28,26 +28,12 @@ Rails.application.configure do
   # Disable request forgery protection in test environment.
   config.action_controller.allow_forgery_protection = false
 
-  # Store uploaded files on the local file system in a temporary directory.
-  config.active_storage.service = :test
-
-  # Tell Action Mailer not to deliver emails to the real world.
-  # The :test delivery method accumulates sent emails in the
-  # ActionMailer::Base.deliveries array.
-  config.action_mailer.delivery_method = :test
-
-  # Set host to be used by links generated in mailer templates.
-  config.action_mailer.default_url_options = {host: "example.com"}
-
   # Print deprecation notices to the stderr.
   config.active_support.deprecation = :stderr
 
   # Raises error for missing translations.
   # config.i18n.raise_on_missing_translations = true
 
-  # Annotate rendered view with file names.
-  # config.action_view.annotate_rendered_view_with_filenames = true
-
   # Raise error when a before_action's only/except options reference missing actions.
   config.action_controller.raise_on_missing_callback_actions = true
 end