generated_schema_validations 0.2.3 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cc227cec06fe251e20eef36cd0d21b05f5014ed6d8a91d18ce23eab11055f99f
-  data.tar.gz: ba0b6b325854965b6c9f30d0341c049396757480a0b9cec0428dfc4ec800ef95
+  metadata.gz: 2d7371cf78c33a1ff16867c837724f1dc51bb7145a83b8d6cf90a8f160382fb3
+  data.tar.gz: 7544fd35cf7dd4daef98a4223c2208bca9a4c74482bbc503290122e216bada3c
 SHA512:
-  metadata.gz: 21dc22f43b73d4782f1ca0b4071f53efbb17b84255d94c8a9f5c97cfed19e24871b10ba0c85bd7354cb3ad9b480406b521b2408e9e57fbd6e58b1f18aa3b22f6
-  data.tar.gz: d1b6d05f58c67a63d04429c4c4ddf4b91edf8838c9bd7a15216045277a077ef52aced4ede41b9a0c0c7a24cdff0844bd67bc14f25136059bd37d03c69c66a81c
+  metadata.gz: 752b409572e541277f7c4313e1c4168223eb740cd4c5a5cdbef4245d1b66953f9f8c34303f25dba4754f00d198d78b59dd2fc1b2704d8d968a1b877cdcbcd295
+  data.tar.gz: 6495630671eb4abb5e8a2f439f0780a27251b1538b092694593ffecba75a5183bd3934ef65615e4b087098eb311f1fce36e339bb920b601a2d5d235a9dbbd12e

data/README.md

@@ -95,6 +95,11 @@ You can watch changes on `schema_validations.rb` to understand the generated val
 
 ## Changelog
 
+### 0.3.0
+
+* Check usage of schema_validations (see #3)
+* Force excluding unique validations with where clause (see #2)
+
 ### 0.2.3
 
 * Add `jsonb` and `xml` as possible field type

data/generated_schema_validations.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |spec|
   spec.name          = 'generated_schema_validations'
-  spec.version       = '0.2.3'
+  spec.version       = '0.3.0'
   spec.authors       = ['Georg Limbach']
   spec.email         = ['georg.limbach@lichtbit.com']
 

data/lib/generated_schema_validations/table.rb

@@ -13,6 +13,7 @@ class GeneratedSchemaValidations::Table
     @table_name = table_name
     @column_names = []
     @possible_belongs_to_not_null_columns = []
+    @bad_indexes = []
     @unique_indexes = []
     @validations = []
 
@@ -25,6 +26,7 @@ class GeneratedSchemaValidations::Table
     if @possible_belongs_to_not_null_columns.present?
       string += "  belongs_to_presence_validations_for(#{@possible_belongs_to_not_null_columns.inspect})\n"
     end
+    string += "  bad_uniqueness_validations_for(#{@bad_indexes.inspect})\n" if @bad_indexes.present?
     string += "  belongs_to_uniqueness_validations_for(#{@unique_indexes.inspect})\n" if @unique_indexes.present?
     string += "  uniqueness_validations_for(#{@unique_indexes.inspect})\n" if @unique_indexes.present?
     string += @validations.uniq.map { |v| "  #{v}\n" }.join
@@ -137,6 +139,10 @@ class GeneratedSchemaValidations::Table
     return unless index_options[:unique]
     return unless names.all? { |name| name.to_s.in?(@column_names) }
 
-    @unique_indexes.push(names.map(&:to_s))
+    if defined?(Rails::Railtie) && (Rails.env.development? || Rails.env.test?) && index_options[:where]
+      @bad_indexes.push(names.map(&:to_s))
+    else
+      @unique_indexes.push(names.map(&:to_s))
+    end
   end
 end

data/lib/generated_schema_validations/template.rb

@@ -11,14 +11,29 @@ module SchemaValidations
 
   included do
     class_attribute :schema_validations_excluded_columns, default: %i[id created_at updated_at type]
+    class_attribute :schema_validations_called, default: false
+
+    if defined?(Rails::Railtie) && (Rails.env.development? || Rails.env.test?)
+      TracePoint.trace(:end) do |t|
+        if t.self.respond_to?(:schema_validations_called) && t.self < ApplicationRecord &&
+           !t.self.schema_validations_called
+          raise "#{t.self}: schema_validations or skip_schema_validations missing"
+        end
+      end
+    end
   end
 
   class_methods do
     def schema_validations(exclude: [], schema_table_name: table_name)
-      self.schema_validations_excluded_columns += exclude
+      self.schema_validations_called = true
+      self.schema_validations_excluded_columns += exclude.map(&:to_sym)
       send("dbv_#{schema_table_name}_validations")
     end
 
+    def skip_schema_validations
+      self.schema_validations_called = true
+    end
+
     TABLE_VALIDATIONS
 
     def validates_with_filter(attribute, options)
@@ -36,6 +51,17 @@ module SchemaValidations
       end
     end
 
+    def bad_uniqueness_validations_for(unique_indexes)
+      unique_indexes.each do |names|
+        names.each do |name|
+          next if name.to_sym.in?(schema_validations_excluded_columns)
+
+          raise "Unique index with where clause is outside the scope of this gem.\n\n" \
+                "You can exclude this column: `schema_validations exclude: [:#{name}]`"
+        end
+      end
+    end
+
     def belongs_to_uniqueness_validations_for(unique_indexes)
       reflect_on_all_associations(:belongs_to).each do |association|
         dbv_uniqueness_validations_for(unique_indexes, foreign_key: association.foreign_key.to_s,

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: generated_schema_validations
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.3.0
 platform: ruby
 authors:
 - Georg Limbach
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-02-28 00:00:00.000000000 Z
+date: 2023-04-20 00:00:00.000000000 Z
 dependencies: []
 description: After each migration it generates a file with some validations. Each
   active record should include this file and can uns generated validations.