generated_schema_validations 0.1.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 977b8c39503dc3cabfad86bc011240a877dfb84c49d12d4f9fe7f643426bbbc0
-  data.tar.gz: 5a6ab82e347f48f6bb7ff5c0308bbfeec6b9f20414967036a0149d2e56592224
+  metadata.gz: 70a54053cb481280797981eb0f5cb1746dc446611de1ef7ed3ee112db984b08b
+  data.tar.gz: 328ee9c6a2638a317018c69689ca2775f247e8d82fc0038669d5f1d4caa91c57
 SHA512:
-  metadata.gz: 06345f91aaa7aa5a8d3b797a80bb70c55e58450aad7e1abf38c136373b3c7db3ed184bcc91ca7ba43f88611628e468700d6c909f30f2b9b06a5aa99749d84c85
-  data.tar.gz: e2ff2c3ed55bb9aa6af514f1ccdb19dc80eb0b098de3c2a141d00cd85cdb3ff01717f6986038619d0048c31b9519a348aff090f3785e725dcc61dc4f7350bd1e
+  metadata.gz: c60e7b895927d42d5534cad96bc2918e633f4bd59b77614cbe8712c46539976a4db2d842004027e757f372ddf77f40f7f1e493f395988788aeee82df178a3a85
+  data.tar.gz: ab1bd36fc0440980e39aa6b2ce18e7311ab38cc2e0a8192aa72818db91be65a5b6bfa47eb0282749a7362f987b63bbe23a13859c5a2c88e0f89d4af85e2e5505

data/.gitignore

@@ -9,3 +9,4 @@
 
 # rspec failure tracking
 .rspec_status
+generated_schema_validations-*.gem

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    generated_schema_validations (0.1.0)
+    generated_schema_validations (0.2.0)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -27,7 +27,7 @@ To generate `app/models/concerns/schema_validations.rb`:
 
 ### Use validations
 
-Add to `app/mode/application_record.rb`:
+Add to `app/models/application_record.rb`:
 
 ```ruby
 class ApplicationRecord < ActiveRecord::Base
@@ -51,7 +51,7 @@ class User < ApplicationRecord
 end
 ```
 
-### Exclude from rubocp and simplecov
+### Exclude from rubocop and simplecov
 
 Add to simplecov config file (e.g. `.simplecov`):
 
@@ -93,6 +93,24 @@ validate :stuff, numericality: true
 
 You can watch changes on `schema_validations.rb` to understand the generated validations.
 
+## Changelog
+
+### 0.2.1
+
+* Close tempfile before reading
+
+### 0.2.0
+
+* Add validations of date and datetime columns to be in database range
+
+### 0.1.2
+
+* Exclude columns in unique validations
+
+### 0.1.1
+
+* Add column type `binary`
+
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/Lichtbit/generated_schema_validations.

data/generated_schema_validations.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |spec|
   spec.name          = 'generated_schema_validations'
-  spec.version       = '0.1.0'
+  spec.version       = '0.2.1'
   spec.authors       = ['Georg Limbach']
   spec.email         = ['georg.limbach@lichtbit.com']
 

data/lib/generated_schema_validations/dumper.rb

@@ -11,10 +11,10 @@ class GeneratedSchemaValidations::Dumper
       raise 'The scheme is not well-formed.' if schema_content.include?('ActiveRecord')
 
       file.write(schema_content)
+      file.close
 
       load file.path
     ensure
-      file.close
       file.unlink
     end
   end

data/lib/generated_schema_validations/table.rb

@@ -76,16 +76,22 @@ class GeneratedSchemaValidations::Table
 
   def datetime(name, column_options = {})
     null_validation(:datetime, name, column_options)
+    validates name, :date_time_in_db_range
   end
 
   def date(name, column_options = {})
     null_validation(:date, name, column_options)
+    validates name, :date_in_db_range
   end
 
   def boolean(name, column_options = {})
     null_validation(:boolean, name, column_options)
   end
 
+  def binary(name, column_options = {})
+    null_validation(:binary, name, column_options)
+  end
+
   def string(name, column_options = {})
     text(name, column_options)
   end

data/lib/generated_schema_validations/template.rb

@@ -54,6 +54,7 @@ module SchemaValidations
     def dbv_uniqueness_validations_for(unique_indexes, foreign_key:, column:)
       unique_indexes.each do |names|
         next unless foreign_key.in?(names)
+        next if column.to_sym.in?(schema_validations_excluded_columns)
 
         scope = (names - [foreign_key]).map(&:to_sym)
         options = { allow_nil: true }
@@ -70,4 +71,24 @@ module SchemaValidations
       end
     end
   end
+
+  class DateTimeInDbRangeValidator < ActiveModel::EachValidator
+    def validate_each(record, attr_name, value)
+      return if value.nil?
+      return unless value.is_a?(DateTime) || value.is_a?(Time)
+      return if value.year.between?(-4711, 294275) # see https://www.postgresql.org/docs/9.3/datatype-datetime.html
+
+      record.errors.add(attr_name, :invalid, options)
+    end
+  end
+
+  class DateInDbRangeValidator < ActiveModel::EachValidator
+    def validate_each(record, attr_name, value)
+      return if value.nil?
+      return unless value.is_a?(Date)
+      return if value.year.between?(-4711, 5874896) # see https://www.postgresql.org/docs/9.3/datatype-datetime.html
+
+      record.errors.add(attr_name, :invalid, options)
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: generated_schema_validations
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Georg Limbach
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-01-07 00:00:00.000000000 Z
+date: 2022-02-03 00:00:00.000000000 Z
 dependencies: []
 description: After each migration it generates a file with some validations. Each
   active record should include this file and can uns generated validations.
@@ -53,7 +53,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.0.8
 signing_key: 
 specification_version: 4
 summary: Generate rails validations from schema.rb file