gene_pool 1.0.0 → 1.0.1

data/History.txt

@@ -1,3 +1,8 @@
+=== 1.0.1 / 2010-09-12
+
+* Bug Fixes
+  * Debug logging was NOT thread-safe
+
 == 1.0.0 / 2010-09-05
 
 * 1 major enhancement:

data/VERSION

@@ -1 +1 @@
-1.0.0
+1.0.1

data/gene_pool.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{gene_pool}
-  s.version = "1.0.0"
+  s.version = "1.0.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Brad Pardee"]
-  s.date = %q{2010-09-08}
+  s.date = %q{2010-09-12}
   s.description = %q{Generic pooling library for creating a connection pool}
   s.email = %q{bradpardee@gmail.com}
   s.extra_rdoc_files = [

data/lib/gene_pool.rb

@@ -58,7 +58,7 @@ class GenePool
       connection = renew(reserved_connection_placeholder)
     end
     
-    @logger.debug "#{@name}: Checkout connection #{connection.object_id} self=#{self}" if @logger && @logger.debug?
+    @logger.debug "#{@name}: Checkout connection #{connection.object_id} self=#{dump}" if @logger && @logger.debug?
     return connection
   end
 
@@ -68,7 +68,7 @@ class GenePool
       @checked_out.delete(connection)
       @queue.signal
     end
-    @logger.debug "#{@name}: Checkin connection #{connection.object_id} self=#{self}" if @logger && @logger.debug?
+    @logger.debug "#{@name}: Checkin connection #{connection.object_id} self=#{dump}" if @logger && @logger.debug?
   end
   
   # Create a scope for checking out a connection
@@ -95,7 +95,7 @@ class GenePool
       @checked_out.delete(connection)
       @queue.signal
     end
-    @logger.debug "#{@name}: Removed connection #{connection.object_id} self=#{self}" if @logger && @logger.debug?
+    @logger.debug "#{@name}: Removed connection #{connection.object_id} self=#{dump}" if @logger && @logger.debug?
   end
 
   # If a connection needs to be renewed for some reason, reassign it here
@@ -122,13 +122,20 @@ class GenePool
   
   # Perform the given block for each connection, i.e., closing each connection.
   def each
-    @connections.each { |connection| yield connection }
+    @mutex.synchronize do
+      @connections.each { |connection| yield connection }
+    end
   end
   
-  def to_s
-    conn = @connections.map{|c| c.object_id}.join(',')
-    chk  = @checked_out.map{|c| c.object_id}.join(',')
-    with = @with_map.keys.map{|k| "#{k}=#{@with_map[k].object_id}"}.join(',')
+  private
+  
+  def dump
+    conn = chk = with = nil
+    @mutex.synchronize do
+      conn = @connections.map{|c| c.object_id}.join(',')
+      chk  = @checked_out.map{|c| c.object_id}.join(',')
+      with = @with_map.keys.map{|k| "#{k}=#{@with_map[k].object_id}"}.join(',')
+    end
     "connections=#{conn} checked_out=#{chk} with_map=#{with}"
   end
 end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
     - 1
     - 0
-    - 0
-  version: 1.0.0
+    - 1
+  version: 1.0.1
 platform: ruby
 authors: 
   - Brad Pardee
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-09-08 00:00:00 -04:00
+date: 2010-09-12 00:00:00 -04:00
 default_executable: 
 dependencies: []