gemsmith 8.2.0 → 9.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 789e4603ef1a279accc50fae9d0b07f92c75e454
-  data.tar.gz: acd7977976268ac612fca91693113bc2364acb7b
+  metadata.gz: b08284244aeaddea3f3d3b8b96080bc3e836b950
+  data.tar.gz: 1c5ffe0e06e10034acee7795a8bf8586325c783d
 SHA512:
-  metadata.gz: 8790821afac91ddb715151e18f3a8f94f8b20c11fce89e53fda64bbcdd893b0b688757d1e3ce2bf584aa78b2fefdb3b0551b26a976386188c857e3b47fe31149
-  data.tar.gz: 3aa6b05408afe61b0cfd61db64e15022a28babdaa511e704d8540b8712ad387aa99b1b891f8af5882ae81cc7496e26b46141c1215dd0b2eed1d4c020c0f5cc7f
+  metadata.gz: ba6952350cd01cbbf932a83ab3afefb4221a9540b8807109b12fc995c13e22763bf4d59532bbd8047463962f1c492a1627d628a0f02776fca5327eeb4eec2316
+  data.tar.gz: c7b95301f395bc829f2949aea66f9226a40012a30ded74e47b749328717ae3e24218a099f3304c4b516deed99cd00ef77ca6f8a0f4864f57911d96150c5ba486

data/README.md

@@ -79,7 +79,7 @@ A command line interface for smithing new Ruby gems.
 # Requirements
 
 0. A UNIX-based system.
-0. [Ruby 2.3.x](https://www.ruby-lang.org).
+0. [Ruby 2.4.x](https://www.ruby-lang.org).
 0. [RubyGems](https://rubygems.org).
 0. [Bundler](https://github.com/bundler/bundler).
 

data/lib/gemsmith/cli.rb

@@ -162,14 +162,14 @@ module Gemsmith
                   type: :boolean,
                   default: configuration.to_h.dig(:generate, :patreon)
     def generate name
-      say
+      print_cli_and_rails_engine_option_error && return if options.cli? && options.rails?
+
       info "Generating gem..."
 
       setup_configuration name: name, options: options.to_h
       self.class.generators.each { |generator| generator.run self, configuration: configuration }
 
       info "Gem generation finished."
-      say
     end
 
     desc "-o, [--open=GEM]", "Open a gem in default editor."
@@ -232,5 +232,10 @@ module Gemsmith
         generate: options.symbolize_keys
       )
     end
+
+    def print_cli_and_rails_engine_option_error
+      error "Generating a gem with CLI and Rails Engine functionality is not allowed. " \
+            "Build separate gems for improved separation of concerns and design."
+    end
   end
 end

data/lib/gemsmith/credentials.rb

@@ -24,7 +24,9 @@ module Gemsmith
       [Authenticators::RubyGems, Authenticators::Basic]
     end
 
-    def initialize key: self.class.default_key, url: self.class.default_url, shell: Bundler::UI::Shell.new
+    def initialize key: self.class.default_key,
+                   url: self.class.default_url,
+                   shell: Bundler::UI::Shell.new
       @key = key
       @url = url
       @shell = shell

data/lib/gemsmith/gem/requirement.rb

@@ -4,7 +4,8 @@ require "versionaire"
 
 module Gemsmith
   module Gem
-    # Defines a gem requirement. This is a partial, cleaner implementation of the RubyGems `Gem::Requirement` object.
+    # Defines a gem requirement. This is a partial, cleaner implementation of the RubyGems
+    # `Gem::Requirement` object.
     class Requirement
       def self.operators
         [">", ">=", "=", "!=", "<", "<=", "~>"]
@@ -20,7 +21,8 @@ module Gemsmith
             operator, version = object.split " "
             new operator: operator, raw_version: version
           else
-            fail Errors::RequirementConversion, %(Invalid string conversion. Use: "<operator> <version>".)
+            fail Errors::RequirementConversion,
+                 %(Invalid string conversion. Use: "<operator> <version>".)
         end
       end
 
@@ -42,7 +44,9 @@ module Gemsmith
 
       def validate!
         return true if self.class.operators.include?(operator)
-        fail Errors::RequirementOperator, %(Invalid gem requirement operator. Use: #{self.class.operators.join ", "}.)
+
+        fail Errors::RequirementOperator,
+             %(Invalid gem requirement operator. Use: #{self.class.operators.join ", "}.)
       end
     end
   end

data/lib/gemsmith/generators/base.rb

@@ -32,6 +32,10 @@ module Gemsmith
       def gem_name
         configuration.dig :gem, :name
       end
+
+      def gem_path
+        configuration.dig :gem, :path
+      end
     end
   end
 end

data/lib/gemsmith/generators/rails.rb

@@ -10,7 +10,7 @@ module Gemsmith
 
       def install_rails
         return if rails?
-        return unless cli.yes?("Ruby on Rails is not installed. Would you like to install it (y/n)?")
+        return unless cli.yes?("Ruby on Rails is not installed. Would you like it installed (y/n)?")
         cli.run "gem install rails"
       end
 
@@ -32,23 +32,12 @@ module Gemsmith
         cli.template "%gem_name%/gemfiles/rails-%rails_version%.x.gemfile.tt", configuration
       end
 
-      def add_comments
-        file = "%gem_name%/app/controllers/%gem_path%/application_controller.rb"
-        comment = "#{indentation}# The application controller.\n"
-        cli.insert_into_file file, comment, before: /.+class.+/
-
-        file = "%gem_name%/app/mailers/%gem_path%/application_mailer.rb"
-        comment = "#{indentation}# The application mailer.\n"
-        cli.insert_into_file file, comment, before: /.+class.+/
-
-        file = "%gem_name%/app/models/%gem_path%/application_record.rb"
-        comment = "#{indentation}# The application record.\n"
-        cli.insert_into_file file, comment, before: /.+class.+/
+      def stub_assets
+        cli.run %(printf "%s" > "#{gem_name}/app/assets/javascripts/#{gem_path}/application.js")
+        cli.run %(printf "%s" > "#{gem_name}/app/assets/stylesheets/#{gem_path}/application.css")
       end
 
       def remove_files
-        gem_path = configuration.dig :gem, :path
-
         cli.remove_file "#{gem_name}/app/helpers/#{gem_path}/application_helper.rb", configuration
         cli.remove_file "#{gem_name}/lib/#{gem_path}/version.rb", configuration
         cli.remove_file "#{gem_name}/MIT-LICENSE", configuration
@@ -62,7 +51,7 @@ module Gemsmith
         create_engine
         create_generator_files
         create_travis_gemfiles
-        add_comments
+        stub_assets
         remove_files
       end
 

data/lib/gemsmith/generators/rake.rb

@@ -33,7 +33,8 @@ module Gemsmith
 
       def configure_rakefile
         return if default_tasks.empty?
-        cli.append_to_file "%gem_name%/Rakefile", %(\ntask default: %w[#{default_tasks.join(" ")}]\n)
+        cli.append_to_file "%gem_name%/Rakefile",
+                           %(\ntask default: %w[#{default_tasks.join(" ")}]\n)
       end
     end
   end

data/lib/gemsmith/generators/rspec.rb

@@ -24,7 +24,11 @@ module Gemsmith
 
       def install_templates
         cli.template "#{rspec_root}/spec_helper.rb.tt", configuration
-        cli.template("#{rspec_root}/rails_helper.rb.tt", configuration) if configuration.dig(:generate, :rails)
+
+        if configuration.dig(:generate, :rails)
+          cli.template("#{rspec_root}/rails_helper.rb.tt", configuration)
+        end
+
         cli.template "#{rspec_root}/support/shared_contexts/temp_dir.rb.tt", configuration
       end
     end

data/lib/gemsmith/generators/rubocop.rb

@@ -10,7 +10,7 @@ module Gemsmith
         cli.uncomment_lines "#{gem_name}/Rakefile", /require.+rubocop.+/
         cli.uncomment_lines "#{gem_name}/Rakefile", /RuboCop.+/
         cli.template "%gem_name%/.rubocop.yml.tt", configuration
-        cli.run "rubocop --auto-correct > /dev/null"
+        cli.run "rubocop --auto-correct #{gem_name} > /dev/null"
       end
     end
   end

data/lib/gemsmith/helpers/cli.rb

@@ -8,7 +8,11 @@ module Gemsmith
 
       def print_gems gems
         say "Multiple versions found:\n\n"
-        gems.each.with_index { |spec, index| say "#{index + 1}. #{spec.name} #{spec.version.version}" }
+
+        gems.each.with_index do |spec, index|
+          say "#{index + 1}. #{spec.name} #{spec.version.version}"
+        end
+
         say "q. Quit.\n\n"
       end
 

data/lib/gemsmith/helpers/template.rb

@@ -2,8 +2,8 @@
 
 module Gemsmith
   module Helpers
-    # Provides helper methods for use by the Thor CLI. These methods are necessary to resolve %% file
-    # and folder variables and render dynamic content within the Thor ERB *templates* structure.
+    # Provides Thor CLI helper methods. These methods are necessary to resolve %% file and folder
+    # variables and render dynamic content within the Thor ERB *templates* structure.
     module Template
       def gem_name
         configuration.dig :gem, :name

data/lib/gemsmith/identity.rb

@@ -12,7 +12,7 @@ module Gemsmith
     end
 
     def self.version
-      "8.2.0"
+      "9.0.0"
     end
 
     def self.version_label

data/lib/gemsmith/rake/publisher.rb

@@ -31,7 +31,8 @@ module Gemsmith
       end
 
       def push
-        creds = credentials.new key: gem_spec.allowed_push_key.to_sym, url: gem_spec.allowed_push_host
+        creds = credentials.new key: gem_spec.allowed_push_key.to_sym,
+                                url: gem_spec.allowed_push_host
         creds.create
 
         options = %(--key "#{translate_key creds.key}" --host "#{gem_spec.allowed_push_host}")
@@ -62,7 +63,8 @@ module Gemsmith
         if status
           shell.confirm "Pushed #{gem_spec.package_file_name} to #{gem_spec.allowed_push_host}."
         else
-          shell.error "Failed pushing #{gem_spec.package_file_name} to #{gem_spec.allowed_push_host}. " \
+          shell.error "Failed pushing #{gem_spec.package_file_name} to " \
+                      "#{gem_spec.allowed_push_host}. " \
                       "Check gemspec and gem credential settings."
         end
 

data/lib/gemsmith/templates/%gem_name%/%gem_name%.gemspec.tt

@@ -18,6 +18,7 @@ Gem::Specification.new do |spec|
   end
   <%- end -%>
 
+  spec.required_ruby_version = "~> <%= config.dig(:versions, :ruby)[/\d{1}\.\d{1}/] %>"
   <%- if config.dig(:generate, :cli) -%>
   spec.add_dependency "thor", "~> 0.19"
   spec.add_dependency "thor_plus", "~> 4.1"
@@ -43,7 +44,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "reek", "~> 4.5"
   <%- end -%>
   <%- if config.dig(:generate, :rubocop) -%>
-  spec.add_development_dependency "rubocop", "~> 0.46"
+  spec.add_development_dependency "rubocop", "~> 0.47"
   <%- end -%>
   <%- if config.dig(:generate, :scss_lint) -%>
   spec.add_development_dependency "scss_lint", "~> 0.50"
@@ -52,7 +53,11 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "codeclimate-test-reporter", "~> 1.0"
   <%- end -%>
 
+  <%- if config.dig(:generate, :rails) -%>
+  spec.files = Dir["app/**/*", "bin/**/*", "config/**/*", "lib/**/*", "vendor/**/*"]
+  <%- else -%>
   spec.files = Dir["lib/**/*"]
+  <%- end -%>
   spec.extra_rdoc_files = Dir["README*", "LICENSE*"]
   <%- if config.dig(:generate, :cli) -%>
   spec.executables << "<%= config.dig(:gem, :name) %>"

data/lib/gemsmith/templates/%gem_name%/.rubocop.yml.tt

@@ -11,6 +11,8 @@ Style/AndOr:
   EnforcedStyle: conditionals
 Style/CaseIndentation:
   IndentOneStep: true
+Style/Documentation:
+  Enabled: false
 Style/EmptyMethod:
   EnforcedStyle: expanded
 Style/MethodDefParentheses:
@@ -43,4 +45,6 @@ Metrics/BlockLength:
     - "**/*.gemspec"
     - "spec/**/*"
 Metrics/LineLength:
-  Max: 120
+  Max: 100
+Metrics/ParameterLists:
+  Max: 3

data/lib/gemsmith/templates/%gem_name%/.travis.yml.tt

@@ -3,6 +3,7 @@ language: ruby
 gemfile:
   - gemfiles/rails-<%= config.dig(:versions, :rails) %>.x.gemfile
 <%- end -%>
+before_install: gem update --system && gem update && gem cleanup
 <%- if config.dig(:generate, :code_climate) -%>
 after_script: bundle exec codeclimate-test-reporter
 <%- end -%>

data/lib/gemsmith/templates/%gem_name%/spec/spec_helper.rb.tt

@@ -11,7 +11,9 @@ require "pry-state"
 <%- end -%>
 <%- unless config.dig(:generate, :rails) -%>require "<%= config.dig(:gem, :path) %>"<%- end -%>
 
-Dir[File.join(File.dirname(__FILE__), "support/shared_contexts/**/*.rb")].each { |file| require file }
+Dir[File.join(File.dirname(__FILE__), "support/shared_contexts/**/*.rb")].each do |file|
+  require file
+end
 
 RSpec.configure do |config|
   config.order = "random"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gemsmith
 version: !ruby/object:Gem::Version
-  version: 8.2.0
+  version: 9.0.0
 platform: ruby
 authors:
 - Brooke Kuhlmann
@@ -30,8 +30,22 @@ cert_chain:
   n/LUZ1dKhIHzfKx1B4+TEIefArObGfkLIDM8+Dq1RX7TF1k81Men7iu4MgE9bYBn
   3dE+xI3FdB5gWcdWxdtgRCmWjtXeYYyb4z6NQQ==
   -----END CERTIFICATE-----
-date: 2016-12-18 00:00:00.000000000 Z
+date: 2017-01-22 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.14'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.14'
 - !ruby/object:Gem::Dependency
   name: thor
   requirement: !ruby/object:Gem::Requirement
@@ -52,98 +66,98 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.1'
+        version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.1'
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: refinements
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: versionaire
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: runcom
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: '0.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: '0.5'
 - !ruby/object:Gem::Dependency
   name: milestoner
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.1'
+        version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.1'
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: pragmater
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: tocer
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -318,14 +332,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.46'
+        version: '0.47'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.46'
+        version: '0.47'
 - !ruby/object:Gem::Dependency
   name: codeclimate-test-reporter
   requirement: !ruby/object:Gem::Requirement
@@ -435,7 +449,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - "~>"
     - !ruby/object:Gem::Version
-      version: '2.3'
+      version: '2.4'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -443,7 +457,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.6.9
 signing_key: 
 specification_version: 4
 summary: A command line interface for smithing new Ruby gems.