gemsmith 12.3.0 → 12.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e71855a6f08321f65becd469a300372e139eb48b42a91d93848671ad7fafacf8
-  data.tar.gz: 526912b2c040acd0bbabd0c40b5c9f5433174d1d190d385949af09f41a976aa3
+  metadata.gz: 6b44005b2a835fdd8da0dd85dfefba1bfe65fd26d4a511c1c755428a26c74a03
+  data.tar.gz: 98101b4e988c1628f0cf875a80d06cd7af672576c49a4ac61b3980f9fedb4028
 SHA512:
-  metadata.gz: 1724540b1ecffb8e97a9d347bed31b509b942416d07e8bee9394052b4128d693fcd3510a6fcaf1ed4f95b061529ce2f41d8936049f00e0c6c9c2bdb43a5b3287
-  data.tar.gz: b2ce13d02d7d27cd8605153c0fc169e40a4fd1bbff4165dbe689ae0c0db1e9db43efe7e36e010c1aac9c036b8e250a55e1eb05ceb680fbfcc47fa088398a8ff9
+  metadata.gz: 15aadf5fd3156836a11f0919d7b42c81838e6fc73781e74e05e186ebd361ef9a3fbf0912a51ce065e3d60d676b9e33dba5e1a8da946cc19ba5c6ca031209b541
+  data.tar.gz: 6bd18fb2cd91f3991b499af532b315372d669f5efb25fc2c53484d6d678f3a3ee05cf077676c3a8f6c05a7e631368812b682475ce0efc64e58da228389875e0c

data/README.md

@@ -57,7 +57,8 @@ A command line interface for smithing new Ruby gems.
 - Supports [Pry](http://pryrepl.org).
 - Supports [Reek](https://github.com/troessner/reek).
 - Supports [RSpec](http://rspec.info).
-- Supports [Rubocop](https://github.com/bbatsov/rubocop).
+- Supports [Rubocop](https://github.com/rubocop-hq/rubocop).
+- Supports [Rubocop RSpec](https://github.com/rubocop-hq/rubocop-rspec).
 - Supports [Ruby on Rails](http://rubyonrails.org).
 - Supports [RubyGems Security](http://guides.rubygems.org/security).
 - Supports [Thor](https://github.com/erikhuda/thor).
@@ -340,6 +341,7 @@ Once your gem is released, you might want to let the world know about your accom
 - [How to Spread the Word About Your Code](https://hacks.mozilla.org/2013/05/how-to-spread-the-word-about-your-code)
 - [Ruby Community](https://www.ruby-lang.org/en/community)
 - [RubyFlow](http://www.rubyflow.com)
+- [RubyDaily](http://rubydaily.org)
 - [Ruby Devs Slack](https://rubydevs.herokuapp.com)
 
 ## Troubleshooting

data/lib/gemsmith/credentials.rb

@@ -8,15 +8,10 @@ require "gemsmith/authenticators/ruby_gems"
 module Gemsmith
   # Generates gem credentials for RubyGems and/or alternative servers.
   class Credentials
-    attr_reader :key, :url
-
-    def self.default_key
-      :rubygems_api_key
-    end
+    DEFAULT_KEY = :rubygems_api_key
+    DEFAULT_URL = "https://rubygems.org"
 
-    def self.default_url
-      "https://rubygems.org"
-    end
+    attr_reader :key, :url
 
     def self.file_path
       File.join ENV.fetch("HOME"), ".gem", "credentials"
@@ -26,14 +21,11 @@ module Gemsmith
       [Authenticators::RubyGems, Authenticators::Basic]
     end
 
-    # :reek:DuplicateMethodCall
-    def initialize key: self.class.default_key,
-                   url: self.class.default_url,
-                   shell: Thor::Shell::Basic.new
+    def initialize key: DEFAULT_KEY, url: DEFAULT_URL, shell: Thor::Shell::Basic.new
       @key = key
       @url = url
       @shell = shell
-      @credentials = load_credentials
+      @credentials = read
     end
 
     def authenticator
@@ -46,39 +38,41 @@ module Gemsmith
     end
 
     def valid?
-      credentials? && !String(credentials[key]).empty?
+      exist? && !String(credentials[key]).empty?
     end
 
-    # rubocop:disable Metrics/AbcSize
-    # :reek:TooManyStatements
     def create
-      return if valid?
-
-      login = shell.ask %(What is your "#{url}" login?)
-      password = shell.ask %(What is your "#{url}" password?), echo: false
-      shell.say
-
-      new_credentials = credentials.merge key => authenticator.new(login, password).authorization
-
-      file_path = self.class.file_path
-      FileUtils.mkdir_p File.dirname file_path
-      File.open(file_path, "w") { |file| file << YAML.dump(new_credentials) }
-      FileUtils.chmod(0o600, file_path)
+      write unless valid?
     end
-    # rubocop:enable Metrics/AbcSize
 
     private
 
     attr_reader :credentials, :shell
 
-    def credentials?
+    def exist?
       File.exist? self.class.file_path
     end
 
-    def load_credentials
+    def read
       Hash YAML.load_file(self.class.file_path)
     rescue StandardError
       {}
     end
+
+    def write
+      file_path = self.class.file_path
+
+      FileUtils.mkdir_p File.dirname file_path
+      File.open(file_path, "w") { |file| file << YAML.dump(update) }
+      FileUtils.chmod 0o600, file_path
+    end
+
+    def update
+      login = shell.ask %(What is your "#{url}" login?)
+      password = shell.ask %(What is your "#{url}" password?), echo: false
+      shell.say
+
+      credentials.merge key => authenticator.new(login, password).authorization
+    end
   end
 end

data/lib/gemsmith/gem/module_formatter.rb

@@ -35,6 +35,7 @@ module Gemsmith
       def body content
         content.lstrip.split("\n").reduce "" do |body, line|
           next "#{body}\n" if line.blank?
+
           body + "#{self.class.indent depth + 1}#{line.gsub(/^\s{2}/, "")}\n"
         end
       end

data/lib/gemsmith/gem/specification.rb

@@ -65,6 +65,7 @@ module Gemsmith
 
       def validate
         return if spec.is_a?(self.class.specification)
+
         fail(Errors::Specification, %(Unknown gem specification: "#{file_path}".))
       end
     end

data/lib/gemsmith/generators/bundler.rb

@@ -7,7 +7,7 @@ module Gemsmith
       def run
         Dir.chdir(gem_root) do
           cli.say_status :info, "Installing gem dependencies...", :green
-          `bundle install`
+          cli.run "bundle install"
         end
       end
     end

data/lib/gemsmith/generators/circle_ci.rb

@@ -6,6 +6,7 @@ module Gemsmith
     class CircleCI < Base
       def run
         return unless configuration.dig(:generate, :circle_ci)
+
         template "%gem_name%/circle.yml.tt"
       end
     end

data/lib/gemsmith/generators/code_climate.rb

@@ -6,6 +6,7 @@ module Gemsmith
     class CodeClimate < Base
       def run
         return unless configuration.dig(:generate, :code_climate)
+
         template "%gem_name%/.codeclimate.yml.tt"
       end
     end

data/lib/gemsmith/generators/engine.rb

@@ -11,6 +11,7 @@ module Gemsmith
       def install_rails
         return if rails?
         return unless cli.yes?("Ruby on Rails is not installed. Would you like it installed (y/n)?")
+
         cli.run "gem install rails"
       end
 

data/lib/gemsmith/generators/git_cop.rb

@@ -6,6 +6,7 @@ module Gemsmith
     class GitCop < Base
       def run
         return unless configuration.dig(:generate, :git_cop)
+
         cli.uncomment_lines "#{gem_name}/Rakefile", %r(require.+git\/cop.+)
       end
     end

data/lib/gemsmith/generators/git_hub.rb

@@ -6,6 +6,7 @@ module Gemsmith
     class GitHub < Base
       def run
         return unless configuration.dig(:generate, :git_hub)
+
         template "%gem_name%/.github/ISSUE_TEMPLATE.md.tt"
         template "%gem_name%/.github/PULL_REQUEST_TEMPLATE.md.tt"
       end

data/lib/gemsmith/generators/guard.rb

@@ -6,6 +6,7 @@ module Gemsmith
     class Guard < Base
       def run
         return unless configuration.dig(:generate, :guard)
+
         template "%gem_name%/Guardfile.tt"
       end
     end

data/lib/gemsmith/generators/rake.rb

@@ -10,11 +10,13 @@ module Gemsmith
 
       def generate_code_quality_task
         return "" if code_quality_tasks.empty?
+
         %(\ndesc "Run code quality checks"\ntask code_quality: %i[#{code_quality_tasks}]\n)
       end
 
       def generate_default_task
         return "" if default_task.empty?
+
         %(\ntask default: %i[#{default_task}]\n)
       end
 
@@ -65,11 +67,13 @@ module Gemsmith
 
       def append_code_quality_task
         return if code_quality_task.empty?
+
         cli.append_to_file "%gem_name%/Rakefile", generate_code_quality_task
       end
 
       def append_default_task
         return if default_task.empty?
+
         cli.append_to_file "%gem_name%/Rakefile", generate_default_task
       end
     end

data/lib/gemsmith/generators/rspec.rb

@@ -30,6 +30,7 @@ module Gemsmith
 
       def install_rails_helper
         return unless configuration.dig(:generate, :engine)
+
         template "#{rspec_root}/rails_helper.rb.tt"
       end
     end

data/lib/gemsmith/git.rb

@@ -13,6 +13,7 @@ module Gemsmith
 
     def self.github_url project
       return "" if github_user.empty?
+
       "https://github.com/#{github_user}/#{project}"
     end
   end

data/lib/gemsmith/helpers/cli.rb

@@ -34,6 +34,7 @@ module Gemsmith
 
       def inspect_gem specification, method
         return unless specification
+
         Gem::Inspector.new.public_send method, Gem::Specification.new(specification.spec_file)
       rescue Versionaire::Errors::Conversion => error
         say_status :error, error.message, :red

data/lib/gemsmith/identity.rb

@@ -12,7 +12,7 @@ module Gemsmith
     end
 
     def self.version
-      "12.3.0"
+      "12.4.0"
     end
 
     def self.version_label

data/lib/gemsmith/rake/builder.rb

@@ -27,6 +27,7 @@ module Gemsmith
 
       def validate
         return if `git status --porcelain`.empty?
+
         shell.error "Build failed: Gem has uncommitted changes."
         kernel.exit 1
       end

data/lib/gemsmith/rake/publisher.rb

@@ -64,7 +64,7 @@ module Gemsmith
       end
 
       def translate_key key
-        key == credentials.default_key ? :rubygems : key
+        key == credentials::DEFAULT_KEY ? :rubygems : key
       end
 
       def process_push status

data/lib/gemsmith/templates/%gem_name%/%gem_name%.gemspec.tt

@@ -55,7 +55,10 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "<%= config.dig(:generate, :engine) ? "rspec-rails" : "rspec" %>", "~> 3.8"
   <%- end -%>
   <%- if config.dig(:generate, :rubocop) -%>
-  spec.add_development_dependency "rubocop", "~> 0.58"
+  spec.add_development_dependency "rubocop", "~> 0.60"
+  <%- end -%>
+  <%- if config.dig(:generate, :rubocop) && config.dig(:generate, :rspec) -%>
+  spec.add_development_dependency "rubocop-rspec", "~> 1.30"
   <%- end -%>
 
   <%- if config.dig(:generate, :engine) -%>

data/lib/gemsmith/templates/%gem_name%/.rubocop.yml.tt

@@ -1,5 +1,13 @@
 inherit_from:
-  - https://raw.githubusercontent.com/bkuhlmann/code_quality/v2.1.0/configurations/rubocop/ruby.yml
+  - https://raw.githubusercontent.com/bkuhlmann/code_quality/2.5.0/configurations/rubocop/ruby.yml
+<%- if config.dig(:generate, :rspec) -%>
+  - https://raw.githubusercontent.com/bkuhlmann/code_quality/2.5.0/configurations/rubocop/rspec.yml
+<%- end -%>
 <%- if config.dig(:generate, :engine) -%>
-  - https://raw.githubusercontent.com/bkuhlmann/code_quality/v2.1.0/configurations/rubocop/rails.yml
+  - https://raw.githubusercontent.com/bkuhlmann/code_quality/2.5.0/configurations/rubocop/rails.yml
+<%- end -%>
+
+<%- if config.dig(:generate, :cli) -%>
+Lint/Void:
+  CheckForMethodsWithNoSideEffects: false
 <%- end -%>

data/lib/gemsmith/templates/%gem_name%/CODE_OF_CONDUCT.md.tt

@@ -2,10 +2,11 @@
 
 ## Our Pledge
 
-In the interest of fostering an open and welcoming environment, we as contributors and maintainers pledge to making
-participation in our project and our community a harassment-free experience for everyone, regardless of age, body size,
-disability, ethnicity, gender identity and expression, level of experience, nationality, personal appearance, race,
-religion, or sexual identity and orientation.
+In the interest of fostering an open and welcoming environment, we as contributors and maintainers
+pledge to making participation in our project and our community a harassment-free experience for
+everyone, regardless of age, body size, disability, ethnicity, sex characteristics, gender identity
+and expression, level of experience, education, socio-economic status, nationality, personal
+appearance, race, religion, or sexual identity and orientation.
 
 ## Our Standards
 
@@ -22,40 +23,44 @@ Examples of unacceptable behavior by participants include:
 * The use of sexualized language or imagery and unwelcome sexual attention or advances
 * Trolling, insulting/derogatory comments, and personal or political attacks
 * Public or private harassment
-* Publishing others' private information, such as a physical or electronic address, without explicit permission
+* Publishing others' private information, such as a physical or electronic address, without explicit
+  permission
 * Other conduct which could reasonably be considered inappropriate in a professional setting
 
 ## Our Responsibilities
 
-Project maintainers are responsible for clarifying the standards of acceptable behavior and are expected to take
-appropriate and fair corrective action in response to any instances of unacceptable behavior.
+Project maintainers are responsible for clarifying the standards of acceptable behavior and are
+expected to take appropriate and fair corrective action in response to any instances of unacceptable
+behavior.
 
-Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits,
-issues, and other contributions that are not aligned to this Code of Conduct, or to ban temporarily or permanently any
-contributor for other behaviors that they deem inappropriate, threatening, offensive, or harmful.
+Project maintainers have the right and responsibility to remove, edit, or reject comments, commits,
+code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, or
+to ban temporarily or permanently any contributor for other behaviors that they deem inappropriate,
+threatening, offensive, or harmful.
 
 ## Scope
 
-This Code of Conduct applies both within project spaces and in public spaces when an individual is representing the
-project or its community. Examples of representing a project or community include using an official project e-mail
-address, posting via an official social media account, or acting as an appointed representative at an online or offline
-event. Representation of a project may be further defined and clarified by project maintainers.
+This Code of Conduct applies both within project spaces and in public spaces when an individual is
+representing the project or its community. Examples of representing a project or community include
+using an official project e-mail address, posting via an official social media account, or acting as
+an appointed representative at an online or offline event. Representation of a project may be
+further defined and clarified by project maintainers.
 
 ## Enforcement
 
-Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team at
-[<%= config.dig :author, :email %>](mailto:<%= config.dig :author, :email %>). All complaints will be reviewed and
-investigated and will result in a response that is deemed necessary and appropriate to the circumstances. The project
-team is obligated to maintain confidentiality with regard to the reporter of an incident. Further details of specific
-enforcement policies may be posted separately.
+Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting
+the project team at [<%= config.dig :author, :name %>](mailto:<%= config.dig :author, :email %>).
+All complaints will be reviewed and investigated and will result in a response that is deemed
+necessary and appropriate to the circumstances. The project team is obligated to maintain
+confidentiality with regard to the reporter of an incident. Further details of specific enforcement
+policies may be posted separately.
 
-Project maintainers who do not follow or enforce the Code of Conduct in good faith may face temporary or permanent
-repercussions as determined by other members of the project's leadership.
+Project maintainers who do not follow or enforce the Code of Conduct in good faith may face
+temporary or permanent repercussions as determined by other members of the project's leadership.
 
 ## Attribution
 
 This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
-available at [http://contributor-covenant.org/version/1/4][version]
+available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.html
 
-[homepage]: http://contributor-covenant.org
-[version]: http://contributor-covenant.org/version/1/4/
+[homepage]: https://www.contributor-covenant.org

data/lib/gemsmith/templates/%gem_name%/spec/lib/%gem_path%/cli_spec.rb.tt

@@ -32,36 +32,43 @@ RSpec.describe <%= config.dig(:gem, :class) %>::CLI do
 
   describe "--config" do
     let(:command) { "--config" }
+
     it_behaves_like "a config command"
   end
 
   describe "-c" do
     let(:command) { "-c" }
+
     it_behaves_like "a config command"
   end
 
   describe "--version" do
     let(:command) { "--version" }
+
     it_behaves_like "a version command"
   end
 
   describe "-v" do
     let(:command) { "-v" }
+
     it_behaves_like "a version command"
   end
 
   describe "--help" do
     let(:command) { "--help" }
+
     it_behaves_like "a help command"
   end
 
   describe "-h" do
     let(:command) { "-h" }
+
     it_behaves_like "a help command"
   end
 
   context "with no command" do
     let(:command) { nil }
+
     it_behaves_like "a help command"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gemsmith
 version: !ruby/object:Gem::Version
-  version: 12.3.0
+  version: 12.4.0
 platform: ruby
 authors:
 - Brooke Kuhlmann
@@ -29,7 +29,7 @@ cert_chain:
   4Zrsxi713z6sndd9JBAm4G7mJiV93MsuCM5N4ZDY7XaxIhvctNSNhX/Yn8LLdtGI
   b4jw5t40FKyNUvLPPXYAvQALBtk=
   -----END CERTIFICATE-----
-date: 2018-08-07 00:00:00.000000000 Z
+date: 2018-11-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -93,14 +93,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.58'
+        version: '0.60'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.58'
+        version: '0.60'
 - !ruby/object:Gem::Dependency
   name: runcom
   requirement: !ruby/object:Gem::Requirement
@@ -339,6 +339,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.8'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.30'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.30'
 - !ruby/object:Gem::Dependency
   name: wirb
   requirement: !ruby/object:Gem::Requirement
@@ -460,7 +474,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.7
+rubygems_version: 2.7.8
 signing_key: 
 specification_version: 4
 summary: A command line interface for smithing new Ruby gems.