gems-status 0.8.0 → 0.9.0

data/lib/gems-status/gems_composite_command.rb

@@ -39,9 +39,9 @@ class GemsCompositeCommand < GemsCommand
     @checkers.each do |check_object|
       Utils::log_debug "checking #{check_object.class.name}"
       @results[@target].sort.each do |k, gems|
-        @checker_results[k] = "" unless @checker_results[k] 
         gems.each do |gem|
           if !check_object.check?(gem)  
+           @checker_results[k] = "" unless @checker_results[k] 
            @checker_results[gem.name] << "
            <br/>#{gem.name} #{gem.version} #{gem.origin}: <br/>
            #{check_object.description} " 
@@ -103,7 +103,6 @@ class GemsCompositeCommand < GemsCommand
         comments = nil
       end
       ViewResults::print_results(k, @results, @target, checker_results, comments)
-      @checker_results.delete(k) 
       @comments.delete(k)
     end
     ViewResults::print_tail(@checker_results, @comments)

data/lib/gems-status/gems_status_metadata.rb

@@ -1,3 +1,3 @@
 module GemsStatusMetadata
-  VERSION = "0.8.0"
+  VERSION = "0.9.0"
 end

data/lib/gems-status/not_a_security_alert_checker.rb

@@ -1,3 +1,4 @@
+require "gmail"
 require "json"
 require "open-uri"
 
@@ -9,24 +10,93 @@ require "gems-status/scm_security_messages"
 
 class NotASecurityAlertChecker < GemChecker
   def initialize(conf)
-    Utils::check_parameters('NotASecurityAlertChecker', conf, ["fixed", "source_repos"])
+    Utils::check_parameters('NotASecurityAlertChecker', conf, ["fixed", "source_repos", "email_username", "email_password", "mailing_lists", "email_to"])
     @fixed = conf["fixed"]
     @source_repos = conf["source_repos"]
     @security_messages = {}
+    @email_username = conf["email_username"]
+    @email_password = conf["email_password"]
+    @mailing_lists = conf["mailing_lists"]
+    @email_to = conf["email_to"]
+    @emails = {}
+    download_emails
   end
 
-  def check?(gem)
-    @security_messages = {}
+  def download_emails
+    #TODO: only download new emails and keep the old ones in a database
+     #puts "Security email alerts from #{mailing_list} #{gmail.inbox.count(:unread, :to => mailing_list}"
+    Gmail.new(@email_username, @email_password) do |gmail|
+     @mailing_lists.each do |mailing_list|
+       @emails[mailing_list] = []
+       Utils::log_debug "Security email alerts from #{mailing_list} #{gmail.inbox.count( :to => mailing_list)}"
+       #TODO: only read new emails
+       #gmail.inbox.emails(:unread, :to => "rubyonrails-security@googlegroups.com").each do |email|
+       gmail.inbox.emails(:to => mailing_list).each do |email|
+         Utils::log_debug "Read #{email.subject}"
+         @emails[mailing_list] << email
+       end
+      end
+    end
+  end
+
+  def send_emails(gem)
+    return if @security_messages.length == 0
+    #gems.origin == gems.gems_url if we are looking to an upstream gem, 
+    #for example in rubygems.org. We only care about our application gems.
+    return if gem.origin == gem.gems_url
+    mssg = ""
+    mssg = "#{gem.name} #{gem.version} : #{gem.origin} \n"
+    @security_messages.each do |k,v|
+      mssg = mssg + "\n #{v}"
+    end
+    email_receiver = @email_to
+    Gmail.new(@email_username, @email_password) do |gmail|
+      gmail.deliver do
+        to email_receiver
+        subject "[gems-status] security alerts for #{gem.name}"
+        text_part do
+           body mssg
+         end
+      end
+    end
+    Utils::log_debug "Email sent to #{@email_to} "
+    Utils::log_debug "with body #{mssg} "
+  end
+
+  def look_in_scm(gem)
     version = gem.version
     source_repo = source_repo(gem)
     if ! source_repo
       Utils::log_error gem.name, "Not source URL for #{gem.name}"
-      @security_messages = {gem.name => "Not source URL for #{gem.name}"} 
-      return false
+      return 
     end
     Utils::log_debug "Source URL for #{gem.name} #{source_repo}"
     look_for_security_messages(gem.name, source_repo)
     filter_security_messages_already_fixed(gem.version)
+  end
+
+  def look_in_emails(gem)
+    @emails.each do |listname, emails|
+      emails.each do |email|
+        if listname.include?(gem.name)
+          @security_messages[Utils::next_key(gem.name)] = email.subject
+          Utils::log_debug "looking for security emails: listname matches gem #{gem.name}: #{listname}"
+          next
+        end
+        if email.subject.include?(gem.name)
+          @security_messages[Utils::next_key(gem.name)] = email.subject
+          Utils::log_debug "looking for security emails: subject matches gem #{gem.name}: #{email.subject}"
+          next
+        end
+      end
+    end
+  end
+
+  def check?(gem)
+    @security_messages = {}
+    look_in_scm(gem)
+    look_in_emails(gem)
+    send_emails(gem)
     return @security_messages.length == 0
   end
 
@@ -42,6 +112,7 @@ class NotASecurityAlertChecker < GemChecker
  private
 
  def filter_security_messages_already_fixed(version)
+   #TODO: let's use a database instead of having the info in yaml file
    @security_messages.delete_if do |k,v|
      @fixed[k] && Gem::Version.new(@fixed[k]) <= version 
    end

data/lib/gems-status/scm_check_messages.rb

@@ -1,6 +1,5 @@
 class ScmCheckMessages
   MAX_RETRIES = 3
-  @@keys = {}
 
   def check_messages(name, source_repo, message_checker, counter = 0)
     begin
@@ -33,10 +32,7 @@ private
   end
 
   def next_key(name)
-    @@keys[name] = 0 unless @@keys[name]
-    key = name + @@keys[name].to_s
-    @@keys[name] = @@keys[name] + 1
-    return key
+    return Utils::next_key(name)
   end
 
   def message(commit)

data/lib/gems-status/utils.rb

@@ -5,11 +5,19 @@ class Utils
   attr_accessor :errors
   @@errors = {}
   @@md5_sums = {}
+  @@keys = {}
 
   def Utils.errors
     return @@errors
   end
-  
+
+  def Utils.next_key(name)
+    @@keys[name] = 0 unless @@keys[name]
+    key = name + @@keys[name].to_s
+    @@keys[name] = @@keys[name] + 1
+    return key
+  end
+
   def Utils.check_parameters(classname, conf, parameters)
     if !conf['classname'] then
       raise "trying to initialize #{classname} when parameter classname does not exists"

data/lib/gems-status/view_results.rb

@@ -3,9 +3,9 @@ require 'gems-status/gems_status_metadata'
 require 'gems-status/utils'
 
 class ViewResults
-  @@patched = 0
-  @@outdated = 0
-  @@up_to_date = 0
+  @@patched = []
+  @@outdated = []
+  @@up_to_date = []
 
   def ViewResults.print_description(ids)
     puts "
@@ -47,18 +47,20 @@ class ViewResults
     <p> At the end there are the errors, checks and comments that do not apply to any of the gems. Look them carefully.
     </p>
     <p>
+    There is a summary at the end.
+    </p>
     You should run gems-status periodically until the lists of errors, patched, outdated and checks are gone.
     </p>
     "
   end
 
-  def ViewResults.update_summary(name_color)
-    if name_color == "alert"
-      @@patched += 1
-    elsif name_color == "warning"
-      @@outdated += 1
+  def ViewResults.update_summary(gem_name, status)
+    if status == "alert"
+      @@patched << gem_name
+    elsif status == "warning"
+      @@outdated << gem_name
     else
-      @@up_to_date += 1
+      @@up_to_date << gem_name
     end
   end
 
@@ -116,9 +118,9 @@ class ViewResults
         md5 = gem.md5
       end
     end
-    puts "<tr><td width='50%'><span class='#{name_color}'>#{k.upcase}</span></td><td width='10%'>version</td><td width='40%'>md5</td></tr>"
+    puts "<tr><td width='50%'><span class='#{name_color}'><a name=\"#{k}\" />#{k}</span></td><td width='10%'>version</td><td width='40%'>md5</td></tr>"
     puts html_string
-    update_summary(name_color)
+    update_summary(k, name_color)
     puts "</table>"
     puts "</p>"
     if checker_results
@@ -145,7 +147,7 @@ class ViewResults
     <style>
     body 
     {
-    font-size: 100%;
+    font-size: 90%;
     }
     h1
     {
@@ -155,7 +157,8 @@ class ViewResults
     h2
     {
     font-size: 100%;
-    font-weight: bold;
+    font-style: italic;
+    font-weight: normal;
     }
     .gem_name
     {
@@ -186,19 +189,19 @@ class ViewResults
     .errors
     {
     color: #ff0000;
-    font-size: 80%;
+    font-size: 100%;
     font-style: italic;
     }
     .check
     {
     color: #a0a0a0;
-    font-size: 80%;
+    font-size: 100%;
     font-style: italic;
     }
     .comment
     {
     color: #a0a0a0;
-    font-size: 80%;
+    font-size: 100%;
     font-style: italic;
     }
     .table_results
@@ -210,24 +213,48 @@ class ViewResults
     <body>"
   end
 
-  def ViewResults.print_hash(desc, data, style)
+  def ViewResults.print_hash(desc, data, style, anchor = false)
     return if !data or data.length == 0
     puts "<p>"
     puts "<h2>#{desc}: #{data.length}</h2>"
-    data.each {|k,v| puts "<span class='#{style}'>#{k.upcase} : #{v}</span><br/>"}
+    data.each do |k,v| 
+      if anchor
+        puts "<a href=\"\##{k}\"><span class='#{style}'>#{k}</span></a>"
+      else
+        puts "<span class='#{style}'>#{k}</span>"
+      end
+      puts "<span class='#{style}'> #{v}</span><br/>"
+
+    end
     puts "</p>"
   end
 
   def ViewResults.print_summary
-    puts "<h2>summary</h2>"
-    puts "patched/errored: #{@@patched} outdated: #{@@outdated} up-to-date: #{@@up_to_date}"
+    puts "<a name='summary'/><h1>Summary</h1>"
+    puts "<p><h2>patched/errored</h2>"
+    puts "<ul>"
+    @@patched.each do |p|
+      puts "<li><a href=\"\##{p}\">#{p}</a>"
+    end
+    puts "</ul></p>"
+    puts "<p><h2>outdated #{@@outdated.length}</h2>"
+    @@outdated.each do |p|
+      puts "<li><a href=\"\##{p}\">#{p}</a>"
+    end
+    puts "</ul></p>"
+    puts "<p> <h2>up-to-date #{@@up_to_date.length}</h2>"
+    @@up_to_date.each do |p|
+      puts "<li><a href=\"\##{p}\">#{p}</a>"
+    end
+    puts "</ul></p>"
   end
 
   def ViewResults.print_tail(checker_results, comments)
-    self.print_hash("checks", checker_results, "check")
+    puts "<h1>Others</h1>"
     self.print_hash("comments", comments, "comment")
     self.print_hash("errors", Utils::errors, "errors")
     self.print_summary
+    self.print_hash("checks", checker_results, "summary", true)
     date = Time.now.strftime('%a %b %d %H:%M:%S %Z %Y')
     puts "<p class='footer'>run by <a href=\"https://github.com/jordimassaguerpla/gems-status\">gems-status</a> - #{date} - version: #{GemsStatusMetadata::VERSION}</p>
     </body>

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: gems-status
 version: !ruby/object:Gem::Version 
-  hash: 63
+  hash: 59
   prerelease: 
   segments: 
   - 0
-  - 8
+  - 9
   - 0
-  version: 0.8.0
+  version: 0.9.0
 platform: ruby
 authors: 
 - Jordi Massaguer Pla
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-06-18 00:00:00 Z
+date: 2012-06-27 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: xml-simple