gems-status 0.28.0 → 0.29.0

data/lib/gems-status/checkers/git_check_messages.rb

@@ -27,4 +27,8 @@ private
     return commit.sha
   end
 
+  def date(commit)
+    commit.date
+  end
+
 end

data/lib/gems-status/checkers/hg_check_messages.rb

@@ -28,5 +28,9 @@ private
     return commit.hash_id
   end
 
+  def date(commit)
+    commit.date
+  end
+
 end
 

data/lib/gems-status/checkers/not_a_security_alert_checker.rb

@@ -3,6 +3,7 @@ require "json"
 require "open-uri"
 
 require "gems-status/checkers/gem_checker"
+require "gems-status/checkers/security_alert"
 require "gems-status/checkers/git_check_messages"
 require "gems-status/checkers/hg_check_messages"
 require "gems-status/checkers/svn_check_messages"
@@ -93,12 +94,12 @@ class NotASecurityAlertChecker < GemChecker
     @emails.each do |listname, emails|
       emails.each do |email|
         if match_name(listname, gem.name)
-          @security_messages[key_for_emails(listname, gem, email)] = email.subject
+          @security_messages[key_for_emails(listname, gem, email)] = SecurityAlert.new(email.subject)
           Utils::log_debug "looking for security emails: listname matches gem #{gem.name}: #{listname}"
           next
         end
         if match_name(email.subject, gem.name)
-          @security_messages[key_for_emails(listname, gem, email)] = email.subject
+          @security_messages[key_for_emails(listname, gem, email)] = SecurityAlert.new(email.subject)
           Utils::log_debug "looking for security emails: subject matches gem #{gem.name}: #{email.subject}"
           next
         end
@@ -113,7 +114,7 @@ class NotASecurityAlertChecker < GemChecker
     @security_messages = {}
     look_in_scm(gem)
     look_in_emails(gem)
-    filter_security_messages_already_fixed(gem.version)
+    filter_security_messages_already_fixed(gem.version, gem.date)
     send_emails(gem)
     return @security_messages.length == 0
   end
@@ -121,7 +122,7 @@ class NotASecurityAlertChecker < GemChecker
  def description
    result = ""
    @security_messages.keys.sort.each do |k|
-     result = result + "[#{k}] - #{@security_messages[k]}"
+     result = result + "[#{k}] - #{@security_messages[k].desc}"
      result = result + "Fixed in #{@fixed[k]}" if @fixed[k]
      result = result + "<br/>" 
    end
@@ -131,12 +132,14 @@ class NotASecurityAlertChecker < GemChecker
 
  private
 
- def filter_security_messages_already_fixed(version)
+ def filter_security_messages_already_fixed(version, date)
    #TODO: let's use a database instead of having the info in yaml file
-   #TODO: can we know which commits are in a particular version? by date?
    @security_messages.delete_if do |k,v|
      @fixed[k] && Gem::Version.new(@fixed[k]) <= version 
    end
+   @security_messages.delete_if do |k,v|
+     v.date && date && v.date < date
+   end
  end
 
  def source_repo(gem)

data/lib/gems-status/checkers/scm_check_messages.rb

@@ -29,7 +29,7 @@ private
           next
         end
         Utils::log_debug "security key: #{key}"
-        results[key] = message(commit)
+        results[key] = SecurityAlert.new(message(commit), date(commit))
       end
     end
     return results
@@ -46,4 +46,8 @@ private
   def messages(name, source_repo)
     raise NotImplementedError 
   end
+
+  def date(commit)
+    raise NotImplementedError
+  end
 end

data/lib/gems-status/checkers/security_alert.rb

@@ -0,0 +1,7 @@
+class SecurityAlert
+  attr_accessor :desc, :date
+  def initialize(desc, date = nil)
+    @desc = desc
+    @date = date
+  end
+end

data/lib/gems-status/checkers/svn_check_messages.rb

@@ -31,4 +31,9 @@ private
     source_repo_splitted = URI.parse(source_repo).path.split("/")
     return source_repo_splitted[-1]
   end
+
+ def date(commit)
+   nil
+ end
+
 end

data/lib/gems-status/gem_simple.rb

@@ -42,5 +42,10 @@ class GemSimple
     return @gems_url && @gems_url.start_with?("git://")
   end
 
+  def date
+    Utils::log_error(@name, "I do not know when #{@name} was released")
+    nil
+  end
+
 end
 

data/lib/gems-status/gems_status_metadata.rb

@@ -1,3 +1,3 @@
 module GemsStatusMetadata
-  VERSION = "0.28.0"
+  VERSION = "0.29.0"
 end

data/lib/gems-status/sources/ruby_gems_gems_gem_simple.rb

@@ -1,4 +1,5 @@
 require "gems-status/gem_simple"
+require "time"
 
 class RubyGemsGems_GemSimple < GemSimple
 
@@ -25,5 +26,18 @@ class RubyGemsGems_GemSimple < GemSimple
     end 
     return @md5
   end
+
+  def date
+    Utils::log_debug "looking for date for #{@name} - #{@version}"
+    versions = JSON.parse(open("https://rubygems.org/api/v1/versions/#{@name}.json").read)
+    versions.each do |version|
+      if Gem::Version.new(version["number"]) == @version
+        Utils::log_debug  "Date for #{@name} - #{@version} : #{version["built_at"]}"
+        return Time.parse version["built_at"]
+      end
+    end
+    nil
+  end
+
 end
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: gems-status
 version: !ruby/object:Gem::Version 
-  hash: 111
+  hash: 107
   prerelease: 
   segments: 
   - 0
-  - 28
+  - 29
   - 0
-  version: 0.28.0
+  version: 0.29.0
 platform: ruby
 authors: 
 - Jordi Massaguer Pla
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-12-14 00:00:00 Z
+date: 2012-12-21 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: xml-simple
@@ -127,6 +127,7 @@ files:
 - lib/gems-status/checkers/hg_check_messages.rb
 - lib/gems-status/checkers/gem_checker.rb
 - lib/gems-status/checkers/exists_in_upstream.rb
+- lib/gems-status/checkers/security_alert.rb
 - lib/gems-status/checkers/not_rails_checker.rb
 - lib/gems-status/checkers/not_a_security_alert_checker.rb
 - lib/gems-status/gems_composite_command.rb
@@ -175,7 +176,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.8.11
+rubygems_version: 1.8.15
 signing_key: 
 specification_version: 3
 summary: compares rubygems from different sources