gemdiff 0.6.12 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 343a5fa8e71fcac1992320d5f9c1b759509c8e05
-  data.tar.gz: 6422b7b33074f0f2832b436d33b9f1f0951198c0
+  metadata.gz: 80e10c9bdcb66f4c19cd26e3c9f9ccb1810f7006
+  data.tar.gz: 06bbdbfb7da6cab122545d91ebc94ae4c56418ce
 SHA512:
-  metadata.gz: 124c7f650aae3e29b4ff7ada2bf44fe69bfad99fe636eaf2ac2e2a486b736ef13dd335a3e74598c53bbe64af0237e8693eba68745562cd8f9c5b4e042fb74545
-  data.tar.gz: f56c3139d47dcbd5f58394ada36a9e05679f2e284a64b3b25dd9d71abb32cb17bb42f48ce042685fdabf238a61d947bc6328f9997c6ea3fe7dce4a97e035bc04
+  metadata.gz: 9c2abd3e49411e4439e78e2410f6dc20b7bdd995094987320a1c9eabab524f35cbe8da125f4294cfc380073412d4f1a6f6c8ea595d86f317c154d5ece38dddb8
+  data.tar.gz: 6f2edf76411e2892ec007440092b5a873c48d1771bc9836ec23ccea178a95d98c34c93a26777bdd7bc5575ff884870ed562dfd4d14186da73bcdbef38aaeaced

data/.travis.yml

@@ -1,5 +1,5 @@
 language: ruby
 rvm:
-  - 2.1.2
+  - 2.1.3
   - 2.0.0
   - 1.9.3

data/README.md

@@ -3,7 +3,7 @@
 [![Gem Version](https://badge.fury.io/rb/gemdiff.svg)](http://rubygems.org/gems/gemdiff)
 [![Build Status](https://travis-ci.org/teeparham/gemdiff.svg?branch=master)](https://travis-ci.org/teeparham/gemdiff)
 
-`gemdiff` is a command-line utility to find and compare source code repositories
+`gemdiff` is a command-line utility to find and compare source code 
 associated with ruby gems. It makes it easy to compare source code differences
 between the current version of a gem in your bundle and the latest version of the gem.
 `gemdiff` helps connect gem version management (rubygems + bundler) with source code (github).
@@ -12,14 +12,14 @@ between the current version of a gem in your bundle and the latest version of th
 
 You want to view the source code differences between versions of gems when your dependencies are updated. 
 `gemdiff` does the source repository lookup, opens common GitHub pages, and simplifies your git workflow for a 
-bundled project (see `outdated`, `update`).
+bundled project.
 
 ### How?
 
 `gemdiff` finds a repository by inspecting the local or remote gemspec, or searching github if needed. 
 It uses bundler to list your outdated gems. For each outdated gem, it determines your currently used version and 
 the version you can update to, and builds a compare view URL with the old and new version tags. 
-It also provides `update` for a simple `bundle update <gem>` and commit workflow.
+It provides `update` for a simple `bundle update <gem>` and commit workflow.
 
 ## Install
 
@@ -32,7 +32,7 @@ gem install gemdiff
 ### `gemdiff outdated`
 
 Runs `bundle outdated --strict` in the current directory.
-For each outdated gem, you can open the compare view for that gem, skip it, or exit all prompts. 
+For each outdated gem, you can open the compare view for that gem, skip it, or exit. 
 Enter `y` to review.
 
 `outdated` is the default task, so `gemdiff` with no arguments is the same as `gemdiff outdated`.
@@ -174,13 +174,12 @@ is not helpful. Some gems' source code is not on GitHub. `gemdiff` could support
 2. The GitHub repository must have tagged releases to show compare views. If you find gems that do not tag 
 releases, submit an issue to the gem maintainer to tag their releases.
 
-3. The versions must be tagged using the standard name format of `v1.2.3`. If you find gems that follow
+3. The versions must be tagged using the standard format of `v1.2.3`. If you find gems that follow
 a non-standard format (such as `1.2.3`), please open an issue or submit a pull request. 
 See [`lib/gemdiff/outdated_gem.rb`](https://github.com/teeparham/gemdiff/blob/master/lib/gemdiff/outdated_gem.rb).
 
-4. Encourage gem maintainers to either enter the GitHub repository URL in the `homepage` field of their gemspec,
-or anywhere in the description. `gemdiff` is much faster if so, and if not, it guesses the best match using
-the GitHub search API. If you find exceptions, open an issue or submit a pull request.
+4. Encourage gem maintainers to enter the GitHub repository URL in the `homepage` field of their gemspec
+or anywhere in the description. If you find exceptions, open an issue or submit a pull request.
 See [`lib/gemdiff/repo_finder.rb`](https://github.com/teeparham/gemdiff/blob/master/lib/gemdiff/repo_finder.rb).
 
 ### More Info

data/gemdiff.gemspec

@@ -24,8 +24,8 @@ Gem::Specification.new do |spec|
   spec.add_dependency "thor", "~> 0.19"
   spec.add_dependency "launchy", "~> 2.4"
 
-  spec.add_development_dependency "bundler", "~> 1.5"
-  spec.add_development_dependency "minitest", "~> 5.3"
-  spec.add_development_dependency "mocha", "~> 1.0"
-  spec.add_development_dependency "rake", "~> 10.1"
+  spec.add_development_dependency "bundler", "~> 1.6"
+  spec.add_development_dependency "minitest", "~> 5.4"
+  spec.add_development_dependency "mocha", "~> 1.1"
+  spec.add_development_dependency "rake", "~> 10.3"
 end

data/lib/gemdiff/repo_finder.rb

@@ -1,4 +1,5 @@
 require 'octokit'
+require 'yaml'
 
 module Gemdiff
   module RepoFinder
@@ -16,7 +17,6 @@ module Gemdiff
         activemodel:                 'rails/rails',
         activerecord:                'rails/rails',
         activesupport:               'rails/rails',
-        color:                       'halostatue/color',
         :"color-schemer"          => 'Team-Sass/color-schemer',
         delayed_job:                 'collectiveidea/delayed_job',
         ffi:                         'ffi/ffi',
@@ -47,8 +47,10 @@ module Gemdiff
         if (full_name = REPO_EXCEPTIONS[gem_name.to_sym])
           return github_repo(full_name)
         end
-        return nil unless (spec = gemspec(gem_name))
-        match = spec.match(GITHUB_REPO_REGEX)
+        return nil unless (yaml = gemspec(gem_name))
+        spec = YAML.load(yaml)
+        return spec.homepage if spec.homepage =~ GITHUB_REPO_REGEX        
+        match = spec.description.match(GITHUB_REPO_REGEX)
         match && match[0]
       end
 
@@ -82,7 +84,7 @@ module Gemdiff
       end
 
       def find_remote_gemspec(name)
-        `gem spec -r #{name}`
+        `gem spec -r #{name}` if last_shell_command_success?
       end
     end
   end

data/lib/gemdiff/version.rb

@@ -1,3 +1,3 @@
 module Gemdiff
-  VERSION = '0.6.12'
+  VERSION = '0.7.0'
 end

data/test/repo_finder_test.rb

@@ -4,7 +4,7 @@ module Gemdiff
   class RepoFinderTest < MiniTest::Spec
     describe ".github_url" do
       it "returns github url from local gemspec" do
-        RepoFinder.stubs find_local_gemspec: "homepage: http://github.com/rails/arel"
+        RepoFinder.stubs find_local_gemspec: fake_gemspec("homepage: http://github.com/rails/arel")
         RepoFinder.stubs  last_shell_command_success?: true
         assert_equal "http://github.com/rails/arel", RepoFinder.github_url("arel")
       end
@@ -12,19 +12,19 @@ module Gemdiff
       it "returns github url from remote gemspec" do
         RepoFinder.stubs find_local_gemspec: ""
         RepoFinder.stubs  last_shell_command_success?: false
-        RepoFinder.stubs find_remote_gemspec: "homepage: http://github.com/rails/arel"
+        RepoFinder.stubs find_remote_gemspec: fake_gemspec("homepage: http://github.com/rails/arel")
         assert_equal "http://github.com/rails/arel", RepoFinder.github_url("arel")
       end
 
       it "returns github url from github search" do
         RepoFinder.stubs octokit_client: mock_octokit("haml/haml")
-        RepoFinder.stubs gemspec: ""
+        RepoFinder.stubs gemspec: fake_gemspec
         assert_equal "http://github.com/haml/haml", RepoFinder.github_url("haml")
       end
 
       it "returns nil when not found" do
         RepoFinder.stubs octokit_client: mock_octokit(nil)
-        RepoFinder.stubs gemspec: ""
+        RepoFinder.stubs gemspec: fake_gemspec
         assert_nil RepoFinder.github_url("not_found")
       end
 
@@ -44,5 +44,17 @@ module Gemdiff
                    end
       mock { stubs search_repositories: mock_items }
     end
+
+FAKE_GEMSPEC = %(
+--- !ruby/object:Gem::Specification
+name: fake
+version: !ruby/object:Gem::Version
+  version: 1.2.3
+description: fake
+)
+
+    def fake_gemspec(extra = "")
+      [FAKE_GEMSPEC, extra].compact.join("\n")
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gemdiff
 version: !ruby/object:Gem::Version
-  version: 0.6.12
+  version: 0.7.0
 platform: ruby
 authors:
 - Tee Parham
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-24 00:00:00.000000000 Z
+date: 2014-10-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: octokit
@@ -58,56 +58,56 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '1.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '1.6'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.3'
+        version: '5.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.3'
+        version: '5.4'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '1.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '1.1'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.1'
+        version: '10.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.1'
+        version: '10.3'
 description: Command-line utility to find source repositories for ruby gems, open
   common github pages, compare gem versions, and simplify gem update workflow in git
 email: