gem_version_check 0.0.9 → 0.0.10

data/README.md

@@ -12,23 +12,31 @@ At XING we use this gem in combination with jenkins to automatically check on ge
 
 Use the Github project name:
 
-    gem_version_check fdietz/team_dashboard activesupport rspec
+    gem_version_check fdietz/team_dashboard
 
 Use any url to a Gemfile.lock:
 
-    gem_version_check https://raw.github.com/fdietz/team_dashboard/raw/master/Gemfile.lock activesupport rspec
+    gem_version_check https://raw.github.com/fdietz/team_dashboard/raw/master/Gemfile.lock
 
 ## Configuration
 
-Use GITHUB_HOST environment variable if you use Enterprise Github:
+Use --host option if you use Enterprise Github:
 
-    GITHUB_HOST=github.mycompany.com gem_version_check fdietz/team_dashboard activesupport rspec
+    gem_version_check fdietz/team_dashboard --host github.mycompany.com
+
+Use --only option if you want to specify the list of gems
+
+    gem_version_check fdietz/team_dashboard --only activesupport,rspec
+
+Use --output-format if you want different formats
+
+    gem_version_check fdietz/team_dashboard --output-format=json
 
 ## Example Report
 
 ### Pretty Print
 
-Example command: gem_version_check fdietz/team_dashboard activesupport rspec
+Example command: gem_version_check fdietz/team_dashboard --only activesupport,rspec
 
 Output:
 

data/lib/gem_version_check/dependency.rb

@@ -7,7 +7,7 @@ module GemVersionCheck
 
     def initialize(name, expected_version = nil)
       @name = name
-      @expected_version = expected_version || latest_version
+      @expected_version = expected_version
     end
 
     def check(lock_file)
@@ -15,7 +15,7 @@ module GemVersionCheck
       @used = !!@version
       return unless used?
       
-      @result = @expected_version == @version
+      @result = expected_version == @version
     end
 
     def valid?
@@ -26,6 +26,14 @@ module GemVersionCheck
       @used
     end
 
+    def gem_not_found?
+      expected_version.nil?
+    end
+
+    def expected_version
+      @expected_version ||= latest_version
+    end
+
     def latest_version
       @latest_version ||= begin
         spec = retrieve_spec

data/lib/gem_version_check/formatter/pretty_print.rb

@@ -27,20 +27,26 @@ module GemVersionCheck
         "Project: #{project.check_failed? ? red : green}#{project.name}#{black}" 
       end
 
-      def dependency_listitem(dependency)
-        " * #{dependency.name}: #{ yield dependency }\n"
+      def dependency_listitem(dep)
+        " #{dep.name}: #{ yield dep }\n"
       end
 
-      def format_dependency(dependency)
-        result = dependency.valid? ? valid_dependency(dependency) : invalid_dependency(dependency)
+      def format_dependency(dep)
+        if dep.gem_not_found?
+          "not found"
+        elsif dep.valid?
+          valid_dependency(dep)
+        else
+          invalid_dependency(dep)
+        end
       end
 
-      def valid_dependency(dependency)
-        "#{green}#{dependency.expected_version} ✓#{black}"
+      def valid_dependency(dep)
+        "#{green}#{dep.expected_version} ✓#{black}"
       end
 
-      def invalid_dependency(dependency)
-        "#{dependency.expected_version} != #{red}#{dependency.version}#{black}"
+      def invalid_dependency(dep)
+        "#{dep.expected_version} != #{red}#{dep.version}#{black}"
       end
 
       def black

data/lib/gem_version_check/version.rb

@@ -1,3 +1,3 @@
 module GemVersionCheck
-  VERSION = "0.0.9"
+  VERSION = "0.0.10"
 end

data/spec/dependency_spec.rb

@@ -9,8 +9,8 @@ module GemVersionCheck
 
       let(:dependency) { Dependency.new("activesupport", "3.2.9") }
       let(:invalid_dependency) { Dependency.new("activesupport", "3.2.10") }
-      let(:not_found_dependency) { Dependency.new("rails", "3.2.9") }
-
+      let(:not_used_dependency) { Dependency.new("rails", "3.2.9") }
+      
       context "#valid?" do
         it "is valid if current version == expected version" do
           dependency.check(lock_file)
@@ -30,8 +30,23 @@ module GemVersionCheck
         end
 
         it "return false if not found in lock file" do
-          not_found_dependency.check(lock_file)
-          not_found_dependency.should_not be_used
+          not_used_dependency.check(lock_file)
+          not_used_dependency.should_not be_used
+        end
+      end
+
+      context "#gem_not_found?" do
+        it "returns false if gem was found on gems server" do
+          dependency.check(lock_file)
+          dependency.should_not be_gem_not_found
+        end
+
+        it "returns true if gem was not found on gems server" do
+          dep = Dependency.new("non_existing_gem") 
+          dep.expects(:retrieve_spec).returns(nil)
+          dep.check(lock_file)
+
+          dep.should be_gem_not_found
         end
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gem_version_check
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 0.0.10
   prerelease: 
 platform: ruby
 authors:
@@ -139,7 +139,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2330606061019261803
+      hash: -4198302242782915360
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -148,7 +148,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2330606061019261803
+      hash: -4198302242782915360
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24