gem_velocity 0.0.8 → 0.0.9

data/lib/gem_velocity.rb

@@ -2,7 +2,14 @@ require "gem_velocity/version"
 require "gem_velocity/helpers"
 require "gem_velocity/gem_data"
 require "gem_velocity/gruff_builder"
-require "gem_velocity/velocitators/all"
+
+require "gem_velocity/velocitators/base_velocitator"
+require "gem_velocity/velocitators/single_velocitator"
+require "gem_velocity/velocitators/aggregated_velocitator"
+require "gem_velocity/velocitators/multiplexer"
+require "gem_velocity/velocitators/factory"
+
+
 require "gem_velocity/errors"
 
 require 'active_support/all'

data/spec/aggregated_velocitor_spec.rb

@@ -0,0 +1,53 @@
+require 'spec_helper'
+
+describe AggregatedVelocitator do
+  before do
+    @gem_name = "haml-i18n-extractor"
+    # it's just a regex match ^version
+    @major_version = "0x"
+    @minor_version = "0.4.x"
+  end
+
+  it "can initialize and find out about all versions in a major" do
+    velocitator = AggregatedVelocitator.new(@gem_name, @major_version)
+    velocitator.versions.should == ["0.5.9", "0.5.8", "0.5.6", "0.5.5", "0.5.4", "0.5.3", "0.5.2", "0.5.1", "0.5.0", "0.4.3", "0.4.2", "0.4.1", "0.4.0", "0.3.5", "0.3.4", "0.3.2", "0.3.0", "0.2.1", "0.2.0", "0.1.0", "0.0.21", "0.0.20", "0.0.19", "0.0.18", "0.0.17", "0.0.16", "0.0.15", "0.0.12", "0.0.10", "0.0.9", "0.0.5"]
+  end
+
+  it "can initialize and find out about all versions in specific a minor" do
+    velocitator = AggregatedVelocitator.new(@gem_name, @minor_version)
+    velocitator.versions.should == ["0.4.3", "0.4.2", "0.4.1", "0.4.0"]
+  end
+
+  it "sends the first and last version passed as versions though" do
+    velocitator = AggregatedVelocitator.new(@gem_name, @minor_version)
+    velocitator.versions = ["0.4.3","0.4.0"]
+  end
+
+  it "sends only one graph that is the total of those versions" do
+    velocitator = AggregatedVelocitator.new(@gem_name, @minor_version)
+    velocitator.line_data.should_not be_empty # [1,2,3]
+  end
+
+  it "sets the max to the multiple of one of its members max * the amount of versions" do
+    velocitator = AggregatedVelocitator.new(@gem_name, @minor_version)
+    velocitator.default_max_value.should eq 356
+  end
+
+  it "sends only one graph and can draw a graph of it" do
+    velocitator = AggregatedVelocitator.new(@gem_name, @minor_version)
+    file = velocitator.graph
+  end
+
+  it "hides the legend caption" do
+    velocitator = AggregatedVelocitator.new(@gem_name, "0.0.17")
+    velocitator.graph_options[:hide_legend].should == true
+  end
+
+  it "should accumlate the same data as a single_velocitator" do
+    a_velocitator = AggregatedVelocitator.new(@gem_name, "0.0.17")
+    s_velocitator = SingleVelocitator.new(@gem_name, "0.0.17")
+    a_velocitator.versions.should == s_velocitator.versions
+    a_velocitator.graph_options[:line_datas].should == s_velocitator.graph_options[:line_datas]
+  end
+
+end

data/spec/factory_spec.rb

@@ -0,0 +1,54 @@
+require 'spec_helper'
+
+describe "velocitator factory" do
+
+  # pass in singles, or aggregated
+
+  it "velocitator generation from name and version" do
+    options = { gem_name: "haml-i18n-extractor", version: "0.0.17" }
+    vg = Factory.new(options)
+    vg.version.should == "0.0.17"
+    vg.versions.should == ["0.0.17"]
+    vg.gem_name.should =="haml-i18n-extractor"
+  end
+
+  it "velocitator generation from full name single" do
+    options = { full_name: "haml-i18n-extractor-0.0.17" }
+    vg = Factory.new(options)
+    vg.version.should == "0.0.17"
+    vg.versions.should == ["0.0.17"]
+    vg.gem_name.should =="haml-i18n-extractor"
+  end
+
+  it "velocitator generation from full name aggregated" do
+    options = { full_name: "haml-i18n-extractor-0.4.x" }
+    vg = Factory.new(options)
+    vg.version.should == "0.4.x"
+    vg.versions.should == ["0.4.3", "0.4.2", "0.4.1", "0.4.0"]
+    vg.gem_name.should =="haml-i18n-extractor"
+  end
+
+  it "velocitator generation from weird full name" do
+    options = { full_name: "haml-i18n-extractor-0.0.17-dashes-mix-it-up" }
+    lambda { 
+      # would be this, but we're raising cause we're hitting rubygems
+      vg = Factory.new(options)
+      vg.version.should == "up"
+      vg.versions.should == ["up"]
+      vg.gem_name.should =="haml-i18n-extractor-0.0.17-dashes-mix-it"
+    }.should raise_error(NoSuchGem)
+  end
+
+  it "is used in making velocitators from base single" do
+    options = { gem_name: "haml-i18n-extractor", version: "0.0.17" }
+    velocitator = BaseVelocitator.create(options)
+    velocitator.class.should == SingleVelocitator
+  end
+
+  it "is used in making velocitators from base aggregated" do
+    options = { gem_name: "haml-i18n-extractor", version: "0.4.x" }
+    velocitator = BaseVelocitator.create(options)
+    velocitator.class.should == AggregatedVelocitator
+  end
+
+end

data/spec/gruff_builder_spec.rb

@@ -1,9 +1,6 @@
 require 'spec_helper'
 
 describe GruffBuilder do
-  before do
-    @tmp_dir = SpecHelper.tmpdir
-  end
 
   it "raises if no root or if versions isnt an array" do
     lambda { builder = GruffBuilder.new(nil,nil,nil,nil, {}) }.should raise_error

data/spec/multiplexer_spec.rb

@@ -0,0 +1,73 @@
+require 'spec_helper'
+
+# TODO this spec duplicates a lot of the velocitator specs?
+# refactor this spec in conjunction with velocitator_spec
+# also, probably should refactor multiplexer to inherit from base_velocitator
+# instead of being it's own thing.
+
+describe Multiplexer do
+  before do
+    # single
+    @v1 = BaseVelocitator.create(:gem_name => "haml-i18n-extractor", :version => "0.0.17")
+    @v2 = BaseVelocitator.create(:gem_name => "haml-i18n-extractor", :version => "0.0.16")
+    # aggregate
+    @v3 = BaseVelocitator.create(:gem_name => "haml-i18n-extractor", :version => "0.4.x")
+    @velocitators = [@v1,@v2,@v3]
+    @multiplexer = Multiplexer.new(@velocitators)
+  end
+
+  it "initializes with velocitators" do
+    @multiplexer = Multiplexer.new(@velocitators)
+    @multiplexer.velocitators.should == [@v1,@v2,@v3]
+  end
+
+  it "keeps the line_datas of each velocitator" do
+    @multiplexer.graph_options[:line_datas].size.should eq 3
+    ld3 = @multiplexer.graph_options[:line_datas].last
+    @v3.line_data.each {|total|
+      ld3.include?(total).should be_true
+    }
+  end
+
+  it "keeps line datas aligned with time" do
+    # could be a better test here (time factored in)
+    @multiplexer.graph_options[:line_datas].map(&:size).sort.uniq.size.should == 1 # all of them should be the same size (padded with 0's)...
+  end
+
+  it "start time is the earliest date of them all" do
+    @velocitators.each { |v|
+      v.effective_start_time.should >= @multiplexer.effective_start_time
+    }
+  end
+
+  it "end time is the latest" do
+    @velocitators.each { |v|
+      v.effective_end_time.should <= @multiplexer.effective_end_time
+    }
+  end
+
+  it "defines the largest max" do
+    @velocitators.each { |v|
+      v.effective_max_value <= @multiplexer.effective_max_value
+    }
+  end
+
+  it "smallest minimum" do
+    @velocitators.each { |v|
+      v.effective_min_value >= @multiplexer.effective_min_value
+    }
+  end
+
+  # FIXME
+  it "sets the root according to the first velocitators root it finds or cwd otherwise" do
+    @multiplexer.root.should == Dir.pwd
+    @v1.root = @tmp_dir
+    @multiplexer.root.should eq @tmp_dir
+  end
+
+  it "can draw a graph" do
+    file = @multiplexer.graph
+    puts file.inspect
+  end
+end
+

data/spec/no_time_cop_spec.rb

@@ -5,53 +5,37 @@ describe 'with no time stubbing', :do_not_use_time_cop do
   # hax slow internet connections make this slow.
   if ENV['VELOCITATOR_REAL_LONG']
     it "has a shortcut graph method #1" do
-      velocitator = SingleVelocitator.new("rails", "2.3.5")
-      # WTF all is shit
+      v = velocitator = SingleVelocitator.new("rails", "2.3.5")
       # https://rubygems.org/gems/rails/versions/2.3.5
-      # should be close to 1m!!
+      # should be close to 1m, but the total from thei api returned is ~33k.
+      # between 2013-03-07 and 2013-03-08 it "starts". but there's a ton of missing data from rubygems.
       #
-      # gb = velocitator.send(:gruff_builder)
-      # gb.line_datas.first.index{|z| z.nonzero?}
-      # => 1199
-      # gb.line_datas.first.size #[1199]
-      # => 1417
-      # 1417 - 1199
-      # => 218
+      # v.send(:gem_data).downloads_metadata(v.version, v.send(:effective_start_time), v.send(:effective_end_time))
+      # _.map(&:last).sum
       #
-      # velocitator.send(:gem_data).send(:downloads_metadata, velocitator.versions.first,velocitator.effective_date_range.first, velocitator.effective_date_range.last).size
-      # => 1417
-      # velocitator.send(:gem_data).downloads_day(velocitator.versions.first,velocitator.effective_date_range.first, velocitator.effective_date_range.last).size
-      # => 218
-      # x = Gems.downloads(velocitator.gem_name, velocitator.versions.first, velocitator.effective_date_range.first, velocitator.effective_date_range.last)
-      # x.to_a.index{|z| z.last.nonzero?}
-      # => 1198
-      #x.to_a.index{|z| z.last.nonzero?}
-      # FIXME . got local dump of database
-      #binding.pry
-     velocitator = SingleVelocitator.new("rails", "2.3.5")
+      # FIXME https://github.com/rubygems/rubygems.org/pull/606 has the method under test which is busted in reality.
       file = velocitator.graph("/tmp")
     end
 
     it "has a shortcut graph method #2" do
-      velocitator = MultipleVelocitator.new("rails", ["4.0.0","3.2.14","0.9.1"])
-      file = velocitator.graph("/tmp", [3.months.ago, Time.now])
+      versions = ["4.0.0","3.2.14","0.9.1"]
+      gem_name = "rails"
+      velocitators = versions.map{|v| SingleVelocitator.new(gem_name, v)}
+      plexer = Multiplexer.new(velocitators)
+      plexer.root = "/tmp"
+      file = plexer.graph("/tmp", [3.months.ago, Time.now])
       File.exist?(file).should be_true
     end
 
     it "has a shortcut graph method #3" do
       velocitator = AggregatedVelocitator.new("rails", "4")
-      puts velocitator.versions
-      puts velocitator.totals.inspect
       file = velocitator.graph("/tmp")
       File.exist?(file).should be_true
     end
 
     it "has a shortcut graph method #4" do
       velocitator = AggregatedVelocitator.new("haml-i18n-extractor", "0") # all of it
-      puts velocitator.aggregated_versions
-      puts velocitator.versions
       file = velocitator.graph("/tmp")
-      puts file.inspect
       File.exist?(file).should be_true
     end
   end

data/spec/single_velocitator_spec.rb

@@ -0,0 +1,92 @@
+require 'spec_helper'
+
+# https://github.com/shaiguitar/rubygems.org/compare/api_not_returning_all_results_over_90_days?expand=1
+
+describe "a Velocitator rendering graphs" do
+
+  # testing single_velocitator is enough to test base
+  it "can render a graph" do
+    velocitator = SingleVelocitator.new("haml-i18n-extractor", "0.0.17")
+    velocitator.date_range = [ 7.days.ago, 3.days.ago ]
+    velocitator.root = SpecHelper.tmpdir
+
+    # Plausible to change this?
+    # the values for the two days mentioned in the date range.
+    # should this be the specific date range values?? aggregated since when? not aggregated?
+    velocitator.graph_options[:line_datas].should == [[303, 303, 303, 304, 304]]
+
+    velocitator.graph_options[:title].should == "haml-i18n-extractor-0.0.17\n(downloads: 377)"
+    velocitator.graph_options[:labels].should == ({1=>"2013-09-13", (velocitator.line_data.size-2) =>"2013-09-17"})
+    velocitator.graph_options[:max_value].should == 306 # the max in the range (time.now)
+    velocitator.graph_options[:min_value].should == 0
+
+    file = velocitator.graph
+    File.exist?(file).should be_true
+    #`open #{file} -a preview.app`
+    #Kernel.sleep(10)
+  end
+
+  it "has a shortcut graph method #1" do
+    velocitator = SingleVelocitator.new("haml-i18n-extractor", "0.0.17")
+    file = velocitator.graph(SpecHelper.tmpdir,[1.day.ago, Time.now])
+    File.exist?(file).should be_true
+  end
+
+  it "has a shortcut graph method #2" do
+    velocitator = SingleVelocitator.new("haml-i18n-extractor", "0.0.17")
+    file = velocitator.graph
+    File.exist?(file).should be_true
+  end
+
+  it "has a shortcut graph metho #3" do
+    velocitator = SingleVelocitator.new("haml-i18n-extractor", "0.0.17")
+    file = velocitator.graph(nil,nil,0,1000)
+    File.exist?(file).should be_true
+  end
+end
+
+describe SingleVelocitator do
+  it 'raises if you dont pass name and version(s)' do
+    lambda { SingleVelocitator.new(nil,nil) }.should raise_error ArgumentError
+  end
+
+  it 'raises if the gem is not found' do
+    lambda { SingleVelocitator.new("NOSICHGEMPlZ123","0.1") }.should raise_error NoSuchGem
+  end
+
+  it 'raises if the version is not found' do
+    lambda { SingleVelocitator.new("haml-i18n-extractor","100.999.42.666.pre") }.should raise_error NoSuchVersion
+  end
+
+  it "holds the totals of the gem" do
+    velocitator = SingleVelocitator.new("haml-i18n-extractor", "0.0.17")
+    velocitator.totals.first[:version_downloads].should eq 377
+    #binding.pry
+  end
+
+  it "sets a specific date range according to the gem's info" do
+    velocitator = SingleVelocitator.new("haml-i18n-extractor", "0.0.17")
+    velocitator.effective_date_range.should eq ["2013-06-16T00:00:00Z", "2013-09-20T00:00:00Z"]
+  end
+
+  it "can override the default time ranges if its in the range" do
+    velocitator = SingleVelocitator.new("haml-i18n-extractor", "0.0.17")
+    velocitator.date_range = [1.day.ago, Time.now]
+    velocitator.effective_date_range.should eq ["2013-09-19T00:00:00Z", "2013-09-20T00:00:00Z"]
+  end
+
+  it "can override a max and min" do
+    velocitator = SingleVelocitator.new("haml-i18n-extractor", "0.0.17")
+    lambda {
+      velocitator.max_value = 500
+      velocitator.min_value = 10
+    }.should_not raise_error
+  end
+
+  it "has line data" do
+    velocitator = SingleVelocitator.new("haml-i18n-extractor", "0.0.17")
+    velocitator.line_data.should_not be_empty # [1,2,3]
+  end
+end
+
+

data/spec/spec_helper.rb

@@ -42,6 +42,10 @@ RSpec.configure do |c|
     end
   end
 
+  c.before(:all) do
+    @tmp_dir = SpecHelper.tmpdir
+  end
+
   c.after(:suite) do
     FileUtils.rm_rf(SpecHelper.tmpdir)
   end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: gem_velocity
 version: !ruby/object:Gem::Version 
-  hash: 15
+  hash: 13
   prerelease: 
   segments: 
   - 0
   - 0
-  - 8
-  version: 0.0.8
+  - 9
+  version: 0.0.9
 platform: ruby
 authors: 
 - Shai Rosenfeld
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2013-10-20 00:00:00 Z
+date: 2013-10-27 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: gruff
@@ -203,9 +203,13 @@ files:
 - README.md
 - Rakefile
 - TODO
-- examples/rails-4.0.0-3.2.14-0.9.1.png
-- examples/rails-4.0.0-3.2.14-2.3.5.png
-- examples/rails-4.0.1.rc1-4.0.0-4.0.0.rc2-4.0.0.rc1-4.0.0.beta1.png
+- examples/README.md
+- examples/generate_images.rb
+- examples/public/images/AggregatedVelocitator-haml-i18n-extractor-0.4.x.png
+- examples/public/images/Multiplexer-haml-i18n-extractor-0.0.17-0.0.16-0.4.x.png
+- examples/public/images/Multiplexer-haml-i18n-extractor-0.4.x-0.3.x.png
+- examples/public/images/SingleVelocitator-haml-i18n-extractor-0.0.16.png
+- examples/public/images/SingleVelocitator-haml-i18n-extractor-0.0.17.png
 - gem_velocity.gemspec
 - lib/gem_velocity.rb
 - lib/gem_velocity/errors.rb
@@ -213,17 +217,20 @@ files:
 - lib/gem_velocity/gruff_builder.rb
 - lib/gem_velocity/helpers.rb
 - lib/gem_velocity/velocitators/aggregated_velocitator.rb
-- lib/gem_velocity/velocitators/all.rb
 - lib/gem_velocity/velocitators/base_velocitator.rb
-- lib/gem_velocity/velocitators/multiple_velocitator.rb
+- lib/gem_velocity/velocitators/factory.rb
+- lib/gem_velocity/velocitators/multiplexer.rb
 - lib/gem_velocity/velocitators/single_velocitator.rb
 - lib/gem_velocity/version.rb
+- spec/aggregated_velocitor_spec.rb
+- spec/factory_spec.rb
 - spec/gem_data_spec.rb
 - spec/gruff_builder_spec.rb
 - spec/helpers_spec.rb
+- spec/multiplexer_spec.rb
 - spec/no_time_cop_spec.rb
+- spec/single_velocitator_spec.rb
 - spec/spec_helper.rb
-- spec/velocitator_spec.rb
 homepage: https://github.com/shaiguitar/gem_velocities
 licenses: 
 - MIT
@@ -258,9 +265,12 @@ signing_key:
 specification_version: 3
 summary: generate gem velocity images
 test_files: 
+- spec/aggregated_velocitor_spec.rb
+- spec/factory_spec.rb
 - spec/gem_data_spec.rb
 - spec/gruff_builder_spec.rb
 - spec/helpers_spec.rb
+- spec/multiplexer_spec.rb
 - spec/no_time_cop_spec.rb
+- spec/single_velocitator_spec.rb
 - spec/spec_helper.rb
-- spec/velocitator_spec.rb

data/lib/gem_velocity/velocitators/all.rb

@@ -1,4 +0,0 @@
-require "gem_velocity/velocitators/base_velocitator"
-require "gem_velocity/velocitators/single_velocitator"
-require "gem_velocity/velocitators/multiple_velocitator"
-require "gem_velocity/velocitators/aggregated_velocitator"

data/lib/gem_velocity/velocitators/multiple_velocitator.rb

@@ -1,34 +0,0 @@
-class MultipleVelocitator < BaseVelocitator
-
-  def initialize(gem_name, versions)
-    super(gem_name, versions)
-  end
-
-  def default_start
-    base_earliest_time_for(versions)
-  end
-
-  def default_max_value
-    base_max_for(versions)
-  end
-
-  def graph_options
-    opts = {
-      :title => title,
-      :labels => ({1 => time_format_str_small(effective_start_time), (line_datas.first.size-2) => time_format_str_small(effective_end_time) }),
-      :max_value => effective_max_value,
-      :min_value => effective_min_value,
-      :line_datas => line_datas,
-    }
-  end
-
-  def line_datas
-    default_line_datas
-  end
-
-  def title
-    "#{gem_name}"
-  end
-
-
-end