gem_velocity 0.0.3 → 0.0.4

data/README.md

@@ -10,32 +10,24 @@ It draws graphs. So...you'll need imagemagick/rmagick. I'm sure you'll survive.
 
 # Example
 
-This spec below:
+Here's one: [celluloid](https://gist.github.com/shaiguitar/7e6d95971c5254fa3665)
+
+Here's some more:
 
 <pre>
-  it "has a shortcut graph method #1" do
-    VCR.use_cassette('velocitator-rails-multiple-graph-shortcut-3') do
-      velocitator = Velocitator.new("rails", ["4.0.0","3.2.14","2.3.5"])
-      file = velocitator.graph("/tmp")
-      File.exist?(file).should be_true
-    end
-  end
+  velocitator = Velocitator.new("rails", ["4.0.0","3.2.14","2.3.5"])
+  file = velocitator.graph("/tmp")
 </pre>
 
 Produces:
 
 ![here](examples/rails-4.0.0-3.2.14-2.3.5.png)
 
-This spec below (notice the date range):
+Notice the date range:
 
 <pre>
-  it "has a shortcut graph method #2" do
-    VCR.use_cassette('velocitator-rails-multiple-graph-shortcut-4') do
-      velocitator = Velocitator.new("rails", ["4.0.0","3.2.14","0.9.1"])
-      file = velocitator.graph("/tmp", [3.months.ago, Time.now])
-      File.exist?(file).should be_true
-    end
-  end
+  velocitator = Velocitator.new("rails", ["4.0.0","3.2.14","0.9.1"])
+  file = velocitator.graph("/tmp", [3.months.ago, Time.now])
 </pre>
 
 Produces:
@@ -53,5 +45,3 @@ Lemme know.
 ## Feedback
 
 Is appreciated! Any (other) ideas?
-
-

data/TODO

@@ -1,5 +1,18 @@
 move VCR to an :around spec
 change readme.md to have one example with different options to populate
-
 Add an aggregate method to add #graph for a point version? (e.g, 0.n.x graph for all n versions. maybe just major, maybe minor, whatever).
 
+web ui/embeddable links with those images.
+  can't remove images
+  have uniq name: hash the date_range,max,min,name,versions. (and time?)
+  shard the directories of where the image goes so it doesn't bomb out?
+
+SingleVersionsVelocitator takes versions
+SingleVersionsVelocitator has a shortcut for displaying all versions in a major?
+MajorVersionsVelocitator takes one major version
+AllVersionsVelocitator takes no version, dispalys all stats
+
+I want to be able to have a line be one version, or a few versions in one, mix those/not, then decide to display them in the end
+  line_datas needs to be abstracted away. actually the versions concepts should be eliminated??
+    so I need to have something abstract a version but it could be a few of them...
+      move all the logic of changing version -> line_data into something and have that able to handle 1 or n.

data/gem_velocity.gemspec

@@ -29,5 +29,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "vcr"
   spec.add_development_dependency "webmock", "= 1.13" # vcr requirement?
   spec.add_development_dependency "timecop"
+  spec.add_development_dependency "sourcify"
+  spec.add_development_dependency "ParseTree"
 
 end

data/lib/gem_velocity/errors.rb

@@ -0,0 +1,5 @@
+class NoData < StandardError; end
+class NoSuchGem < StandardError; end
+class NoSuchVersion < StandardError; end
+
+

data/lib/gem_velocity/gem_data.rb

@@ -15,36 +15,44 @@ class GemData
     h
   end
 
-  def downloads_day(version)
-    # todo rename method? aggregated downloads per day
+  # todo rename method? aggregated downloads per day
+  def downloads_day(version, start_time = nil, end_time = Time.now)
+    start_time = start_time || versions_built_at[version]
     total_so_far = 0
-    # start day 0 as first download day.
     found_first_download = false
-    ret = downloads_metadata(version).map do |day,downloads_that_day|
+    ret = downloads_metadata(version, start_time, end_time).map do |day,downloads_that_day|
       if found_first_download
         total_so_far += downloads_that_day
         [day, total_so_far]
       else
         if !downloads_that_day.zero?
           found_first_download = true
+          total_so_far += downloads_that_day
           nil
         end
       end
     end.compact
   end
 
-  private
-
   def versions_metadata
     # cache api call.
     @versions_metadata ||= Gems.versions(@name)
+    # it should be a hash
+    if @versions_metadata.is_a?(String)
+      if @versions_metadata.match(/This rubygem could not be found/)
+        raise(NoSuchGem, "This rubygem could not be found")
+      end
+    end
+    @versions_metadata
   end
 
-  def downloads_metadata(version)
+  private
+
+  def downloads_metadata(version, start_time, end_time)
     # cache api call.
     @downloads_metadata ||= {}
     return @downloads_metadata[version] if @downloads_metadata[version]
-    @downloads_metadata[version] ||= Gems.downloads(@name, version).to_a
+    @downloads_metadata[version] ||= Gems.downloads(@name, version, start_time, end_time).to_a
   end
 
 

data/lib/gem_velocity/gruff_builder.rb

@@ -7,8 +7,6 @@ end
 
 class GruffBuilder
 
-  class NoData < StandardError; end
-
   MIN_VALUE = 0
   MAX_VALUE = 300
 
@@ -16,9 +14,9 @@ class GruffBuilder
   attr_accessor :title, :labels, :line_datas, :min_value, :max_value
 
   def initialize(root, relative_path, versions, gem_name, gruff_options = {})
-    @root = root || raise("you must set a root. default is root/public/images")
+    @root = root || raise(ArgumentError,"you must set a root. default is root/public/images")
     @relative_path = relative_path || "public/images/"
-    @versions = versions.is_a?(Array) ? versions : raise("versions must be an array")
+    @versions = versions.is_a?(Array) ? versions : raise(ArgumentError,"versions must be an array")
     @gem_name = gem_name
     @title = gruff_options[:title] || ""
     @labels = gruff_options[:labels] || {}

data/lib/gem_velocity/velocitator.rb

@@ -15,11 +15,13 @@ class Velocitator
 
   def initialize(gem_name, versions)
     @gem_name = gem_name || raise(ArgumentError, 'need a name')
-    @versions = if versions.is_a?(String) 
+    @versions = if versions.is_a?(String)
                   [versions]
                 else
                   versions
                 end || raise(ArgumentError, 'required versions')
+    validate_correct_gem
+    validate_correct_versions
   end
 
   def date_range=(args)
@@ -30,6 +32,19 @@ class Velocitator
     @date_range = args.map{|t| time_format_str(t) }
   end
 
+  def effective_date_range
+    # we allow overwriting by passing a date range.
+    if @date_range.is_a?(Array) && @date_range.compact.size==2
+      @date_range
+    else
+      default_date_range
+    end
+  end
+
+  def title
+    "#{gem_name}-#{versions.join("-")}"
+  end
+
   def line_datas
     versions.map do |v|
       specific_days_in_range.map do |day_in_range|
@@ -43,23 +58,13 @@ class Velocitator
     end
   end
 
-  def effective_date_range
-    # we allow overwriting by passing a date range.
-    if @date_range.is_a?(Array) && @date_range.compact.size==2
-      @date_range
-    else
-      default_date_range
-    end
-  end
-
-  # call, after you set all the attributes you want.
+  # after you set all the attributes you want.
   # you can set (or there will be fallback defaults)
-  #
   # max, min
   # date_range (leave nil for default values in either start or end)
   def gruff_builder
     opts = {
-      :title => "#{gem_name}-#{versions.join("-")}",
+      :title => title,
       # just the first and last dates. give a small offset so it fits into the pciture.
       # line_datas.first.size -2 should be the max of any one of the line-datas, all should be same size.
       :labels => ({1 => time_format_str_small(effective_start_time), (line_datas.first.size-2) => time_format_str_small(effective_end_time) }),
@@ -134,4 +139,16 @@ class Velocitator
   def gem_data
     @gem_data ||= GemData.new(@gem_name)
   end
+
+  def validate_correct_versions
+    versions.each do |v|
+      gem_data.versions.include?(v) || raise(NoSuchVersion,"version not found for #{versions}.")
+    end
+  end
+
+  def validate_correct_gem
+    # this will bomb out if bad version is passed.
+    gem_data.versions_metadata
+  end
+
 end

data/lib/gem_velocity/version.rb

@@ -1,3 +1,3 @@
 module GemVelocity
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/lib/gem_velocity.rb

@@ -3,6 +3,7 @@ require "gem_velocity/helpers"
 require "gem_velocity/gem_data"
 require "gem_velocity/gruff_builder"
 require "gem_velocity/velocitator"
+require "gem_velocity/errors"
 
 require 'active_support/all'
 require 'date'

data/spec/gem_data_spec.rb

@@ -1,27 +1,17 @@
 require 'spec_helper'
 
 describe GemData do
-  before do
-    Timecop.travel(Time.local(2013, 10, 7, 0, 0, 0))
-    Timecop.freeze
- end
-
   it "collects version info for a given gem" do
-    VCR.use_cassette('gem-data-haml-i18n-extractor-0.0.17-versions') do
-      GemData.new("haml-i18n-extractor").versions.should include "0.0.17"
-    end
+    GemData.new("haml-i18n-extractor").versions.should include "0.0.17"
   end
 
   it "maps built_at and versions for access" do
-    VCR.use_cassette('gem-data-haml-i18n-extractor-0.0.17-versions-built-at') do
-      GemData.new("haml-i18n-extractor").versions_built_at["0.0.17"].should == "2013-06-16T00:00:00Z"
-    end
+    GemData.new("haml-i18n-extractor").versions_built_at["0.0.17"].should == "2013-06-16T00:00:00Z"
   end
 
   it "can show download information" do
-    VCR.use_cassette('gem-data-haml-i18n-extractor-0.0.17-downloads-day') do
-      GemData.new("haml-i18n-extractor").downloads_day("0.0.17").should == [["2013-07-11", 3], ["2013-07-12", 5], ["2013-07-13", 6], ["2013-07-14", 6], ["2013-07-15", 8], ["2013-07-16", 10], ["2013-07-17", 16], ["2013-07-18", 16], ["2013-07-19", 19], ["2013-07-20", 20], ["2013-07-21", 20], ["2013-07-22", 22], ["2013-07-23", 23], ["2013-07-24", 29], ["2013-07-25", 29], ["2013-07-26", 29], ["2013-07-27", 29], ["2013-07-28", 29], ["2013-07-29", 30], ["2013-07-30", 32], ["2013-07-31", 34], ["2013-08-01", 34], ["2013-08-02", 34], ["2013-08-03", 34], ["2013-08-04", 34], ["2013-08-05", 36], ["2013-08-06", 36], ["2013-08-07", 36], ["2013-08-08", 39], ["2013-08-09", 39], ["2013-08-10", 39], ["2013-08-11", 39], ["2013-08-12", 40], ["2013-08-13", 42], ["2013-08-14", 43], ["2013-08-15", 45], ["2013-08-16", 45], ["2013-08-17", 46], ["2013-08-18", 46], ["2013-08-19", 46], ["2013-08-20", 46], ["2013-08-21", 47], ["2013-08-22", 49], ["2013-08-23", 53], ["2013-08-24", 53], ["2013-08-25", 54], ["2013-08-26", 54], ["2013-08-27", 56], ["2013-08-28", 56], ["2013-08-29", 58], ["2013-08-30", 58], ["2013-08-31", 58], ["2013-09-01", 60], ["2013-09-02", 62], ["2013-09-03", 63], ["2013-09-04", 63], ["2013-09-05", 65], ["2013-09-06", 67], ["2013-09-07", 67], ["2013-09-08", 67], ["2013-09-09", 68], ["2013-09-10", 68], ["2013-09-11", 68], ["2013-09-12", 73], ["2013-09-13", 73], ["2013-09-14", 73], ["2013-09-15", 73], ["2013-09-16", 74], ["2013-09-17", 74], ["2013-09-18", 74], ["2013-09-19", 75], ["2013-09-20", 76], ["2013-09-21", 76], ["2013-09-22", 76], ["2013-09-23", 76], ["2013-09-24", 79], ["2013-09-25", 83], ["2013-09-26", 90], ["2013-09-27", 90], ["2013-09-28", 90], ["2013-09-29", 92], ["2013-09-30", 92], ["2013-10-01", 92], ["2013-10-02", 92], ["2013-10-03", 92], ["2013-10-04", 94], ["2013-10-05", 94], ["2013-10-06", 94], ["2013-10-07", 95]]
-    end
+    result = GemData.new("haml-i18n-extractor").downloads_day("0.0.17")
+    result.should == [["2013-06-17", 54], ["2013-06-18", 57], ["2013-06-19", 58], ["2013-06-20", 62], ["2013-06-21", 63], ["2013-06-22", 68], ["2013-06-23", 70], ["2013-06-24", 73], ["2013-06-25", 82], ["2013-06-26", 243], ["2013-06-27", 246], ["2013-06-28", 248], ["2013-06-29", 248], ["2013-06-30", 248], ["2013-07-01", 248], ["2013-07-02", 255], ["2013-07-03", 258], ["2013-07-04", 260], ["2013-07-05", 260], ["2013-07-06", 263], ["2013-07-07", 263], ["2013-07-08", 265], ["2013-07-09", 266], ["2013-07-10", 268], ["2013-07-11", 271], ["2013-07-12", 273], ["2013-07-13", 274], ["2013-07-14", 274], ["2013-07-15", 276], ["2013-07-16", 278], ["2013-07-17", 284], ["2013-07-18", 284], ["2013-07-19", 287], ["2013-07-20", 288], ["2013-07-21", 288], ["2013-07-22", 290], ["2013-07-23", 291], ["2013-07-24", 297], ["2013-07-25", 297], ["2013-07-26", 297], ["2013-07-27", 297], ["2013-07-28", 297], ["2013-07-29", 298], ["2013-07-30", 300], ["2013-07-31", 302], ["2013-08-01", 302], ["2013-08-02", 302], ["2013-08-03", 302], ["2013-08-04", 302], ["2013-08-05", 304], ["2013-08-06", 304], ["2013-08-07", 304], ["2013-08-08", 307], ["2013-08-09", 307], ["2013-08-10", 307], ["2013-08-11", 307], ["2013-08-12", 308], ["2013-08-13", 310], ["2013-08-14", 311], ["2013-08-15", 313], ["2013-08-16", 313], ["2013-08-17", 314], ["2013-08-18", 314], ["2013-08-19", 314], ["2013-08-20", 314], ["2013-08-21", 315], ["2013-08-22", 317], ["2013-08-23", 321], ["2013-08-24", 321], ["2013-08-25", 322], ["2013-08-26", 322], ["2013-08-27", 324], ["2013-08-28", 324], ["2013-08-29", 326], ["2013-08-30", 326], ["2013-08-31", 326], ["2013-09-01", 328], ["2013-09-02", 330], ["2013-09-03", 331], ["2013-09-04", 331], ["2013-09-05", 333], ["2013-09-06", 335], ["2013-09-07", 335], ["2013-09-08", 335], ["2013-09-09", 336], ["2013-09-10", 336], ["2013-09-11", 336], ["2013-09-12", 341], ["2013-09-13", 341], ["2013-09-14", 341], ["2013-09-15", 341], ["2013-09-16", 342], ["2013-09-17", 342], ["2013-09-18", 342], ["2013-09-19", 343], ["2013-09-20", 344]]
   end
 
 

data/spec/no_time_cop_spec.rb

@@ -1,17 +1,16 @@
 require 'spec_helper'
 
-describe 'with no time stubbing' do
+describe 'with no time stubbing', :do_not_use_time_cop do
 
-  it "has a shortcut graph method #1" do
-    VCR.use_cassette('velocitator-rails-multiple-graph-shortcut-3') do
+  # hax slow internet connections make this slow.
+  if ENV['VELOCITATOR_REAL_LONG']
+    it "has a shortcut graph method #1" do
       velocitator = Velocitator.new("rails", ["4.0.0","3.2.14","2.3.5"])
       file = velocitator.graph("/tmp")
       File.exist?(file).should be_true
     end
-  end
 
-  it "has a shortcut graph method #2" do
-    VCR.use_cassette('velocitator-rails-multiple-graph-shortcut-4') do
+    it "has a shortcut graph method #2" do
       velocitator = Velocitator.new("rails", ["4.0.0","3.2.14","0.9.1"])
       file = velocitator.graph("/tmp", [3.months.ago, Time.now])
       File.exist?(file).should be_true

data/spec/spec_helper.rb

@@ -1,12 +1,14 @@
 require 'gem_velocity'
 require 'pry'
 require 'vcr'
+require 'sourcify'
 require 'active_support/all' # time
 require 'timecop'
 
 VCR.configure do |c|
   c.cassette_library_dir = 'spec/fixtures/vcr_cassettes'
   c.hook_into :webmock # or :fakeweb
+  c.default_cassette_options = { :record => :new_episodes }
 end
 
 module SpecHelper
@@ -16,6 +18,27 @@ module SpecHelper
 end
 
 RSpec.configure do |c|
+  c.treat_symbols_as_metadata_keys_with_true_values = true
+  c.around(:each) do |example|
+    #freeze time unless explicitly said not to!
+    unless example.metadata[:do_not_use_time_cop]
+      Timecop.travel(Time.local(2013, 9, 20, 10, 0, 0))
+      Timecop.freeze
+    end
+    example.run
+    unless example.metadata[:do_not_use_time_cop]
+      Timecop.return
+    end
+  end
+
+  c.around(:each) do |example|
+    example_hashified = example.metadata[:description_args].first.unpack("s").first
+    puts "\nRunning example: #{example.metadata[:description_args]}\n"
+    VCR.use_cassette("rspec-example-#{(example_hashified)}") do
+      example.run
+    end
+  end
+
   c.after(:suite) do
     FileUtils.rm_rf(SpecHelper.tmpdir)
   end

data/spec/velocitator_spec.rb

@@ -2,91 +2,78 @@ require 'spec_helper'
 
 describe Velocitator do
 
-  before do
-    # for Time.now
-    # Also, the 10 mins flattens out to 00: but we don't care at this point as it's day by day.
-    Timecop.travel(Time.local(2013, 9, 20, 10, 0, 0))
-    Timecop.freeze
+  it 'raises if you dont pass name and version(s)' do
+    lambda { Velocitator.new(nil,nil) }.should raise_error ArgumentError
   end
 
-  after do
-    Timecop.return
+  it 'raises if the gem is not found' do
+    lambda { Velocitator.new("NOSICHGEMPlZ123","0.1") }.should raise_error NoSuchGem
   end
 
-  it 'raises if you dont pass name and version(s)' do
-    lambda { Velocitator.new(nil,nil) }.should raise_error ArgumentError
+  it 'raises if the version is not found' do
+    # cause the .pre matters!!1
+    lambda { Velocitator.new("haml-i18n-extractor","100.999.42.666.pre") }.should raise_error NoSuchVersion
   end
 
-  describe "a specific version" do
+ describe "a specific version" do
+
     it "sets a specific date range according to the gem's info" do
-      VCR.use_cassette('velocitator-haml-i18n-extractor-0.0.17-versions-info') do
-        velocitator = Velocitator.new("haml-i18n-extractor", "0.0.17")
-        velocitator.effective_date_range.should eq ["2013-06-16T00:00:00Z", "2013-09-20T00:00:00Z"]
-      end
+      velocitator = Velocitator.new("haml-i18n-extractor", "0.0.17")
+      velocitator.effective_date_range.should eq ["2013-06-16T00:00:00Z", "2013-09-20T00:00:00Z"]
     end
 
     it "can override the default time ranges if its in the range" do
-      VCR.use_cassette('velocitator-haml-i18n-extractor-0.0.17-versions-override') do
-        velocitator = Velocitator.new("haml-i18n-extractor", "0.0.17")
-        velocitator.date_range = [1.day.ago, Time.now]
-        velocitator.effective_date_range.should eq ["2013-09-19T00:00:00Z", "2013-09-20T00:00:00Z"]
-        velocitator.line_datas.size.should eq (velocitator.versions.size)
-      end
+      velocitator = Velocitator.new("haml-i18n-extractor", "0.0.17")
+      velocitator.date_range = [1.day.ago, Time.now]
+      velocitator.effective_date_range.should eq ["2013-09-19T00:00:00Z", "2013-09-20T00:00:00Z"]
+      velocitator.line_datas.size.should eq (velocitator.versions.size)
     end
 
     it "can set a max and min" do
-      VCR.use_cassette('velocitator-haml-i18n-extractor-0.0.17-versions') do
-        velocitator = Velocitator.new("haml-i18n-extractor", "0.0.17")
-        lambda {
-          velocitator.max_value = 500
-          velocitator.min_value = 10
-        }.should_not raise_error
-      end
+      velocitator = Velocitator.new("haml-i18n-extractor", "0.0.17")
+      lambda {
+        velocitator.max_value = 500
+        velocitator.min_value = 10
+      }.should_not raise_error
     end
 
     it "can render a graph" do
-      VCR.use_cassette('velocitator-haml-i18n-extractor-0.0.17-versions-graph') do
-        velocitator = Velocitator.new("haml-i18n-extractor", "0.0.17")
-        velocitator.date_range = [1.day.ago, Time.now]
-        velocitator.root = SpecHelper.tmpdir
-        builder = velocitator.gruff_builder
-
-        # fixture / webmock / data etc.. if it fails, rm -rf spec/fixtures/vcr_cassettes
-        builder.line_datas.should == [[75,76]]
-        builder.title.should == "haml-i18n-extractor-0.0.17"
-        builder.labels.should == ({1=>"2013-09-19", (builder.line_datas.first.size-2) =>"2013-09-20"})
-        builder.max_value.should == 95
-        builder.min_value.should == 0
-
-        file = builder.write
-        File.exist?(file).should be_true
-        #`open #{file} -a preview.app`
-        #Kernel.sleep(10)
-      end
+      velocitator = Velocitator.new("haml-i18n-extractor", "0.0.17")
+      velocitator.date_range = [1.day.ago, Time.now]
+      velocitator.root = SpecHelper.tmpdir
+      builder = velocitator.gruff_builder
+
+      # FIXME
+      # also, pending on issue relating to
+      # https://github.com/shaiguitar/rubygems.org/compare/api_not_returning_all_results_over_90_days?expand=1
+      builder.line_datas.should == [[343, 344]]
+      builder.title.should == "haml-i18n-extractor-0.0.17"
+      builder.labels.should == ({1=>"2013-09-19", (builder.line_datas.first.size-2) =>"2013-09-20"})
+      builder.max_value.should == 344
+      builder.min_value.should == 0
+
+      file = builder.write
+      File.exist?(file).should be_true
+      #`open #{file} -a preview.app`
+      #Kernel.sleep(10)
     end
 
     it "has a shortcut graph method #1" do
-      VCR.use_cassette('velocitator-haml-i18n-extractor-0.0.17-graph-shortcut-1') do
-        velocitator = Velocitator.new("haml-i18n-extractor", "0.0.17")
-        file = velocitator.graph(SpecHelper.tmpdir,[1.day.ago, Time.now])
-        File.exist?(file).should be_true
-      end
+      velocitator = Velocitator.new("haml-i18n-extractor", "0.0.17")
+      file = velocitator.graph(SpecHelper.tmpdir,[1.day.ago, Time.now])
+      File.exist?(file).should be_true
     end
 
     it "has a shortcut graph method #2" do
-      VCR.use_cassette('velocitator-haml-i18n-extractor-0.0.17-graph-shortcut-2') do
-        velocitator = Velocitator.new("haml-i18n-extractor", "0.0.17")
-        file = velocitator.graph
-        File.exist?(file).should be_true
-      end
+      velocitator = Velocitator.new("haml-i18n-extractor", "0.0.17")
+      file = velocitator.graph
+      File.exist?(file).should be_true
     end
 
     it "has a shortcut graph metho #3" do
-      VCR.use_cassette('velocitator-haml-i18n-extractor-0.0.17-graph-shortcut-3') do
-        velocitator = Velocitator.new("haml-i18n-extractor", "0.0.17")
-       file = velocitator.graph(nil,nil,0,1000)
-        File.exist?(file).should be_true
-      end
+      velocitator = Velocitator.new("haml-i18n-extractor", "0.0.17")
+      file = velocitator.graph(nil,nil,0,1000)
+      File.exist?(file).should be_true
     end
 
   end
@@ -94,62 +81,41 @@ describe Velocitator do
   describe "Multiple versions" do
     before do 
       @some_versions = ["0.0.17", "0.0.5","0.0.10"]
-      Timecop.travel(Time.local(2013, 9, 20, 10, 0, 0))
-      Timecop.freeze
-
-    end
-
-    after do
-      Timecop.return
     end
 
-
     it "can initialize multiple versions" do
-      VCR.use_cassette('velocitator-haml-i18n-extractor-multiple-versions') do
-        velocitator = Velocitator.new("haml-i18n-extractor", @some_versions)
-        velocitator.versions.should == @some_versions
-      end
+      velocitator = Velocitator.new("haml-i18n-extractor", @some_versions)
+      velocitator.versions.should == @some_versions
     end
 
     it "sets the earliest start range from to all of the versions info" do
-      VCR.use_cassette('velocitator-haml-i18n-extractor-0.0.17-multiple-versions-info') do
-        # some_versions.map{|v| GemData.new("haml-i18n-extractor").versions_built_at[v]}
-        # => ["2013-06-16T00:00:00Z", "2013-03-22T00:00:00Z", "2013-05-06T00:00:00Z"]
-        velocitator = Velocitator.new("haml-i18n-extractor", @some_versions)
-        velocitator.effective_date_range.should eq ["2013-03-22T00:00:00Z", "2013-09-20T00:00:00Z"]
-      end
+      # some_versions.map{|v| GemData.new("haml-i18n-extractor").versions_built_at[v]}
+      # => ["2013-06-16T00:00:00Z", "2013-03-22T00:00:00Z", "2013-05-06T00:00:00Z"]
+      velocitator = Velocitator.new("haml-i18n-extractor", @some_versions)
+      velocitator.effective_date_range.should eq ["2013-03-22T00:00:00Z", "2013-09-20T00:00:00Z"]
     end
 
     it "sets the max value to the max of all of versions" do
-      VCR.use_cassette('velocitator-haml-i18n-extractor-0.0.17-multiple-versions-max-value') do
-        velocitator = Velocitator.new("haml-i18n-extractor", @some_versions)
-        velocitator.default_max_value.should eq 95
-      end
+      velocitator = Velocitator.new("haml-i18n-extractor", @some_versions)
+      velocitator.default_max_value.should eq 344
     end
 
     it "sets the max value to the max of all of versions" do
-      VCR.use_cassette('velocitator-haml-i18n-extractor-0.0.17-multiple-versions-max-value') do
-        velocitator = Velocitator.new("haml-i18n-extractor", @some_versions)
-        velocitator.default_max_value.should eq 95
-      end
+      velocitator = Velocitator.new("haml-i18n-extractor", @some_versions)
+      velocitator.default_max_value.should eq 344
     end
 
     it "should set the line data to an array of versions.size with equal length which should be the max value of any one of them" do
-      VCR.use_cassette('velocitator-haml-i18n-extractor-0.0.17-multiple-versions-line-data') do
-        velocitator = Velocitator.new("haml-i18n-extractor", @some_versions)
-        velocitator.line_datas.size.should == @some_versions.size
-        # all of them should be the same size, padded with 0's if there is no download info
-        velocitator.line_datas.map{|d| d.size }.uniq.size.should == 1
-      end
+      velocitator = Velocitator.new("haml-i18n-extractor", @some_versions)
+      velocitator.line_datas.size.should == @some_versions.size
+      # all of them should be the same size, padded with 0's if there is no download info
+      velocitator.line_datas.map{|d| d.size }.uniq.size.should == 1
     end
 
     it "has a shortcut graph method" do
-      VCR.use_cassette('velocitator-haml-i18n-extractor-multiple-graph-shortcut') do
-        velocitator = Velocitator.new("haml-i18n-extractor", @some_versions)
-        file = velocitator.graph
-        puts file.inspect
-        File.exist?(file).should be_true
-      end
+      velocitator = Velocitator.new("haml-i18n-extractor", @some_versions)
+      file = velocitator.graph
+      File.exist?(file).should be_true
     end
   end
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: gem_velocity
 version: !ruby/object:Gem::Version 
-  hash: 25
+  hash: 23
   prerelease: 
   segments: 
   - 0
   - 0
-  - 3
-  version: 0.0.3
+  - 4
+  version: 0.0.4
 platform: ruby
 authors: 
 - Shai Rosenfeld
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2013-10-08 00:00:00 Z
+date: 2013-10-11 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: gruff
@@ -159,6 +159,34 @@ dependencies:
         version: "0"
   type: :development
   version_requirements: *id010
+- !ruby/object:Gem::Dependency 
+  name: sourcify
+  prerelease: false
+  requirement: &id011 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  type: :development
+  version_requirements: *id011
+- !ruby/object:Gem::Dependency 
+  name: ParseTree
+  prerelease: false
+  requirement: &id012 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  type: :development
+  version_requirements: *id012
 description: generate gem velocity images
 email: 
 - srosenfeld@engineyard.com
@@ -179,6 +207,7 @@ files:
 - examples/rails-4.0.0-3.2.14-2.3.5.png
 - gem_velocity.gemspec
 - lib/gem_velocity.rb
+- lib/gem_velocity/errors.rb
 - lib/gem_velocity/gem_data.rb
 - lib/gem_velocity/gruff_builder.rb
 - lib/gem_velocity/helpers.rb