gem_kit-release 0.2.0 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e224f994b90b2c2cac1787966d239addd12c90604042885a95cd28e99a9bbb1c
-  data.tar.gz: 4d2a5e0eeb4c067dd7724a684ed74139e9cf8bbc24d2bf57dcd5893f3d279dfd
+  metadata.gz: 7c57bae0a6fbc182e752ab68d4e5eaa6f1441354e9f906d9ee6d336c8c51c9e4
+  data.tar.gz: 73cc9921720bad183c573a5cd7bdb077bd118ed6f3eb2d1a0f417f0c9a1bf9de
 SHA512:
-  metadata.gz: 97fcf1a6509824873ec0bcf7e1f5ea170620c3a877153f394ee0b706f917cf51ca64537d6511398dddece0a86ff4181c1081c284574cdde5b5022a91f6ce7698
-  data.tar.gz: d48ec9f51cfa5810635a7ee4eb8a63ed0ee58be5436901cc245534021884a35b784dc1ef8610661ae09f1dfd74e72460e30518da4ce90e323636da1dc211814a
+  metadata.gz: 507b97ad08897e529ba1d471b696beeeb8af74fdd782e7067de2ac0f6ffa51f20010d782de808727083781b4e4b766fa7327cf122b300b284e88441e2d2899ef
+  data.tar.gz: 1fc2b130909d685e609f30e54a59faa8ad8e047ec057be23a5cfbea5648d1919a4b28fbf2bf2076239a7af4a3523ccd9b49cdc899333b0d1cd7d1e8bab113080

data/lib/gem_kit/release/cli.rb

@@ -2,7 +2,11 @@
 
 require "thor"
 
-require_relative "../../gem_kit"
+# `require`, not `require_relative`: gem_kit is a separate gem, and inside an
+# installed gem_kit-release there is no ../gem_kit to reach. It works in the
+# monorepo, where both gems share one lib/, which is exactly why this is worth
+# a comment.
+require "gem_kit"
 require_relative "version"
 require_relative "changelog"
 require_relative "project"
@@ -169,7 +173,12 @@ module GemKit
     def self.run(arguments, out: $stdout, err: $stderr)
       CLI.start(arguments)
       0
-    rescue Failure => failure
+    rescue Failure, Project::NotFound, Project::Ambiguous => failure
+      # NotFound and Ambiguous are rescued here rather than only in
+      # Commands::Command#project, because a Project is lazy: `detect` succeeds
+      # on a gemspec that exists, and the failure surfaces later, from whichever
+      # command first asks for `version` or `spec`. Catching it at the entry
+      # point is the only place that covers all of them.
       err.puts(failure.message)
       1
     rescue SystemExit => exit_exception
@@ -214,6 +223,20 @@ describe "gem_kit/release/cli" do
     end
   end
 
+  # A gemspec that exists but does not parse fails inside Gem::Specification
+  # rather than in Project.detect, which is a different place than it looks.
+  it "reports an unparseable gemspec instead of raising" do
+    Dir.mktmpdir do |dir|
+      File.write(File.join(dir, "demo.gemspec"),
+                 %(Gem::Specification.new do |spec|\n  spec.description = <<~D\n    unterminated\n))
+
+      status, _out, err = invoke(["release", "--dry-run"], dir)
+
+      status.should == 1
+      err.should.match(/could not load .*demo\.gemspec/)
+    end
+  end
+
   it "fails on an unknown command" do
     with_gem do |dir|
       invoke(["nonsense"], dir).first.should.not == 0

data/lib/gem_kit/release/version.rb

@@ -2,6 +2,6 @@
 
 module GemKit
   module Release
-    VERSION = "0.2.0"
+    VERSION = "0.2.2"
   end
 end

data/lib/gem_kit/release.rb

@@ -1,6 +1,10 @@
 # frozen_string_literal: true
 
-require_relative "../gem_kit"
+# `require`, not `require_relative`: gem_kit is a separate gem, and inside an
+# installed gem_kit-release there is no ../gem_kit to reach. It works in the
+# monorepo, where both gems share one lib/, which is exactly why this is worth
+# a comment.
+require "gem_kit"
 require_relative "release/version"
 require_relative "release/changelog"
 require_relative "release/project"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gem_kit-release
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.2
 platform: ruby
 authors:
 - Nathan Kidd