gem_config 0.2.4 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e38c07a983ddbdf73d79f7b1f7c613849d552c60
-  data.tar.gz: 394380642649dbd31e48c5c91350dd0a74aab495
+  metadata.gz: 1046dd50da7f348b21c6bfcc3e71903012f82897
+  data.tar.gz: 44245b10f3f50bd9edde6414fb25f109bbd5378c
 SHA512:
-  metadata.gz: b1fef53ce71a8d421011cfef1c1cd075795488b17fe32e1076dbf5d756f3512ef5e68e3ce66fce120ae07a8c1a6cbc0a1c87a0f986bac773c51d2e37748e5ced
-  data.tar.gz: 206c1aecd2f2aa37393b05fb69b7ff210c4bef027810cc2f6dbb844e5f07b58061f0f20b981ab56ff8b0786ae031db2b433570438adf9227ac8adee4103df4b7
+  metadata.gz: 01e105eeb51018f58561cecaeb4816ba754449488401d58c1544bdbfa145124a4689231014c40fefd66e988b600dd35094cc634bb1c8009d8993801f0ea6c202
+  data.tar.gz: 6402a8a2746c3319e2742db56c4f8999a032f18242f9f4b7187583471c8ec641f798e42d4f524926257c43955c6ad68132f9e4e6a7227420672832ab8220e832

data/.travis.yml

@@ -3,5 +3,5 @@ rvm:
   - 1.9.2
   - 1.9.3
   - 2.0.0
-  - jruby-19mode
-  - rbx-19mode
+  - 2.1.0
+  - jruby

data/README.md

@@ -19,8 +19,12 @@ Gem::Specification.new do |gem|
   ...
   gem.add_runtime_dependency 'gem_config'
 end
+```
 
+```ruby
 # lib/awesomeness.rb
+require 'gem_config'
+
 module Awesomeness
   include GemConfig::Base
 
@@ -45,7 +49,9 @@ Include and configure a gem like this:
 ```ruby
 # Gemfile
 gem 'awesomeness'
+```
 
+```ruby
 # config/initializers/awesomeness.rb
 Awesomeness.configure do |config|
   config.api_key = 'foobarbaz'

data/gem_config.gemspec

@@ -8,7 +8,7 @@ Gem::Specification.new do |gem|
   gem.version       = GemConfig::VERSION
   gem.platform      = Gem::Platform::RUBY
   gem.authors       = ['Manuel Meurer']
-  gem.email         = 'manuel.meurer@gmail.com'
+  gem.email         = 'manuel@krautcomputing.com'
   gem.summary       = 'A nifty way to make your gem configurable.'
   gem.description   = 'A nifty way to make your gem configurable.'
   gem.homepage      = 'https://github.com/krautcomputing/gem_config'

data/lib/gem_config.rb

@@ -1,4 +1,7 @@
+require 'gem_config/version'
+
 module GemConfig
+  InvalidKeyError = Class.new(StandardError)
 end
 
 require 'gem_config/rules'

data/lib/gem_config/configuration.rb

@@ -16,6 +16,11 @@ module GemConfig
       end
     end
 
+    def unset(key)
+      raise InvalidKeyError, "#{key} is not a valid key." unless self.rules.keys.include?(key.to_sym)
+      remove_instance_variable "@#{key}" if instance_variable_defined?("@#{key}")
+    end
+
     def method_missing(method, *args, &block)
       case
       when self.rules.keys.include?(method.to_sym)
@@ -29,10 +34,6 @@ module GemConfig
 
     private
 
-    def unset(key)
-      remove_instance_variable "@#{key}" if instance_variable_defined?("@#{key}")
-    end
-
     def set(key, value)
       self.rules.check(key, value)
       instance_variable_set "@#{key}", value

data/lib/gem_config/rules.rb

@@ -1,7 +1,5 @@
 module GemConfig
   class Rules < Hash
-    InvalidKeyError = Class.new(StandardError)
-
     def has(key, attrs = {})
       check_attributes attrs
       self[key.to_sym] = attrs

data/lib/gem_config/version.rb

@@ -1,3 +1,3 @@
 module GemConfig
-  VERSION = '0.2.4'
+  VERSION = '0.3.0'
 end

data/spec/lib/configuration_spec.rb

@@ -4,6 +4,7 @@ describe GemConfig::Configuration do
   subject do
     GemConfig::Configuration.new.tap do |configuration|
       configuration.rules.has :foo, default: 'bar'
+      configuration.rules.has :bar
       configuration.rules.has :count
       configuration.rules.has :api_key, default: 'foobarbaz'
       configuration.foo   = 'pelle'
@@ -30,6 +31,28 @@ describe GemConfig::Configuration do
     end
   end
 
+  describe '#unset' do
+    context 'with an existing key' do
+      context 'when that key has not been set' do
+        it 'doesnt change anything' do
+          expect { subject.unset(:bar) }.to_not change { subject.bar }
+        end
+      end
+
+      context 'when that key has been set' do
+        it 'unsets the key' do
+          expect { subject.unset(:count) }.to change { subject.count }.from(123).to(nil)
+        end
+      end
+    end
+
+    context 'with a non-existing key' do
+      it 'raises an exception' do
+        expect { subject.unset(:pelle) }.to raise_error(GemConfig::InvalidKeyError)
+      end
+    end
+  end
+
   describe 'setting a configuration option' do
     it 'checks if the value is allowed' do
       subject.rules.should_receive :check, with: [:foo, 'bar']
@@ -44,11 +67,11 @@ describe GemConfig::Configuration do
     end
 
     it 'does not set the configuration option if the value is not allowed' do
-      subject.rules.stub(:check, with: [:foo, 'bar']).and_raise(GemConfig::Rules::InvalidKeyError)
+      subject.rules.stub(:check, with: [:foo, 'bar']).and_raise(GemConfig::InvalidKeyError)
       expect do
         begin
           subject.foo = 'bar'
-        rescue GemConfig::Rules::InvalidKeyError
+        rescue GemConfig::InvalidKeyError
         end
       end.to_not change { subject.foo }.from('bar')
     end

data/spec/lib/rules_spec.rb

@@ -122,35 +122,35 @@ describe GemConfig::Rules do
     it "raises an error if the value is not set as a rule" do
       expect do
         subject.check :foo, 1
-      end.to raise_error(GemConfig::Rules::InvalidKeyError)
+      end.to raise_error(GemConfig::InvalidKeyError)
     end
 
     it "raises an error if :classes are defined the the value's class is not included in them" do
       subject.has :foo, classes: String
       expect do
         subject.check :foo, 1
-      end.to raise_error(GemConfig::Rules::InvalidKeyError)
+      end.to raise_error(GemConfig::InvalidKeyError)
     end
 
     it 'raises an error if :values are defined the the value is not included in them' do
       subject.has :foo, values: ['foo', 'bar']
       expect do
         subject.check :foo, 'baz'
-      end.to raise_error(GemConfig::Rules::InvalidKeyError)
+      end.to raise_error(GemConfig::InvalidKeyError)
     end
 
     it "does not raise an error if :classes are defined the the value's class is included in them" do
       subject.has :foo, classes: [String, Numeric]
       expect do
         subject.check :foo, 1
-      end.to_not raise_error(GemConfig::Rules::InvalidKeyError)
+      end.to_not raise_error(GemConfig::InvalidKeyError)
     end
 
     it 'does not raise an error if :values are defined the the value is included in them' do
       subject.has :foo, values: ['foo', 'bar']
       expect do
         subject.check :foo, 'foo'
-      end.to_not raise_error(GemConfig::Rules::InvalidKeyError)
+      end.to_not raise_error(GemConfig::InvalidKeyError)
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gem_config
 version: !ruby/object:Gem::Version
-  version: 0.2.4
+  version: 0.3.0
 platform: ruby
 authors:
 - Manuel Meurer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-06 00:00:00.000000000 Z
+date: 2014-02-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -39,7 +39,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 2.13.0
 description: A nifty way to make your gem configurable.
-email: manuel.meurer@gmail.com
+email: manuel@krautcomputing.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -80,7 +80,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.2
+rubygems_version: 2.2.0
 signing_key: 
 specification_version: 4
 summary: A nifty way to make your gem configurable.