gem-contribute 0.2.0 → 0.3.0

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gem-contribute
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Chris Hagmann
@@ -23,10 +23,94 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '2.4'
+- !ruby/object:Gem::Dependency
+  name: dry-initializer
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.2'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.2'
+- !ruby/object:Gem::Dependency
+  name: dry-monads
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.10'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.10'
+- !ruby/object:Gem::Dependency
+  name: dry-operation
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.1'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.1'
+- !ruby/object:Gem::Dependency
+  name: tty-prompt
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.23'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.23'
+- !ruby/object:Gem::Dependency
+  name: tty-spinner
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.9'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.9'
+- !ruby/object:Gem::Dependency
+  name: zeitwerk
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.6'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.6'
 description: |
   gem-contribute reads a project's Gemfile.lock, resolves each gem's source
   repository via the RubyGems API, surfaces open contributable issues from
-  those repositories, and offers a one-keystroke fork-clone-branch flow so a
+  those repositories, and offers a one-keystroke fix flow so a
   developer can go from "I noticed an issue" to "I have a working branch" in
   seconds. v0.1 supports GitHub-hosted gems with OAuth device-flow auth.
 email:
@@ -40,6 +124,8 @@ files:
 - ".github/ISSUE_TEMPLATE/workshop-issue.md"
 - ".github/PULL_REQUEST_TEMPLATE.md"
 - ".github/workflows/auto-merge-kicked-tires.yml"
+- ".github/workflows/ci.yml"
+- ".github/workflows/pr-template-check.yml"
 - CHANGELOG.md
 - CLAUDE.md
 - CODE_OF_CONDUCT.md
@@ -49,6 +135,8 @@ files:
 - MAINTAINER.md
 - README.md
 - Rakefile
+- docs/OPEN_QUESTIONS.md
+- docs/ROADMAP.md
 - docs/_config.yml
 - docs/adr/0001-just-in-time-auth.md
 - docs/adr/0002-bundler-lockfile-parser.md
@@ -60,8 +148,13 @@ files:
 - docs/adr/0008-rooibos-tui-framework.md
 - docs/adr/0009-top-level-namespace.md
 - docs/adr/0010-charm-ruby-tui-framework.md
+- docs/adr/0011-host-adapter-owns-host-verbs.md
+- docs/adr/0012-output-free-service-objects-three-interface-architecture.md
+- docs/adr/0013-revert-to-rooibos.md
+- docs/adr/0014-ship-bundler-and-rubygems-plugins.md
 - docs/adr/README.md
 - docs/claude-code-prompt.md
+- docs/design-interface-layer.md
 - docs/design.md
 - docs/ideas.md
 - docs/index.md
@@ -78,18 +171,31 @@ files:
 - lib/gem_contribute/cli.rb
 - lib/gem_contribute/cli/auth.rb
 - lib/gem_contribute/cli/config.rb
-- lib/gem_contribute/cli/fork_clone_branch.rb
+- lib/gem_contribute/cli/fix.rb
+- lib/gem_contribute/cli/fork.rb
 - lib/gem_contribute/cli/init.rb
+- lib/gem_contribute/cli/issue_announcer.rb
 - lib/gem_contribute/cli/issues.rb
+- lib/gem_contribute/cli/platform_tools.rb
+- lib/gem_contribute/cli/post_clone_hooks.rb
 - lib/gem_contribute/cli/rate_limit_footer.rb
 - lib/gem_contribute/cli/scan.rb
 - lib/gem_contribute/cli/submit.rb
+- lib/gem_contribute/cli/workflow.rb
 - lib/gem_contribute/config.rb
 - lib/gem_contribute/errors.rb
+- lib/gem_contribute/git.rb
 - lib/gem_contribute/host_adapter.rb
 - lib/gem_contribute/host_adapters/github_adapter.rb
 - lib/gem_contribute/locked_gem.rb
 - lib/gem_contribute/lockfile_parser.rb
+- lib/gem_contribute/operations/announce.rb
+- lib/gem_contribute/operations/branch.rb
+- lib/gem_contribute/operations/clone.rb
+- lib/gem_contribute/operations/fix_pipeline.rb
+- lib/gem_contribute/operations/fork.rb
+- lib/gem_contribute/output/null.rb
+- lib/gem_contribute/output/standard.rb
 - lib/gem_contribute/project.rb
 - lib/gem_contribute/resolver.rb
 - lib/gem_contribute/token_store.rb

data/lib/gem_contribute/cli/fork_clone_branch.rb

@@ -1,204 +0,0 @@
-# frozen_string_literal: true
-
-require "open3"
-
-module GemContribute
-  module CLI
-    # `gem-contribute fork-clone-branch <gem>/<issue#>`
-    #
-    # Performs the full sequence the TUI's `f` keybinding will trigger in
-    # Stage 3:
-    #
-    #   1. Resolve <gem> via the RubyGems Resolver (no lockfile required;
-    #      the lockfile is for discovery via `scan`, not gating here).
-    #   2. Read the cached GitHub token; raise AuthRequired with a clear
-    #      `auth login` hint if missing.
-    #   3. Look up the viewer's login.
-    #   4. If they don't already have a fork, fork the upstream repo.
-    #   5. Poll until the fork is reachable (forks return 202 immediately
-    #      but the resource may 404 for a few seconds).
-    #   6. `git clone` the fork to `<clone_root>/<owner>/<repo>`.
-    #   7. `git checkout -b gem-contribute/issue-<N>` from the default branch.
-    #   8. Print the local path on stdout.
-    #
-    # The shell-outs use Open3 with explicit args (not strings) to avoid any
-    # shell-injection surface.
-    class ForkCloneBranch
-      DEFAULT_CLONE_ROOT = File.expand_path("~/code/oss")
-      BRANCH_PREFIX = "gem-contribute/issue-"
-      FORK_READINESS_RETRIES = 12 # 12 × 5s = 60s ceiling
-      FORK_READINESS_INTERVAL = 5
-
-      def initialize(stdout: $stdout,
-                     stderr: $stderr,
-                     resolver: Resolver.new,
-                     store: TokenStore.new,
-                     adapter_factory: ->(token:) { HostAdapters::GitHubAdapter.new(token: token) },
-                     git: Git.new,
-                     clone_root: DEFAULT_CLONE_ROOT,
-                     sleeper: ->(s) { Kernel.sleep(s) })
-        @stdout = stdout
-        @stderr = stderr
-        @resolver = resolver
-        @store = store
-        @adapter_factory = adapter_factory
-        @git = git
-        @clone_root = clone_root
-        @sleeper = sleeper
-      end
-
-      def run(argv)
-        return missing_clone_root if @clone_root.nil?
-
-        target = argv.shift
-        return print_usage_error if target.nil? || !target.include?("/")
-
-        gem_name, issue = target.split("/", 2)
-        adapter = build_adapter
-        return 1 if adapter.nil?
-
-        project = resolve_or_fail(gem_name)
-        return 1 if project.nil?
-
-        execute(adapter, project, issue)
-      rescue AuthRequired
-        @stderr.puts "Not authenticated. Run `gem-contribute auth login` first."
-        1
-      rescue AdapterError => e
-        @stderr.puts "fork-clone-branch failed: #{e.message}"
-        1
-      end
-
-      private
-
-      def missing_clone_root
-        @stderr.puts "clone_root is not configured. Run `gem-contribute init` first."
-        1
-      end
-
-      def print_usage_error
-        @stderr.puts "Usage: gem-contribute fork-clone-branch <gem>/<issue#>"
-        2
-      end
-
-      def build_adapter
-        token = @store.token_for("github.com")
-        if token.nil?
-          @stderr.puts "Not authenticated. Run `gem-contribute auth login` first."
-          return nil
-        end
-        @adapter_factory.call(token: token)
-      end
-
-      def resolve_or_fail(gem_name)
-        return GemContribute::SELF_PROJECT if gem_name == GemContribute::SELF_PROJECT.gem_name
-
-        gem = LockedGem.new(name: gem_name, version: "*", source_type: :rubygems, source_uri: "https://rubygems.org/")
-        project = @resolver.resolve(gem)
-
-        if project.host != "github.com"
-          @stderr.puts "Cannot fork-clone-branch: #{gem_name} resolves to #{project.host} " \
-                       "(only github.com is supported at v0.1)"
-          return nil
-        end
-
-        project
-      end
-
-      def execute(adapter, project, issue)
-        viewer = adapter.viewer_login
-        clone_url = ensure_fork(adapter, project, viewer)
-        local_path = clone_into_root(project, clone_url)
-        branch_name = "#{BRANCH_PREFIX}#{issue}"
-        @git.checkout_branch(local_path, branch_name)
-        # `submit` needs to know the canonical project to point the PR at.
-        # Naming it `upstream` follows the standard fork workflow convention.
-        @git.add_remote(local_path, "upstream",
-                        "https://github.com/#{project.owner}/#{project.repo}.git")
-
-        @stdout.puts "Forked, cloned, and branched."
-        @stdout.puts "  path:   #{local_path}"
-        @stdout.puts "  branch: #{branch_name}"
-        @stdout.puts "  upstream: https://github.com/#{project.owner}/#{project.repo}"
-        @stdout.puts "  fork:     https://github.com/#{viewer}/#{project.repo}"
-        @stdout.puts
-        @stdout.puts "Next: cd #{local_path} && make your changes, then `gem-contribute submit`."
-        0
-      end
-
-      def ensure_fork(adapter, project, viewer)
-        if adapter.already_forked?(project)
-          @stdout.puts "You already have a fork at #{viewer}/#{project.repo}. Skipping fork."
-          return "https://github.com/#{viewer}/#{project.repo}.git"
-        end
-
-        @stdout.puts "Forking #{project.owner}/#{project.repo} → #{viewer}/#{project.repo}..."
-        body = adapter.fork(project)
-        wait_until_ready(adapter, viewer, project.repo)
-        body.fetch("clone_url")
-      end
-
-      def wait_until_ready(adapter, viewer, name)
-        ready = FORK_READINESS_RETRIES.times.any? do |i|
-          break true if adapter.fork_ready?(viewer, name)
-
-          @sleeper.call(FORK_READINESS_INTERVAL) unless i == FORK_READINESS_RETRIES - 1
-          false
-        end
-        return if ready
-
-        raise AdapterError, "fork not reachable after #{FORK_READINESS_RETRIES * FORK_READINESS_INTERVAL}s"
-      end
-
-      def clone_into_root(project, clone_url)
-        target = File.join(@clone_root, project.owner, project.repo)
-        if File.directory?(File.join(target, ".git"))
-          @stdout.puts "Reusing existing clone at #{target}."
-          return target
-        end
-
-        FileUtils.mkdir_p(File.dirname(target))
-        @stdout.puts "Cloning into #{target}..."
-        @git.clone(clone_url, target)
-        target
-      end
-    end
-
-    # Thin wrapper around git so the spec can swap in a fake without shelling
-    # out. The real implementation uses Open3 with arg-list invocation — no
-    # shell, so no injection surface.
-    class Git
-      def clone(url, target)
-        run!(["git", "clone", url, target])
-      end
-
-      def checkout_branch(path, branch)
-        run!(["git", "-C", path, "checkout", "-b", branch])
-      end
-
-      def add_remote(path, name, url)
-        # Idempotent: if the remote already exists (e.g. reusing a clone)
-        # we silently succeed rather than fail the whole flow.
-        return if remote_exists?(path, name)
-
-        run!(["git", "-C", path, "remote", "add", name, url])
-      end
-
-      def push(path, remote, branch)
-        run!(["git", "-C", path, "push", "-u", remote, branch])
-      end
-
-      def remote_exists?(path, name)
-        out, _err, status = Open3.capture3("git", "-C", path, "remote")
-        status.success? && out.split("\n").include?(name)
-      end
-
-      def run!(argv)
-        _stdout, stderr_str, status = Open3.capture3(*argv)
-        return if status.success?
-
-        raise GemContribute::AdapterError, "git #{argv[1..].join(" ")} failed: #{stderr_str.strip}"
-      end
-    end
-  end
-end