gem-compiler 0.8.0 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: 2f88322755fee2322a31c6516b5f52dc9470bc132e2fde88628f6a0f449987ac
-  data.tar.gz: 53a1dc54a53791f6a106d012e6306228f548a906549dd601c7c273c252048013
+SHA1:
+  metadata.gz: f715fe84339746f8ec890e713c7e162bb73d53d5
+  data.tar.gz: 5898f0dfb960d964755662674c469c84d95e5db4
 SHA512:
-  metadata.gz: dc22e52f9e0328c93b90a0ed5e8dce3d63aece8377af375aba94e3c0d2d6e30dbd3bf37a91d6043fb859cb561e3e94622998b237509040f32b45e12cc694c381
-  data.tar.gz: 149623d4a832894032c1a249fabe912a8a6af1028faf9ad62a5735ebdb7aebe2b7e283f416c63f78ed69c4d3d03df89fe1b965ab1f71e96a30445cb66a91985c
+  metadata.gz: b879e33e40fa3ed600305f8c759caae5d3387af03577eb5fdf7bd5e8b3e61029edd7a5f5d3bdb33c6ca5a3fe5f6fa2beec001b48f70492f24042a74e51f9380d
+  data.tar.gz: 1212ed35d0ae616c54e1df0a857b40cfb83e03d6bcf52030e34e2d5ac160ca74097bee9ba360f0a4db4d19d22236b62524481700cfda2fbbbc553e6be247fc9c

data/CHANGELOG.md

@@ -10,6 +10,24 @@ upgrading.
 
 ## [Unreleased]
 
+## [0.9.0] - 2020-04-05
+
+### Added
+- Allow symbol stripping from extensions (using `--strip`). (#40, #48, #50)
+- Introduce more strict Ruby version locking (using `--abi-lock`). (#51, #52)
+
+### Fixed
+- Solve upcoming RubyGems deprecation warnings
+
+### Changed
+- Deal with RubyGems 3.x `new_spec` deprecation in tests.
+- CI: Replace Travis/AppVeyor with GitHub Actions for Ubuntu, macOS and Windows.
+- No longer raise exceptions when executed against non-compilable gems. (#38, #47)
+
+### Removed
+- Drop support for Ruby 2.3.x, as it reached EOL (End Of Life)
+- Drop support for RubyGems older than 2.6.0 (Ruby 2.4 includes RubyGems 2.6.8)
+
 ## [0.8.0] - 2017-12-28
 
 ### Added
@@ -94,7 +112,8 @@ upgrading.
 
 - Initial public release, extracted from internal project.
 
-[Unreleased]: https://github.com/luislavena/gem-compiler/compare/v0.8.0...HEAD
+[Unreleased]: https://github.com/luislavena/gem-compiler/compare/v0.9.0...HEAD
+[0.8.0]: https://github.com/luislavena/gem-compiler/compare/v0.8.0...v0.9.0
 [0.8.0]: https://github.com/luislavena/gem-compiler/compare/v0.7.0...v0.8.0
 [0.7.0]: https://github.com/luislavena/gem-compiler/compare/v0.6.0...v0.7.0
 [0.6.0]: https://github.com/luislavena/gem-compiler/compare/v0.5.0...v0.6.0

data/README.md

@@ -3,8 +3,6 @@
 A RubyGems plugin that generates binary (pre-compiled) gems.
 
 [![Gem Version](https://img.shields.io/gem/v/gem-compiler.svg)](https://rubygems.org/gems/gem-compiler)
-[![Travis status](https://img.shields.io/travis/luislavena/gem-compiler/master.svg)](https://travis-ci.org/luislavena/gem-compiler)
-[![AppVeyor status](https://img.shields.io/appveyor/ci/luislavena/gem-compiler/master.svg)](https://ci.appveyor.com/project/luislavena/gem-compiler)
 [![Code Climate](https://img.shields.io/codeclimate/github/luislavena/gem-compiler.svg)](https://codeclimate.com/github/luislavena/gem-compiler)
 
 - [home](https://github.com/luislavena/gem-compiler)
@@ -19,8 +17,49 @@ Ruby C extensions and bundles the result into a new gem.
 It uses an *outside-in* approach and leverages on existing RubyGems code to
 do it.
 
-The result of the compilation is a binary gem built for your current platform,
-skipping the need of a compiler toolchain when installing it.
+## Benefits
+
+Using `gem-compiler` removes the need to install a compiler toolchain on the
+platform used to run the extension. This means less dependencies are required
+in those systems and can reduce associated update/maintenance cycles.
+
+Additionally, by having only binaries, it reduces the time it takes to install
+several gems that normally take minutes to compile themselves and the needed
+dependencies.
+
+Without `gem-compiler`, takes more than a minute to install Nokogiri on
+Ubuntu 18.04:
+
+```console
+$ time gem install --local nokogiri-1.10.7.gem
+Building native extensions. This could take a while...
+Successfully installed nokogiri-1.10.7
+1 gem installed
+
+real    1m22.670s
+user    1m5.856s
+sys     0m18.637s
+```
+
+Compared to the installation of the pre-compiled version:
+
+```console
+$ gem compile nokogiri-1.10.7.gem --prune
+Unpacking gem: 'nokogiri-1.10.7' in temporary directory...
+Building native extensions. This could take a while...
+  Successfully built RubyGem
+  Name: nokogiri
+  Version: 1.10.7
+  File: nokogiri-1.10.7-x86_64-linux.gem
+
+$ time gem install --local nokogiri-1.10.7-x86_64-linux.gem
+Successfully installed nokogiri-1.10.7-x86_64-linux
+1 gem installed
+
+real    0m1.697s
+user    0m1.281s
+sys     0m0.509s
+```
 
 ## Installation
 
@@ -91,22 +130,59 @@ process:
     Successfully installed nokogiri-1.6.6.2-x86_64-darwin-12
     1 gem installed
 
-#### Restrictions of binaries
+#### Restricting generated binary gems
+
+Gems compiled with `gem-compiler` be lock to the version of Ruby used
+to compile them, following Ruby's ABI compatibility (`MAJOR.MINOR`)
+
+This means that a gem compiled with Ruby 2.6.1 could be installed in any
+version of Ruby 2.6.x (Eg. 2.6.4).
+
+You can tweak this behavior by using `--abi-lock` option during compilation.
+There are 3 available modes:
 
-Gems compiled with `gem-compiler` will be lock to the version of Ruby used
-to compile them.
+* `ruby`: Follows Ruby's ABI. Gems compiled with Ruby 2.6.1 can be installed
+  in any Ruby 2.6.x (default behavior).
+* `strict`: Uses Ruby's full version. Gems compiled with Ruby 2.6.1 can only
+  be installed in Ruby 2.6.1.
+* `none`: Disables Ruby compatibility. Gems compiled with this option can be
+  installed on any version of Ruby (alias for `--no-abi-lock`).
 
-This means that a gem compiled under Ruby 2.2 could only be installed under
-Ruby 2.2.
+**Warning**: usage of `none` is not recommended since different versions of
+Ruby might expose different APIs. The binary might be expecting specific
+features not present in the version of Ruby you're installing the gem into.
 
-You can disable this by using `--no-abi-lock` option during compilation:
+#### Reducing extension's size (stripping)
 
-    $ gem compile yajl-ruby-1.1.0.gem --no-abi-lock
+By default, RubyGems do not strip symbols from compiled extensions, including
+debugging information and can result in increased size of final package.
 
-**Warning**: this is not recommended since different versions of Ruby might
-expose different options on the API. The binary might be expecting specific
-features not present in the version of Ruby you're installing the binary gem
-into.
+With `--strip`, you can reduce extensions by using same stripping options used
+by Ruby itself (see `RbConfig::CONFIG["STRIP"]`):
+
+```console
+$ gem compile oj-3.10.0.gem --strip
+Unpacking gem: 'oj-3.10.0' in temporary directory...
+Building native extensions. This could take a while...
+Stripping symbols from extensions (using 'strip -S -x')...
+  Successfully built RubyGem
+  Name: oj
+  Version: 3.10.0
+  File: oj-3.10.0-x86_64-linux.gem
+```
+
+Or you can provide your own stripping command instead:
+
+```console
+$ gem compile oj-3.10.0.gem --strip "strip --strip-unneeded"
+Unpacking gem: 'oj-3.10.0' in temporary directory...
+Building native extensions. This could take a while...
+Stripping symbols from extensions (using 'strip --strip-unneeded')...
+  Successfully built RubyGem
+  Name: oj
+  Version: 3.10.0
+  File: oj-3.10.0-x86_64-linux.gem
+```
 
 ### Compiling from Rake
 
@@ -129,9 +205,9 @@ required.
 ### Ruby and RubyGems
 
 It's assumed you have Ruby and RubyGems installed. gem-compiler requires
-RubyGems 1.8.x to properly work.
+RubyGems 2.6.x to work.
 
-If you don't have RubyGems 1.8.x, you can upgrade by running:
+If you don't have RubyGems 2.6.x, you can upgrade by running:
 
     $ gem update --system
 
@@ -146,7 +222,7 @@ right one.
 
 For those using RubyInstaller-based builds, you will need to download the
 DevKit from their [downloads page](http://rubyinstaller.org/downloads)
-and follow the [installation instructions](https://github.com/oneclick/rubyinstaller/wiki/Development-Kit).
+and follow the installation instructions.
 
 To be sure your installation of Ruby is based on RubyInstaller, execute at
 the command prompt:
@@ -155,7 +231,7 @@ the command prompt:
 
 And from the output:
 
-    tcs-ruby 1.9.3p196 (2012-04-21, TCS patched 2012-04-21) [i386-mingw32]
+    ruby 2.4.9p362 (2019-10-02 revision 67824) [x64-mingw32]
 
 If you see `mingw32`, that means you're using a RubyInstaller build
 (MinGW based).

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rubygems/package_task"
 
 gemspec = Gem::Specification.load("gem-compiler.gemspec")

data/lib/rubygems/commands/compile_command.rb

@@ -1,9 +1,22 @@
+# frozen_string_literal: true
+
+require "rbconfig"
 require "rubygems/command"
 
 class Gem::Commands::CompileCommand < Gem::Command
+  ABIs = {
+      "ruby"   => :ruby,
+      "strict" => :strict,
+      "none"   => :none
+  }.freeze
+
   def initialize
-    super "compile", "Create binary pre-compiled gem",
-          output: Dir.pwd
+    defaults = {
+      output: Dir.pwd,
+      abi_lock: :ruby
+    }
+
+    super "compile", "Create binary pre-compiled gem", defaults
 
     add_option "-O", "--output DIR", "Directory where binary will be stored" do |value, options|
       options[:output] = File.expand_path(value, Dir.pwd)
@@ -17,8 +30,28 @@ class Gem::Commands::CompileCommand < Gem::Command
       options[:prune] = true
     end
 
-    add_option "-N", "--no-abi-lock", "Do not lock compiled Gem to Ruby's ABI" do |value, options|
-      options[:no_abi_lock] = true
+    add_option "--abi-lock MODE",
+      "Lock to version of Ruby (ruby, strict, none)" do |value, options|
+
+      mode = ABIs[value]
+      unless mode
+        valid = ABIs.keys.sort
+        raise OptionParser::InvalidArgument, "#{value} (#{valid.join ', '} are valid)"
+      end
+
+      options[:abi_lock] = mode
+    end
+
+    add_option "-N", "--no-abi-lock", "Do not lock compiled Gem to Ruby's ABI (same as --abi-lock=none)" do |value, options|
+      options[:abi_lock] = :none
+    end
+
+    add_option "-S", "--strip [CMD]", "Strip symbols from generated binaries" do |value, options|
+      if value.nil? || value.empty?
+        options[:strip] = RbConfig::CONFIG["STRIP"]
+      else
+        options[:strip] = value
+      end
     end
   end
 

data/lib/rubygems/compiler.rb

@@ -1,4 +1,7 @@
+# frozen_string_literal: true
+
 require "fileutils"
+require "open3"
 require "rbconfig"
 require "tmpdir"
 require "rubygems/installer"
@@ -25,6 +28,8 @@ class Gem::Compiler
 
     artifacts = collect_artifacts
 
+    strip_artifacts artifacts
+
     if shared_dir = options[:include_shared_dir]
       shared_libs = collect_shared(shared_dir)
 
@@ -44,6 +49,19 @@ class Gem::Compiler
 
   private
 
+  def adjust_abi_lock(gemspec)
+    abi_lock = @options[:abi_lock] || :ruby
+    case abi_lock
+    when :ruby
+      ruby_abi = RbConfig::CONFIG["ruby_version"]
+      gemspec.required_ruby_version = "~> #{ruby_abi}"
+    when :strict
+      cfg = RbConfig::CONFIG
+      ruby_abi = "#{cfg["MAJOR"]}.#{cfg["MINOR"]}.#{cfg["TEENY"]}.0"
+      gemspec.required_ruby_version = "~> #{ruby_abi}"
+    end
+  end
+
   def adjust_gemspec_files(gemspec, artifacts)
     # remove any non-existing files
     if @options[:prune]
@@ -115,19 +133,9 @@ class Gem::Compiler
   end
 
   def prepare_installer
-    # RubyGems 2.5 specifics
-    unpack_options = options.dup.merge(unpack: true)
-    if Gem::Installer.respond_to?(:at)
-      installer = Gem::Installer.at(@gemfile, unpack_options)
-    else
-      installer = Gem::Installer.new(@gemfile, options.dup.merge(unpack: true))
-    end
-
-    # RubyGems 2.2 specifics
-    if installer.spec.respond_to?(:full_gem_path=)
-      installer.spec.full_gem_path = @target_dir
-      installer.spec.extension_dir = File.join(@target_dir, "lib")
-    end
+    installer = Gem::Installer.at(@gemfile, options.dup.merge(unpack: true))
+    installer.spec.full_gem_path = @target_dir
+    installer.spec.extension_dir = File.join(@target_dir, "lib")
 
     # Ensure Ruby version is met
     if installer.respond_to?(:ensure_required_ruby_version_met)
@@ -141,14 +149,16 @@ class Gem::Compiler
 
     # Hmm, gem already compiled?
     if installer.spec.platform != Gem::Platform::RUBY
-      raise CompilerError,
-            "The gem file seems to be compiled already."
+      info "The gem file seems to be compiled already. Skipping."
+      cleanup
+      terminate_interaction
     end
 
     # Hmm, no extensions?
     if installer.spec.extensions.empty?
-      raise CompilerError,
-            "There are no extensions to build on this gem file."
+      info "There are no extensions to build on this gem file. Skipping."
+      cleanup
+      terminate_interaction
     end
 
     installer
@@ -162,10 +172,7 @@ class Gem::Compiler
     gemspec.platform = Gem::Platform::CURRENT
 
     # adjust version of Ruby
-    unless @options[:no_abi_lock]
-      ruby_abi = RbConfig::CONFIG["ruby_version"]
-      gemspec.required_ruby_version = "~> #{ruby_abi}"
-    end
+    adjust_abi_lock(gemspec)
 
     # build new gem
     output_gem = nil
@@ -186,6 +193,45 @@ class Gem::Compiler
     output_gem
   end
 
+  def simple_run(command, command_name)
+    begin
+      output, status = Open3.capture2e(*command)
+    rescue => error
+      raise Gem::CompilerError, "#{command_name} failed#{error.message}"
+    end
+
+    yield(status, output) if block_given?
+
+    unless status.success?
+      exit_reason =
+        if status.exited?
+          ", exit code #{status.exitstatus}"
+        elsif status.signaled?
+          ", uncaught signal #{status.termsig}"
+        end
+
+      raise Gem::CompilerError, "#{command_name} failed#{exit_reason}"
+    end
+  end
+
+  def strip_artifacts(artifacts)
+    return unless options[:strip]
+
+    strip_cmd = options[:strip]
+
+    info "Stripping symbols from extensions (using '#{strip_cmd}')..."
+
+    artifacts.each do |artifact|
+      cmd = [strip_cmd, artifact].join(' ').rstrip
+
+      simple_run(cmd, "strip #{File.basename(artifact)}") do |status, output|
+        if status.success?
+          debug "Stripped #{File.basename(artifact)}"
+        end
+      end
+    end
+  end
+
   def tmp_dir
     @tmp_dir ||= Dir.glob(Dir.mktmpdir).first
   end
@@ -197,6 +243,14 @@ class Gem::Compiler
     # unpack gem sources into target_dir
     # We need the basename to keep the unpack happy
     info "Unpacking gem: '#{basename}' in temporary directory..."
-    installer.unpack(@target_dir)
+
+    # RubyGems >= 3.1.x
+    if installer.respond_to?(:package)
+      package = installer.package
+    else
+      package = Gem::Package.new(@gemfile)
+    end
+
+    package.extract_files(@target_dir)
   end
 end

data/lib/rubygems/compiler/version.rb

@@ -1,7 +1,8 @@
 # encoding: UTF-8
+# frozen_string_literal: true
 
 module Gem
   class Compiler
-    VERSION = "0.8.0"
+    VERSION = "0.9.0"
   end
 end

data/lib/rubygems_plugin.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 require "rubygems/command_manager"
 Gem::CommandManager.instance.register_command :compile

data/test/rubygems/test_gem_commands_compile_command.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rubygems/test_case"
 require "rubygems/commands/compile_command"
 require "rubygems/package"
@@ -20,4 +22,55 @@ class TestGemCommandsCompileCommand < Gem::TestCase
 
     assert_match %r{Please specify a gem file on the command line}, e.message
   end
+
+  def test_handle_abi_lock_ruby
+    @cmd.handle_options []
+
+    assert_equal :ruby, @cmd.options[:abi_lock]
+  end
+
+  def test_handle_abi_lock_explicit_ruby
+    @cmd.handle_options ["--abi-lock=ruby"]
+
+    assert_equal :ruby, @cmd.options[:abi_lock]
+  end
+
+  def test_handle_abi_lock_strict
+    @cmd.handle_options ["--abi-lock=strict"]
+
+    assert_equal :strict, @cmd.options[:abi_lock]
+  end
+
+  def test_handle_abi_lock_none
+    @cmd.handle_options ["--abi-lock=none"]
+
+    assert_equal :none, @cmd.options[:abi_lock]
+  end
+
+  def test_handle_no_abi_lock_none
+    @cmd.handle_options ["--no-abi-lock"]
+
+    assert_equal :none, @cmd.options[:abi_lock]
+  end
+
+  def test_handle_abi_lock_unknown
+    e = assert_raises OptionParser::InvalidArgument do
+      @cmd.handle_options %w[--abi-lock unknown]
+    end
+
+    assert_equal "invalid argument: --abi-lock unknown (none, ruby, strict are valid)",
+                 e.message
+  end
+
+  def test_handle_strip_default
+    @cmd.handle_options %w[--strip]
+
+    assert_equal RbConfig::CONFIG["STRIP"], @cmd.options[:strip]
+  end
+
+  def test_handle_strip_custom
+    @cmd.handle_options ["--strip", "strip --custom"]
+
+    assert_equal "strip --custom", @cmd.options[:strip]
+  end
 end

data/test/rubygems/test_gem_compiler.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rubygems/test_case"
 require "rubygems/compiler"
 
@@ -25,14 +27,16 @@ class TestGemCompiler < Gem::TestCase
 
     compiler = Gem::Compiler.new(gem_file, :output => @output_dir)
 
-    e = assert_raises Gem::Compiler::CompilerError do
+    assert_raises Gem::MockGemUi::SystemExitException do
       use_ui @ui do
         compiler.compile
       end
     end
 
-    assert_equal "There are no extensions to build on this gem file.",
-                 e.message
+    out = @ui.output.split "\n"
+
+    assert_equal "There are no extensions to build on this gem file. Skipping.",
+                  out.last
   end
 
   def test_compile_non_ruby
@@ -40,13 +44,15 @@ class TestGemCompiler < Gem::TestCase
 
     compiler = Gem::Compiler.new(gem_file, :output => @output_dir)
 
-    e = assert_raises Gem::Compiler::CompilerError do
+    assert_raises Gem::MockGemUi::SystemExitException do
       use_ui @ui do
         compiler.compile
       end
     end
 
-    assert_equal "The gem file seems to be compiled already.", e.message
+    out = @ui.output.split "\n"
+
+    assert_equal "The gem file seems to be compiled already. Skipping.", out.last
   end
 
   def test_compile_pre_install_hooks
@@ -307,7 +313,7 @@ class TestGemCompiler < Gem::TestCase
     util_reset_arch
   end
 
-  def test_compile_lock_ruby_abi
+  def test_compile_abi_lock_ruby
     util_reset_arch
 
     ruby_abi = RbConfig::CONFIG["ruby_version"]
@@ -317,7 +323,29 @@ class TestGemCompiler < Gem::TestCase
       util_fake_extension s, "foo", util_custom_configure(artifact)
     }
 
-    compiler = Gem::Compiler.new(gem_file, :output => @output_dir)
+    compiler = Gem::Compiler.new(gem_file, :output => @output_dir, :abi_lock => nil)
+    output_gem = nil
+
+    use_ui @ui do
+      output_gem = compiler.compile
+    end
+
+    spec = util_read_spec File.join(@output_dir, output_gem)
+
+    assert_equal Gem::Requirement.new("~> #{ruby_abi}"), spec.required_ruby_version
+  end
+
+  def test_compile_abi_lock_explicit_ruby
+    util_reset_arch
+
+    ruby_abi = RbConfig::CONFIG["ruby_version"]
+    artifact = "foo.#{RbConfig::CONFIG["DLEXT"]}"
+
+    gem_file = util_bake_gem("foo") { |s|
+      util_fake_extension s, "foo", util_custom_configure(artifact)
+    }
+
+    compiler = Gem::Compiler.new(gem_file, :output => @output_dir, :abi_lock => :ruby)
     output_gem = nil
 
     use_ui @ui do
@@ -326,19 +354,65 @@ class TestGemCompiler < Gem::TestCase
 
     spec = util_read_spec File.join(@output_dir, output_gem)
 
-    assert_equal spec.required_ruby_version, Gem::Requirement.new("~> #{ruby_abi}")
+    assert_equal Gem::Requirement.new("~> #{ruby_abi}"), spec.required_ruby_version
   end
 
-  def test_compile_no_lock_ruby_abi
+  def test_compile_abi_lock_strict
     util_reset_arch
 
+    ruby_abi = "%d.%d.%d.0" % RbConfig::CONFIG.values_at("MAJOR", "MINOR", "TEENY")
     artifact = "foo.#{RbConfig::CONFIG["DLEXT"]}"
 
     gem_file = util_bake_gem("foo") { |s|
       util_fake_extension s, "foo", util_custom_configure(artifact)
     }
 
-    compiler = Gem::Compiler.new(gem_file, :output => @output_dir, :no_abi_lock => true)
+    compiler = Gem::Compiler.new(gem_file, :output => @output_dir, :abi_lock => :strict)
+    output_gem = nil
+
+    use_ui @ui do
+      output_gem = compiler.compile
+    end
+
+    spec = util_read_spec File.join(@output_dir, output_gem)
+
+    assert_equal Gem::Requirement.new("~> #{ruby_abi}"), spec.required_ruby_version
+  end
+
+  def test_compile_abi_lock_none
+    util_reset_arch
+
+    artifact = "foo.#{RbConfig::CONFIG["DLEXT"]}"
+
+    gem_file = util_bake_gem("foo") { |s|
+      util_fake_extension s, "foo", util_custom_configure(artifact)
+    }
+
+    compiler = Gem::Compiler.new(gem_file, :output => @output_dir, :abi_lock => :none)
+    output_gem = nil
+
+    use_ui @ui do
+      output_gem = compiler.compile
+    end
+
+    spec = util_read_spec File.join(@output_dir, output_gem)
+
+    assert_equal Gem::Requirement.new(">= 0"), spec.required_ruby_version
+  end
+
+  def test_compile_strip_cmd
+    util_reset_arch
+    hook_simple_run
+
+    old_rbconfig_strip = RbConfig::CONFIG["STRIP"]
+    RbConfig::CONFIG["STRIP"] = "rbconfig-strip-cmd"
+
+    gem_file = util_bake_gem("foo") do |spec|
+      util_dummy_extension spec, "bar"
+    end
+
+    compiler = Gem::Compiler.new(gem_file, :output => @output_dir,
+                                :strip => "echo strip-custom")
     output_gem = nil
 
     use_ui @ui do
@@ -346,8 +420,38 @@ class TestGemCompiler < Gem::TestCase
     end
 
     spec = util_read_spec File.join(@output_dir, output_gem)
+    assert_includes spec.files, "lib/bar.#{RbConfig::CONFIG["DLEXT"]}"
+
+    assert_match %r|Stripping symbols from extensions|, @ui.output
+    refute_match %r|#{RbConfig::CONFIG["STRIP"]}|, @ui.output
+    assert_match %r|using 'echo strip-custom'|, @ui.output
+  ensure
+    RbConfig::CONFIG["STRIP"] = old_rbconfig_strip
+    restore_simple_run
+  end
+
+  ##
+  # Replace `simple_run` to help testing command execution
+
+  def hook_simple_run
+    Gem::Compiler.class_eval do
+      alias_method :orig_simple_run, :simple_run
+      remove_method :simple_run
+
+      def simple_run(command, command_name)
+        say "#{command_name}: #{command}"
+      end
+    end
+  end
+
+  ##
+  # Restore `simple_run` to its original version
 
-    assert_equal spec.required_ruby_version, Gem::Requirement.new(">= 0")
+  def restore_simple_run
+    Gem::Compiler.class_eval do
+      remove_method :simple_run
+      alias_method :simple_run, :orig_simple_run
+    end
   end
 
   ##
@@ -364,11 +468,54 @@ class TestGemCompiler < Gem::TestCase
   def util_bake_gem(name = "a", *extra, &block)
     files = ["lib/#{name}.rb"].concat(extra)
 
-    spec = new_spec name, "1", nil, files, &block
+    spec = if Gem::VERSION >= "3.0.0"
+      util_spec name, "1", nil, files, &block
+    else
+      new_spec name, "1", nil, files, &block
+    end
 
     File.join @tempdir, "gems", "#{spec.full_name}.gem"
   end
 
+  ##
+  # Add a dummy, valid extension to provided spec
+
+  def util_dummy_extension(spec, name = "a")
+    extconf = File.join("ext", name, "extconf.rb")
+    dummy_c = File.join("ext", name, "dummy.c")
+
+    spec.extensions << extconf
+    spec.files << dummy_c
+
+    dir = spec.gem_dir
+    FileUtils.mkdir_p dir
+
+    Dir.chdir dir do
+      FileUtils.mkdir_p File.dirname(extconf)
+
+      # extconf.rb
+      File.open extconf, "w" do |f|
+        f.write <<~EOF
+          require "mkmf"
+
+          create_makefile("#{name}")
+        EOF
+      end
+
+      # dummy.c
+      File.open dummy_c, "w" do |f|
+        f.write <<~EOF
+          #include <ruby.h>
+
+          void Init_#{name}(void)
+          {
+              rb_p(ID2SYM(rb_intern("ok")));
+          }
+        EOF
+      end
+    end
+  end
+
   ##
   # Add a fake extension to provided spec and accept an optional script.
   # Default to no-op if none is provided.

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gem-compiler
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.9.0
 platform: ruby
 authors:
 - Luis Lavena
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-28 00:00:00.000000000 Z
+date: 2020-04-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -74,15 +74,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.3.0
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.5.0
+      version: 2.6.0
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.4
+rubygems_version: 2.6.14.4
 signing_key: 
 specification_version: 4
 summary: A RubyGems plugin that generates binary gems.