gem-clone 0.4.2 → 0.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f10b5ead51ab522bd8575ce4d75a262dbfc1c92e190207d1101631bb76a24366
-  data.tar.gz: db822b7b07fbcb6ec522c667cc90829d70c6fcd93b18bedd8591971d7cadc2b1
+  metadata.gz: 836f42b5a4924b0e9d94246ff6d12bb2f39faa30c51647d8443f75a4f1b98656
+  data.tar.gz: 22c882c0be0897264b54cbf865e9ba234cd7ec05d778ece19431c1158c6e8577
 SHA512:
-  metadata.gz: 1c897ef52329cfbbaae20e125d630a142d849cade5d2cfcf52c901aa91a118f63bd27fa9661f8fc8a849978281cab629fefdc7a6b436f18500030a93dc8818fe
-  data.tar.gz: 864e09fd30b7a65ae23b4162bc226c9806d69e3820562600e900a0f1627be5573a9c7f6c8a1903641941e0b3521b3be97cf55e55cbaff730b5a3d9142ece4a70
+  metadata.gz: e911bd7cf6c713b46e3e9ca34da2edd34c2af8e6988e308ace4b403d7526a7722abc009f1b8c655f06f0da76fa5522cafffa82bceeaa8a2995dc2e80f1b60500
+  data.tar.gz: fb3c3a11745f66da76dc3db82173d3b01c611e5905578a6f3feeddac926bf8faa4208ca0c39ab95e6f5d2e8a1846ddf8dfdc9b16c3f477e6cd260b8c17a1819b

data/README.md

@@ -126,7 +126,7 @@ The plugin performs the following steps:
 
 ### URL Normalization
 
-The plugin automatically normalizes repository URLs by removing common Git hosting service paths:
+Gem metadata names the same repository in many shapes, so the plugin folds them to one before cloning. Common Git hosting service paths are removed:
 
 - `/tree/*` → removed (GitHub, GitLab branches/tags)
 - `/blob/*` → removed (GitHub, GitLab file views)
@@ -137,8 +137,16 @@ The plugin automatically normalizes repository URLs by removing common Git hosti
 - `/tags/*` → removed (tag pages)
 - `/branches/*` → removed (branch pages)
 
-**Example:**
+So is anything else that does not name the repository itself:
+
+- `#fragment` and `?query` → removed
+- `http://` → `https://`
+- `https://www.` → `https://`
+- trailing `/` and `.git` → removed
+
+**Examples:**
 - `https://github.com/rails/rails/tree/v8.0.2` → `https://github.com/rails/rails`
+- `http://www.github.com/rails/rails.git` → `https://github.com/rails/rails`
 
 ### Cross-platform Support
 

data/lib/rubygems/commands/clone_command.rb

@@ -5,6 +5,9 @@ require 'uri'
 require 'open3'
 
 class Gem::Commands::CloneCommand < Gem::Command
+  # git goget answers with this when the repository cannot be reached at all.
+  GOGET_SKIPPED = 3
+
   def initialize
     super 'clone', 'Clone a gem repository using git goget, ghq, or git'
 
@@ -102,9 +105,11 @@ Examples:
   def normalize_repository_url(url)
     return url if url.nil? || url.empty?
 
-    normalized_url = url.gsub(%r{/(tree|blob|commits|releases|issues|pull|tags|branches)/.*$}, '')
+    normalized_url = url.sub(/[#?].*/m, '')
+    normalized_url = normalized_url.sub(%r{\Ahttp://}, 'https://').sub(%r{\Ahttps://www\.}, 'https://')
+    normalized_url = normalized_url.gsub(%r{/(tree|blob|commits|releases|issues|pull|tags|branches)/.*$}, '')
 
-    normalized_url.chomp('/')
+    normalized_url.chomp('/').sub(/\.git\z/, '')
   end
 
   def clone_repository(url)
@@ -133,13 +138,16 @@ Examples:
   end
 
   def clone_with_git_goget(url)
-    command = "git goget #{url}"
-    say "Executing: #{command}" if options[:verbose]
+    say "Executing: git goget #{url}" if options[:verbose]
 
-    system(command)
+    system("git", "goget", url)
 
-    if $?.success?
+    case $?.exitstatus
+    when 0
       say "Successfully cloned repository: #{url}"
+    when GOGET_SKIPPED
+      alert_error "Repository is unreachable: #{url}"
+      terminate_interaction 1
     else
       alert_error "Failed to clone repository with git goget."
       terminate_interaction 1
@@ -147,11 +155,10 @@ Examples:
   end
 
   def clone_with_ghq(url)
-    command = "ghq get #{url}"
     say "git goget not found, falling back to ghq" if options[:verbose]
-    say "Executing: #{command}" if options[:verbose]
+    say "Executing: ghq get #{url}" if options[:verbose]
 
-    system(command)
+    system("ghq", "get", url)
 
     if $?.success?
       say "Successfully cloned repository: #{url}"
@@ -162,11 +169,10 @@ Examples:
   end
 
   def clone_with_git(url)
-    command = "git clone #{url}"
     say "ghq not found, falling back to git clone" if options[:verbose]
-    say "Executing: #{command}" if options[:verbose]
+    say "Executing: git clone #{url}" if options[:verbose]
 
-    system(command)
+    system("git", "clone", url)
 
     if $?.success?
       say "Successfully cloned repository: #{url}"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gem-clone
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.4.3
 platform: ruby
 authors:
 - Hiroshi SHIBATA