geet 0.31.1 → 0.32.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bf5b6b46f33b00c38e4f383c186ca62d9a196f3516cee7e5569cabc087e028be
-  data.tar.gz: eb3464d9583e1a9672bba43752ba56707cd1ab84931e9df830c74cadbebe266d
+  metadata.gz: 2903cf0f0d89e0f84d45e434545cf6958adcad59ec3ccbe7bad825bb987834a4
+  data.tar.gz: 255f580c0f8f555f6fb3e69ded39a785d062907db5da4d0d909cf03b12a85bf9
 SHA512:
-  metadata.gz: 983a7f8a246f87ecacd86b2afd8dd0aa6e9deaff51b443ecc29697c91b2b8c3fcb9fee462ef295fe66a526e527111e0cf0bace6b7294c38353223481df5a3d06
-  data.tar.gz: 6e55131d0d846d6d72c9d5e1312c40291bb996313c3106e33cc1e3069c82464d6b0119eacd4f037453e9dba89b6f620d0179a65cb6adbc0248c53dd959289943
+  metadata.gz: 195be7f2ca33e9fadcada902dcacff479d3dfa17ca4424fc876bfeea53e69cc56e2044f36f3e52cc4d73053f8015ce944bc047a60f7c9645759c95126644ce0f
+  data.tar.gz: d1b5c383990d18d0340e6d0b52ff60212f0d5788fd9c35c5598af125e6df20b72c5ad375817531345222c16676b96ae1dd7e9d69e6a85d7e81f3db002c9de9c7

data/bin/geet

@@ -30,7 +30,11 @@ class GeetLauncher
       return
     end
 
-    repository = Git::Repository.new(upstream: !!options[:upstream], protected_repositories: protected_repositories)
+    repository = Git::Repository.new(
+      upstream: !!options[:upstream],
+      protected_repositories: protected_repositories,
+      api_token_required: !TOKEN_OPTIONAL_COMMANDS.include?(command)
+    )
 
     case command
     when GIST_CREATE_COMMAND

data/geet.gemspec

@@ -8,7 +8,7 @@ Gem::Specification.new do |s|
   s.platform    = Gem::Platform::RUBY
   s.required_ruby_version = ">= 3.3.0"
   s.authors     = ["Saverio Miroddi"]
-  s.date        = "2026-07-24"
+  s.date        = "2026-10-14"
   s.email       = ["saverio.pub2@gmail.com"]
   s.homepage    = "https://github.com/saveriomiroddi/geet"
   s.summary     = "Commandline interface for performing SCM host operations, eg. create a PR on GitHub"

data/lib/geet/commandline/commands.rb

@@ -20,6 +20,13 @@ module Geet
       REPO_ADD_UPSTREAM_COMMAND = T.let("repo.add_upstream", String)
       REPO_CREATE_COMMAND = T.let("repo.create", String)
       REPO_OPEN_COMMAND = T.let("repo.open", String)
+
+      TOKEN_OPTIONAL_COMMANDS = T.let([
+        LABEL_LIST_COMMAND,
+        MILESTONE_LIST_COMMAND,
+        PR_LIST_COMMAND,
+        PR_OPEN_COMMAND,
+      ].freeze, T::Array[String])
     end
   end
 end

data/lib/geet/git/repository.rb

@@ -23,14 +23,15 @@ module Geet
           upstream: T::Boolean,
           git_client: Utils::GitClient,
           warnings: T::Boolean,                          # disable all the warnings
-          protected_repositories: T::Array[String]       # warn when creating an issue/pr on these repos (format: `owner/repo`)
+          protected_repositories: T::Array[String],      # warn when creating an issue/pr on these repos (format: `owner/repo`)
+          api_token_required: T::Boolean
         )
         .void
       }
-      def initialize(upstream: false, git_client: DEFAULT_GIT_CLIENT, warnings: true, protected_repositories: [])
+      def initialize(upstream: false, git_client: DEFAULT_GIT_CLIENT, warnings: true, protected_repositories: [], api_token_required: true)
         @upstream = upstream
         @git_client = git_client
-        @api_token = T.let(extract_env_api_token, String)
+        @api_token = T.let(extract_env_api_token(required: api_token_required), T.nilable(String))
         @warnings = warnings
         @protected_repositories = protected_repositories
       end
@@ -200,9 +201,12 @@ module Geet
         @api_interface ||= Github::ApiInterface.new(@api_token, repo_path: @git_client.path(upstream: @upstream), upstream: @upstream)
       end
 
-      sig { returns(String) }
-      def extract_env_api_token
-        ENV["GH_TOKEN"] || raise("GH_TOKEN not set!")
+      sig { params(required: T::Boolean).returns(T.nilable(String)) }
+      def extract_env_api_token(required:)
+        api_token = ENV["GH_TOKEN"]
+        raise "GH_TOKEN not set!" if required && api_token.nil?
+
+        api_token
       end
     end
   end

data/lib/geet/github/api_interface.rb

@@ -13,6 +13,7 @@ module Geet
       API_AUTH_USER = T.let("", String) # We don't need the login, as the API key uniquely identifies the user
       API_BASE_URL = T.let("https://api.github.com", String)
       GRAPHQL_API_URL = T.let("https://api.github.com/graphql", String)
+      UNAUTHENTICATED_NOT_FOUND_HINT = T.let("GH_TOKEN is not set; private repositories require it", String)
 
       sig { returns(T.nilable(String)) }
       attr_reader :repository_path
@@ -22,13 +23,13 @@ module Geet
       #
       sig {
         params(
-          api_token: String,
+          api_token: T.nilable(String),
           repo_path: T.nilable(String),
           upstream: T.nilable(T::Boolean)
         ).void
       }
       def initialize(api_token, repo_path: nil, upstream: nil)
-        @api_token = T.let(api_token, String)
+        @api_token = T.let(api_token, T.nilable(String))
         @repository_path = T.let(repo_path, T.nilable(String))
         @upstream = T.let(upstream, T.nilable(T::Boolean))
       end
@@ -78,6 +79,8 @@ module Geet
 
           if error?(response)
             error_message = decode_and_format_error(T.cast(parsed_response, T::Hash[String, T.untyped]))
+            # GitHub hides private repositories from unauthenticated requests behind a 404.
+            error_message += " (#{UNAUTHENTICATED_NOT_FOUND_HINT})" if response.code == "404" && @api_token.nil?
             raise Geet::Shared::HttpError.new(error_message, response.code)
           end
 
@@ -110,7 +113,7 @@ module Geet
 
         Net::HTTP.start(uri.host, use_ssl: true) do |http|
           request = Net::HTTP::Post.new(uri).tap do
-            it.basic_auth API_AUTH_USER, @api_token
+            it.basic_auth API_AUTH_USER, @api_token if @api_token
             it["Accept"] = "application/vnd.github.v3+json"
             it.body = {query:, variables:}.to_json
           end
@@ -169,7 +172,7 @@ module Geet
         Net::HTTP.start(uri.host, use_ssl: true) do |http|
           request = http_class.new(uri)
 
-          request.basic_auth API_AUTH_USER, @api_token
+          request.basic_auth API_AUTH_USER, @api_token if @api_token
           request.body = data.to_json if data
           request["Accept"] = "application/vnd.github.v3+json"
 

data/lib/geet/helpers/services_workflow_helper.rb

@@ -26,11 +26,7 @@ module Geet
       #
       sig { returns(Github::PR) }
       def checked_find_branch_pr
-        owner = if @repository.upstream?
-          @repository.authenticated_user.username
-        else
-          @git_client.owner
-        end
+        owner = @git_client.owner
 
         head = @git_client.current_branch
 

data/lib/geet/version.rb

@@ -2,5 +2,5 @@
 # typed: strict
 
 module Geet
-  VERSION = "0.31.1"
+  VERSION = "0.32.1"
 end

data/spec/integration/open_pr_spec.rb

@@ -39,4 +39,27 @@ describe Geet::Services::OpenPr do
     end
 
   end # context 'with github.com'
+
+  context "when opening an upstream PR" do
+    let(:repository) { instance_double(Geet::Git::Repository, upstream?: true) }
+
+    it "uses the origin owner without requesting the authenticated user" do
+      pr = instance_double(
+        Geet::Github::PR,
+        link: "https://github.com/upstream/repository/pull/1"
+      )
+
+      allow(git_client).to receive(:owner).and_return(owner)
+      allow(git_client).to receive(:current_branch).and_return(branch)
+      allow(repository).to receive(:prs).with(owner:, head: branch).and_return([pr])
+      expect(repository).not_to receive(:authenticated_user)
+
+      expect {
+        service_instance = described_class.new(repository, git_client: git_client)
+        allow(service_instance).to receive(:open_file_with_default_application)
+
+        expect(service_instance.execute).to equal(pr)
+      }.to output("Finding PR with head (#{owner}:#{branch})...\n").to_stdout
+    end
+  end
 end

data/spec/unit/geet_launcher_spec.rb

@@ -45,5 +45,46 @@ describe GeetLauncher do
     ensure
       ENV["GH_TOKEN"] = without_token if without_token
     end
+
+    {
+      Geet::Commandline::Commands::LABEL_LIST_COMMAND => Geet::Services::ListLabels,
+      Geet::Commandline::Commands::MILESTONE_LIST_COMMAND => Geet::Services::ListMilestones,
+      Geet::Commandline::Commands::PR_LIST_COMMAND => Geet::Services::ListPrs,
+      Geet::Commandline::Commands::PR_OPEN_COMMAND => Geet::Services::OpenPr,
+    }.each do |command, service_class|
+      it "dispatches #{command} with an optional API token" do
+        launcher = described_class.new
+        repository = instance_double(Geet::Git::Repository)
+        service = instance_double(service_class)
+
+        allow_any_instance_of(Geet::Commandline::Configuration).to receive(:decode_argv).and_return([command, {}])
+        allow(launcher).to receive(:protected_repositories).and_return([])
+        expect(Geet::Git::Repository).to receive(:new).with(
+          upstream: false,
+          protected_repositories: [],
+          api_token_required: false
+        ).and_return(repository)
+        expect(service_class).to receive(:new).with(repository).and_return(service)
+        expect(service).to receive(:execute).with(no_args)
+
+        launcher.launch
+      end
+    end
+
+    it "requires an API token for issue.list" do
+      launcher = described_class.new
+
+      allow_any_instance_of(Geet::Commandline::Configuration).to receive(:decode_argv).and_return([
+        Geet::Commandline::Commands::ISSUE_LIST_COMMAND,
+        {},
+      ])
+      allow(launcher).to receive(:protected_repositories).and_return([])
+      expect(Geet::Services::ListIssues).not_to receive(:new)
+
+      api_token = ENV.delete("GH_TOKEN")
+      expect { launcher.launch }.to raise_error("GH_TOKEN not set!")
+    ensure
+      ENV["GH_TOKEN"] = api_token if api_token
+    end
   end
 end

data/spec/unit/git/repository_spec.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe Geet::Git::Repository do
+  describe "API token handling" do
+    it "allows the token to be omitted when authentication is not required" do
+      api_token = ENV.delete("GH_TOKEN")
+
+      expect { described_class.new(api_token_required: false) }.not_to raise_error
+    ensure
+      ENV["GH_TOKEN"] = api_token if api_token
+    end
+
+    it "requires the token by default" do
+      api_token = ENV.delete("GH_TOKEN")
+
+      expect { described_class.new }.to raise_error("GH_TOKEN not set!")
+    ensure
+      ENV["GH_TOKEN"] = api_token if api_token
+    end
+  end
+end

data/spec/unit/github/api_interface_spec.rb

@@ -0,0 +1,51 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+require "webmock/rspec"
+
+describe Geet::Github::ApiInterface do
+  describe "authentication" do
+    let(:request_url) { "https://api.github.com/repos/owner/repository/issues" }
+
+    it "sends an unauthenticated request when no token is available" do
+      request = stub_request(:get, request_url)
+        .with { |actual_request| !actual_request.headers.key?("Authorization") }
+        .to_return(status: 200, body: "[]")
+
+      described_class.new(nil, repo_path: "owner/repository").send_request("issues")
+
+      expect(request).to have_been_requested.once
+    end
+
+    it "authenticates the request when a token is available" do
+      authorization = "Basic #{Base64.strict_encode64(":token")}"
+      request = stub_request(:get, request_url)
+        .with(headers: {"Authorization" => authorization})
+        .to_return(status: 200, body: "[]")
+
+      described_class.new("token", repo_path: "owner/repository").send_request("issues")
+
+      expect(request).to have_been_requested.once
+    end
+
+    context "when the response is Not Found" do
+      before do
+        stub_request(:get, request_url).to_return(status: 404, body: {message: "Not Found"}.to_json)
+      end
+
+      it "hints at the missing token when no token is available" do
+        expect {
+          described_class.new(nil, repo_path: "owner/repository").send_request("issues")
+        }.to raise_error(Geet::Shared::HttpError, "Not Found (GH_TOKEN is not set; private repositories require it)") { |error|
+          expect(error.code).to eq(404)
+        }
+      end
+
+      it "doesn't hint at the token when one is available" do
+        expect {
+          described_class.new("token", repo_path: "owner/repository").send_request("issues")
+        }.to raise_error(Geet::Shared::HttpError, "Not Found")
+      end
+    end
+  end
+end

data/spec/unit/github/pr_spec.rb

@@ -7,6 +7,32 @@ require_relative "../../../lib/geet/github/pr"
 require_relative "../../../lib/geet/github/api_interface"
 
 describe Geet::Github::PR do
+  describe ".list" do
+    it "filters upstream PRs by the supplied origin owner and branch" do
+      api_interface = instance_double(Geet::Github::ApiInterface, upstream?: true)
+      matching_pr = {
+        "number" => 1,
+        "title" => "Matching PR",
+        "html_url" => "https://github.com/upstream/repository/pull/1",
+        "head" => {"label" => "origin-owner:topic"},
+      }
+      other_pr = {
+        "number" => 2,
+        "title" => "Other PR",
+        "html_url" => "https://github.com/upstream/repository/pull/2",
+        "head" => {"label" => "other-owner:topic"},
+      }
+
+      expect(api_interface).to receive(:send_request)
+        .with("pulls", multipage: true)
+        .and_return([matching_pr, other_pr])
+
+      prs = described_class.list(api_interface, owner: "origin-owner", head: "topic")
+
+      expect(prs.map(&:number)).to eq([1])
+    end
+  end
+
   describe "#fetch_available_merge_method" do
     let(:api_interface) { instance_double(Geet::Github::ApiInterface) }
     let(:pr_number) { 123 }

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: geet
 version: !ruby/object:Gem::Version
-  version: 0.31.1
+  version: 0.32.1
 platform: ruby
 authors:
 - Saverio Miroddi
 bindir: bin
 cert_chain: []
-date: 2026-07-24 00:00:00.000000000 Z
+date: 2026-10-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: base64
@@ -260,6 +260,8 @@ files:
 - spec/spec_helper.rb
 - spec/unit/commandline/configuration_spec.rb
 - spec/unit/geet_launcher_spec.rb
+- spec/unit/git/repository_spec.rb
+- spec/unit/github/api_interface_spec.rb
 - spec/unit/github/pr_spec.rb
 - spec/unit/github/repository_spec.rb
 - spec/unit/services/create_repo_spec.rb
@@ -310,7 +312,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.10
+rubygems_version: 4.0.20
 specification_version: 4
 summary: Commandline interface for performing SCM host operations, eg. create a PR
   on GitHub