geet 0.30.0 → 0.31.0

data/spec/integration/open_repo_spec.rb

@@ -8,7 +8,6 @@ require_relative "../../lib/geet/services/open_repo"
 module Geet
   describe Services::OpenRepo do
     let(:git_client) { Utils::GitClient.new }
-    let(:repository) { Git::Repository.new(git_client: git_client) }
 
     OWNER = "donaldduck"
     REPOSITORY_NAME = "testrepo"
@@ -27,7 +26,7 @@ module Geet
           expected_output = ""
 
           expect {
-            service_instance = described_class.new(repository, git_client: git_client)
+            service_instance = described_class.new(git_client: git_client)
 
             expect(service_instance).to receive(:open_file_with_default_application).with(expected_url) do
               # do nothing; just don't open the browser

data/spec/unit/commandline/configuration_spec.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+# typed: false
+
+require "spec_helper"
+
+describe Geet::Commandline::Configuration do
+  describe "#decode_argv" do
+    it "decodes long repository creation options" do
+      stub_const("ARGV", [
+        "repo", "create",
+        "--visibility", "private",
+        "--upstream", "git@github.com:owner/project.git",
+      ])
+
+      expect(described_class.new.decode_argv).to eq([
+        "repo.create",
+        {visibility: "private", upstream: "git@github.com:owner/project.git"},
+      ])
+    end
+
+    it "decodes short repository creation options" do
+      stub_const("ARGV", [
+        "repo", "create",
+        "-v", "public",
+        "-u", "https://github.com/owner/project.git",
+      ])
+
+      expect(described_class.new.decode_argv).to eq([
+        "repo.create",
+        {visibility: "public", upstream: "https://github.com/owner/project.git"},
+      ])
+    end
+  end
+end

data/spec/unit/geet_launcher_spec.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+# typed: false
+
+require "spec_helper"
+load File.expand_path("../../bin/geet", __dir__)
+
+describe GeetLauncher do
+  describe "#launch" do
+    it "dispatches repository creation before constructing an existing repository" do
+      service = instance_double(Geet::Services::CreateRepo)
+      allow_any_instance_of(Geet::Commandline::Configuration).to receive(:decode_argv).and_return([
+        Geet::Commandline::Commands::REPO_CREATE_COMMAND,
+        {visibility: "private"},
+      ])
+      expect(Geet::Services::CreateRepo).to receive(:new).and_return(service)
+      expect(service).to receive(:execute).with(visibility: "private")
+      expect(Geet::Git::Repository).not_to receive(:new)
+
+      described_class.new.launch
+    end
+
+    it "dispatches repository opening without constructing an authenticated repository" do
+      service = instance_double(Geet::Services::OpenRepo)
+      allow_any_instance_of(Geet::Commandline::Configuration).to receive(:decode_argv).and_return([
+        Geet::Commandline::Commands::REPO_OPEN_COMMAND,
+        {upstream: true},
+      ])
+      expect(Geet::Services::OpenRepo).to receive(:new).and_return(service)
+      expect(service).to receive(:execute).with(upstream: true)
+      expect(Geet::Git::Repository).not_to receive(:new)
+
+      without_token = ENV.delete("GH_TOKEN")
+      described_class.new.launch
+    ensure
+      ENV["GH_TOKEN"] = without_token if without_token
+    end
+  end
+end

data/spec/unit/github/repository_spec.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+require_relative "../../spec_helper"
+
+RSpec.describe Geet::Github::Repository do
+  let(:api_interface) { instance_double(Geet::Github::ApiInterface) }
+  let(:response) do
+    {
+      "full_name" => "donald/geet",
+      "html_url" => "https://github.com/donald/geet",
+      "ssh_url" => "git@github.com:donald/geet.git",
+    }
+  end
+
+  it "creates a private repository for the authenticated user" do
+    expect(api_interface).to receive(:send_request).with("/user/repos", data: {name: "geet", private: true}).and_return(response)
+    repository = described_class.create("geet", "private", api_interface)
+    expect([repository.full_name, repository.html_url, repository.ssh_url]).to eq(["donald/geet", "https://github.com/donald/geet", "git@github.com:donald/geet.git"])
+  end
+
+  it "creates a public repository for the authenticated user" do
+    expect(api_interface).to receive(:send_request).with("/user/repos", data: {name: "geet", private: false}).and_return(response)
+    described_class.create("geet", "public", api_interface)
+  end
+
+  it "requests a named fork" do
+    expect(api_interface).to receive(:send_request).with("/repos/upstream/project/forks", data: {name: "geet"}).and_return(response)
+    described_class.fork("upstream/project", "geet", api_interface)
+  end
+
+  it "fetches a repository" do
+    expect(api_interface).to receive(:send_request).with("/repos/donald/geet").and_return(response)
+    expect(described_class.fetch("donald/geet", api_interface).full_name).to eq("donald/geet")
+  end
+
+  it "updates the default branch" do
+    expect(api_interface).to receive(:send_request).with("/repos/donald/geet", data: {default_branch: "topic"}, http_method: :patch)
+    described_class.new(response, api_interface).update_default_branch("topic")
+  end
+end

data/spec/unit/services/create_repo_spec.rb

@@ -0,0 +1,187 @@
+# frozen_string_literal: true
+# typed: false
+
+require "spec_helper"
+
+describe Geet::Services::CreateRepo do
+  describe "#execute" do
+    let(:git_client) { instance_double(Geet::Utils::GitClient) }
+    let(:api_interface) { instance_double(Geet::Github::ApiInterface) }
+    let(:prompt) { instance_double(TTY::Prompt) }
+    let(:out) { StringIO.new }
+
+    subject(:service) do
+      described_class.new(
+        directory: "/tmp/geet",
+        out:,
+        git_client:,
+        api_interface:,
+        prompt:,
+        sleeper: ->(_) {},
+        fork_attempts: 3
+      )
+    end
+
+    before do
+      allow(git_client).to receive(:head_commit?).and_return(true)
+      allow(git_client).to receive(:current_branch).and_return("topic")
+      allow(git_client).to receive(:remote_defined?).with("origin").and_return(false)
+    end
+
+    it "rejects a repository without commits before making an API request" do
+      allow(git_client).to receive(:head_commit?).and_return(false)
+
+      expect(Geet::Github::Repository).not_to receive(:create)
+      expect { service.execute(visibility: "private") }.to raise_error("The repository has no commits!")
+    end
+
+    it "rejects a detached HEAD before prompting or making an API request" do
+      allow(git_client).to receive(:current_branch).and_raise("Couldn't find current branch")
+
+      expect(prompt).not_to receive(:select)
+      expect(Geet::Github::Repository).not_to receive(:create)
+      expect { service.execute }.to raise_error("Couldn't find current branch")
+    end
+
+    it "rejects an existing origin before making an API request" do
+      allow(git_client).to receive(:remote_defined?).with("origin").and_return(true)
+
+      expect(Geet::Github::Repository).not_to receive(:create)
+      expect { service.execute(visibility: "private") }.to raise_error('Remote "origin" already exists!')
+    end
+
+    it "rejects an existing upstream before making an API request" do
+      allow(git_client).to receive(:remote_defined?).with("upstream").and_return(true)
+
+      expect(Geet::Github::Repository).not_to receive(:fork)
+      expect { service.execute(upstream: "https://github.com/upstream/project.git") }
+        .to raise_error('Remote "upstream" already exists!')
+    end
+
+    it "rejects invalid visibility before making an API request" do
+      expect(Geet::Github::Repository).not_to receive(:create)
+      expect { service.execute(visibility: "internal") }.to raise_error("Visibility must be private or public!")
+    end
+
+    it "rejects visibility in fork mode before making an API request" do
+      allow(git_client).to receive(:remote_defined?).with("upstream").and_return(false)
+
+      expect(Geet::Github::Repository).not_to receive(:fork)
+      expect { service.execute(visibility: "private", upstream: "https://github.com/upstream/project.git") }
+        .to raise_error("Visibility can't be specified with upstream!")
+    end
+
+    it "prompts for visibility when it is omitted" do
+      repository = instance_double(Geet::Github::Repository, ssh_url: "git@github.com:donald/geet.git", html_url: "https://github.com/donald/geet")
+      allow(prompt).to receive(:select).with("Visibility:", ["private", "public"]).and_return("private")
+      allow(Geet::Github::Repository).to receive(:create).with("geet", "private", api_interface).and_return(repository)
+      allow(git_client).to receive(:add_remote)
+      allow(git_client).to receive(:push)
+      allow(repository).to receive(:update_default_branch)
+
+      service.execute
+    end
+
+    it "does not prompt when public visibility is explicit" do
+      repository = instance_double(Geet::Github::Repository, ssh_url: "git@github.com:donald/geet.git", html_url: "https://github.com/donald/geet")
+      expect(prompt).not_to receive(:select)
+      allow(Geet::Github::Repository).to receive(:create).with("geet", "public", api_interface).and_return(repository)
+      allow(git_client).to receive(:add_remote)
+      allow(git_client).to receive(:push)
+      allow(repository).to receive(:update_default_branch)
+
+      service.execute(visibility: "public")
+    end
+
+    it "creates a repository, configures origin, pushes, and updates the default branch in order" do
+      repository = instance_double(
+        Geet::Github::Repository,
+        full_name: "donald/geet",
+        ssh_url: "git@github.com:donald/geet.git",
+        html_url: "https://github.com/donald/geet"
+      )
+      allow(prompt).to receive(:select).and_return("private")
+      expect(Geet::Github::Repository).to receive(:create)
+        .with("geet", "private", api_interface).ordered.and_return(repository)
+      expect(git_client).to receive(:add_remote)
+        .with("origin", "git@github.com:donald/geet.git").ordered
+      expect(git_client).to receive(:push).with(remote_branch: "topic").ordered
+      expect(repository).to receive(:update_default_branch).with("topic").ordered
+
+      expect(service.execute).to eq(repository)
+      expect(out.string).to include("Repository address: https://github.com/donald/geet")
+      expect(out.string).to include("Default branch: topic")
+    end
+
+    it "waits for a fork, configures both remotes, pushes, and updates the default branch" do
+      upstream = "https://github.com/upstream/project.git"
+      provisional_repository = instance_double(Geet::Github::Repository, full_name: "donald/geet")
+      repository = instance_double(
+        Geet::Github::Repository,
+        ssh_url: "git@github.com:donald/geet.git",
+        html_url: "https://github.com/donald/geet"
+      )
+      sleeper = proc {}
+      service = described_class.new(
+        directory: "/tmp/geet", out:, git_client:, api_interface:, prompt:,
+        sleeper:, fork_attempts: 3
+      )
+      allow(git_client).to receive(:remote_defined?).with("upstream").and_return(false)
+      expect(git_client).to receive(:remote_path).with(upstream).ordered.and_return("upstream/project")
+      expect(Geet::Github::Repository).to receive(:fork)
+        .with("upstream/project", "geet", api_interface).ordered.and_return(provisional_repository)
+      expect(Geet::Github::Repository).to receive(:fetch)
+        .with("donald/geet", api_interface).ordered.and_raise(Geet::Shared::HttpError.new("Not Found", 404))
+      expect(sleeper).to receive(:call).with(1).ordered
+      expect(Geet::Github::Repository).to receive(:fetch)
+        .with("donald/geet", api_interface).ordered.and_return(repository)
+      expect(git_client).to receive(:add_remote)
+        .with("origin", "git@github.com:donald/geet.git").ordered
+      expect(git_client).to receive(:add_remote).with("upstream", upstream).ordered
+      expect(git_client).to receive(:push).with(remote_branch: "topic").ordered
+      expect(repository).to receive(:update_default_branch).with("topic").ordered
+
+      expect(service.execute(upstream:)).to eq(repository)
+      expect(out.string).to include("Repository address: https://github.com/donald/geet")
+      expect(out.string).to include("Default branch: topic")
+    end
+
+    it "times out after all fork fetch attempts return 404" do
+      upstream = "https://github.com/upstream/project.git"
+      provisional_repository = instance_double(Geet::Github::Repository, full_name: "donald/geet")
+      allow(git_client).to receive(:remote_defined?).with("upstream").and_return(false)
+      allow(git_client).to receive(:remote_path).with(upstream).and_return("upstream/project")
+      allow(Geet::Github::Repository).to receive(:fork).and_return(provisional_repository)
+      allow(Geet::Github::Repository).to receive(:fetch)
+        .and_raise(Geet::Shared::HttpError.new("Not Found", 404))
+
+      expect { service.execute(upstream:) }.to raise_error("Timed out waiting for fork donald/geet")
+    end
+
+    it "immediately propagates a non-404 fork fetch error" do
+      upstream = "https://github.com/upstream/project.git"
+      provisional_repository = instance_double(Geet::Github::Repository, full_name: "donald/geet")
+      error = Geet::Shared::HttpError.new("Server Error", 500)
+      allow(git_client).to receive(:remote_defined?).with("upstream").and_return(false)
+      allow(git_client).to receive(:remote_path).with(upstream).and_return("upstream/project")
+      allow(Geet::Github::Repository).to receive(:fork).and_return(provisional_repository)
+      allow(Geet::Github::Repository).to receive(:fetch).and_raise(error)
+
+      expect { service.execute(upstream:) }.to raise_error(error)
+    end
+
+    it "stops before pushing or updating the default branch when adding a remote fails" do
+      repository = instance_double(
+        Geet::Github::Repository,
+        ssh_url: "git@github.com:donald/geet.git",
+        html_url: "https://github.com/donald/geet"
+      )
+      allow(Geet::Github::Repository).to receive(:create).and_return(repository)
+      allow(git_client).to receive(:add_remote).and_raise("remote failure")
+      expect(git_client).not_to receive(:push)
+      expect(repository).not_to receive(:update_default_branch)
+
+      expect { service.execute(visibility: "private") }.to raise_error("remote failure")
+    end
+  end
+end

data/spec/unit/services/merge_pr_spec.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+# typed: false
+
+require "spec_helper"
+
+require_relative "../../../lib/geet/git/repository"
+require_relative "../../../lib/geet/services/merge_pr"
+
+describe Geet::Services::MergePr do
+  describe "#execute" do
+    let(:repository) { instance_double(Geet::Git::Repository) }
+    let(:git_client) { instance_double(Geet::Utils::GitClient) }
+
+    subject { described_class.new(repository, out: StringIO.new, git_client: git_client) }
+
+    it "raises when both --rebase and --squash are passed" do
+      expect { subject.execute(rebase: true, squash: true) }
+        .to raise_error("Can't specify both --rebase and --squash")
+    end
+  end
+end

data/spec/unit/utils/git_client_spec.rb

@@ -0,0 +1,50 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+require "tmpdir"
+
+describe Geet::Utils::GitClient do
+  subject { described_class.new }
+
+  describe "#head_commit?" do
+    it "returns true when HEAD resolves" do
+      allow(subject).to receive(:execute_git_command).with("rev-parse --verify HEAD", allow_error: true, silent_stderr: true).and_return("abc123")
+      expect(subject.head_commit?).to be(true)
+    end
+
+    it "returns false for an unborn HEAD" do
+      allow(subject).to receive(:execute_git_command).with("rev-parse --verify HEAD", allow_error: true, silent_stderr: true).and_return("")
+      expect(subject.head_commit?).to be(false)
+    end
+  end
+
+  describe "#remote_path" do
+    it "extracts an SSH repository path" do
+      expect(subject.remote_path("git@github.com:owner/project.git")).to eq("owner/project")
+    end
+
+    it "extracts an HTTPS repository path" do
+      expect(subject.remote_path("https://github.com/owner/project.git")).to eq("owner/project")
+    end
+
+    it "rejects an unsupported address" do
+      expect { subject.remote_path("owner/project") }.to raise_error(RuntimeError, 'Unexpected remote reference format: "owner/project"')
+    end
+  end
+
+  describe "#add_remote" do
+    it "passes a URL containing shell metacharacters as a single argument" do
+      Dir.mktmpdir do |directory|
+        marker = File.join(directory, "injected")
+        url = "https://example.com/owner/project.git; touch #{marker}"
+        git_client = described_class.new(location: directory)
+        system("git", "init", "--quiet", directory, exception: true)
+
+        git_client.add_remote("origin", url)
+
+        expect(File).not_to exist(marker)
+        expect(`git -C #{directory.shellescape} remote get-url origin`.strip).to eq(url)
+      end
+    end
+  end
+end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: geet
 version: !ruby/object:Gem::Version
-  version: 0.30.0
+  version: 0.31.0
 platform: ruby
 authors:
 - Saverio Miroddi
 bindir: bin
 cert_chain: []
-date: 2026-05-12 00:00:00.000000000 Z
+date: 2026-07-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: base64
@@ -43,14 +43,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.14.0
+        version: '0.14'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.14.0
+        version: '0.14'
 - !ruby/object:Gem::Dependency
   name: sorbet-runtime
   requirement: !ruby/object:Gem::Requirement
@@ -99,14 +99,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.3'
+        version: '13.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.3'
+        version: '13.3'
 description: Commandline interface for performing SCM host operations, eg. create
   a PR on GitHub, with support for multiple hosts.
 email:
@@ -128,6 +128,12 @@ files:
 - Rakefile
 - bin/geet
 - bin/tapioca
+- docs/superpowers/plans/2026-07-12-pre-existing-build-and-ci-fixes.md
+- docs/superpowers/plans/2026-07-12-repo-create.md
+- docs/superpowers/plans/2026-07-12-ruby-4-upgrade.md
+- docs/superpowers/specs/2026-07-12-pre-existing-build-and-ci-fixes-design.md
+- docs/superpowers/specs/2026-07-12-repo-create-design.md
+- docs/superpowers/specs/2026-07-12-ruby-4-upgrade-design.md
 - extra/anonymize_vcr_data
 - extra/issue_editing.png
 - extra/pr_editing.png
@@ -145,6 +151,7 @@ files:
 - lib/geet/github/label.rb
 - lib/geet/github/milestone.rb
 - lib/geet/github/pr.rb
+- lib/geet/github/repository.rb
 - lib/geet/github/user.rb
 - lib/geet/helpers/json_helper.rb
 - lib/geet/helpers/os_helper.rb
@@ -159,6 +166,7 @@ files:
 - lib/geet/services/create_label.rb
 - lib/geet/services/create_milestone.rb
 - lib/geet/services/create_pr.rb
+- lib/geet/services/create_repo.rb
 - lib/geet/services/list_issues.rb
 - lib/geet/services/list_labels.rb
 - lib/geet/services/list_milestones.rb
@@ -201,7 +209,7 @@ files:
 - sorbet/rbi/gems/public_suffix@6.0.1.rbi
 - sorbet/rbi/gems/racc@1.8.1.rbi
 - sorbet/rbi/gems/rainbow@3.1.1.rbi
-- sorbet/rbi/gems/rake@12.3.3.rbi
+- sorbet/rbi/gems/rake@13.4.2.rbi
 - sorbet/rbi/gems/rbi@0.3.7.rbi
 - sorbet/rbi/gems/rbs@4.0.0.dev.5.rbi
 - sorbet/rbi/gems/regexp_parser@2.11.2.rbi
@@ -250,7 +258,13 @@ files:
 - spec/integration/open_pr_spec.rb
 - spec/integration/open_repo_spec.rb
 - spec/spec_helper.rb
+- spec/unit/commandline/configuration_spec.rb
+- spec/unit/geet_launcher_spec.rb
 - spec/unit/github/pr_spec.rb
+- spec/unit/github/repository_spec.rb
+- spec/unit/services/create_repo_spec.rb
+- spec/unit/services/merge_pr_spec.rb
+- spec/unit/utils/git_client_spec.rb
 - spec/vcr_cassettes/create_gist_private.yml
 - spec/vcr_cassettes/create_gist_public.yml
 - spec/vcr_cassettes/create_issue.yml
@@ -289,14 +303,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 3.2.0
+      version: 3.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.7
+rubygems_version: 4.0.10
 specification_version: 4
 summary: Commandline interface for performing SCM host operations, eg. create a PR
   on GitHub