geet 0.3.17 → 0.3.18

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a475adafa9bb0791266b171ea0e8ba05caf076227f1d3b68efe75697479c2cca
-  data.tar.gz: e63c7d8d46c3f44b0962ee1c3445e3aaf076f03b41f218bfde957779decfd445
+  metadata.gz: 8b37d7ac48684dcd431b13c0e00cb9f999764ae714dec3c8d046102469f7f62f
+  data.tar.gz: 43a045941aff66c212314ae0de2c5c439434c75e89240ce2c59750f5759dcc5a
 SHA512:
-  metadata.gz: 1d19fde0bb7c9733ee7aaea4c249378077d242c56f92055f29c1f3eb27e200de06890f2d5e97c76a58ffc604c46674ceddd8fc349b17907cee89fdfabbd029c0
-  data.tar.gz: dbdad4b310621f063af44aabfe71fb485232a836085c5729a057d350911408db3e3dd18e7a40459ceb80d4cae000f279ceaf2798a1eaf9f6caeab7b704da3fa8
+  metadata.gz: fe4aa67774fef6b5943ae4f6eb2950ec4d4c2b7f004aa963438e00904d80d01c3a73db8671567c718b6fc9b235a2e9d2002744ec891bce3ff4af1144ffa01d28
+  data.tar.gz: 14c3efa61fa206f3f3f70432c3683d394f9e4e4e09f6cefad757d96d11b88110559f393d22d296acef963d72d7117c668125724da79d8f1f6cbda9e35dfc367a

data/README.md

@@ -18,17 +18,12 @@ The functionalities currently supported are:
 
 - Github/Gitlab:
   - create label
-  - list issues
-  - list labels
-  - list milestones
-  - list PRs
-  - merge PR
+  - list issues, labels, milestones, MR/PRs
+  - merge MR/PR
+  - open repository
 - Github:
   - comment PR
-  - create gist
-  - create issue
-  - create milestone
-  - create PR
+  - create gist, issue, milestone, PR
 
 ## Samples
 

data/bin/geet

@@ -76,6 +76,10 @@ class GeetLauncher
       Services::MergePr.new(repository).execute(**options)
     when PR_OPEN_COMMAND
       Services::OpenPr.new(repository).execute(**options)
+    when REPO_ADD_UPSTREAM_COMMAND
+      Services::AddUpstreamRepo.new(repository).execute
+    when REPO_OPEN_COMMAND
+      Services::OpenRepo.new(repository).execute(**options)
     else
       raise "Internal error - Unrecognized command #{command.inspect}"
     end

data/geet.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |s|
   s.platform    = Gem::Platform::RUBY
   s.required_ruby_version = '>= 2.3.0'
   s.authors     = ['Saverio Miroddi']
-  s.date        = '2021-01-18'
+  s.date        = '2021-05-28'
   s.email       = ['saverio.pub2@gmail.com']
   s.homepage    = 'https://github.com/saveriomiroddi/geet'
   s.summary     = 'Commandline interface for performing SCM host operations, eg. create a PR on GitHub'

data/lib/geet/commandline/commands.rb

@@ -16,6 +16,8 @@ module Geet
       PR_LIST_COMMAND = 'pr.list'
       PR_MERGE_COMMAND = 'pr.merge'
       PR_OPEN_COMMAND = 'pr.open'
+      REPO_ADD_UPSTREAM_COMMAND = 'repo.add_upstream'
+      REPO_OPEN_COMMAND = 'repo.open'
     end
   end
 end

data/lib/geet/commandline/configuration.rb

@@ -98,6 +98,15 @@ module Geet
         long_help: 'Open in the browser the PR for the current branch'
       ]
 
+      REPO_ADD_UPSTREAM_OPTIONS = [
+        long_help: 'Add the upstream repository to the current repository (configuration).'
+      ]
+
+      REPO_OPEN_OPTIONS = [
+        ['-u', '--upstream',                                'Open the upstream repository'],
+        long_help: 'Open the current repository in the browser'
+      ]
+
       # Commands decoding table
 
       COMMANDS_DECODING_TABLE = {
@@ -124,6 +133,10 @@ module Geet
           'merge' => PR_MERGE_OPTIONS,
           'open' => PR_OPEN_OPTIONS,
         },
+        'repo' => {
+          'add_upstream' => REPO_ADD_UPSTREAM_OPTIONS,
+          'open' => REPO_OPEN_OPTIONS,
+        },
       }
 
       # Public interface

data/lib/geet/git/repository.rb

@@ -85,6 +85,12 @@ module Geet
         attempt_provider_call(:PR, :list, api_interface, owner: owner, head: head, milestone: milestone)
       end
 
+      # Returns the RemoteRepository instance.
+      #
+      def remote
+        attempt_provider_call(:RemoteRepository, :find, api_interface)
+      end
+
       # REMOTE FUNCTIONALITIES (ACCOUNT)
 
       def authenticated_user

data/lib/geet/github/api_interface.rb

@@ -11,6 +11,8 @@ module Geet
       API_AUTH_USER = '' # We don't need the login, as the API key uniquely identifies the user
       API_BASE_URL = 'https://api.github.com'
 
+      attr_reader :repository_path
+
       # repo_path: optional for operations that don't require a repository, eg. gist creation.
       # upstream:  boolean; makes sense only when :repo_path is set.
       #

data/lib/geet/github/remote_repository.rb

@@ -0,0 +1,37 @@
+# frozen_string_literal: true
+
+module Geet
+  module Github
+    # A remote repository. Currently only provides the parent path.
+    #
+    # It's a difficult choice whether to independently use the repository path, or relying on the one
+    # stored in the ApiInterface.
+    # The former design is conceptually cleaner, but it practically (as of the current design) introduces
+    # duplication. All in all, for simplicity, the latter design is chosen, but is subject to redesign.
+    #
+    class RemoteRepository
+      # Nil if the repository is not a fork.
+      #
+      attr_reader :parent_path
+
+      def initialize(api_interface, parent_path: nil)
+        @api_interface = api_interface
+        @parent_path = parent_path
+      end
+
+      # Get the repository parent path.
+      #
+      # https://docs.github.com/en/rest/reference/repos#get-a-repository
+      #
+      def self.find(api_interface)
+        api_path = "/repos/#{api_interface.repository_path}"
+
+        response = api_interface.send_request(api_path)
+
+        parent_path = response['parent']&.fetch("full_name")
+
+        self.new(api_interface, parent_path: parent_path)
+      end
+    end # module RemoteRepository
+  end # module GitHub
+end # module Geet

data/lib/geet/gitlab/api_interface.rb

@@ -10,6 +10,8 @@ module Geet
     class ApiInterface
       API_BASE_URL = 'https://gitlab.com/api/v4'
 
+      attr_reader :repository_path
+
       # repo_path: "path/namespace"; required for the current GitLab operations.
       # upstream:  boolean; required for the current GitLab operations.
       #

data/lib/geet/services/add_upstream_repo.rb

@@ -0,0 +1,37 @@
+# frozen_string_literal: true
+
+module Geet
+  module Services
+    # Add the upstream repository to the current repository (configuration).
+    #
+    class AddUpstreamRepo
+      DEFAULT_GIT_CLIENT = Utils::GitClient.new
+
+      def initialize(repository, out: $stdout, git_client: DEFAULT_GIT_CLIENT)
+        @repository = repository
+        @out = out
+        @git_client = git_client
+      end
+
+      def execute
+        raise "Upstream remote already existing!" if @git_client.remote_defined?(Utils::GitClient::UPSTREAM_NAME)
+
+        parent_path = @repository.remote.parent_path
+
+        parent_url = compose_parent_url(parent_path)
+
+        @git_client.add_remote(Utils::GitClient::UPSTREAM_NAME, parent_url)
+      end
+
+      private
+
+      # Use the same protocol as the main repository.
+      #
+      def compose_parent_url(parent_path)
+        protocol, domain, separator, _, suffix = @git_client.remote_components
+
+        "#{protocol}#{domain}#{separator}#{parent_path}#{suffix}"
+      end
+    end
+  end
+end

data/lib/geet/services/open_repo.rb

@@ -0,0 +1,50 @@
+# frozen_string_literal: true
+
+require_relative '../helpers/os_helper'
+
+module Geet
+  module Services
+    # Open in the browser the current repository.
+    #
+    class OpenRepo
+      include Helpers::OsHelper
+
+      DEFAULT_GIT_CLIENT = Utils::GitClient.new
+
+      def initialize(repository, out: $stdout, git_client: DEFAULT_GIT_CLIENT)
+        @repository = repository
+        @out = out
+        @git_client = git_client
+      end
+
+      def execute(upstream: false)
+        remote_options = upstream ? {name: Utils::GitClient::UPSTREAM_NAME} : {}
+
+        repo_url = @git_client.remote(**remote_options)
+        repo_url = convert_repo_url_to_http_protocol(repo_url)
+
+        open_file_with_default_application(repo_url)
+
+        repo_url
+      end
+
+      private
+
+      # The repository URL may be in any of the git/http protocols.
+      #
+      def convert_repo_url_to_http_protocol(repo_url)
+        case repo_url
+        when /https:/
+        when /git@/
+        else
+          # Minimal error, due to match guaranteed by GitClient#remote.
+          raise
+        end
+
+        domain, _, path = repo_url.match(Utils::GitClient::REMOTE_URL_REGEX)[2..4]
+
+        "https://#{domain}/#{path}"
+      end
+    end
+  end
+end

data/lib/geet/utils/attributes_selection_manager.rb

@@ -88,6 +88,13 @@ module Geet
       #   select_entries('reviewer', all_collaborators, 'donaldduck', nil)
       #
       def select_entries(entry_type, entries, pattern, name_method)
+        # Support both formats Array and String.
+        # It seems that at some point, SimpleScripting started splitting arrays automatically, so until
+        # the code is adjusted accordingly, this accommodates both the CLI and the test suite.
+        # Tracked here: https://github.com/saveriomiroddi/geet/issues/171.
+        #
+        pattern = pattern.join(',') if pattern.is_a?(Array)
+
         if pattern == MANUAL_LIST_SELECTION_FLAG
           Geet::Utils::ManualListSelection.new.select_entries(entry_type, entries, name_method: name_method)
         else

data/lib/geet/utils/git_client.rb

@@ -11,15 +11,25 @@ module Geet
     class GitClient
       include Geet::Helpers::OsHelper
 
-      ORIGIN_NAME   = 'origin'
       UPSTREAM_NAME = 'upstream'
 
-      # For simplicity, we match any character except the ones the separators.
-      REMOTE_ORIGIN_REGEX = %r{
+      # Simplified, but good enough, pattern.
+      #
+      # Relevant matches:
+      #
+      #   1: protocol + suffix
+      #   2: domain
+      #   3: domain<>path separator
+      #   4: path (repo, project)
+      #   5: suffix
+      #
+      REMOTE_URL_REGEX = %r{
         \A
-        (?:https://(.+?)/|git@(.+?):)
-        ([^/]+/.*?)
-        (?:\.git)?
+        (https://|git@)
+        (.+?)
+        ([/:])
+        (.+/.+?)
+        (\.git)?
         \Z
       }x
 
@@ -109,15 +119,22 @@ module Geet
       end
 
       ##########################################################################
-      # REPOSITORY/REMOTE APIS
+      # REPOSITORY/REMOTE QUERYING APIS
       ##########################################################################
 
+      # Return the components of the remote, according to REMOTE_URL_REGEX; doesn't include the full
+      # match.
+      #
+      def remote_components(name: nil)
+        remote.match(REMOTE_URL_REGEX)[1..]
+      end
+
       # Example: `donaldduck/geet`
       #
       def path(upstream: false)
-        remote_name = upstream ? UPSTREAM_NAME : ORIGIN_NAME
+        remote_name_option = upstream ? {name: UPSTREAM_NAME} : {}
 
-        remote(remote_name)[REMOTE_ORIGIN_REGEX, 3]
+        remote(**remote_name_option)[REMOTE_URL_REGEX, 4]
       end
 
       def owner
@@ -126,12 +143,10 @@ module Geet
 
       def provider_domain
         # We assume that it's not possible to have origin and upstream on different providers.
-        #
-        remote_url = remote(ORIGIN_NAME)
 
-        domain = remote_url[REMOTE_ORIGIN_REGEX, 1] || remote_url[REMOTE_ORIGIN_REGEX, 2]
+        domain = remote()[REMOTE_URL_REGEX, 2]
 
-        raise "Can't identify domain in the provider domain string: #{domain}" if domain !~ /(.*)\.\w+/
+        raise "Can't identify domain in the provider domain string: #{domain}" if domain !~ /\w+\.\w+/
 
         domain
       end
@@ -141,12 +156,15 @@ module Geet
       #
       # The result is in the format `git@github.com:donaldduck/geet.git`
       #
-      def remote(name)
+      # options
+      #   :name:           remote name; if unspecified, the default remote is used.
+      #
+      def remote(name: nil)
         remote_url = execute_git_command("ls-remote --get-url #{name}")
 
-        if remote_url == name
+        if !remote_defined?(name)
           raise "Remote #{name.inspect} not found!"
-        elsif remote_url !~ REMOTE_ORIGIN_REGEX
+        elsif remote_url !~ REMOTE_URL_REGEX
           raise "Unexpected remote reference format: #{remote_url.inspect}"
         end
 
@@ -159,7 +177,8 @@ module Geet
       def remote_defined?(name)
         remote_url = execute_git_command("ls-remote --get-url #{name}")
 
-        # If the remote is not define, `git ls-remote` will return the passed value.
+        # If the remote is not defined, `git ls-remote` will return the passed value.
+        #
         remote_url != name
       end
 
@@ -195,6 +214,10 @@ module Geet
         execute_git_command("fetch --prune")
       end
 
+      def add_remote(name, url)
+        execute_git_command("remote add #{name.shellescape} #{url}")
+      end
+
       ##########################################################################
       # INTERNAL HELPERS
       ##########################################################################

data/lib/geet/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Geet
-  VERSION = '0.3.17'
+  VERSION = '0.3.18'
 end

data/spec/integration/comment_pr_spec.rb

@@ -17,7 +17,7 @@ describe Geet::Services::CommentPr do
 
     it 'should add a comment to the PR for the current branch' do
       allow(git_client).to receive(:current_branch).and_return(branch)
-      allow(git_client).to receive(:remote).with('origin').and_return("git@github.com:#{owner}/#{repository_name}")
+      allow(git_client).to receive(:remote).with(no_args).and_return("git@github.com:#{owner}/#{repository_name}")
 
       expected_pr_number = 3
       expected_output = <<~STR

data/spec/integration/create_issue_spec.rb

@@ -12,7 +12,7 @@ describe Geet::Services::CreateIssue do
 
   context 'with labels, assignees and milestones' do
     it 'should create an issue' do
-      allow(git_client).to receive(:remote).with('origin').and_return('git@github.com:donaldduck/testrepo_f')
+      allow(git_client).to receive(:remote).with(no_args).and_return('git@github.com:donaldduck/testrepo_f')
 
       expected_output = <<~STR
         Finding labels...
@@ -47,8 +47,8 @@ describe Geet::Services::CreateIssue do
     context 'without labels, assignees and milestones' do
       it 'should create an upstream issue' do
         allow(git_client).to receive(:current_branch).and_return('mybranch')
-        allow(git_client).to receive(:remote).with('origin').and_return('git@github.com:donaldduck/testrepo')
-        allow(git_client).to receive(:remote).with('upstream').and_return('git@github.com:momcorp/therepo')
+        allow(git_client).to receive(:remote).with(no_args).and_return('git@github.com:donaldduck/testrepo')
+        allow(git_client).to receive(:remote).with(name: 'upstream').and_return('git@github.com:momcorp/therepo')
 
         expected_output = <<~STR
           Creating the issue...

data/spec/integration/create_label_spec.rb

@@ -13,7 +13,7 @@ describe Geet::Services::CreateLabel do
   context 'with github.com' do
     context 'with user-specified color' do
       it 'should create a label' do
-        allow(git_client).to receive(:remote).with('origin').and_return('git@github.com:donaldduck/testrepo')
+        allow(git_client).to receive(:remote).with(no_args).and_return('git@github.com:donaldduck/testrepo')
 
         expected_output = <<~STR
           Creating label...
@@ -34,8 +34,8 @@ describe Geet::Services::CreateLabel do
 
       context 'upstream' do
         it 'should create a label' do
-          allow(git_client).to receive(:remote).with('origin').and_return('git@github.com:donaldduck/testrepo')
-          allow(git_client).to receive(:remote).with('upstream').and_return('git@github.com:donaldduck-fr/testrepo_gh')
+          allow(git_client).to receive(:remote).with(no_args).and_return('git@github.com:donaldduck/testrepo')
+          allow(git_client).to receive(:remote).with(name: 'upstream').and_return('git@github.com:donaldduck-fr/testrepo_gh')
 
           expected_output = <<~STR
             Creating label...
@@ -58,7 +58,7 @@ describe Geet::Services::CreateLabel do
 
     context 'with auto-generated color' do
       it 'should create a label' do
-        allow(git_client).to receive(:remote).with('origin').and_return('git@github.com:donaldduck/testrepo')
+        allow(git_client).to receive(:remote).with(no_args).and_return('git@github.com:donaldduck/testrepo')
 
         actual_output = StringIO.new
 
@@ -87,7 +87,7 @@ describe Geet::Services::CreateLabel do
 
   context 'with gitlab.com' do
     it 'should create a label' do
-      allow(git_client).to receive(:remote).with('origin').and_return('git@gitlab.com:donaldduck/testproject')
+      allow(git_client).to receive(:remote).with(no_args).and_return('git@gitlab.com:donaldduck/testproject')
 
       expected_output = <<~STR
         Creating label...

data/spec/integration/create_milestone_spec.rb

@@ -12,7 +12,7 @@ describe Geet::Services::CreateMilestone do
 
   context 'with github.com' do
     it 'should create a milestone' do
-      allow(git_client).to receive(:remote).with('origin').and_return('git@github.com:donaldduck/testrepo_upstream')
+      allow(git_client).to receive(:remote).with(no_args).and_return('git@github.com:donaldduck/testrepo_upstream')
 
       expected_output = <<~STR
         Creating milestone...

data/spec/integration/create_pr_spec.rb

@@ -14,7 +14,7 @@ describe Geet::Services::CreatePr do
     context 'with labels, reviewers and milestones' do
       it 'should create a PR' do
         allow(git_client).to receive(:current_branch).and_return('mybranch')
-        allow(git_client).to receive(:remote).with('origin').and_return('git@github.com:donaldduck/testrepo_f')
+        allow(git_client).to receive(:remote).with(no_args).and_return('git@github.com:donaldduck/testrepo_f')
 
         expected_output = <<~STR
           Finding labels...
@@ -50,8 +50,8 @@ describe Geet::Services::CreatePr do
     context 'on an upstream repository' do
       it 'should create an upstream PR' do
         allow(git_client).to receive(:current_branch).and_return('mybranch')
-        allow(git_client).to receive(:remote).with('origin').and_return('git@github.com:donaldduck/testrepo_f')
-        allow(git_client).to receive(:remote).with('upstream').and_return('git@github.com:donald-fr/testrepo_u')
+        allow(git_client).to receive(:remote).with(no_args).and_return('git@github.com:donaldduck/testrepo_f')
+        allow(git_client).to receive(:remote).with(name: 'upstream').and_return('git@github.com:donald-fr/testrepo_u')
 
         expected_output = <<~STR
           Creating PR...
@@ -80,8 +80,8 @@ describe Geet::Services::CreatePr do
         context 'without labels, reviewers and milestones' do
           it 'should create a PR' do
             allow(git_client).to receive(:current_branch).and_return('mybranch')
-            allow(git_client).to receive(:remote).with('origin').and_return('git@github.com:donaldduck/testrepo_f')
-            allow(git_client).to receive(:remote).with('upstream').and_return('git@github.com:donald-fr/testrepo_u')
+            allow(git_client).to receive(:remote).with(no_args).and_return('git@github.com:donaldduck/testrepo_f')
+            allow(git_client).to receive(:remote).with(name: 'upstream').and_return('git@github.com:donald-fr/testrepo_u')
 
             expected_output = <<~STR
               Creating PR...
@@ -112,7 +112,7 @@ describe Geet::Services::CreatePr do
     context 'in automated mode' do
       it 'should raise an error when the working tree is dirty' do
         allow(git_client).to receive(:working_tree_clean?).and_return(false)
-        allow(git_client).to receive(:remote).with('origin').and_return('git@github.com:donaldduck/testrepo_f')
+        allow(git_client).to receive(:remote).with(no_args).and_return('git@github.com:donaldduck/testrepo_f')
 
         expected_output = <<~STR
           Error! Saved summary to /tmp/last_geet_edited_summary.md
@@ -136,7 +136,7 @@ describe Geet::Services::CreatePr do
         expect(git_client).to receive(:upstream_branch).and_return('mybranch')
         expect(git_client).to receive(:push)
 
-        allow(git_client).to receive(:remote).with('origin').and_return('git@github.com:donaldduck/testrepo_f')
+        allow(git_client).to receive(:remote).with(no_args).and_return('git@github.com:donaldduck/testrepo_f')
 
         expected_output = <<~STR
           Pushing to upstream branch...
@@ -161,7 +161,7 @@ describe Geet::Services::CreatePr do
         expect(git_client).to receive(:upstream_branch).and_return(nil)
         expect(git_client).to receive(:push).with(upstream_branch: 'mybranch')
 
-        allow(git_client).to receive(:remote).with('origin').and_return('git@github.com:donaldduck/testrepo_f')
+        allow(git_client).to receive(:remote).with(no_args).and_return('git@github.com:donaldduck/testrepo_f')
 
         expected_output = <<~STR
           Creating upstream branch "mybranch"...

data/spec/integration/list_issues_spec.rb

@@ -12,7 +12,7 @@ describe Geet::Services::ListIssues do
 
   context 'with github.com' do
     it 'should list the default issues' do
-      allow(git_client).to receive(:remote).with('origin').and_return('git@github.com:donaldduck/testrepo')
+      allow(git_client).to receive(:remote).with(no_args).and_return('git@github.com:donaldduck/testrepo')
 
       expected_output = <<~STR
         5. Title 2 (https://github.com/donaldduck/testrepo/issues/5)
@@ -34,7 +34,7 @@ describe Geet::Services::ListIssues do
 
     context 'with assignee filtering' do
       it 'should list the issues' do
-        allow(git_client).to receive(:remote).with('origin').and_return('git@github.com:donaldduck/testrepo_gh')
+        allow(git_client).to receive(:remote).with(no_args).and_return('git@github.com:donaldduck/testrepo_gh')
 
         expected_output = <<~STR
           Finding collaborators...
@@ -57,8 +57,8 @@ describe Geet::Services::ListIssues do
     end
 
     it 'should list the upstream issues' do
-      allow(git_client).to receive(:remote).with('origin').and_return('git@github.com:donaldduck/testrepo_2f')
-      allow(git_client).to receive(:remote).with('upstream').and_return('git@github.com:donald-fr/testrepo_u')
+      allow(git_client).to receive(:remote).with(no_args).and_return('git@github.com:donaldduck/testrepo_2f')
+      allow(git_client).to receive(:remote).with(name: 'upstream').and_return('git@github.com:donald-fr/testrepo_u')
 
       expected_output = <<~STR
         2. Title 2 U (https://github.com/donald-fr/testrepo_u/issues/2)
@@ -81,7 +81,7 @@ describe Geet::Services::ListIssues do
 
   context 'with gitlab.com' do
     it 'should list the issues' do
-      allow(git_client).to receive(:remote).with('origin').and_return('git@gitlab.com:donaldduck/testproject')
+      allow(git_client).to receive(:remote).with(no_args).and_return('git@gitlab.com:donaldduck/testproject')
 
       expected_output = <<~STR
         2. I like more pizza (https://gitlab.com/donaldduck/testproject/issues/2)
@@ -103,7 +103,7 @@ describe Geet::Services::ListIssues do
 
     context 'with assignee filtering' do
       it 'should list the issues' do
-        allow(git_client).to receive(:remote).with('origin').and_return('git@gitlab.com:donaldduck/testproject')
+        allow(git_client).to receive(:remote).with(no_args).and_return('git@gitlab.com:donaldduck/testproject')
 
         expected_output = <<~STR
           Finding collaborators...

data/spec/integration/list_labels_spec.rb

@@ -12,7 +12,7 @@ describe Geet::Services::ListLabels do
 
   context 'with github.com' do
     it 'should list the labels' do
-      allow(git_client).to receive(:remote).with('origin').and_return('git@github.com:donaldduck/geet')
+      allow(git_client).to receive(:remote).with(no_args).and_return('git@github.com:donaldduck/geet')
 
       expected_output = <<~STR
         - bug (#ee0701)
@@ -34,8 +34,8 @@ describe Geet::Services::ListLabels do
     end
 
     it 'should list the upstream labels' do
-      allow(git_client).to receive(:remote).with('origin').and_return('git@github.com:donaldduck/geet')
-      allow(git_client).to receive(:remote).with('upstream').and_return('git@github.com:donaldduck-fr/testrepo_u')
+      allow(git_client).to receive(:remote).with(no_args).and_return('git@github.com:donaldduck/geet')
+      allow(git_client).to receive(:remote).with(name: 'upstream').and_return('git@github.com:donaldduck-fr/testrepo_u')
 
       expected_output = <<~STR
         - bug (#ee0701)
@@ -57,7 +57,7 @@ describe Geet::Services::ListLabels do
 
   context 'with gitlab.com' do
     it 'should list the labels' do
-      allow(git_client).to receive(:remote).with('origin').and_return('git@gitlab.com:donaldduck/testproject')
+      allow(git_client).to receive(:remote).with(no_args).and_return('git@gitlab.com:donaldduck/testproject')
 
       expected_output = <<~STR
         - bug (#d9534f)

data/spec/integration/list_milestones_spec.rb

@@ -12,7 +12,7 @@ describe Geet::Services::ListMilestones do
 
   context 'with github.com' do
     it 'should list the milestones' do
-      allow(git_client).to receive(:remote).with('origin').and_return('git@github.com:donaldduck/geet')
+      allow(git_client).to receive(:remote).with(no_args).and_return('git@github.com:donaldduck/geet')
 
       expected_output = <<~STR
         Finding milestones...
@@ -50,8 +50,8 @@ describe Geet::Services::ListMilestones do
     end
 
     it 'should list the upstream milestones' do
-      allow(git_client).to receive(:remote).with('origin').and_return('git@github.com:donald-fr/testrepo_downstream')
-      allow(git_client).to receive(:remote).with('upstream').and_return('git@github.com:donaldduck/testrepo_upstream')
+      allow(git_client).to receive(:remote).with(no_args).and_return('git@github.com:donald-fr/testrepo_downstream')
+      allow(git_client).to receive(:remote).with(name: 'upstream').and_return('git@github.com:donaldduck/testrepo_upstream')
 
       expected_output = <<~STR
         Finding milestones...
@@ -80,7 +80,7 @@ describe Geet::Services::ListMilestones do
 
   context 'with gitlab.com' do
     it 'should list the milestones' do
-      allow(git_client).to receive(:remote).with('origin').and_return('git@gitlab.com:donaldduck/testproject')
+      allow(git_client).to receive(:remote).with(no_args).and_return('git@gitlab.com:donaldduck/testproject')
 
       expected_output = <<~STR
         Finding milestones...

data/spec/integration/list_prs_spec.rb

@@ -11,7 +11,7 @@ describe Geet::Services::ListPrs do
   let(:upstream_repository) { Geet::Git::Repository.new(upstream: true, git_client: git_client) }
 
   it 'should list the PRs' do
-    allow(git_client).to receive(:remote).with('origin').and_return('git@github.com:donald-fr/testrepo_downstream')
+    allow(git_client).to receive(:remote).with(no_args).and_return('git@github.com:donald-fr/testrepo_downstream')
 
     expected_output = <<~STR
       2. Add testfile3 (downstream) (https://github.com/donald-fr/testrepo_downstream/pull/2)
@@ -32,8 +32,8 @@ describe Geet::Services::ListPrs do
   end
 
   it 'should list the upstream PRs' do
-    allow(git_client).to receive(:remote).with('origin').and_return('git@github.com:donald-fr/testrepo_downstream')
-    allow(git_client).to receive(:remote).with('upstream').and_return('git@github.com:donaldduck/testrepo_upstream')
+    allow(git_client).to receive(:remote).with(no_args).and_return('git@github.com:donald-fr/testrepo_downstream')
+    allow(git_client).to receive(:remote).with(name: 'upstream').and_return('git@github.com:donaldduck/testrepo_upstream')
 
     expected_output = <<~STR
       2. Add testfile3 (upstream) (https://github.com/donaldduck/testrepo_upstream/pull/2)

data/spec/integration/merge_pr_spec.rb

@@ -29,7 +29,7 @@ describe Geet::Services::MergePr do
 
     it 'should merge the PR for the current branch' do
       allow(git_client).to receive(:current_branch).and_return(branch)
-      allow(git_client).to receive(:remote).with('origin').and_return("git@github.com:#{owner}/#{repository_name}")
+      allow(git_client).to receive(:remote).with(no_args).and_return("git@github.com:#{owner}/#{repository_name}")
 
       expected_pr_number = 1
       expected_output = <<~STR
@@ -55,7 +55,7 @@ describe Geet::Services::MergePr do
 
     it 'should merge the PR for the current branch, with branch deletion' do
       allow(git_client).to receive(:current_branch).and_return(branch)
-      allow(git_client).to receive(:remote).with('origin').and_return("git@github.com:#{owner}/#{repository_name}")
+      allow(git_client).to receive(:remote).with(no_args).and_return("git@github.com:#{owner}/#{repository_name}")
 
       expected_pr_number = 2
       expected_output = <<~STR
@@ -86,7 +86,7 @@ describe Geet::Services::MergePr do
 
     it 'should merge the PR for the current branch' do
       allow(git_client).to receive(:current_branch).and_return(branch)
-      allow(git_client).to receive(:remote).with('origin').and_return("git@gitlab.com:#{owner}/#{repository_name}")
+      allow(git_client).to receive(:remote).with(no_args).and_return("git@gitlab.com:#{owner}/#{repository_name}")
 
       expected_pr_number = 4
       expected_output = <<~STR

data/spec/integration/open_pr_spec.rb

@@ -16,7 +16,7 @@ describe Geet::Services::OpenPr do
 
     it 'should open the PR for the current branch' do
       allow(git_client).to receive(:current_branch).and_return(branch)
-      allow(git_client).to receive(:remote).with('origin').and_return("git@github.com:#{owner}/#{repository_name}")
+      allow(git_client).to receive(:remote).with(no_args).and_return("git@github.com:#{owner}/#{repository_name}")
 
       expected_pr_number = 3
       expected_output = <<~STR

data/spec/integration/open_repo_spec.rb

@@ -0,0 +1,46 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+require_relative '../../lib/geet/git/repository'
+require_relative '../../lib/geet/services/open_repo'
+
+module Geet
+  describe Services::OpenRepo do
+    let(:git_client) { Utils::GitClient.new }
+    let(:repository) { Git::Repository.new(git_client: git_client) }
+
+    OWNER = 'donaldduck'
+    REPOSITORY_NAME = 'testrepo'
+
+    REMOTE_URLS = {
+      'git' => "git@github.com:#{OWNER}/#{REPOSITORY_NAME}",
+      'https' => "https://github.com/#{OWNER}/#{REPOSITORY_NAME}",
+    }
+
+    context 'should open the PR for the current branch' do
+      REMOTE_URLS.each do |protocol, remote_url|
+        it "with #{protocol} protocol" do
+          allow(git_client).to receive(:remote).with(no_args).and_return(remote_url)
+
+          expected_url = "https://github.com/#{OWNER}/#{REPOSITORY_NAME}"
+          expected_output = ""
+
+          actual_output = StringIO.new
+          service_instance = described_class.new(repository, out: actual_output, git_client: git_client)
+
+          expect(service_instance).to receive(:open_file_with_default_application).with(expected_url) do
+            # do nothing; just don't open the browser
+          end
+
+          execution_result = VCR.use_cassette('github_com/open_repo') do
+            service_instance.execute
+          end
+
+          expect(actual_output.string).to eql(expected_output)
+          expect(execution_result).to eql(expected_url)
+        end
+      end
+    end # context 'should open the PR for the current branch'
+  end # describe Services::OpenRepo
+end # module Geet

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: geet
 version: !ruby/object:Gem::Version
-  version: 0.3.17
+  version: 0.3.18
 platform: ruby
 authors:
 - Saverio Miroddi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-01-18 00:00:00.000000000 Z
+date: 2021-05-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: simple_scripting
@@ -88,6 +88,7 @@ files:
 - lib/geet/github/label.rb
 - lib/geet/github/milestone.rb
 - lib/geet/github/pr.rb
+- lib/geet/github/remote_repository.rb
 - lib/geet/github/user.rb
 - lib/geet/gitlab/api_interface.rb
 - lib/geet/gitlab/issue.rb
@@ -101,6 +102,7 @@ files:
 - lib/geet/helpers/summary_helper.rb
 - lib/geet/resources/templates/edit_summary.md
 - lib/geet/services/abstract_create_issue.rb
+- lib/geet/services/add_upstream_repo.rb
 - lib/geet/services/close_milestones.rb
 - lib/geet/services/comment_pr.rb
 - lib/geet/services/create_gist.rb
@@ -114,6 +116,7 @@ files:
 - lib/geet/services/list_prs.rb
 - lib/geet/services/merge_pr.rb
 - lib/geet/services/open_pr.rb
+- lib/geet/services/open_repo.rb
 - lib/geet/shared/branches.rb
 - lib/geet/shared/http_error.rb
 - lib/geet/shared/repo_permissions.rb
@@ -135,6 +138,7 @@ files:
 - spec/integration/list_prs_spec.rb
 - spec/integration/merge_pr_spec.rb
 - spec/integration/open_pr_spec.rb
+- spec/integration/open_repo_spec.rb
 - spec/spec_helper.rb
 - spec/vcr_cassettes/create_gist_private.yml
 - spec/vcr_cassettes/create_gist_public.yml
@@ -187,7 +191,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.2.3
 signing_key: 
 specification_version: 4
 summary: Commandline interface for performing SCM host operations, eg. create a PR