geet 0.3.16 → 0.3.17

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 15603a9a3a61fd8b6c3a377bd8fb1f482c121078b153e0cb8f3bdf12609d01f2
-  data.tar.gz: cde2b52ebcc17f2af2e64466c5565a65fad846e946747d91dfd734e5ce108e2c
+  metadata.gz: a475adafa9bb0791266b171ea0e8ba05caf076227f1d3b68efe75697479c2cca
+  data.tar.gz: e63c7d8d46c3f44b0962ee1c3445e3aaf076f03b41f218bfde957779decfd445
 SHA512:
-  metadata.gz: 5ea5d57a2f25a0f83910afe316194d335f11d04b4228324ab577845a74b62331705b3650b654cdb951e69c6fa76438441e1fa1caa3bf431e456acefc39f4457d
-  data.tar.gz: 06c954789d0e39cb723daa45de62c190817773cad1c29d1719524452c98731ded5f0cce8f72450f677c54688c38636b21538eca04226dafb45b00d16ab548806
+  metadata.gz: 1d19fde0bb7c9733ee7aaea4c249378077d242c56f92055f29c1f3eb27e200de06890f2d5e97c76a58ffc604c46674ceddd8fc349b17907cee89fdfabbd029c0
+  data.tar.gz: dbdad4b310621f063af44aabfe71fb485232a836085c5729a057d350911408db3e3dd18e7a40459ceb80d4cae000f279ceaf2798a1eaf9f6caeab7b704da3fa8

data/.gitignore

@@ -1,3 +1,4 @@
 /.ruby-version
 /.ruby-gemset
 /Gemfile.lock
+/test_repos

data/.travis.yml

@@ -6,6 +6,7 @@ rvm:
   - 2.5
   - 2.6
   - 2.7
+  - 3.0
   - ruby-head
 matrix:
   fast_finish: true

data/bin/geet

@@ -28,22 +28,22 @@ class GeetLauncher
       filename = options.delete(:filename)
       options[:publik] = options.delete(:public) if options.key?(:public)
 
-      Services::CreateGist.new.execute(filename, options)
+      Services::CreateGist.new.execute(filename, **options)
     when ISSUE_CREATE_COMMAND
       summary = options[:summary] || Commandline::Editor.new.edit_content(help: SUMMARY_TEMPLATE)
       title, description = split_summary(summary)
 
       options = default_to_manual_selection(options, :labels, :milestone, :assignees)
 
-      Services::CreateIssue.new(repository).execute(title, description, options)
+      Services::CreateIssue.new(repository).execute(title, description, **options)
     when LABEL_CREATE_COMMAND
       name = options.delete(:name)
 
-      Services::CreateLabel.new(repository).execute(name, options)
+      Services::CreateLabel.new(repository).execute(name, **options)
     when ISSUE_LIST_COMMAND
       options = default_to_manual_selection(options, :assignee)
 
-      Services::ListIssues.new(repository).execute(options)
+      Services::ListIssues.new(repository).execute(**options)
     when LABEL_LIST_COMMAND
       Services::ListLabels.new(repository).execute
     when MILESTONE_CLOSE_COMMAND
@@ -52,7 +52,7 @@ class GeetLauncher
       #
       options = {numbers: Shared::Selection::MANUAL_LIST_SELECTION_FLAG}
 
-      Services::CloseMilestones.new(repository).execute(options)
+      Services::CloseMilestones.new(repository).execute(**options)
     when MILESTONE_CREATE_COMMAND
       title = options.delete(:title)
 
@@ -62,20 +62,20 @@ class GeetLauncher
     when PR_COMMENT_COMMAND
       comment = options.delete(:comment)
 
-      Services::CommentPr.new(repository).execute(comment, options)
+      Services::CommentPr.new(repository).execute(comment, **options)
     when PR_CREATE_COMMAND
       summary = options[:summary] || edit_pr_summary(base: options[:base])
       title, description = split_summary(summary)
 
       options = default_to_manual_selection(options, :labels, :milestone, :reviewers)
 
-      Services::CreatePr.new(repository).execute(title, description, options)
+      Services::CreatePr.new(repository).execute(title, description, **options)
     when PR_LIST_COMMAND
       Services::ListPrs.new(repository).execute
     when PR_MERGE_COMMAND
-      Services::MergePr.new(repository).execute(options)
+      Services::MergePr.new(repository).execute(**options)
     when PR_OPEN_COMMAND
-      Services::OpenPr.new(repository).execute(options)
+      Services::OpenPr.new(repository).execute(**options)
     else
       raise "Internal error - Unrecognized command #{command.inspect}"
     end

data/geet.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |s|
   s.platform    = Gem::Platform::RUBY
   s.required_ruby_version = '>= 2.3.0'
   s.authors     = ['Saverio Miroddi']
-  s.date        = '2020-11-16'
+  s.date        = '2021-01-18'
   s.email       = ['saverio.pub2@gmail.com']
   s.homepage    = 'https://github.com/saveriomiroddi/geet'
   s.summary     = 'Commandline interface for performing SCM host operations, eg. create a PR on GitHub'

data/lib/geet/git/repository.rb

@@ -123,7 +123,11 @@ module Geet
             raise "The functionality invoked (#{class_name}.#{meth}) is not currently supported!"
           end
 
-          klass.send(meth, *args)
+          # Can't use ruby2_keywords, because the method definitions use named keyword arguments.
+          #
+          kwargs = args.last.is_a?(Hash) ? args.pop : {}
+
+          klass.send(meth, *args, **kwargs)
         else
           raise "The class referenced (#{full_class_name}) is not currently supported!"
         end

data/lib/geet/github/branch.rb

@@ -5,7 +5,7 @@ module Geet
     class Branch
       # See https://developer.github.com/v3/git/refs/#delete-a-reference
       #
-      def self.delete(name, api_interface)
+      def self.delete(name, api_interface, **)
         api_path = "git/refs/heads/#{name}"
 
         api_interface.send_request(api_path, http_method: :delete)

data/lib/geet/github/issue.rb

@@ -6,7 +6,7 @@ module Geet
     autoload :AbstractIssue, File.expand_path('abstract_issue', __dir__)
 
     class Issue < Geet::Github::AbstractIssue
-      def self.create(title, description, api_interface)
+      def self.create(title, description, api_interface, **)
         api_path = 'issues'
         request_data = { title: title, body: description, base: 'master' }
 

data/lib/geet/github/label.rb

@@ -11,7 +11,7 @@ module Geet
       end
 
       # Returns a flat list of names in string form.
-      def self.list(api_interface)
+      def self.list(api_interface, **)
         api_path = 'labels'
         response = api_interface.send_request(api_path, multipage: true)
 
@@ -24,7 +24,7 @@ module Geet
       end
 
       # See https://developer.github.com/v3/issues/labels/#create-a-label
-      def self.create(name, color, api_interface)
+      def self.create(name, color, api_interface, **)
         api_path = 'labels'
         request_data = { name: name, color: color }
 

data/lib/geet/github/milestone.rb

@@ -24,7 +24,7 @@ module Geet
       end
 
       # See https://developer.github.com/v3/issues/milestones/#create-a-milestone
-      def self.create(title, api_interface)
+      def self.create(title, api_interface, **)
         api_path = 'milestones'
         request_data = { title: title }
 
@@ -39,7 +39,7 @@ module Geet
 
       # See https://developer.github.com/v3/issues/milestones/#get-a-single-milestone
       #
-      def self.find(number, api_interface)
+      def self.find(number, api_interface, **)
         api_path = "milestones/#{number}"
 
         response = api_interface.send_request(api_path)
@@ -53,7 +53,7 @@ module Geet
 
       # See https://developer.github.com/v3/issues/milestones/#list-milestones-for-a-repository
       #
-      def self.list(api_interface)
+      def self.list(api_interface, **)
         api_path = 'milestones'
 
         response = api_interface.send_request(api_path, multipage: true)
@@ -71,7 +71,7 @@ module Geet
       #
       # This is a convenience method; the underlying operation is a generic update.
       #
-      def self.close(number, api_interface)
+      def self.close(number, api_interface, **)
         api_path = "milestones/#{number}"
         request_data = { state: STATE_CLOSED }
 

data/lib/geet/github/user.rb

@@ -45,7 +45,7 @@ module Geet
 
       # See https://developer.github.com/v3/users/#get-the-authenticated-user
       #
-      def self.authenticated(api_interface)
+      def self.authenticated(api_interface, **_)
         api_path = '/user'
 
         response = api_interface.send_request(api_path)
@@ -55,7 +55,7 @@ module Geet
 
       # Returns an array of User instances
       #
-      def self.list_collaborators(api_interface)
+      def self.list_collaborators(api_interface, **)
         api_path = 'collaborators'
         response = api_interface.send_request(api_path, multipage: true)
 

data/lib/geet/gitlab/label.rb

@@ -11,7 +11,7 @@ module Geet
       end
 
       # Returns a flat list of names in string form.
-      def self.list(api_interface)
+      def self.list(api_interface, **)
         api_path = "projects/#{api_interface.path_with_namespace(encoded: true)}/labels"
         response = api_interface.send_request(api_path, multipage: true)
 
@@ -24,7 +24,7 @@ module Geet
       end
 
       # See https://docs.gitlab.com/ee/api/labels.html#create-a-new-label
-      def self.create(name, color, api_interface)
+      def self.create(name, color, api_interface, **)
         api_path = "projects/#{api_interface.path_with_namespace(encoded: true)}/labels"
         request_data = { name: name, color: "##{color}" }
 

data/lib/geet/gitlab/milestone.rb

@@ -17,7 +17,7 @@ module Geet
 
       # See https://docs.gitlab.com/ee/api/milestones.html#list-project-milestones
       #
-      def self.list(api_interface)
+      def self.list(api_interface, **)
         api_path = "projects/#{api_interface.path_with_namespace(encoded: true)}/milestones"
 
         response = api_interface.send_request(api_path, multipage: true)

data/lib/geet/gitlab/user.rb

@@ -13,7 +13,7 @@ module Geet
 
       # Returns an array of User instances
       #
-      def self.list_collaborators(api_interface)
+      def self.list_collaborators(api_interface, **)
         api_path = "projects/#{api_interface.path_with_namespace(encoded: true)}/members"
 
         response = api_interface.send_request(api_path, multipage: true)

data/lib/geet/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Geet
-  VERSION = '0.3.16'
+  VERSION = '0.3.17'
 end

data/spec/integration/create_issue_spec.rb

@@ -59,7 +59,7 @@ describe Geet::Services::CreateIssue do
 
         actual_created_issue = VCR.use_cassette('create_issue_upstream') do
           create_options = { no_open_issue: true, out: actual_output }
-          described_class.new(upstream_repository, out: actual_output).execute('Title', 'Description', create_options)
+          described_class.new(upstream_repository, out: actual_output).execute('Title', 'Description', **create_options)
         end
 
         expect(actual_output.string).to eql(expected_output)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: geet
 version: !ruby/object:Gem::Version
-  version: 0.3.16
+  version: 0.3.17
 platform: ruby
 authors:
 - Saverio Miroddi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-11-16 00:00:00.000000000 Z
+date: 2021-01-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: simple_scripting
@@ -187,7 +187,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.8
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Commandline interface for performing SCM host operations, eg. create a PR