geet 0.27.2 → 0.27.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3c37242c53ca13fb80b44930526950f9bc17c94ee7a3075d535451c76a599f2e
-  data.tar.gz: bf8b1009433f594a4da608d6e7a03b85e1954cb6afe82bc733fbad3c6e6ca300
+  metadata.gz: f2ac451d0da31fbee370de9c62f1b500895c606667a1dad15fed2fa29230a830
+  data.tar.gz: 032d99971b07e75417005cb096c2b0fb4e1b752866453fe708c422ada5778794
 SHA512:
-  metadata.gz: 43681773afc1da211b90587d02f88ca6b8a8e4045398ccdb96b68e1e18f69eb9a2a3f484c075dcf1d5fb13c4f9a19a0e221df503b0546d34617ae2a9b273513d
-  data.tar.gz: 8f139010b72eb1df6a32943909443ed5c54d1ff968236fbb040a85f276706776b6e8d23fadb906028aa910070364422b56ff93901e0908d1e0d271eaae3f07cc
+  metadata.gz: 9ccffdb2b7688650b4e4d16f8bf3cdf3c1503941fb3739356a249e6bf570b6cd737ba6393a30755e255df36c4454e6806beb64f67dd70312e6e6cc7edb115dbc
+  data.tar.gz: 9008e5a5f4a00cd750d97fb6bb76ca1f93d7372b0bfb1079294488a311ecfbb0cebda44ae0e690b75c13147c5d114e45f331fa3ff61b9405d7c8b5d0b5363abd

data/.rubocop.yml

@@ -55,6 +55,13 @@ Layout/SpaceInsideStringInterpolation:
   Enabled: true
   EnforcedStyle: no_space
 
+# Enforce double quotes for strings unless interpolation or escaping makes single quotes more convenient
+# Examples: 'hello' -> "hello", 'foo #{bar}' -> "foo #{bar}", "foo \"bar\"" -> 'foo "bar"'
+Style/StringLiterals:
+  Enabled: true
+  EnforcedStyle: double_quotes
+  ConsistentQuotesInMultiline: true
+
 # Ensure exactly one newline at the end of each file
 Layout/TrailingEmptyLines:
   Enabled: true

data/Gemfile

@@ -1,19 +1,19 @@
 # frozen_string_literal: true
 
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 gemspec
 
 group :development do
-  gem 'byebug'
-  gem 'rubocop', '~> 1.82.1', require: false
-  gem 'spoom', require: false
-  gem 'tapioca', '>= 0.17.10', require: false
+  gem "byebug"
+  gem "rubocop", "~> 1.82.1", require: false
+  gem "spoom", require: false
+  gem "tapioca", ">= 0.17.10", require: false
 end
 
 group :test do
-  gem 'rspec', '~> 3.13.0'
-  gem 'rspec-sorbet'
-  gem 'vcr', '~> 6.4.0'
-  gem 'webmock', '~> 3.1.1'
+  gem "rspec", "~> 3.13.0"
+  gem "rspec-sorbet"
+  gem "vcr", "~> 6.4.0"
+  gem "webmock", "~> 3.1.1"
 end

data/Rakefile

@@ -1,7 +1,7 @@
-require 'rspec/core/rake_task'
+require "rspec/core/rake_task"
 
 RSpec::Core::RakeTask.new(:spec) do |task|
-  task.rspec_opts = ['--order rand']
+  task.rspec_opts = ["--order rand"]
 end
 
 task default: :spec

data/bin/geet

@@ -1,17 +1,17 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
 
-require 'simple_scripting/configuration'
-require 'tmpdir'
-require_relative '../lib/geet'
+require "simple_scripting/configuration"
+require "tmpdir"
+require_relative "../lib/geet"
 
 class GeetLauncher
   include Geet
   include Geet::Commandline::Commands
   include Geet::Helpers::SummaryHelper
 
-  SUMMARY_TEMPLATE = IO.read(File.expand_path('../lib/geet/resources/templates/edit_summary.md', __dir__))
-  SUMMARY_BACKUP = File.join(Dir.tmpdir, 'last_geet_edited_summary.md')
+  SUMMARY_TEMPLATE = IO.read(File.expand_path("../lib/geet/resources/templates/edit_summary.md", __dir__))
+  SUMMARY_BACKUP = File.join(Dir.tmpdir, "last_geet_edited_summary.md")
 
   def launch
     command, options = Commandline::Configuration.new.decode_argv || exit
@@ -98,7 +98,7 @@ class GeetLauncher
 
         Commandline::Editor.new.edit_content(content: prepopulated_summary, help: SUMMARY_TEMPLATE + cancel_pr_help)
       elsif pr_commits.size == 1
-        prepopulated_summary = git.show_description('HEAD')
+        prepopulated_summary = git.show_description("HEAD")
 
         Commandline::Editor.new.edit_content(content: prepopulated_summary, help: SUMMARY_TEMPLATE + cancel_pr_help)
       else
@@ -121,7 +121,7 @@ class GeetLauncher
   def protected_repositories
     configuration = SimpleScripting::Configuration.load
 
-    configuration.protected_repositories.to_s.split(':')
+    configuration.protected_repositories.to_s.split(":")
   end
 end
 

data/geet.gemspec

@@ -1,30 +1,30 @@
 # frozen_string_literal: true
 
-require_relative 'lib/geet/version'
+require_relative "lib/geet/version"
 
 Gem::Specification.new do |s|
-  s.name        = 'geet'
+  s.name        = "geet"
   s.version     = Geet::VERSION
   s.platform    = Gem::Platform::RUBY
-  s.required_ruby_version = '>= 3.2.0'
-  s.authors     = ['Saverio Miroddi']
-  s.date        = '2026-01-18'
-  s.email       = ['saverio.pub2@gmail.com']
-  s.homepage    = 'https://github.com/saveriomiroddi/geet'
-  s.summary     = 'Commandline interface for performing SCM host operations, eg. create a PR on GitHub'
-  s.description = 'Commandline interface for performing SCM host operations, eg. create a PR on GitHub, with support for multiple hosts.'
-  s.license     = 'GPL-3.0-only'
+  s.required_ruby_version = ">= 3.2.0"
+  s.authors     = ["Saverio Miroddi"]
+  s.date        = "2026-01-26"
+  s.email       = ["saverio.pub2@gmail.com"]
+  s.homepage    = "https://github.com/saveriomiroddi/geet"
+  s.summary     = "Commandline interface for performing SCM host operations, eg. create a PR on GitHub"
+  s.description = "Commandline interface for performing SCM host operations, eg. create a PR on GitHub, with support for multiple hosts."
+  s.license     = "GPL-3.0-only"
 
-  s.add_runtime_dependency 'base64', '~> 0.3.0'
-  s.add_runtime_dependency 'ostruct', '~> 0.6.3'
-  s.add_runtime_dependency 'simple_scripting', '~> 0.14.0'
-  s.add_runtime_dependency 'sorbet-runtime', '= 0.6.12883'
-  s.add_runtime_dependency 'tty-prompt', '~> 0.23.1'
-  s.add_runtime_dependency 'zeitwerk', '~> 2.7'
+  s.add_runtime_dependency "base64", "~> 0.3.0"
+  s.add_runtime_dependency "ostruct", "~> 0.6.3"
+  s.add_runtime_dependency "simple_scripting", "~> 0.14.0"
+  s.add_runtime_dependency "sorbet-runtime", "= 0.6.12883"
+  s.add_runtime_dependency "tty-prompt", "~> 0.23.1"
+  s.add_runtime_dependency "zeitwerk", "~> 2.7"
 
-  s.add_development_dependency 'rake', '~> 12.3'
+  s.add_development_dependency "rake", "~> 12.3"
 
   s.files         = `git ls-files`.split("\n")
-  s.executables   << 'geet'
-  s.require_paths = ['lib']
+  s.executables   << "geet"
+  s.require_paths = ["lib"]
 end

data/lib/geet/commandline/commands.rb

@@ -1,23 +1,24 @@
 # frozen_string_literal: true
+# typed: strict
 
 module Geet
   module Commandline
     module Commands
-      GIST_CREATE_COMMAND = 'gist.create'
-      ISSUE_CREATE_COMMAND = 'issue.create'
-      LABEL_CREATE_COMMAND = 'label.create'
-      ISSUE_LIST_COMMAND = 'issue.list'
-      LABEL_LIST_COMMAND = 'label.list'
-      MILESTONE_CLOSE_COMMAND = 'milestone.close'
-      MILESTONE_CREATE_COMMAND = 'milestone.create'
-      MILESTONE_LIST_COMMAND = 'milestone.list'
-      PR_COMMENT_COMMAND = 'pr.comment'
-      PR_CREATE_COMMAND = 'pr.create'
-      PR_LIST_COMMAND = 'pr.list'
-      PR_MERGE_COMMAND = 'pr.merge'
-      PR_OPEN_COMMAND = 'pr.open'
-      REPO_ADD_UPSTREAM_COMMAND = 'repo.add_upstream'
-      REPO_OPEN_COMMAND = 'repo.open'
+      GIST_CREATE_COMMAND = T.let("gist.create", String)
+      ISSUE_CREATE_COMMAND = T.let("issue.create", String)
+      LABEL_CREATE_COMMAND = T.let("label.create", String)
+      ISSUE_LIST_COMMAND = T.let("issue.list", String)
+      LABEL_LIST_COMMAND = T.let("label.list", String)
+      MILESTONE_CLOSE_COMMAND = T.let("milestone.close", String)
+      MILESTONE_CREATE_COMMAND = T.let("milestone.create", String)
+      MILESTONE_LIST_COMMAND = T.let("milestone.list", String)
+      PR_COMMENT_COMMAND = T.let("pr.comment", String)
+      PR_CREATE_COMMAND = T.let("pr.create", String)
+      PR_LIST_COMMAND = T.let("pr.list", String)
+      PR_MERGE_COMMAND = T.let("pr.merge", String)
+      PR_OPEN_COMMAND = T.let("pr.open", String)
+      REPO_ADD_UPSTREAM_COMMAND = T.let("repo.add_upstream", String)
+      REPO_OPEN_COMMAND = T.let("repo.open", String)
     end
   end
 end

data/lib/geet/commandline/configuration.rb

@@ -1,80 +1,83 @@
 # frozen_string_literal: true
+# typed: strict
 
-require 'simple_scripting/argv'
+require "simple_scripting/argv"
 
 module Geet
   module Commandline
     class Configuration
+      extend T::Sig
+
       include Commands
 
       # Command options
 
       GIST_CREATE_OPTIONS = [
-        ['-p', '--public'],
-        ['-s', '--stdin',     "Read content from stdin"],
-        ['-o', '--open-browser', "Open the gist link in the browser after creation"],
-        'filename',
-        '[description]',
+        ["-p", "--public"],
+        ["-s", "--stdin",     "Read content from stdin"],
+        ["-o", "--open-browser", "Open the gist link in the browser after creation"],
+        "filename",
+        "[description]",
       ].freeze
 
       # SimpleScripting 0.9.3 doesn't allow frozen arrays when hash options are present.
       #
       # rubocop:disable Style/MutableConstant
-      ISSUE_CREATE_OPTIONS = [
-        ['-o', '--open-browser',                            "Don't open the issue link in the browser after creation"],
-        ['-l', '--labels "bug,help wanted"',                'Labels'],
-        ['-m', '--milestone 1.5.0',                         'Milestone title pattern'],
-        ['-a', '--assignees john,tom,adrian,kevin',         'Assignee logins'],
-        ['-s', '--summary title_and_description',           'Set the summary (title and optionally description'],
-        ['-u', '--upstream',                                'Create on the upstream repository'],
-        long_help: 'The default editor will be opened for editing title and description.',
-      ]
+      ISSUE_CREATE_OPTIONS = T.let([
+        ["-o", "--open-browser",                            "Don't open the issue link in the browser after creation"],
+        ["-l", '--labels "bug,help wanted"',                "Labels"],
+        ["-m", "--milestone 1.5.0",                         "Milestone title pattern"],
+        ["-a", "--assignees john,tom,adrian,kevin",         "Assignee logins"],
+        ["-s", "--summary title_and_description",           "Set the summary (title and optionally description"],
+        ["-u", "--upstream",                                "Create on the upstream repository"],
+        long_help: "The default editor will be opened for editing title and description.",
+      ], T::Array[T.any(T::Hash[T.untyped, T.untyped], T::Array[String])])
 
       LABEL_CREATE_OPTIONS = [
-        ['-c', '--color color',                             '6-digits hex color; if not specified, a random one is created'],
-        ['-u', '--upstream',                                'Create on the upstream repository'],
-        'name',
+        ["-c", "--color color",                             "6-digits hex color; if not specified, a random one is created"],
+        ["-u", "--upstream",                                "Create on the upstream repository"],
+        "name",
       ].freeze
 
       ISSUE_LIST_OPTIONS = [
-        ['-a', '--assignee john',                           'Assignee login'],
-        ['-u', '--upstream',                                'List on the upstream repository'],
+        ["-a", "--assignee john",                           "Assignee login"],
+        ["-u", "--upstream",                                "List on the upstream repository"],
       ].freeze
 
       LABEL_LIST_OPTIONS = [
-        ['-u', '--upstream',                                'List on the upstream repository'],
+        ["-u", "--upstream",                                "List on the upstream repository"],
       ].freeze
 
-      MILESTONE_CLOSE_OPTIONS = [
-        long_help: 'Close milestones.',
-      ]
+      MILESTONE_CLOSE_OPTIONS = T.let([
+        long_help: "Close milestones.",
+      ], T::Array[T.any(T::Hash[T.untyped, T.untyped], T::Array[String])])
 
-      MILESTONE_CREATE_OPTIONS = [
-        'title',
-        long_help: 'Create a milestone.',
-      ]
+      MILESTONE_CREATE_OPTIONS = T.let([
+        "title",
+        long_help: "Create a milestone.",
+      ], T::Array[T.any(T::Hash[T.untyped, T.untyped], String)])
 
       MILESTONE_LIST_OPTIONS = [
-        ['-u', '--upstream',                                'List on the upstream repository'],
+        ["-u", "--upstream",                                "List on the upstream repository"],
       ].freeze
 
-      PR_COMMENT_OPTIONS = [
-        ['-o', '--open-browser',                            "Don't open the PR link in the browser after creation"],
-        ['-u', '--upstream',                                'Comment on the upstream repository'],
-        'comment',
-        long_help: 'Add a comment to the PR for the current branch.',
-      ]
-
-      PR_CREATE_OPTIONS = [
-        ['-a', '--automerge',                               "Enable automerge (with default strategy)"],
-        ['-o', '--open-browser',                            "Don't open the PR link in the browser after creation"],
-        ['-b', '--base develop',                            "Specify the base branch; defaults to the main branch"],
-        ['-d', '--draft',                                   "Create as draft"],
-        ['-l', '--labels "legacy,code review"',             'Labels'],
-        ['-m', '--milestone 1.5.0',                         'Milestone title pattern'],
-        ['-r', '--reviewers john,tom,adrian,kevin',         'Reviewer logins'],
-        ['-s', '--summary title_and_description',           'Set the summary (title and optionally description'],
-        ['-u', '--upstream',                                'Create on the upstream repository'],
+      PR_COMMENT_OPTIONS = T.let([
+        ["-o", "--open-browser",                            "Don't open the PR link in the browser after creation"],
+        ["-u", "--upstream",                                "Comment on the upstream repository"],
+        "comment",
+        long_help: "Add a comment to the PR for the current branch.",
+      ], T::Array[T.any(T::Hash[T.untyped, T.untyped], T::Array[String], String)])
+
+      PR_CREATE_OPTIONS = T.let([
+        ["-a", "--automerge",                               "Enable automerge (with default strategy)"],
+        ["-o", "--open-browser",                            "Don't open the PR link in the browser after creation"],
+        ["-b", "--base develop",                            "Specify the base branch; defaults to the main branch"],
+        ["-d", "--draft",                                   "Create as draft"],
+        ["-l", '--labels "legacy,code review"',             "Labels"],
+        ["-m", "--milestone 1.5.0",                         "Milestone title pattern"],
+        ["-r", "--reviewers john,tom,adrian,kevin",         "Reviewer logins"],
+        ["-s", "--summary title_and_description",           "Set the summary (title and optionally description"],
+        ["-u", "--upstream",                                "Create on the upstream repository"],
         long_help: <<~STR,
           The default editor will be opened for editing title and description; if the PR adds one commit only, the content will be prepopulated with the commit description.
 
@@ -82,72 +85,73 @@ module Geet
 
           Before creating the PR, the local branch is pushed; if the remote branch is not present, it is created.
         STR
-      ]
+      ], T::Array[T.any(T::Hash[T.untyped, T.untyped], T::Array[String])])
 
       PR_LIST_OPTIONS = [
-        ['-u', '--upstream',                                'List on the upstream repository'],
+        ["-u", "--upstream",                                "List on the upstream repository"],
       ].freeze
 
       # SimpleScripting 0.9.3 doesn't allow frozen arrays when hash options are present.
       #
       # rubocop:disable Style/MutableConstant
-      PR_MERGE_OPTIONS = [
-        ['-d', '--delete-branch',                           'Delete the branch after merging'],
-        ['-s', '--squash',                                  'Squash merge'],
-        ['-u', '--upstream',                                'List on the upstream repository'],
-        long_help: 'Merge the PR for the current branch',
-      ]
-
-      PR_OPEN_OPTIONS = [
-        ['-u', '--upstream',                                'Open on the upstream repository'],
-        long_help: 'Open in the browser the PR for the current branch',
-      ]
-
-      REPO_ADD_UPSTREAM_OPTIONS = [
-        long_help: 'Add the upstream repository to the current repository (configuration).',
-      ]
-
-      REPO_OPEN_OPTIONS = [
-        ['-u', '--upstream',                                'Open the upstream repository'],
-        long_help: 'Open the current repository in the browser',
-      ]
+      PR_MERGE_OPTIONS = T.let([
+        ["-d", "--delete-branch",                           "Delete the branch after merging"],
+        ["-s", "--squash",                                  "Squash merge"],
+        ["-u", "--upstream",                                "List on the upstream repository"],
+        long_help: "Merge the PR for the current branch",
+      ], T::Array[T.any(T::Hash[T.untyped, T.untyped], T::Array[String])])
+
+      PR_OPEN_OPTIONS = T.let([
+        ["-u", "--upstream",                                "Open on the upstream repository"],
+        long_help: "Open in the browser the PR for the current branch",
+      ], T::Array[T.any(T::Hash[T.untyped, T.untyped], T::Array[String])])
+
+      REPO_ADD_UPSTREAM_OPTIONS = T.let([
+        long_help: "Add the upstream repository to the current repository (configuration).",
+      ], T::Array[T.any(T::Hash[T.untyped, T.untyped], T::Array[String])])
+
+      REPO_OPEN_OPTIONS = T.let([
+        ["-u", "--upstream",                                "Open the upstream repository"],
+        long_help: "Open the current repository in the browser",
+      ], T::Array[T.any(T::Hash[T.untyped, T.untyped], T::Array[String])])
 
       # Commands decoding table
 
-      COMMANDS_DECODING_TABLE = {
-        'gist' => {
-          'create' => GIST_CREATE_OPTIONS,
+      COMMANDS_DECODING_TABLE = T.let({
+        "gist" => {
+          "create" => GIST_CREATE_OPTIONS,
         },
-        'issue' => {
-          'create' => ISSUE_CREATE_OPTIONS,
-          'list' => ISSUE_LIST_OPTIONS,
+        "issue" => {
+          "create" => ISSUE_CREATE_OPTIONS,
+          "list" => ISSUE_LIST_OPTIONS,
         },
-        'label' => {
-          'create' => LABEL_CREATE_OPTIONS,
-          'list' => LABEL_LIST_OPTIONS,
+        "label" => {
+          "create" => LABEL_CREATE_OPTIONS,
+          "list" => LABEL_LIST_OPTIONS,
         },
-        'milestone' => {
-          'close' => MILESTONE_CLOSE_OPTIONS,
-          'create' => MILESTONE_CREATE_OPTIONS,
-          'list' => MILESTONE_LIST_OPTIONS,
+        "milestone" => {
+          "close" => MILESTONE_CLOSE_OPTIONS,
+          "create" => MILESTONE_CREATE_OPTIONS,
+          "list" => MILESTONE_LIST_OPTIONS,
         },
-        'pr' => {
-          'comment' => PR_COMMENT_OPTIONS,
-          'create' => PR_CREATE_OPTIONS,
-          'list' => PR_LIST_OPTIONS,
-          'merge' => PR_MERGE_OPTIONS,
-          'open' => PR_OPEN_OPTIONS,
+        "pr" => {
+          "comment" => PR_COMMENT_OPTIONS,
+          "create" => PR_CREATE_OPTIONS,
+          "list" => PR_LIST_OPTIONS,
+          "merge" => PR_MERGE_OPTIONS,
+          "open" => PR_OPEN_OPTIONS,
         },
-        'repo' => {
-          'add_upstream' => REPO_ADD_UPSTREAM_OPTIONS,
-          'open' => REPO_OPEN_OPTIONS,
+        "repo" => {
+          "add_upstream" => REPO_ADD_UPSTREAM_OPTIONS,
+          "open" => REPO_OPEN_OPTIONS,
         },
-      }
+      }, T::Hash[T.untyped, T.untyped])
 
       # Public interface
 
+      sig { returns(T.nilable(T::Array[T.untyped])) }
       def decode_argv
-        SimpleScripting::Argv.decode(COMMANDS_DECODING_TABLE)
+        T.unsafe(SimpleScripting::Argv).decode(COMMANDS_DECODING_TABLE)
       end
     end
   end

data/lib/geet/commandline/editor.rb

@@ -1,28 +1,32 @@
 # frozen_string_literal: true
+# typed: strict
 
-require 'tempfile'
+require "tempfile"
 
 module Geet
   module Commandline
     class Editor
+      extend T::Sig
+
       include Geet::Helpers::OsHelper
 
       # Git style!
-      HELP_SEPARATOR = '------------------------ >8 ------------------------'
+      HELP_SEPARATOR = "------------------------ >8 ------------------------"
 
       # Edits a content in the default editor, optionally providing help.
       #
       # When the help is provided, it's appended to the bottom, separated by HELP_SEPARATOR.
       # The help is stripped after the content if edited.
       #
-      def edit_content(content: '', help: nil)
+      sig { params(content: String, help: T.nilable(String)).returns(String) }
+      def edit_content(content: "", help: nil)
         content += "\n\n" + HELP_SEPARATOR + "\n" + help if help
 
         edited_content = edit_content_in_default_editor(content)
 
         edited_content = edited_content.split(HELP_SEPARATOR, 2).first if help
 
-        edited_content.strip
+        T.must(edited_content).strip
       end
 
       private
@@ -33,11 +37,12 @@ module Geet
       # Interestingly, the API `TTY::Editor.open(content: 'text')` is not very useful,
       # as it doesn't return the filename (!).
       #
+      sig { params(content: String).returns(String) }
       def edit_content_in_default_editor(content)
-        tempfile = Tempfile.open(['geet_editor', '.md']) { |file| file << content }.path
+        tempfile = T.must(Tempfile.open(["geet_editor", ".md"]) { |file| file << content }.path)
         command = "#{system_editor} #{tempfile.shellescape}"
 
-        execute_command(command, description: 'editing', interactive: true)
+        execute_command(command, description: "editing", interactive: true)
 
         content = IO.read(tempfile)
 
@@ -48,8 +53,9 @@ module Geet
 
       # HELPERS ##########################################################################
 
+      sig { returns(String) }
       def system_editor
-        ENV['EDITOR'] || ENV['VISUAL'] || 'vi'
+        ENV["EDITOR"] || ENV["VISUAL"] || "vi"
       end
     end
   end