geet 0.15.0 → 0.16.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f79d89578fca34fafcc206ab8e821849d67f0caaf2462670617d6bdba5e6dbeb
-  data.tar.gz: 9b61f3d999540e14a04888a3a612a3cd4e911adbe52962812b0ca3741316858c
+  metadata.gz: 7298e97b21330d9c837a4eb8435be39df5351b38e60461561176c491b8fcaa08
+  data.tar.gz: 318baabbf8b5d52d0cc6affc9fa39a482a3ecc7a42714bff12ad81beb9959684
 SHA512:
-  metadata.gz: '067489ba58c5c32fa4958ec6f43603b2f5746a7526a2918a0869641d654443e42223ec28876a1d13a3b900513563517200fd2933d5b0f01fdb2d8758cd526fb4'
-  data.tar.gz: 78d9fcc96abc7670b6802a4b3eeccbfd90258e0206da0914d9a845fd2b739f43d1e968791d89cce4a8ea3a2409035cd8d8909747bb9007fa2ff51e9e474cad5d
+  metadata.gz: fef735f691aa7c0c1e78d8598a429b6eb92555761587d2c137b915744516b2b7f3a5bdbde4e14a5094ca79ae1dcf717c310edde9894c7c040cbe833dafceb1be
+  data.tar.gz: 8fb0518d4c8a65449d14d19d4f9fa2b847cddd95b6f97dbb458c334783acc88f0e2e5ed3c0dad2485e2ac36a92b797ebe6eeeec8aafb2d90a05647bbff5aa6bf

data/geet.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |s|
   s.platform    = Gem::Platform::RUBY
   s.required_ruby_version = '>= 2.6.0'
   s.authors     = ['Saverio Miroddi']
-  s.date        = '2022-12-18'
+  s.date        = '2023-01-30'
   s.email       = ['saverio.pub2@gmail.com']
   s.homepage    = 'https://github.com/saveriomiroddi/geet'
   s.summary     = 'Commandline interface for performing SCM host operations, eg. create a PR on GitHub'

data/lib/geet/commandline/configuration.rb

@@ -13,7 +13,7 @@ module Geet
       GIST_CREATE_OPTIONS = [
         ['-p', '--public'],
         ['-s', '--stdin',     "Read content from stdin"],
-        ['-B', '--no-browse', "Don't open the gist link in the browser after creation"],
+        ['-o', '--open-browser', "Open the gist link in the browser after creation"],
         'filename',
         '[description]'
       ].freeze
@@ -22,7 +22,7 @@ module Geet
       #
       # rubocop:disable Style/MutableConstant
       ISSUE_CREATE_OPTIONS = [
-        ['-n', '--no-open-issue',                           "Don't open the issue link in the browser after creation"],
+        ['-o', '--open-browser',                            "Don't open the issue link in the browser after creation"],
         ['-l', '--labels "bug,help wanted"',                'Labels'],
         ['-m', '--milestone 1.5.0',                         'Milestone title pattern'],
         ['-a', '--assignees john,tom,adrian,kevin',         'Assignee logins'],
@@ -60,14 +60,14 @@ module Geet
       ].freeze
 
       PR_COMMENT_OPTIONS = [
-        ['-n', '--no-open-pr',                              "Don't open the PR link in the browser after creation"],
+        ['-o', '--open-browser',                            "Don't open the PR link in the browser after creation"],
         ['-u', '--upstream',                                'Comment on the upstream repository'],
         'comment',
         long_help: 'Add a comment to the PR for the current branch.'
       ]
 
       PR_CREATE_OPTIONS = [
-        ['-n', '--no-open-pr',                              "Don't open the PR link in the browser after creation"],
+        ['-o', '--open-browser',                            "Don't open the PR link in the browser after creation"],
         ['-b', '--base develop',                            "Specify the base branch; defaults to the main branch"],
         ['-d', '--draft',                                   "Create as draft"],
         ['-l', '--labels "legacy,code review"',             'Labels'],

data/lib/geet/services/add_upstream_repo.rb

@@ -18,9 +18,13 @@ module Geet
 
         parent_path = @repository.remote.parent_path
 
-        parent_url = compose_parent_url(parent_path)
+        if parent_path
+          parent_url = compose_parent_url(parent_path)
 
-        @git_client.add_remote(Utils::GitClient::UPSTREAM_NAME, parent_url)
+          @git_client.add_remote(Utils::GitClient::UPSTREAM_NAME, parent_url)
+        else
+          raise "The repository has no upstream!"
+        end
       end
 
       private

data/lib/geet/services/comment_pr.rb

@@ -19,10 +19,10 @@ module Geet
         @git_client = git_client
       end
 
-      def execute(comment, no_open_pr: nil, **)
+      def execute(comment, open_browser: false, **)
         pr = checked_find_branch_pr
         pr.comment(comment)
-        open_file_with_default_application(pr.link) unless no_open_pr
+        open_file_with_default_application(pr.link) if open_browser
         pr
       end
     end

data/lib/geet/services/create_gist.rb

@@ -22,9 +22,9 @@ module Geet
       # options:
       #   :description
       #   :publik:      defaults to false
-      #   :no_browse    defaults to false
+      #   :open_browser defaults to true
       #
-      def execute(full_filename, stdin: false, description: nil, publik: false, no_browse: false)
+      def execute(full_filename, stdin: false, description: nil, publik: false, open_browser: false)
         content = stdin ? $stdin.read : IO.read(full_filename)
 
         gist_access = publik ? 'public' : 'private'
@@ -33,10 +33,10 @@ module Geet
         filename = File.basename(full_filename)
         gist = Geet::Github::Gist.create(filename, content, @api_interface, description: description, publik: publik)
 
-        if no_browse
-          @out.puts "Gist address: #{gist.link}"
-        else
+        if open_browser
           open_file_with_default_application(gist.link)
+        else
+          @out.puts "Gist address: #{gist.link}"
         end
       end
 

data/lib/geet/services/create_issue.rb

@@ -14,11 +14,11 @@ module Geet
       #   :labels
       #   :milestone:     number or description pattern.
       #   :assignees
-      #   :no_open_issue
+      #   :open_browser
       #
       def execute(
           title, description,
-          labels: nil, milestone: nil, assignees: nil, no_open_issue: nil,
+          labels: nil, milestone: nil, assignees: nil, open_browser: false,
           **
       )
         # Inefficient (in worst case, triples the pre issue creation waiting time: #is_collaborator?,
@@ -39,10 +39,10 @@ module Geet
           edit_issue(issue, selected_labels, selected_milestone, selected_assignees)
         end
 
-        if no_open_issue
-          @out.puts "Issue address: #{issue.link}"
-        else
+        if open_browser
           open_file_with_default_application(issue.link)
+        else
+          @out.puts "Issue address: #{issue.link}"
         end
 
         issue

data/lib/geet/services/create_pr.rb

@@ -24,11 +24,11 @@ module Geet
       # options:
       #   :labels
       #   :reviewers
-      #   :no_open_pr
+      #   :open_browser
       #
       def execute(
         title, description, labels: nil, milestone: nil, reviewers: nil,
-        base: nil, draft: false, no_open_pr: nil, **
+        base: nil, draft: false, open_browser: false, **
       )
         ensure_clean_tree
 
@@ -54,10 +54,10 @@ module Geet
           edit_pr(pr, selected_labels, selected_milestone, selected_reviewers)
         end
 
-        if no_open_pr
-          @out.puts "PR address: #{pr.link}"
-        else
+        if open_browser
           open_file_with_default_application(pr.link)
+        else
+          @out.puts "PR address: #{pr.link}"
         end
 
         pr

data/lib/geet/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Geet
-  VERSION = '0.15.0'
+  VERSION = '0.16.0'
 end

data/spec/integration/comment_pr_spec.rb

@@ -27,10 +27,6 @@ describe Geet::Services::CommentPr do
       actual_output = StringIO.new
       service_instance = described_class.new(repository, out: actual_output, git_client: git_client)
 
-      expect(service_instance).to receive(:open_file_with_default_application).with("https://github.com/#{owner}/#{repository_name}/pull/#{expected_pr_number}") do
-        # do nothing; just don't open the browser
-      end
-
       service_result = VCR.use_cassette('github_com/comment_pr') do
         service_instance.execute(comment)
       end

data/spec/integration/create_gist_spec.rb

@@ -20,7 +20,7 @@ describe Geet::Services::CreateGist do
 
     VCR.use_cassette('create_gist_public') do
       described_class.new(out: actual_output).execute(
-        temp_file.path, description: 'testdescription', publik: true, no_browse: true
+        temp_file.path, description: 'testdescription', publik: true
       )
     end
 
@@ -37,7 +37,7 @@ describe Geet::Services::CreateGist do
 
     VCR.use_cassette('create_gist_private') do
       described_class.new(out: actual_output).execute(
-        temp_file.path, description: 'testdescription', no_browse: true
+        temp_file.path, description: 'testdescription'
       )
     end
 

data/spec/integration/create_issue_spec.rb

@@ -31,7 +31,6 @@ describe Geet::Services::CreateIssue do
         described_class.new(repository, out: actual_output).execute(
           'Title', 'Description',
           labels: 'bug,invalid', milestone: '0.0.1', assignees: 'donaldduck,donald-fr',
-          no_open_issue: true
         )
       end
 
@@ -58,7 +57,7 @@ describe Geet::Services::CreateIssue do
         actual_output = StringIO.new
 
         actual_created_issue = VCR.use_cassette('create_issue_upstream') do
-          create_options = { no_open_issue: true, out: actual_output }
+          create_options = { out: actual_output }
           described_class.new(upstream_repository, out: actual_output).execute('Title', 'Description', **create_options)
         end
 

data/spec/integration/create_pr_spec.rb

@@ -37,7 +37,7 @@ describe Geet::Services::CreatePr do
 #           service_instance.execute(
 #             'Title', 'Description',
 #             labels: 'bug,invalid', milestone: '0.0.1', reviewers: 'donald-fr',
-#             no_open_pr: true, output: actual_output
+#             output: actual_output
 #           )
 #         end
 #
@@ -67,7 +67,7 @@ describe Geet::Services::CreatePr do
 #
 #         actual_created_pr = VCR.use_cassette('github_com/create_pr_upstream') do
 #           service_instance = described_class.new(upstream_repository, out: actual_output, git_client: git_client)
-#           service_instance.execute('Title', 'Description', no_open_pr: true, output: actual_output)
+#           service_instance.execute('Title', 'Description', output: actual_output)
 #         end
 #
 #         expect(actual_output.string).to eql(expected_output)
@@ -101,7 +101,7 @@ describe Geet::Services::CreatePr do
 #               service_instance.execute(
 #                 'Title', 'Description',
 #                 labels: '<ignored>',
-#                 no_open_pr: true, output: actual_output
+#                 output: actual_output
 #               )
 #             end
 #
@@ -124,7 +124,7 @@ describe Geet::Services::CreatePr do
 
         operation = -> do
           service_instance = described_class.new(repository, out: actual_output, git_client: git_client)
-          service_instance.execute('Title', 'Description', output: actual_output, automated_mode: true, no_open_pr: true)
+          service_instance.execute('Title', 'Description', output: actual_output, automated_mode: true)
         end
 
         expect(operation).to raise_error(RuntimeError, 'The working tree is not clean!')
@@ -152,7 +152,7 @@ describe Geet::Services::CreatePr do
 #
 #         actual_created_pr = VCR.use_cassette('github_com/create_pr_in_auto_mode_with_push') do
 #           service_instance = described_class.new(repository, out: actual_output, git_client: git_client)
-#           service_instance.execute('Title', 'Description', output: actual_output, automated_mode: true, no_open_pr: true)
+#           service_instance.execute('Title', 'Description', output: actual_output, automated_mode: true)
 #         end
 #
 #         expect(actual_output.string).to eql(expected_output)
@@ -179,7 +179,7 @@ describe Geet::Services::CreatePr do
 #
 #         actual_created_pr = VCR.use_cassette('github_com/create_pr_in_auto_mode_create_upstream') do
 #           service_instance = described_class.new(repository, out: actual_output, git_client: git_client)
-#           service_instance.execute('Title', 'Description', output: actual_output, automated_mode: true, no_open_pr: true)
+#           service_instance.execute('Title', 'Description', output: actual_output, automated_mode: true)
 #         end
 #
 #         expect(actual_output.string).to eql(expected_output)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: geet
 version: !ruby/object:Gem::Version
-  version: 0.15.0
+  version: 0.16.0
 platform: ruby
 authors:
 - Saverio Miroddi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-12-18 00:00:00.000000000 Z
+date: 2023-01-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: simple_scripting