geet 0.1.6 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8b8ebebddfff4a1580ff80b555e1604ebbbd6844
-  data.tar.gz: e14113d4db63b088c94ae74f8c22969b778ffa91
+  metadata.gz: 26e6c4b2966c8c93bbfabdcdcdd31972822ddb19
+  data.tar.gz: 31bd0e906eb426836f1fc912bc8e4b63b1f8d94c
 SHA512:
-  metadata.gz: b5b8165f6462cc767cc77d5c3380f825ff7b0c57636d9ae193336a6509a65da2056c66a89bc81e6b5d2b5e7dcba6ee98f2afb055779033330ef64b59b8d9456a
-  data.tar.gz: 74f65ee2ed758d85f64647e5c9d69c61069d03b5f96db5c750886e7a364ed3a8feb90417ac6a6e5c193b8fce9105fc9f7700b61e6a17a6c48e9c5746c5bb580f
+  metadata.gz: 763f77f17b6cdd5b97fe0547f645943c3d0f360598435a96b2de2e01ed4c576d1c2a1110195b1de04e43496d89fd986105cbbac53f56c393ee60533efafb1fab
+  data.tar.gz: 198ba0c2c055ab1269bc3d14d2d4d2f63c26970359cca5b18e80cc790e000cfa2b973285dd5484e0cecb9ac4e1ddf8d139ea07c31cee231c2bda3000fa736623

data/geet.gemspec

@@ -11,7 +11,7 @@ Gem::Specification.new do |s|
   s.platform    = Gem::Platform::RUBY
   s.required_ruby_version = '>= 2.2.0'
   s.authors     = ['Saverio Miroddi']
-  s.date        = '2017-11-02'
+  s.date        = '2017-11-06'
   s.email       = ['saverio.pub2@gmail.com']
   s.homepage    = 'https://github.com/saveriomiroddi/geet'
   s.summary     = 'Commandline interface for performing SCM (eg. GitHub) operations (eg. PR creation).'

data/lib/geet/git_hub/abstract_issue.rb

@@ -45,7 +45,7 @@ module Geet
       # params:
       #   users:   String, or Array of strings.
       #
-      def assign_user(users)
+      def assign_users(users)
         request_data = { assignees: Array(users) }
         request_address = "#{@api_helper.api_repo_link}/issues/#{@issue_number}/assignees"
 

data/lib/geet/services/create_issue.rb

@@ -13,51 +13,84 @@ module Geet
       #   :assignee_patterns
       #   :no_open_issue
       #
-      def execute(repository, title, description, options = {})
-        if options[:label_patterns]
-          puts 'Finding labels...'
+      def execute(repository, title, description, label_patterns: nil, assignee_patterns: nil, no_open_issue: nil, **)
+        labels_thread = select_labels(repository, label_patterns) if label_patterns
+        assignees_thread = select_assignees(repository, assignee_patterns) if assignee_patterns
 
-          all_labels = repository.labels
-          selected_labels = select_entries(all_labels, options[:label_patterns], type: 'labels')
+        selected_labels = labels_thread&.join&.value
+        assignees = assignees_thread&.join&.value
+
+        puts 'Creating the issue...'
+
+        issue = repository.create_issue(title, description)
+
+        add_labels_thread = add_labels(issue, selected_labels) if selected_labels
+
+        if assignees
+          assign_users_thread = assign_users(issue, assignees)
+        else
+          assign_users_thread = assign_authenticated_user(repository, issue)
         end
 
-        if options[:assignee_patterns]
-          puts 'Finding collaborators...'
+        add_labels_thread&.join
+        assign_users_thread.join
 
-          all_collaborators = repository.collaborators
-          assignees = select_entries(all_collaborators, options[:assignee_patterns], type: 'collaborators')
+        if no_open_issue
+          puts "Issue address: #{issue.link}"
+        else
+          os_open(issue.link)
         end
+      end
 
-        puts 'Creating the issue...'
+      private
 
-        issue = repository.create_issue(title, description)
+      # Internal actions
 
-        if selected_labels
-          puts 'Adding labels...'
+      def select_labels(repository, label_patterns)
+        puts 'Finding labels...'
 
-          issue.add_labels(selected_labels)
+        Thread.new do
+          all_labels = repository.labels
 
-          puts '- labels added: ' + selected_labels.join(', ')
+          select_entries(all_labels, label_patterns, type: 'labels')
         end
+      end
 
-        if assignees
-          puts 'Assigning users...'
+      def select_assignees(repository, assignee_patterns)
+        puts 'Finding collaborators...'
 
-          issue.assign_user(assignees)
+        Thread.new do
+          all_collaborators = repository.collaborators
 
-          puts '- assigned: ' + assignees.join(', ')
-        else
-          issue.assign_user(repository.authenticated_user)
+          select_entries(all_collaborators, assignee_patterns, type: 'collaborators')
         end
+      end
 
-        if options[:no_open_issue]
-          puts "Issue address: #{issue.link}"
-        else
-          os_open(issue.link)
+      def add_labels(issue, selected_labels)
+        puts "Adding labels #{selected_labels.join(', ')}..."
+
+        Thread.new do
+          issue.add_labels(selected_labels)
         end
       end
 
-      private
+      def assign_users(issue, users)
+        puts "Assigning users #{users.join(', ')}..."
+
+        Thread.new do
+          issue.assign_users(users)
+        end
+      end
+
+      def assign_authenticated_user(repository, issue)
+        puts 'Assigning authenticated user...'
+
+        Thread.new do
+          issue.assign_users(repository.authenticated_user)
+        end
+      end
+
+      # Generic helpers
 
       def select_entries(entries, raw_patterns, type: 'entries')
         patterns = raw_patterns.split(',')

data/lib/geet/services/create_pr.rb

@@ -3,6 +3,8 @@
 require_relative '../helpers/os_helper.rb'
 require_relative '../git/repository.rb'
 
+require 'thread'
+
 module Geet
   module Services
     class CreatePr
@@ -13,53 +15,85 @@ module Geet
       #   :reviewer_patterns
       #   :no_open_pr
       #
-      def execute(repository, title, description, options = {})
-        if options[:label_patterns]
-          puts 'Finding labels...'
+      def execute(repository, title, description, label_patterns: nil, reviewer_patterns: nil, no_open_pr: nil, **)
+        labels_thread = select_labels(repository, label_patterns) if label_patterns
+        reviewers_thread = select_reviewers(repository, reviewer_patterns) if reviewer_patterns
+
+        selected_labels = selected_labels&.join&.value
+        reviewers = reviewers_thread&.join&.value
+
+        pr = create_pr(repository, title, description)
+
+        assign_user_thread = assign_authenticated_user(pr, repository)
+        add_labels_thread = add_labels(pr, selected_labels) if selected_labels
+        request_review_thread = request_review(pr, reviewers) if reviewers
+
+        assign_user_thread.join
+        add_labels_thread&.join
+        request_review_thread&.join
+
+        if no_open_pr
+          puts "PR address: #{pr.link}"
+        else
+          os_open(pr.link)
+        end
+      end
+
+      private
+
+      # Internal actions
 
+      def select_labels(repository, label_patterns)
+        puts 'Finding labels...'
+
+        Thread.new do
           all_labels = repository.labels
-          selected_labels = select_entries(all_labels, options[:label_patterns], type: 'labels')
+
+          select_entries(all_labels, label_patterns, type: 'labels')
         end
+      end
 
-        if options[:reviewer_patterns]
-          puts 'Finding collaborators...'
+      def select_reviewers(repository, reviewer_patterns)
+        puts 'Finding collaborators...'
 
+        Thread.new do
           all_collaborators = repository.collaborators
-          reviewers = select_entries(all_collaborators, options[:reviewer_patterns], type: 'collaborators')
+
+          select_entries(all_collaborators, reviewer_patterns, type: 'collaborators')
         end
+      end
 
+      def create_pr(repository, title, description)
         puts 'Creating PR...'
 
         pr = repository.create_pr(title, description, repository.current_head)
+      end
 
+      def assign_authenticated_user(pr, repository)
         puts 'Assigning authenticated user...'
 
-        pr.assign_user(repository.authenticated_user)
+        Thread.new do
+          pr.assign_users(repository.authenticated_user)
+        end
+      end
 
-        if selected_labels
-          puts 'Adding labels...'
+      def add_labels(pr, selected_labels)
+        puts "Adding labels #{selected_labels.join(', ')}..."
 
+        Thread.new do
           pr.add_labels(selected_labels)
-
-          puts '- labels added: ' + selected_labels.join(', ')
         end
+      end
 
-        if reviewers
-          puts 'Requesting review...'
+      def request_review(pr, reviewers)
+        puts "Requesting review from #{reviewers.join(', ')}..."
 
+        Thread.new do
           pr.request_review(reviewers)
-
-          puts '- review requested to: ' + reviewers.join(', ')
-        end
-
-        if options[:no_open_pr]
-          puts "PR address: #{pr.link}"
-        else
-          os_open(pr.link)
         end
       end
 
-      private
+      # Generic helpers
 
       def select_entries(entries, raw_patterns, type: 'entries')
         patterns = raw_patterns.split(',')

data/lib/geet/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Geet
-  VERSION = '0.1.6'
+  VERSION = '0.1.7'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: geet
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.1.7
 platform: ruby
 authors:
 - Saverio Miroddi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-02 00:00:00.000000000 Z
+date: 2017-11-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: simple_scripting
@@ -78,7 +78,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Commandline interface for performing SCM (eg. GitHub) operations (eg. PR